Skip to contentSkip to conversation

media: mtk-vcodec: vdec: remove redundant 'pfb' assignment

PATCH Superseded Tzung-Bi Shih 1 participant 1 message Oct 19, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: mtk-vcodec: vdec: remove redundant 'pfb' assignment

A clang-analyzer warning was reported.

Quoted 1 line
Quoted 1 line

drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c:133:18:

warning: Value stored to 'pfb' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

            struct vdec_fb *pfb = &framebuf->frame_buffer;
                            ^~~   ~~~~~~~~~~~~~~~~~~~~~~~

Removes the redundant 'pfb' assignment to fix.

---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c +0 -1
index 8f4a1f0a0769..3d9f47555884 100644
@@ -133,7 +133,6 @@ static struct vdec_fb *vdec_get_cap_buffer(struct mtk_vcodec_ctx *ctx,
 	struct vdec_fb *pfb = &framebuf->frame_buffer;
 	struct vb2_buffer *dst_buf = &vb2_v4l2->vb2_buf;
 
-	pfb = &framebuf->frame_buffer;
 	pfb->base_y.va = NULL;
 	pfb->base_y.dma_addr = vb2_dma_contig_plane_dma_addr(dst_buf, 0);
 	pfb->base_y.size = ctx->q_data[MTK_Q_DATA_DST].sizeimage[0];
Signature · 1 line
2.33.0.1079.g6e70778dc9-goog