staging: rtl8723bs: core: Remove true and false comparison
PATCH 1/1 staging: rtl8723bs: core: Remove true and false comparison
Remove comparison to true and false in if statement. Issue found with checkpatch.pl.
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +8 -8
@@ -309,8 +309,8 @@ int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)if (cmd_obj->cmdcode ==GEN_CMD_CODE (_SetChannelPlan)) bAllow = true; -if ((pcmdpriv->padapter->hw_init_completed == false && bAllow == false) - ||atomic_read (&(pcmdpriv->cmdthd_running)) == false/* com_thread not running */ +if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) + || !atomic_read (&(pcmdpriv->cmdthd_running))/* com_thread not running */ )return _FAIL;
@@ -407,7 +407,7 @@ int rtw_cmd_thread(void *context)break ; } -if ((padapter->bDriverStopped == true) || (padapter->bSurpriseRemoved == true)) { +if ((padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->bDriverStopped,
@@ -430,7 +430,7 @@ int rtw_cmd_thread(void *context)continue ; _next: -if ((padapter->bDriverStopped == true) || (padapter->bSurpriseRemoved == true)) { +if ((padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->bDriverStopped,
@@ -927,7 +927,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_else GET_ENCRY_ALGO (psecuritypriv, sta, psetstakey_para->algorithm, false); -if (unicast_key == true) +if (unicast_key)memcpy (&psetstakey_para->key, &sta->dot118021x_UncstKey,16 );else memcpy (&psetstakey_para->key, &psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XGrpKeyid].skey,16 );
@@ -1283,7 +1283,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer) (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { bEnterPS = false; -if (bBusyTraffic == true) { +if (bBusyTraffic) {if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount <=4 ) pmlmepriv->LinkDetectInfo.TrafficTransitionCount =4 ;
@@ -1619,7 +1619,7 @@ static void rtw_chk_hi_queue_hdl(struct adapter *padapter)rtw_hal_get_hwreg (padapter,HW_VAR_CHK_HI_QUEUE_EMPTY , &empty); -while (false == empty &&jiffies_to_msecs (jiffies - start) < g_wait_hiq_empty) { +while (!empty &&jiffies_to_msecs (jiffies - start) < g_wait_hiq_empty) {msleep (100 );rtw_hal_get_hwreg (padapter,HW_VAR_CHK_HI_QUEUE_EMPTY , &empty); }
@@ -2054,7 +2054,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *spin_lock_bh (&pmlmepriv->lock); -if ((check_fwstate (pmlmepriv,WIFI_MP_STATE ) == true) && (check_fwstate (pmlmepriv, _FW_UNDER_LINKING) == true)) +if ((check_fwstate (pmlmepriv,WIFI_MP_STATE )) && (check_fwstate (pmlmepriv, _FW_UNDER_LINKING)))_clr_fwstate_ (pmlmepriv, _FW_UNDER_LINKING);set_fwstate (pmlmepriv, _FW_LINKED);
Signature · 1 line
2.25.1
Quoted 26 lines · Kushal Kothari
Remove comparison to true and false in if statement. Issue found with checkpatch.pl.
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error proneSigned-off-by Kushal Kothari <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/staging/rtl8723bs/core/rtw_cmd.c +2
-2@@ -309,8 +309,8 @@ int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)if (cmd_obj->cmdcode ==GEN_CMD_CODE (_SetChannelPlan)) bAllow = true; -if ((pcmdpriv->padapter->hw_init_completed == false && bAllow == false) - ||atomic_read (&(pcmdpriv->cmdthd_running)) == false/* com_thread not running */ +if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) + || !atomic_read (&(pcmdpriv->cmdthd_running))/* com_thread not running */ )return _FAIL;
drivers/staging/rtl8723bs/core/rtw_cmd.c int rtw_cmd_thread(void *context) · line 410
Quoted 5 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +1
-1@@ -407,7 +407,7 @@ int rtw_cmd_thread(void *context)break ; } -if ((padapter->bDriverStopped == true) || (padapter->bSurpriseRemoved == true)) { +if ((padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) {
The parentheses are pretty useless once you have removed the comparison.
julia
Quoted 56 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +5
-6netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->bDriverStopped,@@ -430,7 +430,7 @@ int rtw_cmd_thread(void *context)continue ; _next: -if ((padapter->bDriverStopped == true) || (padapter->bSurpriseRemoved == true)) { +if ((padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->bDriverStopped,@@ -927,7 +927,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_else GET_ENCRY_ALGO (psecuritypriv, sta, psetstakey_para->algorithm, false); -if (unicast_key == true) +if (unicast_key)memcpy (&psetstakey_para->key, &sta->dot118021x_UncstKey,16 );else memcpy (&psetstakey_para->key, &psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XGrpKeyid].skey,16 );@@ -1283,7 +1283,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer) (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { bEnterPS = false; -if (bBusyTraffic == true) { +if (bBusyTraffic) {if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount <=4 ) pmlmepriv->LinkDetectInfo.TrafficTransitionCount =4 ;@@ -1619,7 +1619,7 @@ static void rtw_chk_hi_queue_hdl(struct adapter *padapter)rtw_hal_get_hwreg (padapter,HW_VAR_CHK_HI_QUEUE_EMPTY , &empty); -while (false == empty &&jiffies_to_msecs (jiffies - start) < g_wait_hiq_empty) { +while (!empty &&jiffies_to_msecs (jiffies - start) < g_wait_hiq_empty) {msleep (100 );rtw_hal_get_hwreg (padapter,HW_VAR_CHK_HI_QUEUE_EMPTY , &empty); }@@ -2054,7 +2054,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *spin_lock_bh (&pmlmepriv->lock); -if ((check_fwstate (pmlmepriv,WIFI_MP_STATE ) == true) && (check_fwstate (pmlmepriv, _FW_UNDER_LINKING) == true)) +if ((check_fwstate (pmlmepriv,WIFI_MP_STATE )) && (check_fwstate (pmlmepriv, _FW_UNDER_LINKING)))_clr_fwstate_ (pmlmepriv, _FW_UNDER_LINKING);set_fwstate (pmlmepriv, _FW_LINKED); --2.25.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20211019172359.63583-1-kushalkothari285%40gmail.com.