Skip to contentSkip to conversation

ARM: dts: elpida_ecb240abacn: Change Elpida compatible

PATCH In review Dmitry Osipenko 2 participants 3 messages Oct 19, 2021 – Dec 9, 2021 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: elpida_ecb240abacn: Change Elpida compatible

Vendor prefix shouldn't start with capital letter. The Elpida Memory compatible was never used in practice, hence just correct the compatible.

---
 arch/arm/boot/dts/elpida_ecb240abacn.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/elpida_ecb240abacn.dtsi +1 -1
index d87ee4794f83..9698801cbcfb 100644
@@ -5,7 +5,7 @@
 
 / {
 	elpida_ECB240ABACN: lpddr2 {
-		compatible	= "Elpida,ECB240ABACN","jedec,lpddr2-s4";
+		compatible	= "elpida,ECB240ABACN","jedec,lpddr2-s4";
 		density		= <2048>;
 		io-width	= <32>;
 
Signature · 1 line
2.32.0
#1 lore raw

20.10.2021 02:40, Dmitry Osipenko пишет:

Quoted 14 lines

Vendor prefix shouldn't start with capital letter. The Elpida Memory compatible was never used in practice, hence just correct the compatible.

---
 arch/arm/boot/dts/elpida_ecb240abacn.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/elpida_ecb240abacn.dtsi +0 -0
index d87ee4794f83..9698801cbcfb 100644

arch/arm/boot/dts/elpida_ecb240abacn.dtsi line 11

Quoted 8 lines
arch/arm/boot/dts/elpida_ecb240abacn.dtsi +1 -1
@@ -5,7 +5,7 @@
 
 / {
 	elpida_ECB240ABACN: lpddr2 {
-		compatible	= "Elpida,ECB240ABACN","jedec,lpddr2-s4";
+		compatible	= "elpida,ECB240ABACN","jedec,lpddr2-s4";
 		density		= <2048>;
 		io-width	= <32>;
 

This patch should go via OMAP tree since there is only OMAP board which uses this dtsi. To make it more clear, "elpida" variant is now documented in the bindings [1][2].

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=9e17f71e9c334f14ad6a8ec3edc09c7a4244e12f

[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=001b8b2594db4ea24fbea4c161e665f858917fce

If there is no interest in taking the patch via OMAP tree, then it may go via the DT git tree. Rob, you should pick it up then.

Thanks!

#2 lore raw

Hi,

Quoted 28 lines · Dmitry Osipenko

20.10.2021 02:40, Dmitry Osipenko пишет:

Quoted 14 lines

Vendor prefix shouldn't start with capital letter. The Elpida Memory compatible was never used in practice, hence just correct the compatible.

---
 arch/arm/boot/dts/elpida_ecb240abacn.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/elpida_ecb240abacn.dtsi +0 -0
index d87ee4794f83..9698801cbcfb 100644

arch/arm/boot/dts/elpida_ecb240abacn.dtsi line 11

Quoted 8 lines
arch/arm/boot/dts/elpida_ecb240abacn.dtsi +1 -1
@@ -5,7 +5,7 @@
 
 / {
 	elpida_ECB240ABACN: lpddr2 {
-		compatible	= "Elpida,ECB240ABACN","jedec,lpddr2-s4";
+		compatible	= "elpida,ECB240ABACN","jedec,lpddr2-s4";
 		density		= <2048>;
 		io-width	= <32>;
 

This patch should go via OMAP tree since there is only OMAP board which uses this dtsi. To make it more clear, "elpida" variant is now documented in the bindings [1][2].

Quoted 8 lines

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=9e17f71e9c334f14ad6a8ec3edc09c7a4244e12f

[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=001b8b2594db4ea24fbea4c161e665f858917fce

If there is no interest in taking the patch via OMAP tree, then it may go via the DT git tree. Rob, you should pick it up then.

Applying into omap-for-v5.17/dt thanks.

Regards,

Tony