KVM: MMU: Reset mmu->pkru_mask to avoid stale data
PATCH 1/1 KVM: MMU: Reset mmu->pkru_mask to avoid stale data
When updating mmu->pkru_mask, the value can only be added but it isn't reset in advance. This will make mmu->pkru_mask keep the stale data. Fix this issue.
Fixes commit 2d344105f57c ("KVM, pkeys: introduce pkru_mask to cache conditions")
Signed-off-by Chenyi Qiang <[email protected]>
--- arch/x86/kvm/mmu/mmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/kvm/mmu/mmu.c +3 -3
@@ -4556,10 +4556,10 @@ static void update_pkru_bitmask(struct kvm_mmu *mmu)unsigned bit;bool wp; -if (!is_cr4_pke (mmu)) { - mmu->pkru_mask =0 ; + mmu->pkru_mask =0 ; + +if (!is_cr4_pke (mmu))return ; - } wp =is_cr0_wp (mmu);
Signature · 1 line
2.17.1
Quoted 7 lines · Chenyi Qiang
When updating
mmu->pkru_mask, the value can only be added but it isn't reset in advance. This will makemmu->pkru_maskkeep the stale data. Fix this issue.Fixes commit 2d344105f57c ("KVM, pkeys: introduce pkru_mask to cache conditions")Signed-off-by Chenyi Qiang <[email protected]>---
Reviewed-by Sean Christopherson <[email protected]>
Quoted 19 lines · Chenyi Qiang
When updating
mmu->pkru_mask, the value can only be added but it isn't reset in advance. This will makemmu->pkru_maskkeep the stale data. Fix this issue.Fixes commit 2d344105f57c ("KVM, pkeys: introduce pkru_mask to cache conditions")Signed-off-by Chenyi Qiang <[email protected]>--- arch/x86/kvm/mmu/mmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/x86/kvm/mmu/mmu.c +0
-0@@ -4556,10 +4556,10 @@ static void update_pkru_bitmask(struct kvm_mmu *mmu)unsigned bit;bool wp;
arch/x86/kvm/mmu/mmu.c static void update_pkru_bitmask(struct kvm_mmu *mmu) · line 4565
Quoted 10 lines
arch/x86/kvm/mmu/mmu.c +3
-3-if (!is_cr4_pke (mmu)) { - mmu->pkru_mask =0 ; + mmu->pkru_mask =0 ; + +if (!is_cr4_pke (mmu))return ; - } wp =is_cr0_wp (mmu);
Queued, thanks.
Paolo