genirq: Make irq_cpu_{on,off}line() an Octeon-special
Subsystems (5)
cover genirq: Make irq_cpu_{on,off}line() an Octeon-special
Now that Florian has updated BMIPS to not rely on irq_cpu_offline [1], it is pretty tempting to totally get of this misfeature. We can't really do that because Octeon uses it like crazy, but the couple of other users are easy to convert.
Once this is done, these helpers are hidden behind a config symbol that depends on the Octeon platform being selected. When Octeon is finally removed from the tree, we'll be able to drop this as well.
Marc Zyngier (3):
MIPS: loongson64: Drop call to irq_cpu_offline() irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
genirq: Hide irq_cpu_{on,off}line() behind a deprecated option
arch/mips/loongson64/smp.c | 1 - drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- include/linux/irq.h | 5 ++++- kernel/irq/Kconfig | 7 +++++++ kernel/irq/chip.c | 2 ++ 5 files changed, 39 insertions(+), 13 deletions(-)
Signature · 1 line
2.30.2
PATCH 1/3 MIPS: loongson64: Drop call to irq_cpu_offline()
Also loongson64 calls irq_cpu_offline(), none of its interrupt controllers implement the .irq_cpu_offline callback.
It is thus obvious that this call only serves the dubious purpose of wasting precious CPU cycles by iterating over all interrupts.
Get rid of the call altogether.
--- arch/mips/loongson64/smp.c | 1 - 1 file changed, 1 deletion(-)
arch/mips/loongson64/smp.c +0 -1
@@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void)set_cpu_online (cpu, false);calculate_cpu_foreign_map ();local_irq_save (flags); -irq_cpu_offline ();clear_c0_status (ST0_IM );local_irq_restore (flags);local_flush_tlb_all ();
Signature · 1 line
2.30.2
Re: [PATCH 1/3] MIPS: loongson64: Drop call to irq_cpu_offline()
Quoted 27 lines · Marc Zyngier
Also loongson64 calls
irq_cpu_offline(), none of its interrupt controllers implement the .irq_cpu_offline callback.It is thus obvious that this call only serves the dubious purpose of wasting precious CPU cycles by iterating over all interrupts.
Get rid of the call altogether.
Signed-off-by Marc Zyngier <[email protected]>--- arch/mips/loongson64/smp.c | 1 - 1 file changed, 1 deletion(-)arch/mips/loongson64/smp.c +0
-1@@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void)set_cpu_online (cpu, false);calculate_cpu_foreign_map ();local_irq_save (flags); -irq_cpu_offline ();clear_c0_status (ST0_IM );local_irq_restore (flags);local_flush_tlb_all ();Signature · 1 line
2.30.2
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
Re: [PATCH 1/3] MIPS: loongson64: Drop call to irq_cpu_offline()
In reply to Marc ZyngierQuoted 9 lines · Marc Zyngier
Also loongson64 calls
irq_cpu_offline(), none of its interrupt controllers implement the .irq_cpu_offline callback.It is thus obvious that this call only serves the dubious purpose of wasting precious CPU cycles by iterating over all interrupts.
Get rid of the call altogether.
Signed-off-by Marc Zyngier <[email protected]>
--
Florian
[irqchip: irq/irqchip-next] MIPS: loongson64: Drop call to irq_cpu_offline()
In reply to Marc ZyngierThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: eb5411334c289c473bc11d5cef8b0bea8d7ce324 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/eb5411334c289c473bc11d5cef8b0bea8d7ce324 Author: Marc Zyngier <[email protected]> AuthorDate: Thu, 21 Oct 2021 18:04:12 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Tue, 26 Oct 2021 11:18:33 +01:00
MIPS: loongson64: Drop call to irq_cpu_offline()
Also loongson64 calls irq_cpu_offline(), none of its interrupt controllers implement the .irq_cpu_offline callback.
It is thus obvious that this call only serves the dubious purpose of wasting precious CPU cycles by iterating over all interrupts.
Get rid of the call altogether.
--- arch/mips/loongson64/smp.c | 1 - 1 file changed, 1 deletion(-)
arch/mips/loongson64/smp.c +0 -1
@@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void)set_cpu_online (cpu, false);calculate_cpu_foreign_map ();local_irq_save (flags); -irq_cpu_offline ();clear_c0_status (ST0_IM );local_irq_restore (flags);local_flush_tlb_all ();
PATCH 2/3 irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
In reply to Marc ZyngierThe MIPS GIC driver uses irq_cpu_online() to go and program the per-CPU interrupts. However, this method iterates over all IRQs in the system, despite only 3 per-CPU interrupts being of interest.
Let's be terribly bold and do the iteration ourselves. To ensure mutual exclusion, hold the gic_lock spinlock that is otherwise taken while dealing with these interrupts.
--- drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 11 deletions(-)
drivers/irqchip/irq-mips-gic.c +26 -11
@@ -381,24 +381,35 @@ static void gic_unmask_local_irq_all_vpes(struct irq_data *d)spin_unlock_irqrestore (&gic_lock, flags); } -static void gic_all_vpes_irq_cpu_online (struct irq_data *d) +static void gic_all_vpes_irq_cpu_online (void ) { -struct gic_all_vpes_chip_data *cd; -unsigned int intr; +static unsigned int local_intrs[] = { +GIC_LOCAL_INT_TIMER , +GIC_LOCAL_INT_PERFCTR , +GIC_LOCAL_INT_FDC , + }; +unsigned long flags; +int i; - intr =GIC_HWIRQ_TO_LOCAL (d->hwirq); - cd =irq_data_get_irq_chip_data (d); +spin_lock_irqsave (&gic_lock, flags); -write_gic_vl_map (mips_gic_vx_map_reg (intr), cd->map); -if (cd->mask) -write_gic_vl_smask (BIT (intr)); +for (i =0 ; i <ARRAY_SIZE (local_intrs); i++) { +unsigned int intr = local_intrs[i]; +struct gic_all_vpes_chip_data *cd; + + cd = &gic_all_vpes_chip_data[intr]; +write_gic_vl_map (mips_gic_vx_map_reg (intr), cd->map); +if (cd->mask) +write_gic_vl_smask (BIT (intr)); + } + +spin_unlock_irqrestore (&gic_lock, flags); }static struct irq_chip gic_all_vpes_local_irq_controller = { .name ="MIPS GIC Local" , .irq_mask = gic_mask_local_irq_all_vpes, .irq_unmask = gic_unmask_local_irq_all_vpes, - .irq_cpu_online = gic_all_vpes_irq_cpu_online, };static void __gic_irq_dispatch (void )
@@ -477,6 +488,10 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, intr =GIC_HWIRQ_TO_LOCAL (hwirq); map =GIC_MAP_PIN_MAP_TO_PIN | gic_cpu_pin; +/* +* If adding support for more per-cpu interrupts, keep the the +* array in gic_all_vpes_irq_cpu_online() in sync. +*/ switch (intr) {case GIC_LOCAL_INT_TIMER :/* CONFIG_MIPS_CMP workaround (see __gic_init) */
@@ -663,8 +678,8 @@ static int gic_cpu_startup(unsigned int cpu)/* Clear all local IRQ masks (ie. disable all local interrupts) */ write_gic_vl_rmask (~0 ); -/* Invoke irq_cpu_online callbacks to enable desired interrupts */ -irq_cpu_online (); +/* Enable desired interrupts */ +gic_all_vpes_irq_cpu_online ();return 0 ; }
Signature · 1 line
2.30.2
Re: [PATCH 2/3] irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
Quoted 7 lines · Marc Zyngier
The MIPS GIC driver uses
irq_cpu_online()to go and program the per-CPU interrupts. However, this method iterates over all IRQs in the system, despite only 3 per-CPU interrupts being of interest.Let's be terribly bold and do the iteration ourselves. To ensure mutual exclusion, hold the
gic_lockspinlock that is otherwise taken while dealing with these interrupts.
Please consider a nitpick below. Other than that looks good:
Quoted 11 lines
Signed-off-by Marc Zyngier <[email protected]>--- drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 11 deletions(-)drivers/irqchip/irq-mips-gic.c +0
-0
drivers/irqchip/irq-mips-gic.c static void gic_unmask_local_irq_all_vpes(struct irq_data *d) · line 387
Quoted 10 lines
drivers/irqchip/irq-mips-gic.c +2
-3@@ -381,24 +381,35 @@ static void gic_unmask_local_irq_all_vpes(struct irq_data *d)spin_unlock_irqrestore (&gic_lock, flags); } -static void gic_all_vpes_irq_cpu_online (struct irq_data *d) +static void gic_all_vpes_irq_cpu_online (void ) { -struct gic_all_vpes_chip_data *cd; -unsigned int intr; +static unsigned int local_intrs[] = {
What about adding 'const' here?
-Sergey
Quoted 60 lines
drivers/irqchip/irq-mips-gic.c +18
-6+GIC_LOCAL_INT_TIMER , +GIC_LOCAL_INT_PERFCTR , + GIC_LOCAL_INT_FDC, + }; +unsigned long flags; +int i; - intr =GIC_HWIRQ_TO_LOCAL (d->hwirq); - cd =irq_data_get_irq_chip_data (d); +spin_lock_irqsave (&gic_lock, flags); -write_gic_vl_map (mips_gic_vx_map_reg (intr), cd->map); -if (cd->mask) -write_gic_vl_smask (BIT (intr)); +for (i =0 ; i <ARRAY_SIZE (local_intrs); i++) { +unsigned int intr = local_intrs[i]; +struct gic_all_vpes_chip_data *cd; + + cd = &gic_all_vpes_chip_data[intr]; +write_gic_vl_map (mips_gic_vx_map_reg (intr), cd->map); +if (cd->mask) +write_gic_vl_smask (BIT (intr)); + } + +spin_unlock_irqrestore (&gic_lock, flags); }static struct irq_chip gic_all_vpes_local_irq_controller = { .name ="MIPS GIC Local" , .irq_mask = gic_mask_local_irq_all_vpes, .irq_unmask = gic_unmask_local_irq_all_vpes, - .irq_cpu_online = gic_all_vpes_irq_cpu_online, };static void
__gic_irq_dispatch(void)drivers/irqchip/irq-mips-gic.c +6
-2@@ -477,6 +488,10 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, intr =GIC_HWIRQ_TO_LOCAL (hwirq); map =GIC_MAP_PIN_MAP_TO_PIN | gic_cpu_pin; +/* +* If adding support for more per-cpu interrupts, keep the the +* array in gic_all_vpes_irq_cpu_online() in sync. +*/ switch (intr) {case GIC_LOCAL_INT_TIMER :/* CONFIG_MIPS_CMP workaround (see __gic_init) */ @@ -663,8 +678,8 @@ static int gic_cpu_startup(unsigned int cpu)/* Clear all local IRQ masks (ie. disable all local interrupts) */ write_gic_vl_rmask (~0 ); -/* Invoke irq_cpu_online callbacks to enable desired interrupts */ -irq_cpu_online (); +/* Enable desired interrupts */ +gic_all_vpes_irq_cpu_online ();return 0 ; }Signature · 1 line
2.30.2
Re: [PATCH 2/3] irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
In reply to Marc ZyngierQuoted 9 lines · Marc Zyngier
The MIPS GIC driver uses
irq_cpu_online()to go and program the per-CPU interrupts. However, this method iterates over all IRQs in the system, despite only 3 per-CPU interrupts being of interest.Let's be terribly bold and do the iteration ourselves. To ensure mutual exclusion, hold the
gic_lockspinlock that is otherwise taken while dealing with these interrupts.Signed-off-by Marc Zyngier <[email protected]>
Signature · 1 line
Florian
[irqchip: irq/irqchip-next] irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
In reply to Marc ZyngierThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: dd098a0e031928cf88c89f7577d31821e1f0e6de Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/dd098a0e031928cf88c89f7577d31821e1f0e6de Author: Marc Zyngier <[email protected]> AuthorDate: Thu, 21 Oct 2021 18:04:13 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Tue, 26 Oct 2021 11:19:38 +01:00
irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
The MIPS GIC driver uses irq_cpu_online() to go and program the per-CPU interrupts. However, this method iterates over all IRQs in the system, despite only 3 per-CPU interrupts being of interest.
Let's be terribly bold and do the iteration ourselves. To ensure mutual exclusion, hold the gic_lock spinlock that is otherwise taken while dealing with these interrupts.
--- drivers/irqchip/irq-mips-gic.c | 37 +++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 11 deletions(-)
drivers/irqchip/irq-mips-gic.c +26 -11
@@ -381,24 +381,35 @@ static void gic_unmask_local_irq_all_vpes(struct irq_data *d)spin_unlock_irqrestore (&gic_lock, flags); } -static void gic_all_vpes_irq_cpu_online (struct irq_data *d) +static void gic_all_vpes_irq_cpu_online (void ) { -struct gic_all_vpes_chip_data *cd; -unsigned int intr; +static const unsigned int local_intrs[] = { +GIC_LOCAL_INT_TIMER , +GIC_LOCAL_INT_PERFCTR , +GIC_LOCAL_INT_FDC , + }; +unsigned long flags; +int i; - intr =GIC_HWIRQ_TO_LOCAL (d->hwirq); - cd =irq_data_get_irq_chip_data (d); +spin_lock_irqsave (&gic_lock, flags); -write_gic_vl_map (mips_gic_vx_map_reg (intr), cd->map); -if (cd->mask) -write_gic_vl_smask (BIT (intr)); +for (i =0 ; i <ARRAY_SIZE (local_intrs); i++) { +unsigned int intr = local_intrs[i]; +struct gic_all_vpes_chip_data *cd; + + cd = &gic_all_vpes_chip_data[intr]; +write_gic_vl_map (mips_gic_vx_map_reg (intr), cd->map); +if (cd->mask) +write_gic_vl_smask (BIT (intr)); + } + +spin_unlock_irqrestore (&gic_lock, flags); }static struct irq_chip gic_all_vpes_local_irq_controller = { .name ="MIPS GIC Local" , .irq_mask = gic_mask_local_irq_all_vpes, .irq_unmask = gic_unmask_local_irq_all_vpes, - .irq_cpu_online = gic_all_vpes_irq_cpu_online, };static void __gic_irq_dispatch (void )
@@ -477,6 +488,10 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, intr =GIC_HWIRQ_TO_LOCAL (hwirq); map =GIC_MAP_PIN_MAP_TO_PIN | gic_cpu_pin; +/* +* If adding support for more per-cpu interrupts, keep the the +* array in gic_all_vpes_irq_cpu_online() in sync. +*/ switch (intr) {case GIC_LOCAL_INT_TIMER :/* CONFIG_MIPS_CMP workaround (see __gic_init) */
@@ -663,8 +678,8 @@ static int gic_cpu_startup(unsigned int cpu)/* Clear all local IRQ masks (ie. disable all local interrupts) */ write_gic_vl_rmask (~0 ); -/* Invoke irq_cpu_online callbacks to enable desired interrupts */ -irq_cpu_online (); +/* Enable desired interrupts */ +gic_all_vpes_irq_cpu_online ();return 0 ; }
PATCH 3/3 genirq: Hide irq_cpu_{on,off}line() behind a deprecated option
In reply to Marc Zyngierirq_cpu_{on,off}line() are now only used by the Octeon platform. Make their use conditional on this plaform being enabled, and otherwise hidden away.
--- include/linux/irq.h | 5 ++++- kernel/irq/Kconfig | 7 +++++++ kernel/irq/chip.c | 2 ++ 3 files changed, 13 insertions(+), 1 deletion(-)
include/linux/irq.h +4 -1
@@ -524,9 +524,10 @@ struct irq_chip {void (*irq_bus_lock)(struct irq_data *data);void (*irq_bus_sync_unlock)(struct irq_data *data); +#ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE void (*irq_cpu_online)(struct irq_data *data);void (*irq_cpu_offline)(struct irq_data *data); - +#endif void (*irq_suspend)(struct irq_data *data);void (*irq_resume)(struct irq_data *data);void (*irq_pm_shutdown)(struct irq_data *data);
@@ -606,8 +607,10 @@ struct irqaction;extern int setup_percpu_irq (unsigned int irq,struct irqaction *new);extern void remove_percpu_irq (unsigned int irq,struct irqaction *act); +#ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE extern void irq_cpu_online (void );extern void irq_cpu_offline (void ); +#endif extern int irq_set_affinity_locked (struct irq_data *data,const struct cpumask *cpumask,bool force);extern int irq_set_vcpu_affinity (unsigned int irq,void *vcpu_info);
kernel/irq/Kconfig +7 -0
@@ -144,3 +144,10 @@ config GENERIC_IRQ_MULTI_HANDLER bool help Allow to specify the low level IRQ handler at run time. + +# Cavium Octeon is the last system to use this deprecated option +# Do not even think of enabling this on any new platform +config DEPRECATED_IRQ_CPU_ONOFFLINE + bool + depends on CAVIUM_OCTEON_SOC + default CAVIUM_OCTEON_SOC
kernel/irq/chip.c +2 -0
@@ -1122,6 +1122,7 @@ void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set) }EXPORT_SYMBOL_GPL (irq_modify_status); +#ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE /** * irq_cpu_online - Invoke all irq_cpu_online functions. *
@@ -1181,6 +1182,7 @@ void irq_cpu_offline(void) raw_spin_unlock_irqrestore(&desc->lock, flags); } } +#endif #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
Signature · 1 line
2.30.2
Re: [PATCH 3/3] genirq: Hide irq_cpu_{on,off}line() behind a deprecated option
Quoted 5 lines · Marc Zyngier
irq_cpu_{on,off}line() are now only used by the Octeon platform. Make their use conditional on this plaform being enabled, and otherwise hidden away.
Signed-off-by Marc Zyngier <[email protected]>
Signature · 1 line
Florian
[irqchip: irq/irqchip-next] genirq: Hide irq_cpu_{on,off}line() behind a deprecated option
In reply to Marc ZyngierThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 8d15a7295d33538954df2bca6a4011e4311a9cc2 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/8d15a7295d33538954df2bca6a4011e4311a9cc2 Author: Marc Zyngier <[email protected]> AuthorDate: Thu, 21 Oct 2021 18:04:14 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Tue, 26 Oct 2021 11:19:55 +01:00
genirq: Hide irq_cpu_{on,off}line() behind a deprecated option
irq_cpu_{on,off}line() are now only used by the Octeon platform. Make their use conditional on this plaform being enabled, and otherwise hidden away.
--- include/linux/irq.h | 5 ++++- kernel/irq/Kconfig | 7 +++++++ kernel/irq/chip.c | 2 ++ 3 files changed, 13 insertions(+), 1 deletion(-)
include/linux/irq.h +4 -1
@@ -524,9 +524,10 @@ struct irq_chip {void (*irq_bus_lock)(struct irq_data *data);void (*irq_bus_sync_unlock)(struct irq_data *data); +#ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE void (*irq_cpu_online)(struct irq_data *data);void (*irq_cpu_offline)(struct irq_data *data); - +#endif void (*irq_suspend)(struct irq_data *data);void (*irq_resume)(struct irq_data *data);void (*irq_pm_shutdown)(struct irq_data *data);
@@ -606,8 +607,10 @@ struct irqaction;extern int setup_percpu_irq (unsigned int irq,struct irqaction *new);extern void remove_percpu_irq (unsigned int irq,struct irqaction *act); +#ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE extern void irq_cpu_online (void );extern void irq_cpu_offline (void ); +#endif extern int irq_set_affinity_locked (struct irq_data *data,const struct cpumask *cpumask,bool force);extern int irq_set_vcpu_affinity (unsigned int irq,void *vcpu_info);
kernel/irq/Kconfig +7 -0
@@ -144,3 +144,10 @@ config GENERIC_IRQ_MULTI_HANDLER bool help Allow to specify the low level IRQ handler at run time. + +# Cavium Octeon is the last system to use this deprecated option +# Do not even think of enabling this on any new platform +config DEPRECATED_IRQ_CPU_ONOFFLINE + bool + depends on CAVIUM_OCTEON_SOC + default CAVIUM_OCTEON_SOC
kernel/irq/chip.c +2 -0
@@ -1122,6 +1122,7 @@ void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set) }EXPORT_SYMBOL_GPL (irq_modify_status); +#ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE /** * irq_cpu_online - Invoke all irq_cpu_online functions. *
@@ -1181,6 +1182,7 @@ void irq_cpu_offline(void) raw_spin_unlock_irqrestore(&desc->lock, flags); } } +#endif #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
Hello Marc
Quoted 8 lines · Marc Zyngier
Now that Florian has updated BMIPS to not rely on
irq_cpu_offline[1], it is pretty tempting to totally get of this misfeature. We can't really do that because Octeon uses it like crazy, but the couple of other users are easy to convert.Once this is done, these helpers are hidden behind a config symbol that depends on the Octeon platform being selected. When Octeon is finally removed from the tree, we'll be able to drop this as well.
The whole series has been tested in kernel 5.13 running on Baikal-T1 SoC (2x P5600 cores) with MIPS GIC used as the clock source and clock event device.
-Sergey
Quoted 17 lines
Marc Zyngier (3):
MIPS: loongson64: Drop call toirq_cpu_offline()irqchip/mips-gic: Get rid of the reliance onirq_cpu_online()
genirq: Hide irq_cpu_{on,off}line() behind a deprecated optionarch/mips/loongson64/smp.c | 1 - drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- include/linux/irq.h | 5 ++++- kernel/irq/Kconfig | 7 +++++++ kernel/irq/chip.c | 2 ++ 5 files changed, 39 insertions(+), 13 deletions(-)Signature · 1 line
2.30.2
Serge Semin
Tested-byQuoted 12 lines · Serge Semin
Hello Marc
Quoted 8 lines · Marc Zyngier
Now that Florian has updated BMIPS to not rely on
irq_cpu_offline[1], it is pretty tempting to totally get of this misfeature. We can't really do that because Octeon uses it like crazy, but the couple of other users are easy to convert.Once this is done, these helpers are hidden behind a config symbol that depends on the Octeon platform being selected. When Octeon is finally removed from the tree, we'll be able to drop this as well.
Quoted 5 lines
The whole series has been tested in kernel 5.13 running on Baikal-T1 SoC (2x P5600 cores) with MIPS GIC used as the clock source and clock event device.
Acked-by Serge Semin <[email protected]>
Ah, sorry. copy-pasted a wrong tag. Tested-by of course:
-Sergey
Quoted 20 lines
-Sergey
Quoted 17 lines
Marc Zyngier (3):
MIPS: loongson64: Drop call toirq_cpu_offline()irqchip/mips-gic: Get rid of the reliance onirq_cpu_online()
genirq: Hide irq_cpu_{on,off}line() behind a deprecated optionarch/mips/loongson64/smp.c | 1 - drivers/irqchip/irq-mips-gic.c | 37 ++++++++++++++++++++++++---------- include/linux/irq.h | 5 ++++- kernel/irq/Kconfig | 7 +++++++ kernel/irq/chip.c | 2 ++ 5 files changed, 39 insertions(+), 13 deletions(-)Signature · 1 line
2.30.2