selftests: kvm: fix mismatched fclose() after popen()
Shuah Khan
maintainerPATCH v2 1/1 selftests: kvm: fix mismatched fclose() after popen()
get_warnings_count() does fclose() using File * returned from popen(). Fix it to call pclose() as it should.
tools/testing/selftests/kvm/x86_64/mmio_warning_testx86_64/mmio_warning_test.c: In function ‘get_warnings_count’:x86_64/mmio_warning_test.c:87:9: warning: ‘fclose’ called on pointer returned from a mismatched allocation function [-Wmismatched-dealloc]
87 | fclose(f);
| ^~~~~~~~~
x86_64/mmio_warning_test.c:84:13: note: returned from ‘popen’
84 | f = popen("dmesg | grep \"WARNING:\" | wc -l", "r");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~--- tools/testing/selftests/kvm/x86_64/mmio_warning_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/kvm/x86_64/mmio_warning_test.c +1 -1
@@ -84,7 +84,7 @@ int get_warnings_count(void) f =popen ("dmesg | grep \"WARNING:\" | wc -l" ,"r" );if (fscanf (f,"%d" , &warnings) <1 ) warnings =0 ; -fclose (f); +pclose (f);return warnings; }
Signature · 1 line
2.32.0
Quoted 23 lines · Shuah Khan
get_warnings_count()doesfclose()using File * returned frompopen(). Fix it to callpclose()as it should.
tools/testing/selftests/kvm/x86_64/mmio_warning_testx86_64/mmio_warning_test.c: In function ‘get_warnings_count’:x86_64/mmio_warning_test.c:87:9: warning: ‘fclose’ called on pointer returned from a mismatched allocation function [-Wmismatched-dealloc]87 | fclose(f); | ^~~~~~~~~ x86_64/mmio_warning_test.c:84:13: note: returned from ‘popen’ 84 | f = popen("dmesg | grep \"WARNING:\" | wc -l", "r"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Signed-off-by Shuah Khan <[email protected]>--- tools/testing/selftests/kvm/x86_64/mmio_warning_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/kvm/x86_64/mmio_warning_test.c +0
-0
tools/testing/selftests/kvm/x86_64/mmio_warning_test.c int get_warnings_count(void) · line 90
Quoted 8 lines
tools/testing/selftests/kvm/x86_64/mmio_warning_test.c +1
-1@@ -84,7 +84,7 @@ int get_warnings_count(void) f =popen ("dmesg | grep \"WARNING:\" | wc -l" ,"r" );if (fscanf (f,"%d" , &warnings) <1 ) warnings =0 ; -fclose (f); +pclose (f);return warnings; }
Thanks,
Paolo