Skip to contentSkip to conversation

Remove unused semaphores

PATCH Superseded Fabio M. De Francesco 2 participants 5 messages Oct 22, 2021 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Remove unused semaphores

Remove two unused semaphores.

Fabio M. De Francesco (2):
staging: r8188eu: Remove initialized but unused semaphore
staging: r8188eu: Remove unused semaphore "io_retevt"

 drivers/staging/r8188eu/core/rtw_xmit.c      | 1 -
 drivers/staging/r8188eu/include/osdep_intf.h | 1 -
 drivers/staging/r8188eu/include/rtw_xmit.h   | 1 -
 3 files changed, 3 deletions(-)
Signature · 1 line
2.33.1
#1 lore raw

PATCH 1/2 staging: r8188eu: Remove initialized but unused semaphore

Remove semaphore "xmit_sema" from "struct adapter" because it is initialized but never used.

---
 drivers/staging/r8188eu/core/rtw_xmit.c    | 1 -
 drivers/staging/r8188eu/include/rtw_xmit.h | 1 -
 2 files changed, 2 deletions(-)
drivers/staging/r8188eu/core/rtw_xmit.c +0 -1
index 720e190a7436..0c033a077bf9 100644
@@ -49,7 +49,6 @@ s32	_rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
 	/*  We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
 
 	spin_lock_init(&pxmitpriv->lock);
-	sema_init(&pxmitpriv->xmit_sema, 0);
 	sema_init(&pxmitpriv->terminate_xmitthread_sema, 0);
 
 	/*
drivers/staging/r8188eu/include/rtw_xmit.h +0 -1
index ea8e82e0b4be..b2df1480d66b 100644
@@ -256,7 +256,6 @@ struct agg_pkt_info {
 
 struct	xmit_priv {
 	spinlock_t lock;
-	struct semaphore xmit_sema;
 	struct semaphore terminate_xmitthread_sema;
 	struct __queue be_pending;
 	struct __queue bk_pending;
Signature · 1 line
2.33.1
#2 lore raw

PATCH 2/2 staging: r8188eu: Remove unused semaphore "io_retevt"

In reply to Fabio M. De Francesco

Remove semaphore "io_retevt" because it is never used.

---
 drivers/staging/r8188eu/include/osdep_intf.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/r8188eu/include/osdep_intf.h +0 -1
index 90b37655e9e0..0d7009269aab 100644
@@ -34,7 +34,6 @@ The protection mechanism is through the pending queue.
 	struct urb *piorw_urb;
 	u8 io_irp_cnt;
 	u8 bio_irp_pending;
-	struct semaphore  io_retevt;
 	struct timer_list io_timer;
 	u8 bio_irp_timeout;
 	u8 bio_timer_cancel;
Signature · 1 line
2.33.1
#3 lore raw
In reply to Fabio M. De Francesco
Quoted 13 lines · CEST Fabio M. De Francesco

Remove two unused semaphores.

Fabio M. De Francesco (2):
staging: r8188eu: Remove initialized but unused semaphore
staging: r8188eu: Remove unused semaphore "io_retevt"

 drivers/staging/r8188eu/core/rtw_xmit.c      | 1 -
 drivers/staging/r8188eu/include/osdep_intf.h | 1 -
 drivers/staging/r8188eu/include/rtw_xmit.h   | 1 -
 3 files changed, 3 deletions(-)
Signature · 1 line
2.33.1

I'm sorry but I overlooked the name of the driver in this cover letter :( Am I required to send a v2?

Fabio

#4 lore raw
Quoted 12 lines · Fabio M. De Francesco
Quoted 11 lines · CEST Fabio M. De Francesco

Remove two unused semaphores.

Fabio M. De Francesco (2):
staging: r8188eu: Remove initialized but unused semaphore
staging: r8188eu: Remove unused semaphore "io_retevt"

 drivers/staging/r8188eu/core/rtw_xmit.c      | 1 -
 drivers/staging/r8188eu/include/osdep_intf.h | 1 -
 drivers/staging/r8188eu/include/rtw_xmit.h   | 1 -
 3 files changed, 3 deletions(-)
Quoted 5 lines
Quoted 2 lines
Signature · 1 line
2.33.1

I'm sorry but I overlooked the name of the driver in this cover letter :( Am I required to send a v2?

Please do.