irqchip/irq-csky-mpintc: Fixup mask/unmask un-implementation
Subsystems (2)
[email protected]
maintainerPATCH 1/1 irqchip/irq-csky-mpintc: Fixup mask/unmask un-implementation
From: Guo Ren <[email protected]>
The mask/unmask must be implemented, and enable/disable supplement them if the HW requires something different at startup time. When irq source is disabled by mask, mpintc could complete irq normally.
So just replace the with mask/unmask function.
--- drivers/irqchip/irq-csky-mpintc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-csky-mpintc.c +2 -2
@@ -164,8 +164,8 @@ static int csky_irq_set_affinity(struct irq_data *d,static struct irq_chip csky_irq_chip = { .name ="C-SKY SMP Intc" , .irq_eoi = csky_mpintc_eoi, - .irq_enable = csky_mpintc_enable, - .irq_disable = csky_mpintc_disable, + .irq_unmask = csky_mpintc_enable, + .irq_mask = csky_mpintc_disable, .irq_set_type = csky_mpintc_set_type, #ifdef CONFIG_SMP .irq_set_affinity = csky_irq_set_affinity,
Signature · 1 line
2.25.1
Quoted 10 lines · On Mon, 25 Oct 2021 10:12:19 +0100, [email protected] wrote:
From: Guo Ren <[email protected]>
The mask/unmask must be implemented, and enable/disable supplement them if the HW requires something different at startup time. When irq source is disabled by mask, mpintc could complete irq normally.
So just replace the with mask/unmask function.
Tested-by Guo Ren <[email protected]>
This only makes sense if tested by a third party. It is assumed that the author of a patch has tested it.
Quoted 2 lines
Signed-off-by Guo Ren <[email protected]>Cc Marc Zyngier <[email protected]>
This hasn't been my email address for over two years now. I'm sure my ex manager is happy to hear from you, but I doubt he'll bother replying.
Quoted 9 lines
--- drivers/irqchip/irq-csky-mpintc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/irqchip/irq-csky-mpintc.c +0
-0
drivers/irqchip/irq-csky-mpintc.c static int csky_irq_set_affinity(struct irq_data *d, · line 171
Quoted 10 lines
drivers/irqchip/irq-csky-mpintc.c +2
-2@@ -164,8 +164,8 @@ static int csky_irq_set_affinity(struct irq_data *d,static struct irq_chip csky_irq_chip = { .name ="C-SKY SMP Intc" , .irq_eoi = csky_mpintc_eoi, - .irq_enable = csky_mpintc_enable, - .irq_disable = csky_mpintc_disable, + .irq_unmask = csky_mpintc_enable, + .irq_mask = csky_mpintc_disable, .irq_set_type = csky_mpintc_set_type, #ifdef CONFIG_SMP .irq_set_affinity = csky_irq_set_affinity,
Please rename the functions to match the fields they are assigned to.
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Guo Ren
maintainerQuoted 10 lines · Marc Zyngier
Quoted 7 lines · On Mon, 25 Oct 2021 10:12:19 +0100, [email protected] wrote:
From: Guo Ren <[email protected]>
The mask/unmask must be implemented, and enable/disable supplement them if the HW requires something different at startup time. When irq source is disabled by mask, mpintc could complete irq normally.
Quoted 6 lines
Quoted 3 lines
So just replace the with mask/unmask function.
Tested-by Guo Ren <[email protected]>This only makes sense if tested by a third party. It is assumed that the author of a patch has tested it.
Thx for pointing it out.
Quoted 6 lines
Quoted 3 lines
Signed-off-by Guo Ren <[email protected]>Cc Marc Zyngier <[email protected]>This hasn't been my email address for over two years now. I'm sure my ex manager is happy to hear from you, but I doubt he'll bother replying.
I'll fix up your email in the next patch, thx for still reviewing.
Quoted 14 lines
Quoted 14 lines
--- drivers/irqchip/irq-csky-mpintc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/irqchip/irq-csky-mpintc.c +0
-1@@ -164,8 +164,8 @@ static int csky_irq_set_affinity(struct irq_data *d,static struct irq_chip csky_irq_chip = { .name ="C-SKY SMP Intc" , .irq_eoi = csky_mpintc_eoi, - .irq_enable = csky_mpintc_enable,
Quoted 8 lines
drivers/irqchip/irq-csky-mpintc.c static int csky_irq_set_affinity(struct irq_data *d, · line 171
Quoted 6 lines
drivers/irqchip/irq-csky-mpintc.c +2
-1- .irq_disable = csky_mpintc_disable, + .irq_unmask = csky_mpintc_enable, + .irq_mask = csky_mpintc_disable, .irq_set_type = csky_mpintc_set_type, #ifdef CONFIG_SMP .irq_set_affinity = csky_irq_set_affinity,Please rename the functions to match the fields they are assigned to.
okay
Quoted 7 lines
Thanks,
M.--
Without deviation from the norm, progress is not possible.
Signature · 4 lines
Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/