Nuke unload_i915
cover Nuke unload_i915
Use a silent version of lib function __igt_i915_driver_unload() instead.
Anshuman Gupta (2):
lib: Add silent __igt_i915_driver_unload
perf/perf_pmu: Nuke unload_i915
lib/igt_kmod.c | 86 +++++++++++++++++++++++++------------------ lib/igt_kmod.h | 1 + tests/i915/perf_pmu.c | 31 ++-------------- 3 files changed, 55 insertions(+), 63 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/2 lib: Add silent __igt_i915_driver_unload
Add silent __igt_i915_driver_unload(), which will not print any warning in case of passed argument is NULL.
--- lib/igt_kmod.c | 86 ++++++++++++++++++++++++++++++-------------------- lib/igt_kmod.h | 1 + 2 files changed, 52 insertions(+), 35 deletions(-)
lib/igt_kmod.c +51 -35
@@ -369,56 +369,72 @@ igt_i915_driver_load(const char *opts)return IGT_EXIT_SUCCESS ; } -/** -* igt_i915_driver_unload: -* -* Unloads the i915 driver and its dependencies. -* -*/ -int -igt_i915_driver_unload (void ) +int __igt_i915_driver_unload (const char **whom) { +const char *sound[] = { +"snd_hda_intel" , +"snd_hdmi_lpe_audio" , +NULL , + }; + +const char *aux[] = { +/* gen5: ips uses symbol_get() so only a soft module dependency */ +"intel_ips" , +NULL , + }; +/* unbind vt */ bind_fbcon (false); -if (igt_kmod_is_loaded ("snd_hda_intel" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); - -/* unbind snd_hda_intel */ -kick_snd_hda_intel (); - -if (igt_kmod_unload ("snd_hda_intel" ,0 )) { -igt_warn ("Could not unload snd_hda_intel\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; +for (const char **m = sound; *m; m++) { +if (igt_kmod_is_loaded (*m)) { +igt_terminate_process (SIGTERM ,"alsactl" ); +kick_snd_hda_intel (); +if (igt_kmod_unload (*m,0 )) { +if (whom) + *whom = *m; +return IGT_EXIT_FAILURE ; + } } } -if (igt_kmod_is_loaded ("snd_hdmi_lpe_audio" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); - -if (igt_kmod_unload ("snd_hdmi_lpe_audio" ,0 )) { -igt_warn ("Could not unload snd_hdmi_lpe_audio\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; - } +for (const char **m = aux; *m; m++) { +if (igt_kmod_is_loaded (*m)) +igt_kmod_unload (*m,0 ); } -/* gen5: ips uses symbol_get() so only a soft module dependency */ -if (igt_kmod_is_loaded ("intel_ips" )) -igt_kmod_unload ("intel_ips" ,0 ); -if (igt_kmod_is_loaded ("i915" )) {if (igt_kmod_unload ("i915" ,0 )) { -igt_warn ("Could not unload i915\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/dri" ); +if (whom) + *whom ="i915" ;return IGT_EXIT_SKIP ; } } +return IGT_EXIT_SUCCESS ; +} + +/** +* igt_i915_driver_unload: +* +* Unloads the i915 driver and its dependencies. +* +*/ +int +igt_i915_driver_unload (void ) +{ +const char *whom; +int ret; + + ret =__igt_i915_driver_unload (&whom); +if (ret) { +igt_warn ("Could not unload %s\n" , whom); +igt_kmod_list_loaded (); +igt_lsof ("/dev/dri" ); +igt_lsof ("/dev/snd" ); +return ret; + } +if (igt_kmod_is_loaded ("intel-gtt" ))igt_kmod_unload ("intel-gtt" ,0 );
lib/igt_kmod.h +1 -0
@@ -38,6 +38,7 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);int igt_i915_driver_load (const char *opts);int igt_i915_driver_unload (void ); +int __igt_i915_driver_unload (const char **whom);int igt_amdgpu_driver_load (const char *opts);int igt_amdgpu_driver_unload (void );
Signature · 1 line
2.26.2
Re: [igt-dev] [PATCH i-g-t 1/2] lib: Add silent __igt_i915_driver_unload
Quoted 3 lines · Anshuman Gupta
Add silent
__igt_i915_driver_unload(), which will not print any warning in case of passed argument is NULL.
I think we need to add a "why" to this commit message and that is "so that we can test scenarios when module unload is expected to fail".
Quoted 15 lines
Cc Chris Wilson <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- lib/igt_kmod.c | 86 ++++++++++++++++++++++++++++++-------------------- lib/igt_kmod.h | 1 + 2 files changed, 52 insertions(+), 35 deletions(-)lib/igt_kmod.c +0
-0@@ -369,56 +369,72 @@ igt_i915_driver_load(const char *opts)return IGT_EXIT_SUCCESS ; }
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 372
Quoted 10 lines
lib/igt_kmod.c +1
-8-/** -* igt_i915_driver_unload: -* -* Unloads the i915 driver and its dependencies. -* -*/ -int -igt_i915_driver_unload (void ) +int __igt_i915_driver_unload (const char **whom)
I prefer s/whom/who/ as in "Who failed to unload?".
Quoted 24 lines
lib/igt_kmod.c +12
-8{ +const char *sound[] = { +"snd_hda_intel" , +"snd_hdmi_lpe_audio" , +NULL , + }; + +const char *aux[] = { +/* gen5: ips uses symbol_get() so only a soft module dependency */ +"intel_ips" , +NULL , + }; +/* unbind vt */ bind_fbcon (false); -if (igt_kmod_is_loaded ("snd_hda_intel" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); - -/* unbind snd_hda_intel */ -kick_snd_hda_intel (); - -if (igt_kmod_unload ("snd_hda_intel" ,0 )) { -igt_warn ("Could not unload snd_hda_intel\n" );
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 395
Quoted 10 lines
lib/igt_kmod.c +7
-3-igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; +for (const char **m = sound; *m; m++) { +if (igt_kmod_is_loaded (*m)) { +igt_terminate_process (SIGTERM ,"alsactl" ); +kick_snd_hda_intel (); +if (igt_kmod_unload (*m,0 )) { +if (whom) + *whom = *m;
This seems like a bug. The sound and aux arrays above should be static otherwise these strings go out of scope after the function exits.
Quoted 7 lines
lib/igt_kmod.c +2
-2+return IGT_EXIT_FAILURE ; + } } } -if (igt_kmod_is_loaded ("snd_hdmi_lpe_audio" )) { -igt_terminate_process (SIGTERM ,"alsactl" );
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 403
Quoted 10 lines
lib/igt_kmod.c +3
-7- -if (igt_kmod_unload ("snd_hdmi_lpe_audio" ,0 )) { -igt_warn ("Could not unload snd_hdmi_lpe_audio\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; - } +for (const char **m = aux; *m; m++) { +if (igt_kmod_is_loaded (*m)) +igt_kmod_unload (*m,0 );
This issue exists in previous code too but why not return an error here (and also populate 'whom' or 'who')?
Quoted 8 lines
lib/igt_kmod.c +0
-4} -/* gen5: ips uses symbol_get() so only a soft module dependency */ -if (igt_kmod_is_loaded ("intel_ips" )) -igt_kmod_unload ("intel_ips" ,0 ); -if (igt_kmod_is_loaded ("i915" )) {if (igt_kmod_unload ("i915" ,0 )) {
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 414
Quoted 10 lines
lib/igt_kmod.c +3
-3-igt_warn ("Could not unload i915\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/dri" ); +if (whom) + *whom ="i915" ;return IGT_EXIT_SKIP ; } } +return IGT_EXIT_SUCCESS ;
The issue exists in previous code but to me it seems highly unusual that we are using process exit codes as return values from these functions (both load and unload).
Note that after we have introduced and populated 'whom' or 'who', we just return the value retured from igt_kmod_unload() from here (and similarly in igt_i915_driver_load()) and let the caller figure out who failed to unload from 'whom' or 'who'. That is we don't need separate return values for other drivers vs. i915. Thoughts?
Quoted 41 lines
lib/igt_kmod.c +23
-0+} + +/** +* igt_i915_driver_unload: +* +* Unloads the i915 driver and its dependencies. +* +*/ +int +igt_i915_driver_unload (void ) +{ +const char *whom; +int ret; + + ret =__igt_i915_driver_unload (&whom); +if (ret) { +igt_warn ("Could not unload %s\n" , whom); +igt_kmod_list_loaded (); +igt_lsof ("/dev/dri" ); +igt_lsof ("/dev/snd" ); +return ret; + } +if (igt_kmod_is_loaded ("intel-gtt" ))igt_kmod_unload ("intel-gtt" ,0 );lib/igt_kmod.h +1
-1@@ -38,6 +38,7 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);int igt_i915_driver_load (const char *opts);int igt_i915_driver_unload (void ); +int __igt_i915_driver_unload (const char **whom);int igt_amdgpu_driver_load (const char *opts);int igt_amdgpu_driver_unload (void ); --2.26.2
Re: [igt-dev] [PATCH i-g-t 1/2] lib: Add silent __igt_i915_driver_unload
Quoted 10 lines
-----Original Message-----
From: Dixit, Ashutosh <[email protected]>
Sent: Saturday, February 12, 2022 9:51 AM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]; Wilson, Chris P <[email protected]>; Nilawar, Badal <[email protected]>; [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib: Add silent__igt_i915_driver_unload
Quoted 7 lines
Quoted 3 lines · Anshuman Gupta
Add silent
__igt_i915_driver_unload(), which will not print any warning in case of passed argument is NULL.I think we need to add a "why" to this commit message and that is "so that we can test scenarios when module unload is expected to fail".
Thanks Ashutosh for review, I will add reason for doing this.
Quoted 18 lines
Quoted 18 lines
Cc Chris Wilson <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- lib/igt_kmod.c | 86 ++++++++++++++++++++++++++++++-------------------- lib/igt_kmod.h | 1 + 2 files changed, 52 insertions(+), 35 deletions(-)lib/igt_kmod.c index renamed from lib/igt_kmod.c +0
-0
10e983844..ce9bfc07a100644lib/igt_kmod.c +0
-0@@ -369,56 +369,72 @@ igt_i915_driver_load(const char *opts)return IGT_EXIT_SUCCESS ; }
Quoted 11 lines
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 372
Quoted 9 lines
lib/igt_kmod.c +1
-8-/** -* igt_i915_driver_unload: -* -* Unloads the i915 driver and its dependencies. -* -*/ -int -igt_i915_driver_unload (void ) +int __igt_i915_driver_unload (const char **whom)I prefer s/whom/who/ as in "Who failed to unload?".
I will fix this.
Quoted 31 lines
lib/igt_kmod.c igt_i915_driver_load(const char *opts)
Quoted 10 lines
lib/igt_kmod.c +8
-0{ +const char *sound[] = { +"snd_hda_intel" , +"snd_hdmi_lpe_audio" , +NULL , + }; + +const char *aux[] = { +/* gen5: ips uses symbol_get() so only a soft module dependency */
Quoted 20 lines
lib/igt_kmod.c +6
-11+"intel_ips" , +NULL , + }; +/* unbind vt */ bind_fbcon (false); -if (igt_kmod_is_loaded ("snd_hda_intel" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); - -/* unbind snd_hda_intel */ -kick_snd_hda_intel (); - -if (igt_kmod_unload ("snd_hda_intel" ,0 )) { -igt_warn ("Could not unload snd_hda_intel\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; +for (const char **m = sound; *m; m++) { +if (igt_kmod_is_loaded (*m)) {
Quoted 8 lines
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 395
Quoted 5 lines
lib/igt_kmod.c +5
-0+igt_terminate_process (SIGTERM ,"alsactl" ); +kick_snd_hda_intel (); +if (igt_kmod_unload (*m,0 )) { +if (whom) + *whom = *m;This seems like a bug. The sound and aux arrays above should be static otherwise these strings go out of scope after the function exits.
AFAIU all string literals (both local and global) are part of .rodata elf section, which is ultimately a file backed read-execute-private mapping (r-xp) in process map (/proc/pid/maps). This should not go out of scope. Please correct me if I am being wrong here.
Quoted 6 lines
Quoted 6 lines
lib/igt_kmod.c +2
-0+return IGT_EXIT_FAILURE ; + } } }
Quoted 15 lines
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 403
Quoted 12 lines
lib/igt_kmod.c +3
-9-if (igt_kmod_is_loaded ("snd_hdmi_lpe_audio" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); - -if (igt_kmod_unload ("snd_hdmi_lpe_audio" ,0 )) { -igt_warn ("Could not unload snd_hdmi_lpe_audio\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; - } +for (const char **m = aux; *m; m++) { +if (igt_kmod_is_loaded (*m)) +igt_kmod_unload (*m,0 );This issue exists in previous code too but why not return an error here (and also populate 'whom' or 'who')?
I will return the correct value and set the 'who' here.
Quoted 18 lines
Quoted 18 lines
lib/igt_kmod.c +2
-7} -/* gen5: ips uses symbol_get() so only a soft module dependency */ -if (igt_kmod_is_loaded ("intel_ips" )) -igt_kmod_unload ("intel_ips" ,0 ); -if (igt_kmod_is_loaded ("i915" )) {if (igt_kmod_unload ("i915" ,0 )) { -igt_warn ("Could not unload i915\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/dri" ); +if (whom) + *whom ="i915" ;return IGT_EXIT_SKIP ; } }
Quoted 5 lines
lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 414
Quoted 1 line
lib/igt_kmod.c +1
-0+return IGT_EXIT_SUCCESS ;The issue exists in previous code but to me it seems highly unusual that we are using process exit codes as return values from these functions (both load and unload).
Not sure about this issue, this series is aimed to fix perf_pmu@module-unload Igt test by using correct library function. May by fixing this process exit code Return values can be sent as separate patch.
Quoted 6 lines
Note that after we have introduced and populated 'whom' or 'who', we just return the value retured from
igt_kmod_unload()from here (and similarly inigt_i915_driver_load()) and let the caller figure out who failed to unload from 'whom' or 'who'. That is we don't need separate return values for other drivers vs. i915. Thoughts?
Yeah, we can use same return type either IGT_EXIT_FAILURE/ IGT_EXIT_SKIP or in case of module unload failure. I will add a separate patch in this series to address this.
Thanks,
Anshuman Gupta.
Quoted 44 lines
Quoted 44 lines
lib/igt_kmod.c +23
-0+} + +/** +* igt_i915_driver_unload: +* +* Unloads the i915 driver and its dependencies. +* +*/ +int +igt_i915_driver_unload (void ) +{ +const char *whom; +int ret; + + ret =__igt_i915_driver_unload (&whom); +if (ret) { +igt_warn ("Could not unload %s\n" , whom); +igt_kmod_list_loaded (); +igt_lsof ("/dev/dri" ); +igt_lsof ("/dev/snd" ); +return ret; + } +if (igt_kmod_is_loaded ("intel-gtt" ))igt_kmod_unload ("intel-gtt" ,0 );lib/igt_kmod.h index renamed from lib/igt_kmod.h +0
-0
04c87516f..0898122b3100644lib/igt_kmod.h +1
-0@@ -38,6 +38,7 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);int igt_i915_driver_load (const char *opts);int igt_i915_driver_unload (void ); +int __igt_i915_driver_unload (const char **whom);int igt_amdgpu_driver_load (const char *opts);int
igt_amdgpu_driver_unload(void);
--
2.26.2
Re: [igt-dev] [PATCH i-g-t 1/2] lib: Add silent __igt_i915_driver_unload
Quoted 3 lines · Anshuman
Quoted 3 lines
This seems like a bug. The sound and aux arrays above should be static otherwise these strings go out of scope after the function exits.
?
Quoted 4 lines
AFAIU all string literals (both local and global) are part of .rodata elf section, which is ultimately a file backed read-execute-private mapping (r-xp) in process map (
/proc/pid/maps). This should not go out of scope. Please correct me if I am being wrong here.
Yup, if the file is mmap'd you are right.
Re: [igt-dev] [PATCH i-g-t 1/2] lib: Add silent __igt_i915_driver_unload
In reply to Dixit, AshutoshQuoted 130 lines
-----Original Message-----
From: Dixit, Ashutosh <[email protected]>
Sent: Saturday, February 12, 2022 9:51 AM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]; Wilson, Chris P <[email protected]>; Nilawar, Badal <[email protected]>; [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib: Add silent__igt_i915_driver_unloadQuoted 3 lines · Anshuman Gupta
Add silent
__igt_i915_driver_unload(), which will not print any warning in case of passed argument is NULL.I think we need to add a "why" to this commit message and that is "so that we can test scenarios when module unload is expected to fail".
Quoted 16 lines
Cc Chris Wilson <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- lib/igt_kmod.c | 86 ++++++++++++++++++++++++++++++-------------------- lib/igt_kmod.h | 1 + 2 files changed, 52 insertions(+), 35 deletions(-)lib/igt_kmod.c index renamed from lib/igt_kmod.c +0
-0
10e983844..ce9bfc07a100644lib/igt_kmod.c +0
-0@@ -369,56 +369,72 @@ igt_i915_driver_load(const char *opts)return IGT_EXIT_SUCCESS ; }lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 372
Quoted 10 lines
lib/igt_kmod.c +1
-8-/** -* igt_i915_driver_unload: -* -* Unloads the i915 driver and its dependencies. -* -*/ -int -igt_i915_driver_unload (void ) +int __igt_i915_driver_unload (const char **whom)I prefer s/whom/who/ as in "Who failed to unload?".
lib/igt_kmod.c igt_i915_driver_load(const char *opts)
Quoted 9 lines
lib/igt_kmod.c +8
-0{ +const char *sound[] = { +"snd_hda_intel" , +"snd_hdmi_lpe_audio" , +NULL , + }; + +const char *aux[] = { +/* gen5: ips uses symbol_get() so only a soft module dependency */
Quoted 15 lines
lib/igt_kmod.c +4
-8+"intel_ips" , +NULL , + }; +/* unbind vt */ bind_fbcon (false); -if (igt_kmod_is_loaded ("snd_hda_intel" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); - -/* unbind snd_hda_intel */ -kick_snd_hda_intel (); - -if (igt_kmod_unload ("snd_hda_intel" ,0 )) { -igt_warn ("Could not unload snd_hda_intel\n" );lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 395
Quoted 10 lines
lib/igt_kmod.c +7
-3-igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; +for (const char **m = sound; *m; m++) { +if (igt_kmod_is_loaded (*m)) { +igt_terminate_process (SIGTERM ,"alsactl" ); +kick_snd_hda_intel (); +if (igt_kmod_unload (*m,0 )) { +if (whom) + *whom = *m;This seems like a bug. The sound and aux arrays above should be static otherwise these strings go out of scope after the function exits.
Quoted 7 lines
lib/igt_kmod.c +2
-2+return IGT_EXIT_FAILURE ; + } } } -if (igt_kmod_is_loaded ("snd_hdmi_lpe_audio" )) { -igt_terminate_process (SIGTERM ,"alsactl" );lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 403
Quoted 10 lines
lib/igt_kmod.c +3
-7- -if (igt_kmod_unload ("snd_hdmi_lpe_audio" ,0 )) { -igt_warn ("Could not unload snd_hdmi_lpe_audio\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/snd" ); -return IGT_EXIT_FAILURE ; - } +for (const char **m = aux; *m; m++) { +if (igt_kmod_is_loaded (*m)) +igt_kmod_unload (*m,0 );This issue exists in previous code too but why not return an error here (and also populate 'whom' or 'who')?
Quoted 8 lines
lib/igt_kmod.c +0
-4} -/* gen5: ips uses symbol_get() so only a soft module dependency */ -if (igt_kmod_is_loaded ("intel_ips" )) -igt_kmod_unload ("intel_ips" ,0 ); -if (igt_kmod_is_loaded ("i915" )) {if (igt_kmod_unload ("i915" ,0 )) {lib/igt_kmod.c igt_i915_driver_load(const char *opts) · line 414
Quoted 10 lines
lib/igt_kmod.c +3
-3-igt_warn ("Could not unload i915\n" ); -igt_kmod_list_loaded (); -igt_lsof ("/dev/dri" ); +if (whom) + *whom ="i915" ;return IGT_EXIT_SKIP ; } } +return IGT_EXIT_SUCCESS ;The issue exists in previous code but to me it seems highly unusual that we are using process exit codes as return values from these functions (both load and unload).
Quoted 5 lines
Note that after we have introduced and populated 'whom' or 'who', we just return the value retured from
igt_kmod_unload()from here (and similarly inigt_i915_driver_load()) and let the caller figure out who failed to unload from 'whom' or 'who'. That is we don't need separate return values for other drivers vs. i915. Thoughts?
Actually I missed this earlier while sending v2, perf_pmu test expect i915 module to be busy in certain cases and returning IGT_EXIT_FAILIURE will fail the perf_pmu test.
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6626/shard-tglb8/igt@[email protected]
So in case of *who is NULL , __igt_i915_driver_unload() should return IGT_EXIT_SKIP, whenever igt module fails to unload.
Thanks,
Anshuman Gupta.
Quoted 44 lines
Quoted 44 lines
lib/igt_kmod.c +23
-0+} + +/** +* igt_i915_driver_unload: +* +* Unloads the i915 driver and its dependencies. +* +*/ +int +igt_i915_driver_unload (void ) +{ +const char *whom; +int ret; + + ret =__igt_i915_driver_unload (&whom); +if (ret) { +igt_warn ("Could not unload %s\n" , whom); +igt_kmod_list_loaded (); +igt_lsof ("/dev/dri" ); +igt_lsof ("/dev/snd" ); +return ret; + } +if (igt_kmod_is_loaded ("intel-gtt" ))igt_kmod_unload ("intel-gtt" ,0 );lib/igt_kmod.h index renamed from lib/igt_kmod.h +0
-0
04c87516f..0898122b3100644lib/igt_kmod.h +1
-0@@ -38,6 +38,7 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);int igt_i915_driver_load (const char *opts);int igt_i915_driver_unload (void ); +int __igt_i915_driver_unload (const char **whom);int igt_amdgpu_driver_load (const char *opts);int
igt_amdgpu_driver_unload(void);
--
2.26.2
PATCH 2/2 perf/perf_pmu: Nuke unload_i915
In reply to Anshuman GuptaNuke unload_i915, instead use lib igt_i915_driver_unload() and __igt_i915_driver_unload().
--- tests/i915/perf_pmu.c | 31 +++---------------------------- 1 file changed, 3 insertions(+), 28 deletions(-)
tests/i915/perf_pmu.c +3 -28
@@ -2039,31 +2039,6 @@ static void faulting_read(int gem_fd, const struct mmap_offset *t)munmap (ptr,4096 ); } -static int unload_i915 (void ) -{ -bind_fbcon (false); - -if (igt_kmod_is_loaded ("snd_hda_intel" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); -kick_snd_hda_intel (); -if (igt_kmod_unload ("snd_hda_intel" ,0 )) -return -EAGAIN ; - } - -if (igt_kmod_is_loaded ("snd_hdmi_lpe_audio" )) { -igt_terminate_process (SIGTERM ,"alsactl" ); -if (igt_kmod_unload ("snd_hdmi_lpe_audio" ,0 )) -return -EAGAIN ; - } - -if (igt_kmod_is_loaded ("i915" )) { -if (igt_kmod_unload ("i915" ,0 )) -return -EBUSY ; - } - -return 0 ; -} -static void test_unload (unsigned int num_engines) { igt_fork(child, 1) {
@@ -2126,7 +2101,7 @@ static void test_unload(unsigned int num_engines)igt_debug ("Read %d events from perf and trial unload\n" , count);pmu_read_multi (fd[0 ], count, buf); -igt_assert_eq (unload_i915 (), -EBUSY ); +igt_assert_eq (__igt_i915_driver_unload (NULL ),IGT_EXIT_SKIP );pmu_read_multi (fd[0 ], count, buf);igt_debug ("Close perf\n" );
@@ -2139,7 +2114,7 @@ static void test_unload(unsigned int num_engines)igt_waitchildren ();igt_debug ("Final unload\n" ); -igt_assert_eq (unload_i915 (),0 ); +igt_assert_eq (__igt_i915_driver_unload (NULL ),IGT_EXIT_SUCCESS ); }#define test_each_engine (T , i915, ctx, e) \
@@ -2419,7 +2394,7 @@ igt_main } igt_subtest("module-unload") { -igt_require (unload_i915 () ==0 ); +igt_require (igt_i915_driver_unload () ==IGT_EXIT_SUCCESS );for (int pass =0 ; pass <3 ; pass++)test_unload (num_engines); }
Signature · 1 line
2.26.2
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for Nuke unload_i915
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: Nuke unload_i915
URL : https://patchwork.freedesktop.org/series/96238/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10783 -> IGTPW_6351
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/index.html
Participating hosts (37 -> 34)
------------------------------
Additional (1): fi-tgl-1115g4
Missing (4): fi-ctg-p8600 fi-bsw-cyan bat-dg1-6 bat-adlp-4
Known issues
------------
Here are the changes found in IGTPW_6351 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@amdgpu/[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([i915#1155])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [PASS][5] -> [INCOMPLETE][6] ([i915#2940])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/fi-bsw-kefka/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-bsw-kefka/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][8] ([i915#4103]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([i915#1072]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#3301])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-tgl-1115g4/igt@[email protected]
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-modeset@c-dp1:
- fi-cfl-8109u: [FAIL][12] ([i915#4165]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/fi-cfl-8109u/igt@kms_flip@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-cfl-8109u/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][14] ([i915#295]) -> [PASS][15] +18 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/fi-cfl-8109u/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/fi-cfl-8109u/igt@[email protected]
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6260 -> IGTPW_6351
CI-20190529: 20190529
CI_DRM_10783: 4bcbd6854fa894352f74ae4164b88e7d378106a9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6351: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/index.html
IGT_6260: 46994310410404a07d142f33fab220d718c27f64 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for Nuke unload_i915
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: Nuke unload_i915
URL : https://patchwork.freedesktop.org/series/96238/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10783_full -> IGTPW_6351_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/index.html
Participating hosts (10 -> 7)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Known issues
------------
Here are the changes found in IGTPW_6351_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-3x:
- shard-tglb: NOTRUN -> [SKIP][1] ([i915#1839])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@[email protected]
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][2] -> [FAIL][3] ([i915#2410])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-tglb2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@[email protected]
* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-snb5/igt@[email protected]
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#280])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: NOTRUN -> [TIMEOUT][6] ([i915#2369] / [i915#3063] / [i915#3648])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [TIMEOUT][7] ([i915#2369] / [i915#2481] / [i915#3070])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][8] ([i915#3354])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-snb7/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-kbl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl6/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb4/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb6/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-tglb5/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb3/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-apl4/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl2/igt@gem_exec_fair@[email protected]
- shard-glk: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-glk5/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#2849])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb1/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_schedule@semaphore-codependency:
- shard-snb: NOTRUN -> [SKIP][23] ([fdo#109271]) +112 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-snb2/igt@[email protected]
* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [PASS][24] -> [INCOMPLETE][25] ([i915#456])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-tglb1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb7/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][26] -> [DMESG-WARN][27] ([i915#180]) +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-kbl7/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl4/igt@[email protected]
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [PASS][28] -> [DMESG-WARN][29] ([i915#118]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-glk2/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk8/igt@[email protected]
* igt@gem_media_vme:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#284])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@gem_media_vme.html
* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#4270])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb7/igt@[email protected]
* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#768]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@[email protected]
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271]) +200 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl4/igt@[email protected]
* igt@gem_userptr_blits@access-control:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#3297])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3323])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl6/igt@[email protected]
* igt@gen3_render_linear_blits:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109289]) +5 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@gen3_render_linear_blits.html
* igt@gen9_exec_parse@bb-chained:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#2856]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb6/igt@[email protected]
* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#2856]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@[email protected]
* igt@i915_pm_backlight@bad-brightness:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271]) +134 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk9/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][40] -> [FAIL][41] ([i915#454])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb8/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#1937])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl3/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111644] / [i915#1397] / [i915#2411])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#110892])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb2/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][45] -> [INCOMPLETE][46] ([i915#3921])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-snb5/igt@i915_selftest@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-snb2/igt@i915_selftest@[email protected]
* igt@i915_suspend@forcewake:
- shard-apl: NOTRUN -> [DMESG-WARN][47] ([i915#180])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl6/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-kbl: NOTRUN -> [DMESG-WARN][48] ([i915#180]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl4/igt@[email protected]
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#3826])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@[email protected]
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#404])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#110725] / [fdo#111614]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#111614]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#3777]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl3/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3777])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111615]) +8 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-glk: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3777]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk1/igt@[email protected]
* igt@kms_big_joiner@invalid-modeset:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#2705])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#3886]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk8/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#3886]) +10 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl4/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#3886]) +5 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl4/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3689]) +11 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#3689] / [i915#3886]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [i915#3886])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb7/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_cdclk@plane-scaling:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#3742])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#3742])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb3/igt@[email protected]
* igt@kms_chamelium@dp-frame-dump:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109284] / [fdo#111827]) +6 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][67] ([fdo#109271] / [fdo#111827]) +9 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +17 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +6 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-snb7/igt@[email protected]
* igt@kms_color@pipe-d-invalid-ctm-matrix-sizes:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109278]) +18 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb7/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +7 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl6/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109284] / [fdo#111827]) +13 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb3/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109300] / [fdo#111066])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb2/igt@[email protected]
- shard-apl: NOTRUN -> [TIMEOUT][74] ([i915#1319])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl7/igt@[email protected]
* igt@kms_content_protection@type1:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#111828]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-dpms:
- shard-glk: [PASS][76] -> [FAIL][77] ([i915#3444])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-glk1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#3359]) +6 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3319]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-512x170-random:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278] / [fdo#109279])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][81] -> [DMESG-WARN][82] ([i915#180]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-apl3/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x512-offscreen:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109279] / [i915#3359]) +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#4103])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#111825]) +36 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109274] / [fdo#109278]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb7/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109274]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb8/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-iclb: [PASS][89] -> [SKIP][90] ([i915#3701])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb6/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109280]) +16 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_invalid_mode@clock-too-high:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#4278])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#4278])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb7/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#533])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#533]) +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk9/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-tglb: [PASS][96] -> [INCOMPLETE][97] ([i915#2828] / [i915#456])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-tglb5/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][98] ([fdo#108145] / [i915#265])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk6/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][99] ([fdo#108145] / [i915#265])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl6/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][100] ([fdo#108145] / [i915#265])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl2/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][101] ([i915#3536])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#3536])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#658]) +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl3/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#658]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk8/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#2920])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl7/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][107] -> [SKIP][108] ([fdo#109642] / [fdo#111068] / [i915#658])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb2/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb8/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][109] -> [SKIP][110] ([fdo#109441])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][111] ([i915#132] / [i915#3467]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109441]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][113] ([fdo#109271]) +117 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl7/igt@[email protected]
* igt@kms_vrr@flip-basic:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109502])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109502])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb5/igt@[email protected]
* igt@nouveau_crc@pipe-c-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][116] ([i915#2530]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb3/igt@[email protected]
* igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame:
- shard-iclb: NOTRUN -> [SKIP][117] ([fdo#109278] / [i915#2530])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@[email protected]
* igt@perf@unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> [SKIP][118] ([fdo#109289]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb4/igt@[email protected]
* igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109291]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb1/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html
* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][120] ([fdo#109291]) +4 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@prime_nv_pcopy@test3_1.html
* igt@prime_vgem@basic-userptr:
- shard-tglb: NOTRUN -> [SKIP][121] ([i915#3301])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb5/igt@[email protected]
* igt@sysfs_clients@sema-10:
- shard-tglb: NOTRUN -> [SKIP][122] ([i915#2994]) +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb2/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#2994])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2994]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][125] ([i915#2994])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb8/igt@[email protected]
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#2994]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-kbl3/igt@[email protected]
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][127] ([i915#658]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb4/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [FAIL][129] ([i915#2842]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-apl2/igt@gem_exec_fair@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][131] ([i915#2842]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-tglb7/igt@gem_exec_fair@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][133] ([i915#2842]) -> [PASS][134] +2 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-glk9/igt@gem_exec_fair@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-iclb: [FAIL][135] ([fdo#103375]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-iclb2/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-iclb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-suspend:
- shard-tglb: [INCOMPLETE][137] ([i915#2411] / [i915#4211]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10783/shard-tglb7/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/shard-tglb6/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][139] ([i915#180] / [i915#636])
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6351/index.html