device property: Drop redundant NULL checks
Subsystems (3)
Andy Shevchenko
reviewerPATCH 1/1 device property: Drop redundant NULL checks
In cases when functions are called via fwnode operations, we already know that this is software node we are dealing with, hence no need to check if it's NULL, it can't be,
Reported-by YE Chengfeng <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/base/swnode.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/base/swnode.c +0 -6
@@ -413,9 +413,6 @@ software_node_get_name(const struct fwnode_handle *fwnode) {const struct swnode *swnode =to_swnode (fwnode); -if (!swnode) -return "(null)" ; -return kobject_name (&swnode->kobj); }
@@ -507,9 +504,6 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,int error;int i; -if (!swnode) -return -ENOENT ; - prop =property_entry_get (swnode->node->properties, propname);if (!prop)return -ENOENT ;
Signature · 1 line
2.33.0
Quoted 7 lines · Andy Shevchenko
In cases when functions are called via fwnode operations, we already know that this is software node we are dealing with, hence no need to check if it's NULL, it can't be,
Reported-by YE Chengfeng <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Rafael J. Wysocki <[email protected]>
or please let me know if I need to pick this up.
Quoted 31 lines
--- drivers/base/swnode.c | 6 ------ 1 file changed, 6 deletions(-)drivers/base/swnode.c +0
-7@@ -413,9 +413,6 @@ software_node_get_name(const struct fwnode_handle *fwnode) {const struct swnode *swnode =to_swnode (fwnode); -if (!swnode) -return "(null)" ; -return kobject_name (&swnode->kobj); }@@ -507,9 +504,6 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,int error;int i; -if (!swnode) -return -ENOENT ; - prop =property_entry_get (swnode->node->properties, propname);if (!prop)return -ENOENT ; --2.33.0
Greg Kroah-Hartman
maintainerQuoted 7 lines · Rafael J. Wysocki
Quoted 5 lines · Andy Shevchenko
In cases when functions are called via fwnode operations, we already know that this is software node we are dealing with, hence no need to check if it's NULL, it can't be,
Quoted 6 lines
Quoted 2 lines
Reported-by YE Chengfeng <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Rafael J. Wysocki <[email protected]>or please let me know if I need to pick this up.
I can take it, thanks!
greg k-h