Skip to contentSkip to conversation

ima/evm: mark evm_fixmode as __ro_after_init

PATCH In review Austin Kim 2 participants 3 messages Oct 26, 2021 – Oct 28, 2021

Subsystems (4)
Security (LSM) Keys-trusted Integrity measurement architecture (IMA) Extended Verification Module (EVM)
lore
Share & tools
lore

Austin Kim

author
#0 lore raw

PATCH 1/1 ima/evm: mark evm_fixmode as __ro_after_init

From: Austin Kim <[email protected]>

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.

Signed-off-by Austin Kim <[email protected]>
---
 security/integrity/evm/evm_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/integrity/evm/evm_main.c +1 -1
index 1c8435dfabee..08f907382c61 100644
@@ -78,7 +78,7 @@ static struct xattr_list evm_config_default_xattrnames[] = {
 
 LIST_HEAD(evm_config_xattrnames);
 
-static int evm_fixmode;
+static int evm_fixmode __ro_after_init;
 static int __init evm_set_fixmode(char *str)
 {
 	if (strncmp(str, "fix", 3) == 0)
Signature · 1 line
2.20.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Austin,

The subject line should be just "evm:".

Quoted 4 lines · Austin Kim

From: Austin Kim <[email protected]>

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.

Please properly format the text. From
Documentation/process/submitting-patches.rst:

- The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch.

Quoted 2 lines
Signed-off-by Austin Kim <[email protected]>

Otherwise,

Reviewed-by Mimi Zohar <[email protected]>
author
#2 lore raw

Hello Mimi,

2021년 10월 28일 (목) 오전 9:27, Mimi Zohar <[email protected]>님이 작성:

Quoted 8 lines

Hi Austin,

The subject line should be just "evm:".

Quoted 2 lines · Austin Kim

From: Austin Kim <[email protected]>

Quoted 8 lines
Quoted 2 lines

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.

Please properly format the text. From
Documentation/process/submitting-patches.rst:

- The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch.

Thanks for feedback.
let me resend the patch after updating "subject line" and checking text-format.

BR,
Austin Kim

Quoted 7 lines
Quoted 3 lines
Signed-off-by Austin Kim <[email protected]>

Otherwise,

Reviewed-by Mimi Zohar <[email protected]>