arm64/sme: Initial support for the Scalable Matrix Extension
Subsystems (7)
v5 cover arm64/sme: Initial support for the Scalable Matrix Extension
This series provides initial support for the ARMv9 Scalable Matrix Extension (SME). SME takes the approach used for vectors in SVE and extends this to provide architectural support for matrix operations. A more detailed overview can be found in [1].
For the kernel SME can be thought of as a series of features which are intended to be used together by applications but operate mostly orthogonally:
- The ZA matrix register.
- Streaming mode, in which ZA can be accessed and a subset of SVE features are available.
- A second vector length, used for streaming mode SVE and ZA and controlled using a similar interface to that for SVE.
- TPIDR2, a new userspace controllable system register intended for use by the C library for storing context related to the ZA ABI.
A substantial part of the series is dedicated to refactoring the existing SVE support so that we don't need to duplicate code for handling vector lengths and the SVE registers, this involves creating an array of vector types and making the users take the vector type as a parameter. I'm not 100% happy with this but wasn't able to come up with anything better, duplicating code definitely felt like a bad idea so this felt like the least bad thing. If this approach makes sense to people it might make sense to split this off into a separate series and/or merge it while the rest is pending review to try to make things a little more digestable, the series is very large so it'd probably make things easier to digest if some of the preparatory refactoring could be merged before the rest is ready.
One feature of the architecture of particular note is that switching to and from streaming mode may change the size of and invalidate the contents of the SVE registers, and when in streaming mode the FFR is not accessible. This complicates aspects of the ABI like signal handling and ptrace.
This initial implementation is mainly intended to get the ABI in place, there are several areas which will be worked on going forwards - some of these will be blockers, others could be handled in followup serieses:
- KVM is not currently supported and we depend on !KVM, this is obviously not good - in hopefully the next version I will add support for coexisting with KVM and then in a subsequent series implement support for use of SME by KVM guests.
- It is likely some build configurations have issues, I've not fully checked this yet. In general testing is still ongoing, I anticipate finding and fixing some issues in the implementation.
- No support is currently provided for scheduler control of SME or SME applications, given the size of the SME register state the context switch overhead may be noticable so this may be needed especially for real time applications. Similar concerns already exist for larger SVE vector lengths but are amplified for SME, particularly as the vector length increases.
- There has been no work on optimising the performance of anything the kernel does.
It is not expected that any systems will be encountered that support SME but not SVE, SME is an ARMv9 feature and SVE is mandatory for ARMv9. The code attempts to handle any such systems that are encountered but this hasn't been tested extensively.
Due to dependencies on changes already upstreamed this series is based on a merge of for-next/kselftest and for-next/sve in the arm64 tree.
v5:
- Rebase onto currently merged SVE and kselftest patches.
- Add support for the FA64 option, introduced in the recently published EAC1 update to the specification.
- Pull in test program for the syscall ABI previously sent separately with some revisions and add coverage for the SME ABI.
- Fix checking for options with 1 bit fields in ID_AA64SMFR0_EL1.
- Minor fixes and clarifications to the ABI documentation.
v4:
- Rebase onto merged patches.
- Remove an uneeded NULL check in vec_proc_do_default_vl().
- Include patch to factor out utility routines in kselftests written in assembler.
- Specify -ffreestanding when building TPIDR2 test.
v3:
- Skip FFR rather than predicate registers in sve_flush_live().
- Don't assume a bool is all zeros in sve_flush_live() as per AAPCS.
- Don't redundantly specify a zero index when clearing FFR.
v2:
- Fix several issues with !SME and !SVE configurations.
- Preserve TPIDR2 when creating a new thread/process unless CLONE_SETTLS is set.
- Report traps due to using features in an invalid mode as SIGILL.
- Spell out streaming mode behaviour in SVE ABI documentation more directly.
- Document TPIDR2 in the ABI document.
- Use SMSTART and SMSTOP rather than read/modify/write sequences.
- Rework logic for exiting streaming mode on syscall.
- Don't needlessly initialise SVCR on access trap.
- Always restore SME VL for userspace if SME traps are disabled.
- Only yield to encourage preemption every 128 iterations in za-test, otherwise do a getpid(), and validate SVCR after syscall.
- Leave streaming mode disabled except when reading the vector length in za-test, and disable ZA after detecting a mismatch.
- Add SME support to vlset.
- Clarifications and typo fixes in comments.
- Move sme_alloc() forward declaration back a patch.
Mark Brown (38):
arm64/sve: Make sysctl interface for SVE reusable by SME arm64/sve: Generalise vector length configuration prctl() for SME arm64/sve: Minor clarification of ABI documentation kselftest/arm64: Parameterise ptrace vector length information kselftest/arm64: Allow signal tests to trigger from a function kselftest/arm64: Add a test program to exercise the syscall ABI tools/nolibc: Implement gettid()
arm64: Document boot requirements for FEAT_SME_FA64
arm64: cpufeature: Add has_feature_flag() match function arm64/sme: Provide ABI documentation for SME
arm64/sme: System register and exception syndrome definitions arm64/sme: Define macros for manually encoding SME instructions arm64/sme: Early CPU setup for SME
arm64/sme: Basic enumeration support
arm64/sme: Identify supported SME vector lengths at boot arm64/sme: Implement sysctl to set the default vector length arm64/sme: Implement vector length configuration prctl()s arm64/sme: Implement support for TPIDR2
arm64/sme: Implement SVCR context switching
arm64/sme: Implement streaming SVE context switching arm64/sme: Implement ZA context switching
arm64/sme: Implement traps and syscall handling for SME arm64/sme: Implement streaming SVE signal handling arm64/sme: Implement ZA signal handling
arm64/sme: Implement ptrace support for streaming mode SVE registers arm64/sme: Add ptrace support for ZA
arm64/sme: Disable streaming mode and ZA when flushing CPU state arm64/sme: Save and restore streaming mode over EFI runtime calls arm64/sme: Provide Kconfig for SME
kselftest/arm64: sme: Add streaming SME support to vlset kselftest/arm64: Add tests for TPIDR2
kselftest/arm64: Extend vector configuration API tests to cover SME kselftest/arm64: sme: Provide streaming mode SVE stress test kselftest/arm64: Add stress test for SME ZA context switching kselftest/arm64: signal: Add SME signal handling tests kselftest/arm64: Add streaming SVE to SVE ptrace tests kselftest/arm64: Add coverage for the ZA ptrace interface kselftest/arm64: Add SME support to syscall ABI test
Documentation/arm64/booting.rst | 10 + Documentation/arm64/elf_hwcaps.rst | 33 + Documentation/arm64/index.rst | 1 + Documentation/arm64/sme.rst | 430 ++++++++++++ Documentation/arm64/sve.rst | 72 +- arch/arm64/Kconfig | 11 + arch/arm64/include/asm/cpu.h | 4 + arch/arm64/include/asm/cpufeature.h | 24 + arch/arm64/include/asm/el2_setup.h | 45 ++ arch/arm64/include/asm/esr.h | 13 +- arch/arm64/include/asm/exception.h | 1 + arch/arm64/include/asm/fpsimd.h | 112 ++- arch/arm64/include/asm/fpsimdmacros.h | 77 +++ arch/arm64/include/asm/hwcap.h | 8 + arch/arm64/include/asm/kvm_arm.h | 1 + arch/arm64/include/asm/processor.h | 18 +- arch/arm64/include/asm/sysreg.h | 58 ++ arch/arm64/include/asm/thread_info.h | 2 + arch/arm64/include/uapi/asm/hwcap.h | 8 + arch/arm64/include/uapi/asm/ptrace.h | 69 +- arch/arm64/include/uapi/asm/sigcontext.h | 55 +- arch/arm64/kernel/cpufeature.c | 130 ++++ arch/arm64/kernel/cpuinfo.c | 13 + arch/arm64/kernel/entry-common.c | 10 + arch/arm64/kernel/entry-fpsimd.S | 31 + arch/arm64/kernel/fpsimd.c | 641 ++++++++++++++++-- arch/arm64/kernel/process.c | 28 +- arch/arm64/kernel/ptrace.c | 358 ++++++++-- arch/arm64/kernel/signal.c | 187 ++++- arch/arm64/kernel/syscall.c | 43 +- arch/arm64/kernel/traps.c | 1 + arch/arm64/kvm/fpsimd.c | 3 +- arch/arm64/kvm/reset.c | 8 +- arch/arm64/tools/cpucaps | 2 + include/uapi/linux/elf.h | 2 + include/uapi/linux/prctl.h | 9 + kernel/sys.c | 12 + tools/include/nolibc/nolibc.h | 18 + tools/testing/selftests/arm64/Makefile | 2 +- tools/testing/selftests/arm64/abi/.gitignore | 2 + tools/testing/selftests/arm64/abi/Makefile | 15 + .../selftests/arm64/abi/syscall-abi-asm.S | 307 +++++++++ .../testing/selftests/arm64/abi/syscall-abi.c | 485 +++++++++++++ tools/testing/selftests/arm64/abi/tpidr2.c | 298 ++++++++ tools/testing/selftests/arm64/fp/.gitignore | 4 + tools/testing/selftests/arm64/fp/Makefile | 12 +- tools/testing/selftests/arm64/fp/rdvl-sme.c | 14 + tools/testing/selftests/arm64/fp/rdvl.S | 16 + tools/testing/selftests/arm64/fp/rdvl.h | 1 + tools/testing/selftests/arm64/fp/ssve-stress | 59 ++ tools/testing/selftests/arm64/fp/sve-ptrace.c | 230 ++++--- tools/testing/selftests/arm64/fp/sve-test.S | 30 + tools/testing/selftests/arm64/fp/vec-syscfg.c | 10 + tools/testing/selftests/arm64/fp/vlset.c | 10 +- tools/testing/selftests/arm64/fp/za-ptrace.c | 353 ++++++++++ tools/testing/selftests/arm64/fp/za-stress | 59 ++ tools/testing/selftests/arm64/fp/za-test.S | 431 ++++++++++++ .../testing/selftests/arm64/signal/.gitignore | 2 + .../selftests/arm64/signal/test_signals.h | 2 + .../arm64/signal/test_signals_utils.c | 5 +- .../testcases/fake_sigreturn_sme_change_vl.c | 92 +++ .../arm64/signal/testcases/sme_trap_za.c | 36 + .../selftests/arm64/signal/testcases/sme_vl.c | 70 ++ .../arm64/signal/testcases/ssve_regs.c | 129 ++++ 64 files changed, 4974 insertions(+), 248 deletions(-) create mode 100644 Documentation/arm64/sme.rst create mode 100644 tools/testing/selftests/arm64/abi/.gitignore create mode 100644 tools/testing/selftests/arm64/abi/Makefile create mode 100644 tools/testing/selftests/arm64/abi/syscall-abi-asm.S create mode 100644 tools/testing/selftests/arm64/abi/syscall-abi.c create mode 100644 tools/testing/selftests/arm64/abi/tpidr2.c create mode 100644 tools/testing/selftests/arm64/fp/rdvl-sme.c create mode 100644 tools/testing/selftests/arm64/fp/ssve-stress create mode 100644 tools/testing/selftests/arm64/fp/za-ptrace.c create mode 100644 tools/testing/selftests/arm64/fp/za-stress create mode 100644 tools/testing/selftests/arm64/fp/za-test.S create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sme_change_vl.c create mode 100644 tools/testing/selftests/arm64/signal/testcases/sme_trap_za.c create mode 100644 tools/testing/selftests/arm64/signal/testcases/sme_vl.c create mode 100644 tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
base-commit: be4221f75622617bc17e085d8ff109225e24a31b
Signature · 1 line
2.30.2
PATCH v5 1/38 arm64/sve: Make sysctl interface for SVE reusable by SME
The vector length configuration for SME is very similar to that for SVE so in order to allow reuse refactor the SVE configuration so that it takes the vector type from the struct ctl_table. Since there's no dedicated space for this we repurpose the extra1 field to store the vector type, this is otherwise unused for integer sysctls.
--- arch/arm64/kernel/fpsimd.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
arch/arm64/kernel/fpsimd.c +9 -6
@@ -15,6 +15,7 @@#include <linux/compiler.h> #include <linux/cpu.h> #include <linux/cpu_pm.h> +#include <linux/ctype.h> #include <linux/kernel.h> #include <linux/linkage.h> #include <linux/irqflags.h>
@@ -406,12 +407,13 @@ static unsigned int find_supported_vector_length(enum vec_type type, #if defined(CONFIG_ARM64_SVE) && defined(CONFIG_SYSCTL) -static int sve_proc_do_default_vl(struct ctl_table *table, int write, +static int vec_proc_do_default_vl(struct ctl_table *table, int write, void *buffer, size_t *lenp, loff_t *ppos) { - struct vl_info *info = &vl_info[ARM64_VEC_SVE]; + struct vl_info *info = table->extra1; + enum vec_type type = info->type; int ret; - int vl = get_sve_default_vl(); + int vl = get_default_vl(type); struct ctl_table tmp_table = { .data = &vl, .maxlen = sizeof(vl),
@@ -428,7 +430,7 @@ static int sve_proc_do_default_vl(struct ctl_table *table, int write,if (!sve_vl_valid (vl))return -EINVAL ; -set_sve_default_vl (find_supported_vector_length (ARM64_VEC_SVE , vl)); +set_default_vl (type,find_supported_vector_length (type, vl));return 0 ; }
@@ -436,7 +438,8 @@ static struct ctl_table sve_default_vl_table[] = { { .procname = "sve_default_vector_length", .mode = 0644, - .proc_handler = sve_proc_do_default_vl, + .proc_handler = vec_proc_do_default_vl, + .extra1 = &vl_info[ARM64_VEC_SVE], }, { } };
@@ -1107,7 +1110,7 @@ static void fpsimd_flush_thread_vl(enum vec_type type) vl =get_default_vl (type);if (WARN_ON (!sve_vl_valid (vl))) - vl =SVE_VL_MIN ; + vl = vl_info[type].min_vl; supported_vl =find_supported_vector_length (type, vl);if (WARN_ON (supported_vl != vl))
Signature · 1 line
2.30.2
PATCH v5 2/38 arm64/sve: Generalise vector length configuration prctl() for SME
In reply to Mark BrownIn preparation for adding SME support update the bulk of the implementation for the vector length configuration prctl() calls to be independent of vector type.
--- arch/arm64/include/asm/fpsimd.h | 6 ++--- arch/arm64/kernel/fpsimd.c | 47 ++++++++++++++++++--------------- arch/arm64/kernel/ptrace.c | 4 +-- arch/arm64/kvm/reset.c | 8 +++--- 4 files changed, 34 insertions(+), 31 deletions(-)
arch/arm64/include/asm/fpsimd.h +3 -3
@@ -51,8 +51,8 @@ extern void fpsimd_bind_state_to_cpu(struct user_fpsimd_state *state,extern void fpsimd_flush_task_state (struct task_struct *target);extern void fpsimd_save_and_flush_cpu_state (void ); -/* Maximum VL that SVE VL-agnostic software can transparently support */ -#define SVE_VL_ARCH_MAX 0x100 +/* Maximum VL that SVE/SME VL-agnostic software can transparently support */ +#define VL_ARCH_MAX 0x100/* Offset of FFR in the SVE register dump */ static inline size_t sve_ffr_offset (int vl)
@@ -122,7 +122,7 @@ extern void fpsimd_sync_to_sve(struct task_struct *task);extern void sve_sync_to_fpsimd (struct task_struct *task);extern void sve_sync_from_fpsimd_zeropad (struct task_struct *task); -extern int sve_set_vector_length (struct task_struct *task, +extern int vec_set_vector_length (struct task_struct *task,enum vec_type type,unsigned long vl,unsigned long flags);extern int sve_set_current_vl (unsigned long arg);
arch/arm64/kernel/fpsimd.c +25 -22
113 lines not on this page · raw message
arch/arm64/kernel/ptrace.c +2 -2
@@ -812,9 +812,9 @@ static int sve_set(struct task_struct *target,/* * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by -* sve_set_vector_length(), which will also validate them for us: +* vec_set_vector_length(), which will also validate them for us: */ - ret =sve_set_vector_length (target, header.vl, + ret =vec_set_vector_length (target,ARM64_VEC_SVE , header.vl, ((unsigned long )header.flags & ~SVE_PT_REGS_MASK ) <<16 );if (ret) goto out;
arch/arm64/kvm/reset.c +4 -4
@@ -52,10 +52,10 @@ int kvm_arm_init_sve(void)* The get_sve_reg()/set_sve_reg() ioctl interface will need * to be extended with multiple register slice support in * order to support vector lengths greater than -* SVE_VL_ARCH_MAX: +* VL_ARCH_MAX: */ -if (WARN_ON (kvm_sve_max_vl >SVE_VL_ARCH_MAX )) - kvm_sve_max_vl =SVE_VL_ARCH_MAX ; +if (WARN_ON (kvm_sve_max_vl >VL_ARCH_MAX )) + kvm_sve_max_vl =VL_ARCH_MAX ;/* * Don't even try to make use of vector lengths that
@@ -103,7 +103,7 @@ static int kvm_vcpu_finalize_sve(struct kvm_vcpu *vcpu)* set_sve_vls(). Double-check here just to be sure: */ if (WARN_ON (!sve_vl_valid (vl) || vl >sve_max_virtualisable_vl () || - vl >SVE_VL_ARCH_MAX )) + vl >VL_ARCH_MAX ))return -EIO ; buf =kzalloc (SVE_SIG_REGS_SIZE (sve_vq_from_vl (vl)),GFP_KERNEL );
Signature · 1 line
2.30.2
PATCH v5 3/38 arm64/sve: Minor clarification of ABI documentation
In reply to Mark BrownAs suggested by Luis for the SME version of this explicitly say that the vector length should be extracted from the return value of a set vector length prctl() with a bitwise and rather than just any old and.
--- Documentation/arm64/sve.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/arm64/sve.rst +1 -1
@@ -255,7 +255,7 @@ prctl(PR_SVE_GET_VL) vector length change (which would only normally be the case between a fork() or vfork() and the corresponding execve() in typical use). - To extract the vector length from the result, and it with + To extract the vector length from the result, bitwise and it with PR_SVE_VL_LEN_MASK. Return value: a nonnegative value on success, or a negative value on error:
Signature · 1 line
2.30.2
PATCH v5 4/38 kselftest/arm64: Parameterise ptrace vector length information
In reply to Mark BrownSME introduces a new mode called streaming mode in which the SVE registers have a different vector length. Since the ptrace interface for this is based on the existing SVE interface prepare for supporting this by moving the regset specific configuration into struct and passing that around, allowing these tests to be reused for streaming mode. As we will also have to verify the interoperation of the SVE and streaming SVE regsets don't just iterate over an array.
--- tools/testing/selftests/arm64/fp/sve-ptrace.c | 219 ++++++++++++------ 1 file changed, 142 insertions(+), 77 deletions(-)
tools/testing/selftests/arm64/fp/sve-ptrace.c +142 -77
@@ -21,16 +21,37 @@#include "../../kselftest.h" -#define VL_TESTS (((SVE_VQ_MAX - SVE_VQ_MIN) + 1) * 3) -#define FPSIMD_TESTS 5 - -#define EXPECTED_TESTS (VL_TESTS + FPSIMD_TESTS) +#define ARRAY_SIZE (a) (sizeof(a) / sizeof(a[0]))/* <linux/elf.h> and <sys/auxv.h> don't like each other, so: */ #ifndef NT_ARM_SVE #define NT_ARM_SVE 0x405#endif +struct vec_type { +const char *name; +unsigned long hwcap_type; +unsigned long hwcap; +int regset; +int prctl_set; +}; + +static const struct vec_type vec_types[] = { + { + .name ="SVE" , + .hwcap_type =AT_HWCAP , + .hwcap =HWCAP_SVE , + .regset =NT_ARM_SVE , + .prctl_set =PR_SVE_SET_VL , + }, +}; + +#define VL_TESTS (((SVE_VQ_MAX - SVE_VQ_MIN) + 1) * 3) +#define FLAG_TESTS 2 +#define FPSIMD_TESTS 3 + +#define EXPECTED_TESTS ((VL_TESTS + FLAG_TESTS + FPSIMD_TESTS) * ARRAY_SIZE(vec_types)) +static void fill_buf (char *buf,size_t size) {int i;
@@ -59,7 +80,8 @@ static int get_fpsimd(pid_t pid, struct user_fpsimd_state *fpsimd)return ptrace (PTRACE_GETREGSET , pid,NT_PRFPREG , &iov); } -static struct user_sve_header *get_sve (pid_t pid,void **buf,size_t *size) +static struct user_sve_header *get_sve (pid_t pid,const struct vec_type *type, +void **buf,size_t *size) {struct user_sve_header *sve;void *p;
@@ -80,7 +102,7 @@ static struct user_sve_header *get_sve(pid_t pid, void **buf, size_t *size) iov.iov_base = *buf; iov.iov_len = sz; -if (ptrace (PTRACE_GETREGSET , pid,NT_ARM_SVE , &iov)) +if (ptrace (PTRACE_GETREGSET , pid, type->regset, &iov)) goto error; sve = *buf;
@@ -96,17 +118,18 @@ static struct user_sve_header *get_sve(pid_t pid, void **buf, size_t *size)return NULL ; } -static int set_sve (pid_t pid,const struct user_sve_header *sve) +static int set_sve (pid_t pid,const struct vec_type *type, +const struct user_sve_header *sve) {struct iovec iov; iov.iov_base = (void *)sve; iov.iov_len = sve->size; -return ptrace (PTRACE_SETREGSET , pid,NT_ARM_SVE , &iov); +return ptrace (PTRACE_SETREGSET , pid, type->regset, &iov); }/* Validate setting and getting the inherit flag */ -static void ptrace_set_get_inherit (pid_t child) +static void ptrace_set_get_inherit (pid_t child,const struct vec_type *type) {struct user_sve_header sve;struct user_sve_header *new_sve =NULL ;
@@ -118,9 +141,10 @@ static void ptrace_set_get_inherit(pid_t child) sve.size =sizeof (sve); sve.vl =sve_vl_from_vq (SVE_VQ_MIN ); sve.flags =SVE_PT_VL_INHERIT ; - ret =set_sve (child, &sve); + ret =set_sve (child, type, &sve);if (ret !=0 ) { -ksft_test_result_fail ("Failed to set SVE_PT_VL_INHERIT\n" ); +ksft_test_result_fail ("Failed to set %s SVE_PT_VL_INHERIT\n" , + type->name);return ; }
@@ -128,35 +152,39 @@ static void ptrace_set_get_inherit(pid_t child)* Read back the new register state and verify that we have * set the flags we expected. */ -if (!get_sve (child, (void **)&new_sve, &new_sve_size)) { -ksft_test_result_fail ("Failed to read SVE flags\n" ); +if (!get_sve (child, type, (void **)&new_sve, &new_sve_size)) { +ksft_test_result_fail ("Failed to read %s SVE flags\n" , + type->name);return ; }ksft_test_result (new_sve->flags &SVE_PT_VL_INHERIT , -"SVE_PT_VL_INHERIT set\n" ); +"%s SVE_PT_VL_INHERIT set\n" , type->name);/* Now clear */ sve.flags &= ~SVE_PT_VL_INHERIT ; - ret =set_sve (child, &sve); + ret =set_sve (child, type, &sve);if (ret !=0 ) { -ksft_test_result_fail ("Failed to clear SVE_PT_VL_INHERIT\n" ); +ksft_test_result_fail ("Failed to clear %s SVE_PT_VL_INHERIT\n" , + type->name);return ; } -if (!get_sve (child, (void **)&new_sve, &new_sve_size)) { -ksft_test_result_fail ("Failed to read SVE flags\n" ); +if (!get_sve (child, type, (void **)&new_sve, &new_sve_size)) { +ksft_test_result_fail ("Failed to read %s SVE flags\n" , + type->name);return ; }ksft_test_result (!(new_sve->flags &SVE_PT_VL_INHERIT ), -"SVE_PT_VL_INHERIT cleared\n" ); +"%s SVE_PT_VL_INHERIT cleared\n" , type->name);free (new_sve); }/* Validate attempting to set the specfied VL via ptrace */ -static void ptrace_set_get_vl (pid_t child,unsigned int vl,bool *supported) +static void ptrace_set_get_vl (pid_t child,const struct vec_type *type, +unsigned int vl,bool *supported) {struct user_sve_header sve;struct user_sve_header *new_sve =NULL ;
@@ -166,10 +194,10 @@ static void ptrace_set_get_vl(pid_t child, unsigned int vl, bool *supported) *supported = false;/* Check if the VL is supported in this process */ - prctl_vl =prctl (PR_SVE_SET_VL , vl); + prctl_vl =prctl (type->prctl_set, vl);if (prctl_vl ==-1 ) -ksft_exit_fail_msg ("prctl(PR_SVE_SET_VL) failed: %s (%d)\n" , -strerror (errno), errno); +ksft_exit_fail_msg ("prctl(PR_%s_SET_VL) failed: %s (%d)\n" , + type->name,strerror (errno), errno);/* If the VL is not supported then a supported VL will be returned */ *supported = (prctl_vl == vl);
@@ -178,9 +206,10 @@ static void ptrace_set_get_vl(pid_t child, unsigned int vl, bool *supported)memset (&sve,0 ,sizeof (sve)); sve.size =sizeof (sve); sve.vl = vl; - ret =set_sve (child, &sve); + ret =set_sve (child, type, &sve);if (ret !=0 ) { -ksft_test_result_fail ("Failed to set VL %u\n" , vl); +ksft_test_result_fail ("Failed to set %s VL %u\n" , + type->name, vl);return ; }
@@ -188,12 +217,14 @@ static void ptrace_set_get_vl(pid_t child, unsigned int vl, bool *supported)* Read back the new register state and verify that we have the * same VL that we got from prctl() on ourselves. */ -if (!get_sve (child, (void **)&new_sve, &new_sve_size)) { -ksft_test_result_fail ("Failed to read VL %u\n" , vl); +if (!get_sve (child, type, (void **)&new_sve, &new_sve_size)) { +ksft_test_result_fail ("Failed to read %s VL %u\n" , + type->name, vl);return ; } -ksft_test_result (new_sve->vl = prctl_vl,"Set VL %u\n" , vl); +ksft_test_result (new_sve->vl = prctl_vl,"Set %s VL %u\n" , + type->name, vl);free (new_sve); }
@@ -209,7 +240,7 @@ static void check_u32(unsigned int vl, const char *reg, }/* Access the FPSIMD registers via the SVE regset */ -static void ptrace_sve_fpsimd (pid_t child) +static void ptrace_sve_fpsimd (pid_t child,const struct vec_type *type) {void *svebuf =NULL ;size_t svebufsz =0 ;
@@ -219,17 +250,18 @@ static void ptrace_sve_fpsimd(pid_t child)unsigned char *p;/* New process should start with FPSIMD registers only */ - sve =get_sve (child, &svebuf, &svebufsz); + sve =get_sve (child, type, &svebuf, &svebufsz);if (!sve) { -ksft_test_result_fail ("get_sve: %s\n" ,strerror (errno)); +ksft_test_result_fail ("get_sve(%s): %s\n" , + type->name,strerror (errno));return ; }else { -ksft_test_result_pass ("get_sve(FPSIMD)\n" ); +ksft_test_result_pass ("get_sve(%s FPSIMD)\n" , type->name); }ksft_test_result ((sve->flags &SVE_PT_REGS_MASK ) ==SVE_PT_REGS_FPSIMD , -"Set FPSIMD registers\n" ); +"Set FPSIMD registers via %s\n" , type->name);if ((sve->flags &SVE_PT_REGS_MASK ) !=SVE_PT_REGS_FPSIMD ) goto out;
@@ -243,9 +275,9 @@ static void ptrace_sve_fpsimd(pid_t child) p[j] = j; } -if (set_sve (child, sve)) { -ksft_test_result_fail ("set_sve(FPSIMD): %s\n" , -strerror (errno)); +if (set_sve (child, type, sve)) { +ksft_test_result_fail ("set_sve(%s FPSIMD): %s\n" , + type->name,strerror (errno)); goto out; }
@@ -257,16 +289,20 @@ static void ptrace_sve_fpsimd(pid_t child) goto out; }if (memcmp (fpsimd, &new_fpsimd,sizeof (*fpsimd)) ==0 ) -ksft_test_result_pass ("get_fpsimd() gave same state\n" ); +ksft_test_result_pass ("%s get_fpsimd() gave same state\n" , + type->name);else -ksft_test_result_fail ("get_fpsimd() gave different state\n" ); +ksft_test_result_fail ("%s get_fpsimd() gave different state\n" , + type->name); out:free (svebuf); }/* Validate attempting to set SVE data and read SVE data */ -static void ptrace_set_sve_get_sve_data (pid_t child,unsigned int vl) +static void ptrace_set_sve_get_sve_data (pid_t child, +const struct vec_type *type, +unsigned int vl) {void *write_buf;void *read_buf =NULL ;
@@ -281,8 +317,8 @@ static void ptrace_set_sve_get_sve_data(pid_t child, unsigned int vl) data_size =SVE_PT_SVE_OFFSET +SVE_PT_SVE_SIZE (vq,SVE_PT_REGS_SVE ); write_buf =malloc (data_size);if (!write_buf) { -ksft_test_result_fail ("Error allocating %d byte buffer for VL %u\n" , - data_size, vl); +ksft_test_result_fail ("Error allocating %d byte buffer for %s VL %u\n" , + data_size, type->name, vl);return ; } write_sve = write_buf;
@@ -306,23 +342,26 @@ static void ptrace_set_sve_get_sve_data(pid_t child, unsigned int vl)/* TODO: Generate a valid FFR pattern */ - ret =set_sve (child, write_sve); + ret =set_sve (child, type, write_sve);if (ret !=0 ) { -ksft_test_result_fail ("Failed to set VL %u data\n" , vl); +ksft_test_result_fail ("Failed to set %s VL %u data\n" , + type->name, vl); goto out; }/* Read the data back */ -if (!get_sve (child, (void **)&read_buf, &read_sve_size)) { -ksft_test_result_fail ("Failed to read VL %u data\n" , vl); +if (!get_sve (child, type, (void **)&read_buf, &read_sve_size)) { +ksft_test_result_fail ("Failed to read %s VL %u data\n" , + type->name, vl); goto out; } read_sve = read_buf;/* We might read more data if there's extensions we don't know */ if (read_sve->size < write_sve->size) { -ksft_test_result_fail ("Wrote %d bytes, only read %d\n" , - write_sve->size, read_sve->size); +ksft_test_result_fail ("%s wrote %d bytes, only read %d\n" , + type->name, write_sve->size, + read_sve->size); goto out_read; }
@@ -349,7 +388,8 @@ static void ptrace_set_sve_get_sve_data(pid_t child, unsigned int vl)check_u32 (vl,"FPCR" , write_buf +SVE_PT_SVE_FPCR_OFFSET (vq), read_buf +SVE_PT_SVE_FPCR_OFFSET (vq), &errors); -ksft_test_result (errors ==0 ,"Set and get SVE data for VL %u\n" , vl); +ksft_test_result (errors ==0 ,"Set and get %s data for VL %u\n" , + type->name, vl); out_read:free (read_buf);
@@ -358,7 +398,9 @@ static void ptrace_set_sve_get_sve_data(pid_t child, unsigned int vl) }/* Validate attempting to set SVE data and read SVE data */ -static void ptrace_set_sve_get_fpsimd_data (pid_t child,unsigned int vl) +static void ptrace_set_sve_get_fpsimd_data (pid_t child, +const struct vec_type *type, +unsigned int vl) {void *write_buf;struct user_sve_header *write_sve;
@@ -376,8 +418,8 @@ static void ptrace_set_sve_get_fpsimd_data(pid_t child, unsigned int vl) data_size =SVE_PT_SVE_OFFSET +SVE_PT_SVE_SIZE (vq,SVE_PT_REGS_SVE ); write_buf =malloc (data_size);if (!write_buf) { -ksft_test_result_fail ("Error allocating %d byte buffer for VL %u\n" , - data_size, vl); +ksft_test_result_fail ("Error allocating %d byte buffer for %s VL %u\n" , + data_size, type->name, vl);return ; } write_sve = write_buf;
@@ -395,16 +437,17 @@ static void ptrace_set_sve_get_fpsimd_data(pid_t child, unsigned int vl)fill_buf (write_buf +SVE_PT_SVE_FPSR_OFFSET (vq),SVE_PT_SVE_FPSR_SIZE );fill_buf (write_buf +SVE_PT_SVE_FPCR_OFFSET (vq),SVE_PT_SVE_FPCR_SIZE ); - ret =set_sve (child, write_sve); + ret =set_sve (child, type, write_sve);if (ret !=0 ) { -ksft_test_result_fail ("Failed to set VL %u data\n" , vl); +ksft_test_result_fail ("Failed to set %s VL %u data\n" , + type->name, vl); goto out; }/* Read the data back */ if (get_fpsimd (child, &fpsimd_state)) { -ksft_test_result_fail ("Failed to read VL %u FPSIMD data\n" , - vl); +ksft_test_result_fail ("Failed to read %s VL %u FPSIMD data\n" , + type->name, vl); goto out; }
@@ -419,7 +462,8 @@ static void ptrace_set_sve_get_fpsimd_data(pid_t child, unsigned int vl) sizeof(tmp));if (tmp != fpsimd_state.vregs[i]) { -printf ("# Mismatch in FPSIMD for VL %u Z%d\n" , vl, i); +printf ("# Mismatch in FPSIMD for %s VL %u Z%d\n" , + type->name, vl, i); errors++; } }
@@ -429,8 +473,8 @@ static void ptrace_set_sve_get_fpsimd_data(pid_t child, unsigned int vl)check_u32 (vl,"FPCR" , write_buf +SVE_PT_SVE_FPCR_OFFSET (vq), &fpsimd_state.fpcr, &errors); -ksft_test_result (errors ==0 ,"Set and get FPSIMD data for VL %u\n" , - vl); +ksft_test_result (errors ==0 ,"Set and get FPSIMD data for %s VL %u\n" , + type->name, vl); out:free (write_buf);
@@ -440,7 +484,7 @@ static int do_parent(pid_t child) {int ret =EXIT_FAILURE ;pid_t pid; -int status; +int status, i;siginfo_t si;unsigned int vq, vl;bool vl_supported;
@@ -499,26 +543,47 @@ static int do_parent(pid_t child) } } -/* FPSIMD via SVE regset */ -ptrace_sve_fpsimd (child); - -/* prctl() flags */ -ptrace_set_get_inherit (child); - -/* Step through every possible VQ */ -for (vq =SVE_VQ_MIN ; vq <=SVE_VQ_MAX ; vq++) { - vl =sve_vl_from_vq (vq); +for (i =0 ; i <ARRAY_SIZE (vec_types); i++) { +/* FPSIMD via SVE regset */ +if (getauxval (vec_types[i].hwcap_type) & vec_types[i].hwcap) { +ptrace_sve_fpsimd (child, &vec_types[i]); + }else { +ksft_test_result_skip ("%s FPSIMD get via SVE\n" , + vec_types[i].name); +ksft_test_result_skip ("%s FPSIMD set via SVE\n" , + vec_types[i].name); +ksft_test_result_skip ("%s set read via FPSIMD\n" , + vec_types[i].name); + } -/* First, try to set this vector length */ -ptrace_set_get_vl (child, vl, &vl_supported); +/* prctl() flags */ +ptrace_set_get_inherit (child, &vec_types[i]); + +/* Step through every possible VQ */ +for (vq =SVE_VQ_MIN ; vq <=SVE_VQ_MAX ; vq++) { + vl =sve_vl_from_vq (vq); + +/* First, try to set this vector length */ +if (getauxval (vec_types[i].hwcap_type) & + vec_types[i].hwcap) { +ptrace_set_get_vl (child, &vec_types[i], vl, + &vl_supported); + }else { +ksft_test_result_skip ("%s get/set VL %d\n" , + vec_types[i].name, vl); + vl_supported = false; + } -/* If the VL is supported validate data set/get */ -if (vl_supported) { -ptrace_set_sve_get_sve_data (child, vl); -ptrace_set_sve_get_fpsimd_data (child, vl); - }else { -ksft_test_result_skip ("set SVE get SVE for VL %d\n" , vl); -ksft_test_result_skip ("set SVE get FPSIMD for VL %d\n" , vl); +/* If the VL is supported validate data set/get */ +if (vl_supported) { +ptrace_set_sve_get_sve_data (child, &vec_types[i], vl); +ptrace_set_sve_get_fpsimd_data (child, &vec_types[i], vl); + }else { +ksft_test_result_skip ("%s set SVE get SVE for VL %d\n" , + vec_types[i].name, vl); +ksft_test_result_skip ("%s set SVE get FPSIMD for VL %d\n" , + vec_types[i].name, vl); + } } }
Signature · 1 line
2.30.2
PATCH v5 5/38 kselftest/arm64: Allow signal tests to trigger from a function
In reply to Mark BrownCurrently we have the facility to specify custom code to trigger a signal but none of the tests use it and for some reason the framework requires us to also specify a signal to send as a trigger in order to make use of a custom trigger. This doesn't seem to make much sense, instead allow the use of a custom trigger function without specifying a signal to inject.
--- tools/testing/selftests/arm64/signal/test_signals_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/arm64/signal/test_signals_utils.c +1 -1
@@ -310,7 +310,7 @@ int test_setup(struct tdescr *td)int test_run (struct tdescr *td) { -if (td->sig_trig) { +if (td->sig_trig || td->trigger) {if (td->trigger)return td->trigger (td);else
Signature · 1 line
2.30.2
PATCH v5 6/38 kselftest/arm64: Add a test program to exercise the syscall ABI
In reply to Mark BrownCurrently we don't have any coverage of the syscall ABI so let's add a very dumb test program which sets up register patterns, does a sysscall and then checks that the register state after the syscall matches what we expect. The program is written in an extremely simplistic fashion with the goal of making it easy to verify that it's doing what it thinks it's doing, it is not a model of how one should write actual code.
Currently we validate the general purpose, FPSIMD and SVE registers. There are other thing things that could be covered like FPCR and flags registers, these can be covered incrementally - my main focus at the minute is covering the ABI for the SVE registers.
The program repeats the tests for all possible SVE vector lengths in case some vector length specific optimisation causes issues, as well as testing FPSIMD only. It tries two syscalls, getpid() and sched_yield(), in an effort to cover both immediate return to userspace and scheduling another task though there are no guarantees which cases will be hit.
A new test directory "abi" is added to hold the test, it doesn't seem to fit well into any of the existing directories.
--- tools/testing/selftests/arm64/Makefile | 2 +- tools/testing/selftests/arm64/abi/.gitignore | 1 + tools/testing/selftests/arm64/abi/Makefile | 8 + .../selftests/arm64/abi/syscall-abi-asm.S | 240 +++++++++++++ .../testing/selftests/arm64/abi/syscall-abi.c | 325 ++++++++++++++++++ 5 files changed, 575 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/arm64/abi/.gitignore create mode 100644 tools/testing/selftests/arm64/abi/Makefile create mode 100644 tools/testing/selftests/arm64/abi/syscall-abi-asm.S create mode 100644 tools/testing/selftests/arm64/abi/syscall-abi.c
tools/testing/selftests/arm64/Makefile +1 -1
@@ -4,7 +4,7 @@ ARCH ?= $(shell uname -m 2>/dev/null || echo not) ifneq (,$(filter $(ARCH),aarch64 arm64)) -ARM64_SUBTARGETS ?= tags signal pauth fp mte bti +ARM64_SUBTARGETS ?= tags signal pauth fp mte bti abi else ARM64_SUBTARGETS := endif
tools/testing/selftests/arm64/abi/.gitignore new file +1 -0
@@ -0,0 +1 @@ +syscall-abi
tools/testing/selftests/arm64/abi/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2021 ARM Limited + +TEST_GEN_PROGS := syscall-abi + +include ../../lib.mk + +$(OUTPUT)/syscall-abi: syscall-abi.c syscall-abi-asm.S
tools/testing/selftests/arm64/abi/syscall-abi-asm.S new file +240 -0
240 lines not on this page · raw message
tools/testing/selftests/arm64/abi/syscall-abi.c new file +325 -0
325 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 7/38 tools/nolibc: Implement gettid()
In reply to Mark BrownAllow test programs to determine their thread ID.
--- tools/include/nolibc/nolibc.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
tools/include/nolibc/nolibc.h +18 -0
@@ -1555,6 +1555,12 @@ pid_t sys_getpid(void)return my_syscall0 (__NR_getpid); } +static __attribute__((unused)) +pid_t sys_gettid (void ) +{ +return my_syscall0 (__NR_gettid); +} +static __attribute__((unused))int sys_gettimeofday (struct timeval *tv,struct timezone *tz) {
@@ -2013,6 +2019,18 @@ pid_t getpid(void)return ret; } +static __attribute__((unused)) +pid_t gettid (void ) +{ +pid_t ret =sys_gettid (); + +if (ret <0 ) { +SET_ERRNO (-ret); + ret =-1 ; + } +return ret; +} +static __attribute__((unused))int gettimeofday (struct timeval *tv,struct timezone *tz) {
Signature · 1 line
2.30.2
PATCH v5 8/38 arm64: Document boot requirements for FEAT_SME_FA64
In reply to Mark BrownThe EAC1 release of the SME specification adds the FA64 feature which requires enablement at higher ELs before lower ELs can use it. Document what we require from higher ELs in our boot requirements.
--- Documentation/arm64/booting.rst | 10 ++++++++++ 1 file changed, 10 insertions(+)
Documentation/arm64/booting.rst +10 -0
@@ -340,6 +340,16 @@ Before jumping into the kernel, the following conditions must be met: - SMCR_EL2.LEN must be initialised to the same value for all CPUs the kernel will execute on. + For CPUs with the Scalable Matrix Extension FA64 feature (FEAT_SME_FA64) + + - If EL3 is present: + + - SMCR_EL3.FA64 (bit 31) must be initialised to 0b1. + + - If the kernel is entered at EL1 and EL2 is present: + + - SMCR_EL2.FA64 (bit 31) must be initialised to 0b1. + The requirements described above for CPU mode, caches, MMUs, architected timers, coherency and system registers apply to all CPUs. All CPUs must enter the kernel in the same exception level. Where the values documented
Signature · 1 line
2.30.2
PATCH v5 9/38 arm64: cpufeature: Add has_feature_flag() match function
In reply to Mark BrownThe default has_cpuid_feature() match function operates on the standard 4 bit fields used in the main ID registers which can't be used with some of the ID registers used for SME extensions which have features identified by single bits and need to be exposed both as hwcaps and for kernel internal use. Support matching such simple flag based matches by providing an alternative match function which simply checks if the bit at the specified field_pos is set and provide helper macros for defining hwcaps using this match function rather than has_cpuid_feature().
--- arch/arm64/kernel/cpufeature.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
arch/arm64/kernel/cpufeature.c +26 -0
@@ -1311,6 +1311,20 @@ has_cpuid_feature(const struct arm64_cpu_capabilities *entry, int scope)return feature_matches (val, entry); } +static bool +has_feature_flag (const struct arm64_cpu_capabilities *entry,int scope) +{ +u64 val; + +WARN_ON (scope ==SCOPE_LOCAL_CPU &&preemptible ()); +if (scope ==SCOPE_SYSTEM ) + val =read_sanitised_ftr_reg (entry->sys_reg); +else + val =__read_sysreg_by_encoding (entry->sys_reg); + +return val & ((u64 )1 << entry->field_pos); +} +const struct cpumask *system_32bit_el0_cpumask (void ) {if (!system_supports_32bit_el0 ())
@@ -2367,6 +2381,18 @@ static const struct arm64_cpu_capabilities arm64_features[] = { .matches = match, \ } + +#define HWCAP_CPUID_FLAG_MATCH (reg, field) \ + .matches = has_feature_flag, \ + .sys_reg = reg, \ + .field_pos = field, + +#define HWCAP_CAP_FLAG (reg, field, cap_type, cap) \ + { \ + __HWCAP_CAP(#cap, cap_type, cap) \ + HWCAP_CPUID_FLAG_MATCH(reg, field) \ + } + #ifdef CONFIG_ARM64_PTR_AUTH static const struct arm64_cpu_capabilities ptr_auth_hwcap_addr_matches[] = { {
Signature · 1 line
2.30.2
PATCH v5 10/38 arm64/sme: Provide ABI documentation for SME
In reply to Mark BrownProvide ABI documentation for SME similar to that for SVE. Due to the very large overlap around streaming SVE mode in both implementation and interfaces documentation for streaming mode SVE is added to the SVE document rather than the SME one.
--- Documentation/arm64/index.rst | 1 + Documentation/arm64/sme.rst | 430 ++++++++++++++++++++++++++++++++++ Documentation/arm64/sve.rst | 70 +++++- 3 files changed, 491 insertions(+), 10 deletions(-) create mode 100644 Documentation/arm64/sme.rst
Documentation/arm64/index.rst +1 -0
@@ -21,6 +21,7 @@ ARM64 Architecture perf pointer-authentication silicon-errata + sme sve tagged-address-abi tagged-pointers
Documentation/arm64/sme.rst new file +430 -0
430 lines not on this page · raw message
Documentation/arm64/sve.rst +60 -10
139 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 11/38 arm64/sme: System register and exception syndrome definitions
In reply to Mark BrownThe arm64 Scalable Matrix Extension (SME) adds some new system registers, fields in existing system registers and exception syndromes. This patch adds definitions for these for use in future patches implementing support for this extension.
Since SME will be the first user of FEAT_HCX in the kernel also include the definitions for enumerating it and the HCRX system register it adds.
--- arch/arm64/include/asm/esr.h | 12 ++++++- arch/arm64/include/asm/kvm_arm.h | 1 + arch/arm64/include/asm/sysreg.h | 58 ++++++++++++++++++++++++++++++++ arch/arm64/kernel/traps.c | 1 + 4 files changed, 71 insertions(+), 1 deletion(-)
arch/arm64/include/asm/esr.h +11 -1
@@ -37,7 +37,8 @@#define ESR_ELx_EC_ERET (0x1a)/* EL2 only */ /* Unallocated EC: 0x1B */ #define ESR_ELx_EC_FPAC (0x1C)/* EL1 and above */ -/* Unallocated EC: 0x1D - 0x1E */ +#define ESR_ELx_EC_SME (0x1D) +/* Unallocated EC: 0x1E */ #define ESR_ELx_EC_IMP_DEF (0x1f)/* EL3 only */ #define ESR_ELx_EC_IABT_LOW (0x20)#define ESR_ELx_EC_IABT_CUR (0x21)
@@ -320,6 +321,15 @@#define ESR_ELx_CP15_32_ISS_SYS_CNTFRQ (ESR_ELx_CP15_32_ISS_SYS_VAL(0, 0, 14, 0) |\ ESR_ELx_CP15_32_ISS_DIR_READ) +/* +* ISS values for SME traps +*/ + +#define ESR_ELx_SME_ISS_SME_DISABLED 0 +#define ESR_ELx_SME_ISS_ILL 1 +#define ESR_ELx_SME_ISS_SM_DISABLED 2 +#define ESR_ELx_SME_ISS_ZA_DISABLED 3 +#ifndef __ASSEMBLY__#include <asm/types.h>
arch/arm64/include/asm/kvm_arm.h +1 -0
@@ -279,6 +279,7 @@#define CPTR_EL2_TCPAC (1 << 31)#define CPTR_EL2_TAM (1 << 30)#define CPTR_EL2_TTA (1 << 20) +#define CPTR_EL2_TSM (1 << 12)#define CPTR_EL2_TFP (1 << CPTR_EL2_TFP_SHIFT)#define CPTR_EL2_TZ (1 << 8)#define CPTR_NVHE_EL2_RES1 0x000032ff/* known RES1 bits in CPTR_EL2 (nVHE) */
arch/arm64/include/asm/sysreg.h +58 -0
150 lines not on this page · raw message
arch/arm64/kernel/traps.c +1 -0
@@ -816,6 +816,7 @@ static const char *esr_class_str[] = { [ESR_ELx_EC_SVE] = "SVE", [ESR_ELx_EC_ERET] = "ERET/ERETAA/ERETAB", [ESR_ELx_EC_FPAC] = "FPAC", + [ESR_ELx_EC_SME] = "SME", [ESR_ELx_EC_IMP_DEF] = "EL3 IMP DEF", [ESR_ELx_EC_IABT_LOW] = "IABT (lower EL)", [ESR_ELx_EC_IABT_CUR] = "IABT (current EL)",
Signature · 1 line
2.30.2
PATCH v5 12/38 arm64/sme: Define macros for manually encoding SME instructions
In reply to Mark BrownAs with SVE rather than impose ambitious toolchain requirements for SME we manually encode the few instructions which we require in order to perform the work the kernel needs to do. That is currently:
- Vector store and load for the ZA array.
- Zeroing of the whole ZA array.
This does not include the SMSTART and SMSTOP instructions which are single instructions and only used from C code, a later patch will define them as inline assembly.
--- arch/arm64/include/asm/fpsimdmacros.h | 44 +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
arch/arm64/include/asm/fpsimdmacros.h +44 -0
@@ -93,6 +93,12 @@ .endif .endm +.macro _sme_check_wv v + .if (\v) < 12 || (\v) > 15 + .error "Bad vector select register \v." + .endif +.endm +/* SVE instruction encodings for non-SVE-capable assemblers */ /* (pre binutils 2.28, all kernel capable clang versions support SVE) */
@@ -174,6 +180,44 @@ | (\np) .endm +/* SME instruction encodings for non-SME-capable assemblers */ + +/* + * STR (vector from ZA array): + * STR ZA[\nw, #\offset], [X\nxbase, #\offset, MUL VL] + */ +.macro _sme_str_zav nw, nxbase, offset=0 + _sme_check_wv \nw + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe1200000 \ + | (((\nw) & 3) << 13) \ + | ((\nxbase) << 5) \ + | ((\offset) & 7) +.endm + +/* +* LDR (vector to ZA array): +* LDR ZA[\nw, #\offset], [X\nxbase, #\offset, MUL VL] +*/ +.macro _sme_ldr_zav nw, nxbase, offset=0 + _sme_check_wv \nw + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe1000000 \ + | (((\nw) & 3) << 13) \ + | ((\nxbase) << 5) \ + | ((\offset) & 7) +.endm + +/* +* Zero the entire ZA array +* ZERO ZA +*/ +.macro zero_za + .inst 0xc00800ff +.endm + .macro __for from:req, to:req .if (\from) == (\to) _for__body %\from
Signature · 1 line
2.30.2
PATCH v5 13/38 arm64/sme: Early CPU setup for SME
In reply to Mark BrownSME requires similar setup to that for SVE: disable traps to EL2 and make sure that the maximum vector length is available to EL1, for SME we have two traps - one for SME itself and one for TPIDR2.
In addition since we currently make no active use of priority control for SCMUs we map all SME priorities lower ELs may configure to 0, the architecture specified minimum priority, to ensure that nothing we manage is able to configure itself to consume excessive resources. This will need to be revisited should there be a need to manage SME priorities at runtime.
--- arch/arm64/include/asm/el2_setup.h | 45 ++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)
arch/arm64/include/asm/el2_setup.h +45 -0
@@ -143,6 +143,50 @@ .Lskip_sve_\@: .endm +/* SME register access and priority mapping */ +.macro __init_el2_nvhe_sme + mrs x1, id_aa64pfr1_el1 + ubfx x1, x1, #ID_AA64PFR1_SME_SHIFT, #4 + cbz x1, .Lskip_sme_\@ + + bic x0, x0, #CPTR_EL2_TSM // Also disable SME traps + msr cptr_el2, x0 // Disable copro. traps to EL2 + isb + + mrs x1, sctlr_el2 + orr x1, x1, #SCTLR_ELx_ENTP2 // Disable TPIDR2 traps + msr sctlr_el2, x1 + isb + + mov x1, #0 // SMCR controls + + mrs_s x2, SYS_ID_AA64SMFR0_EL1 + ubfx x2, x2, #ID_AA64SMFR0_FA64_SHIFT, #1 // Full FP in SM? + cbz x2, .Lskip_sme_fa64_\@ + + orr x1, x1, SMCR_ELx_FA64_MASK +.Lskip_sme_fa64_\@: + + orr x1, x1, #SMCR_ELx_LEN_MASK // Enable full SME vector + msr_s SYS_SMCR_EL2, x1 // length for EL1. + + mrs_s x1, SYS_SMIDR_EL1 // Priority mapping supported? + ubfx x1, x1, #SYS_SMIDR_EL1_SMPS_SHIFT, #1 + cbz x1, .Lskip_sme_\@ + + msr_s SYS_SMPRIMAP_EL2, xzr // Make all priorities equal + + mrs x1, id_aa64mmfr1_el1 // HCRX_EL2 present? + ubfx x1, x1, #ID_AA64MMFR1_HCX_SHIFT, #4 + cbz x1, .Lskip_sme_\@ + + mrs_s x1, SYS_HCRX_EL2 + orr x1, x1, #HCRX_EL2_SMPME_MASK // Enable priority mapping + msr_s SYS_HCRX_EL2, x1 + +.Lskip_sme_\@: +.endm + /* Disable any fine grained traps */ .macro __init_el2_fgt mrs x1, id_aa64mmfr0_el1
@@ -196,6 +240,7 @@__init_el2_nvhe_idregs __init_el2_nvhe_cptr__init_el2_nvhe_sve + __init_el2_nvhe_sme__init_el2_fgt __init_el2_nvhe_prepare_eret .endm
Signature · 1 line
2.30.2
PATCH v5 14/38 arm64/sme: Basic enumeration support
In reply to Mark BrownThis patch introduces basic cpufeature support for discovering the presence of the Scalable Matrix Extension and reporting hwcaps for the detected features.
--- Documentation/arm64/elf_hwcaps.rst | 33 +++++++++++++++++ arch/arm64/include/asm/cpu.h | 1 + arch/arm64/include/asm/cpufeature.h | 12 +++++++ arch/arm64/include/asm/fpsimd.h | 2 ++ arch/arm64/include/asm/hwcap.h | 8 +++++ arch/arm64/include/uapi/asm/hwcap.h | 8 +++++ arch/arm64/kernel/cpufeature.c | 55 +++++++++++++++++++++++++++++ arch/arm64/kernel/cpuinfo.c | 9 +++++ arch/arm64/kernel/fpsimd.c | 30 ++++++++++++++++ arch/arm64/tools/cpucaps | 2 ++ 10 files changed, 160 insertions(+)
Documentation/arm64/elf_hwcaps.rst +33 -0
@@ -247,6 +247,39 @@ HWCAP2_MTE Functionality implied by ID_AA64PFR1_EL1.MTE == 0b0010, as described by Documentation/arm64/memory-tagging-extension.rst. +HWCAP2_SME + + Functionality implied by ID_AA64PFR1_EL1.SME == 0b0001, as described + by Documentation/arm64/sme.rst. + +HWCAP2_SME_I16I64 + + Functionality implied by ID_AA64SMFR0_EL1.I16I64 == 0b1111. + +HWCAP2_SME_F64F64 + + Functionality implied by ID_AA64SMFR0_EL1.F64F64 == 0b1. + +HWCAP2_SME_I8I32 + + Functionality implied by ID_AA64SMFR0_EL1.I8I32 == 0b1111. + +HWCAP2_SME_F16F32 + + Functionality implied by ID_AA64SMFR0_EL1.F16F32 == 0b1. + +HWCAP2_SME_B16F32 + + Functionality implied by ID_AA64SMFR0_EL1.B16F32 == 0b1. + +HWCAP2_SME_F32F32 + + Functionality implied by ID_AA64SMFR0_EL1.F32F32 == 0b1. + +HWCAP2_SME_FA64 + + Functionality implied by ID_AA64SMFR0_EL1.FA64 == 0b1. + 4. Unused AT_HWCAP bits -----------------------
arch/arm64/include/asm/cpu.h +1 -0
@@ -57,6 +57,7 @@ struct cpuinfo_arm64 {u64 reg_id_aa64pfr0;u64 reg_id_aa64pfr1;u64 reg_id_aa64zfr0; +u64 reg_id_aa64smfr0;struct cpuinfo_32bit aarch32;
arch/arm64/include/asm/cpufeature.h +12 -0
@@ -727,6 +727,18 @@ static __always_inline bool system_supports_sve(void)cpus_have_const_cap (ARM64_SVE ); } +static __always_inline bool system_supports_sme(void) +{ +return IS_ENABLED (CONFIG_ARM64_SME ) && +cpus_have_const_cap (ARM64_SME ); +} + +static __always_inline bool system_supports_fa64(void) +{ +return IS_ENABLED (CONFIG_ARM64_SME ) && +cpus_have_const_cap (ARM64_SME_FA64 ); +} + static __always_inline bool system_supports_cnp(void) { return IS_ENABLED(CONFIG_ARM64_CNP) &&
arch/arm64/include/asm/fpsimd.h +2 -0
@@ -74,6 +74,8 @@ extern void sve_set_vq(unsigned long vq_minus_1);struct arm64_cpu_capabilities ;extern void sve_kernel_enable (const struct arm64_cpu_capabilities *__unused); +extern void sme_kernel_enable (const struct arm64_cpu_capabilities *__unused); +extern void fa64_kernel_enable (const struct arm64_cpu_capabilities *__unused);extern u64 read_zcr_features (void );
arch/arm64/include/asm/hwcap.h +8 -0
@@ -105,6 +105,14 @@#define KERNEL_HWCAP_RNG __khwcap2_feature(RNG)#define KERNEL_HWCAP_BTI __khwcap2_feature(BTI)#define KERNEL_HWCAP_MTE __khwcap2_feature(MTE) +#define KERNEL_HWCAP_SME __khwcap2_feature(SME) +#define KERNEL_HWCAP_SME_I16I64 __khwcap2_feature(SME_I16I64) +#define KERNEL_HWCAP_SME_F64F64 __khwcap2_feature(SME_F64F64) +#define KERNEL_HWCAP_SME_I8I32 __khwcap2_feature(SME_I8I32) +#define KERNEL_HWCAP_SME_F16F32 __khwcap2_feature(SME_F16F32) +#define KERNEL_HWCAP_SME_B16F32 __khwcap2_feature(SME_B16F32) +#define KERNEL_HWCAP_SME_F32F32 __khwcap2_feature(SME_F32F32) +#define KERNEL_HWCAP_SME_FA64 __khwcap2_feature(SME_FA64)/* * This yields a mask that user programs can use to figure out what
arch/arm64/include/uapi/asm/hwcap.h +8 -0
@@ -75,5 +75,13 @@#define HWCAP2_RNG (1 << 16)#define HWCAP2_BTI (1 << 17)#define HWCAP2_MTE (1 << 18) +#define HWCAP2_SME (1 << 20) +#define HWCAP2_SME_I16I64 (1 << 21) +#define HWCAP2_SME_F64F64 (1 << 22) +#define HWCAP2_SME_I8I32 (1 << 23) +#define HWCAP2_SME_F16F32 (1 << 24) +#define HWCAP2_SME_B16F32 (1 << 25) +#define HWCAP2_SME_F32F32 (1 << 26) +#define HWCAP2_SME_FA64 (1 << 27)#endif /* _UAPI__ASM_HWCAP_H */
arch/arm64/kernel/cpufeature.c +55 -0
91 lines not on this page · raw message
arch/arm64/kernel/cpuinfo.c +9 -0
@@ -94,6 +94,14 @@ static const char *const hwcap_str[] = { [KERNEL_HWCAP_RNG] = "rng", [KERNEL_HWCAP_BTI] = "bti", [KERNEL_HWCAP_MTE] = "mte", + [KERNEL_HWCAP_SME] = "sme", + [KERNEL_HWCAP_SME_I16I64] = "smei16i64", + [KERNEL_HWCAP_SME_F64F64] = "smef64f64", + [KERNEL_HWCAP_SME_I8I32] = "smei8i32", + [KERNEL_HWCAP_SME_F16F32] = "smef16f32", + [KERNEL_HWCAP_SME_B16F32] = "smeb16f32", + [KERNEL_HWCAP_SME_F32F32] = "smef32f32", + [KERNEL_HWCAP_SME_FA64] = "smefa64", };#ifdef CONFIG_COMPAT
@@ -396,6 +404,7 @@ static void __cpuinfo_store_cpu(struct cpuinfo_arm64 *info) info->reg_id_aa64pfr0 =read_cpuid (ID_AA64PFR0_EL1 ); info->reg_id_aa64pfr1 =read_cpuid (ID_AA64PFR1_EL1 ); info->reg_id_aa64zfr0 =read_cpuid (ID_AA64ZFR0_EL1 ); + info->reg_id_aa64smfr0 =read_cpuid (ID_AA64SMFR0_EL1 );if (id_aa64pfr1_mte (info->reg_id_aa64pfr1)) info->reg_gmid =read_cpuid (GMID_EL1 );
arch/arm64/kernel/fpsimd.c +30 -0
@@ -983,6 +983,32 @@ void fpsimd_release_task(struct task_struct *dead_task)#endif /* CONFIG_ARM64_SVE */ +#ifdef CONFIG_ARM64_SME + +void sme_kernel_enable (const struct arm64_cpu_capabilities *__always_unused p) +{ +/* Set priority for all PEs to architecturally defined minimum */ +write_sysreg_s (read_sysreg_s (SYS_SMPRI_EL1 ) & ~SMPRI_EL1_PRIORITY_MASK , +SYS_SMPRI_EL1 ); + +/* Allow SME in kernel */ +write_sysreg (read_sysreg (CPACR_EL1 ) |CPACR_EL1_SMEN_EL1EN ,CPACR_EL1 ); +isb (); +} + +/* +* This must be called after sme_kernel_enable(), we rely on the +* feature table being sorted to ensure this. +*/ +void fa64_kernel_enable (const struct arm64_cpu_capabilities *__always_unused p) +{ +/* Allow use of FA64 */ +write_sysreg_s (read_sysreg_s (SYS_SMCR_EL1 ) | SMCR_ELx_FA64_MASK, +SYS_SMCR_EL1 ); +} + +#endif /* CONFIG_ARM64_SVE */ +/* * Trapped SVE access *
@@ -1525,6 +1551,10 @@ static int __init fpsimd_init(void)if (!cpu_have_named_feature (ASIMD ))pr_notice ("Advanced SIMD is not implemented\n" ); + +if (cpu_have_named_feature (SME ) && !cpu_have_named_feature (SVE )) +pr_notice ("SME is implemented but not SVE\n" ); +return sve_sysctl_init (); }core_initcall (fpsimd_init);
arch/arm64/tools/cpucaps +2 -0
@@ -39,6 +39,8 @@ HW_DBM KVM_PROTECTED_MODE MISMATCHED_CACHE_TYPE MTE +SME +SME_FA64 SPECTRE_V2 SPECTRE_V3A SPECTRE_V4
Signature · 1 line
2.30.2
PATCH v5 15/38 arm64/sme: Identify supported SME vector lengths at boot
In reply to Mark BrownThe vector lengths used for SME are controlled through a similar set of registers to those for SVE and enumerated using a similar algorithm with some slight differences due to the fact that unlike SVE there are no restrictions on which combinations of vector lengths can be supported nor any mandatory vector lengths which must be implemented. Add a new vector type and implement support for enumerating it.
One slightly awkward feature is that we need to read the current vector length using the SVE RVDL instruction while in streaming mode. Rather than add an ops structure we add special cases directly in the otherwise generic vec_probe_vqs() function, this is a bit inelegant but it's the only place where this is an issue.
--- arch/arm64/include/asm/cpu.h | 3 + arch/arm64/include/asm/cpufeature.h | 7 ++ arch/arm64/include/asm/fpsimd.h | 44 ++++++++++ arch/arm64/include/asm/processor.h | 1 + arch/arm64/kernel/cpufeature.c | 49 +++++++++++ arch/arm64/kernel/cpuinfo.c | 4 + arch/arm64/kernel/fpsimd.c | 131 +++++++++++++++++++++++++++- 7 files changed, 238 insertions(+), 1 deletion(-)
arch/arm64/include/asm/cpu.h +3 -0
@@ -63,6 +63,9 @@ struct cpuinfo_arm64 {/* pseudo-ZCR for recording maximum ZCR_EL1 LEN value: */ u64 reg_zcr; + +/* pseudo-SMCR for recording maximum ZCR_EL1 LEN value: */ +u64 reg_smcr; }; DECLARE_PER_CPU(struct cpuinfo_arm64, cpu_data);
arch/arm64/include/asm/cpufeature.h +7 -0
@@ -619,6 +619,13 @@ static inline bool id_aa64pfr0_sve(u64 pfr0)return val >0 ; } +static inline bool id_aa64pfr1_sme (u64 pfr1) +{ +u32 val =cpuid_feature_extract_unsigned_field (pfr1,ID_AA64PFR1_SME_SHIFT ); + +return val >0 ; +} +static inline bool id_aa64pfr1_mte (u64 pfr1) {u32 val =cpuid_feature_extract_unsigned_field (pfr1,ID_AA64PFR1_MTE_SHIFT );
arch/arm64/include/asm/fpsimd.h +44 -0
62 lines not on this page · raw message
arch/arm64/include/asm/processor.h +1 -0
@@ -117,6 +117,7 @@ struct debug_info {enum vec_type {ARM64_VEC_SVE =0 , +ARM64_VEC_SME ,ARM64_VEC_MAX , };
arch/arm64/kernel/cpufeature.c +49 -0
97 lines not on this page · raw message
arch/arm64/kernel/cpuinfo.c +4 -0
@@ -416,6 +416,10 @@ static void __cpuinfo_store_cpu(struct cpuinfo_arm64 *info) id_aa64pfr0_sve(info->reg_id_aa64pfr0)) info->reg_zcr = read_zcr_features(); +if (IS_ENABLED (CONFIG_ARM64_SME ) && +id_aa64pfr1_sme (info->reg_id_aa64pfr1)) + info->reg_smcr =read_smcr_features (); +cpuinfo_detect_icache_policy (info); }
arch/arm64/kernel/fpsimd.c +130 -1
167 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 16/38 arm64/sme: Implement sysctl to set the default vector length
In reply to Mark BrownAs for SVE provide a sysctl which allows the default SME vector length to be configured.
--- arch/arm64/kernel/fpsimd.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-)
arch/arm64/kernel/fpsimd.c +28 -1
@@ -479,6 +479,30 @@ static int __init sve_sysctl_init(void)static int __init sve_sysctl_init (void ) {return 0 ; }#endif /* ! (CONFIG_ARM64_SVE && CONFIG_SYSCTL) */ +#if defined(CONFIG_ARM64_SME ) && defined(CONFIG_SYSCTL ) +static struct ctl_table sme_default_vl_table[] = { + { + .procname ="sme_default_vector_length" , + .mode =0644 , + .proc_handler = vec_proc_do_default_vl, + .extra1 = &vl_info[ARM64_VEC_SME ], + }, + { } +}; + +static int __init sme_sysctl_init (void ) +{ +if (system_supports_sme ()) +if (!register_sysctl ("abi" , sme_default_vl_table)) +return -EINVAL ; + +return 0 ; +} + +#else /* ! (CONFIG_ARM64_SME && CONFIG_SYSCTL) */ +static int __init sme_sysctl_init (void ) {return 0 ; } +#endif /* ! (CONFIG_ARM64_SME && CONFIG_SYSCTL) */ +#define ZREG (sve_state, vq, n) ((char *)(sve_state) + \ (SVE_SIG_ZREG_OFFSET(vq, n) - SVE_SIG_REGS_OFFSET))
@@ -1684,6 +1708,9 @@ static int __init fpsimd_init(void)if (cpu_have_named_feature (SME ) && !cpu_have_named_feature (SVE ))pr_notice ("SME is implemented but not SVE\n" ); -return sve_sysctl_init (); +sve_sysctl_init (); +sme_sysctl_init (); + +return 0 ; }core_initcall (fpsimd_init);
Signature · 1 line
2.30.2
PATCH v5 17/38 arm64/sme: Implement vector length configuration prctl()s
In reply to Mark BrownAs for SVE provide a prctl() interface which allows processes to configure their SME vector length.
--- arch/arm64/include/asm/fpsimd.h | 13 +++++++++++ arch/arm64/include/asm/processor.h | 4 +++- arch/arm64/include/asm/thread_info.h | 1 + arch/arm64/kernel/fpsimd.c | 32 ++++++++++++++++++++++++++++ include/uapi/linux/prctl.h | 9 ++++++++ kernel/sys.c | 12 +++++++++++ 6 files changed, 70 insertions(+), 1 deletion(-)
arch/arm64/include/asm/fpsimd.h +13 -0
@@ -284,6 +284,9 @@ static inline int sme_max_virtualisable_vl(void) return vec_max_virtualisable_vl(ARM64_VEC_SME); } +extern int sme_set_current_vl (unsigned long arg); +extern int sme_get_current_vl (void ); +#else static inline void sme_setup (void ) { }
@@ -293,6 +296,16 @@ static inline int sme_max_virtualisable_vl(void) { return 0; }static inline void sme_smstart_sm (void ) { }static inline void sme_smstop_sm (void ) { } +static inline int sme_set_current_vl (unsigned long arg) +{ +return -EINVAL ; +} + +static inline int sme_get_current_vl (void ) +{ +return -EINVAL ; +} +#endif /* ! CONFIG_ARM64_SME */ /* For use by EFI runtime services calls only */
arch/arm64/include/asm/processor.h +3 -1
@@ -354,9 +354,11 @@ extern void __init minsigstksz_setup(void);*/ #include <asm/fpsimd.h> -/* Userspace interface for PR_SVE_{SET,GET}_VL prctl()s: */ +/* Userspace interface for PR_S[MV]E_{SET,GET}_VL prctl()s: */ #define SVE_SET_VL (arg) sve_set_current_vl(arg)#define SVE_GET_VL () sve_get_current_vl() +#define SME_SET_VL (arg) sme_set_current_vl(arg) +#define SME_GET_VL () sme_get_current_vl()/* PR_PAC_RESET_KEYS prctl */ #define PAC_RESET_KEYS (tsk, arg) ptrauth_prctl_reset_keys(tsk, arg)
arch/arm64/include/asm/thread_info.h +1 -0
@@ -81,6 +81,7 @@ int arch_dup_task_struct(struct task_struct *dst,#define TIF_SVE_VL_INHERIT 24/* Inherit SVE vl_onexec across exec */ #define TIF_SSBD 25/* Wants SSB mitigation */ #define TIF_TAGGED_ADDR 26/* Allow tagged user addresses */ +#define TIF_SME_VL_INHERIT 28/* Inherit SME vl_onexec across exec */ #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
arch/arm64/kernel/fpsimd.c +32 -0
@@ -145,6 +145,8 @@ static unsigned int vec_vl_inherit_flag(enum vec_type type)switch (type) {case ARM64_VEC_SVE :return TIF_SVE_VL_INHERIT ; +case ARM64_VEC_SME : +return TIF_SME_VL_INHERIT ;default :WARN_ON_ONCE (1 );return 0 ;
@@ -797,6 +799,36 @@ int sve_get_current_vl(void)return vec_prctl_status (ARM64_VEC_SVE ,0 ); } +#ifdef CONFIG_ARM64_SME +/* PR_SME_SET_VL */ +int sme_set_current_vl (unsigned long arg) +{ +unsigned long vl, flags; +int ret; + + vl = arg &PR_SME_VL_LEN_MASK ; + flags = arg & ~vl; + +if (!system_supports_sme () ||is_compat_task ()) +return -EINVAL ; + + ret =vec_set_vector_length (current,ARM64_VEC_SME , vl, flags); +if (ret) +return ret; + +return vec_prctl_status (ARM64_VEC_SME , flags); +} + +/* PR_SME_GET_VL */ +int sme_get_current_vl (void ) +{ +if (!system_supports_sme () ||is_compat_task ()) +return -EINVAL ; + +return vec_prctl_status (ARM64_VEC_SME ,0 ); +} +#endif /* CONFIG_ARM64_SME */ +static void vec_probe_vqs (struct vl_info *info,DECLARE_BITMAP (map ,SVE_VQ_MAX )) {
include/uapi/linux/prctl.h +9 -0
@@ -269,4 +269,13 @@ struct prctl_mm_map {# define PR_SCHED_CORE_SHARE_FROM 3/* pull core_sched cookie to pid */ # define PR_SCHED_CORE_MAX 4 +/* arm64 Scalable Matrix Extension controls */ +/* Flag values must be in sync with SVE versions */ +#define PR_SME_SET_VL 63/* set task vector length */ +# define PR_SME_SET_VL_ONEXEC (1 << 18)/* defer effect until exec */ +#define PR_SME_GET_VL 64/* get task vector length */ +/* Bits common to PR_SME_SET_VL and PR_SME_GET_VL */ +# define PR_SME_VL_LEN_MASK 0xffff +# define PR_SME_VL_INHERIT (1 << 17)/* inherit across exec */ +#endif /* _LINUX_PRCTL_H */
kernel/sys.c +12 -0
@@ -116,6 +116,12 @@#ifndef SVE_GET_VL # define SVE_GET_VL () (-EINVAL)#endif +#ifndef SME_SET_VL +# define SME_SET_VL (a) (-EINVAL) +#endif +#ifndef SME_GET_VL +# define SME_GET_VL () (-EINVAL) +#endif #ifndef PAC_RESET_KEYS # define PAC_RESET_KEYS (a, b) (-EINVAL)#endif
@@ -2463,6 +2469,12 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,case PR_SVE_GET_VL : error =SVE_GET_VL ();break ; +case PR_SME_SET_VL : + error =SME_SET_VL (arg2); +break ; +case PR_SME_GET_VL : + error =SME_GET_VL (); +break ;case PR_GET_SPECULATION_CTRL :if (arg3 || arg4 || arg5)return -EINVAL ;
Signature · 1 line
2.30.2
PATCH v5 18/38 arm64/sme: Implement support for TPIDR2
In reply to Mark BrownThe Scalable Matrix Extension introduces support for a new thread specific data register TPIDR2 intended for use by libc. The kernel must save the value of TPIDR2 on context switch and should ensure that all new threads start off with a default value of 0. Add a field to the thread_struct to store TPIDR2 and context switch it with the other thread specific data.
In case there are future extensions which also use TPIDR2 we introduce system_supports_tpidr2() and use that rather than system_supports_sme() for TPIDR2 handling.
--- arch/arm64/include/asm/cpufeature.h | 5 +++++ arch/arm64/include/asm/processor.h | 1 + arch/arm64/kernel/fpsimd.c | 4 ++++ arch/arm64/kernel/process.c | 14 ++++++++++++-- 4 files changed, 22 insertions(+), 2 deletions(-)
arch/arm64/include/asm/cpufeature.h +5 -0
@@ -746,6 +746,11 @@ static __always_inline bool system_supports_fa64(void)cpus_have_const_cap (ARM64_SME_FA64 ); } +static __always_inline bool system_supports_tpidr2(void) +{ +return system_supports_sme (); +} + static __always_inline bool system_supports_cnp(void) { return IS_ENABLED(CONFIG_ARM64_CNP) &&
arch/arm64/include/asm/processor.h +1 -0
@@ -168,6 +168,7 @@ struct thread_struct {u64 mte_ctrl;#endif u64 sctlr_user; +u64 tpidr2_el0; }; static inline unsigned int thread_get_vl(struct thread_struct *thread,
arch/arm64/kernel/fpsimd.c +4 -0
@@ -1098,6 +1098,10 @@ void sme_kernel_enable(const struct arm64_cpu_capabilities *__always_unused p)/* Allow SME in kernel */ write_sysreg (read_sysreg (CPACR_EL1 ) |CPACR_EL1_SMEN_EL1EN ,CPACR_EL1 );isb (); + +/* Allow EL0 to access TPIDR2 */ +write_sysreg (read_sysreg (SCTLR_EL1 ) | SCTLR_ELx_ENTP2,SCTLR_EL1 ); +isb (); }/*
arch/arm64/kernel/process.c +12 -2
@@ -249,6 +249,8 @@ void show_regs(struct pt_regs *regs)static void tls_thread_flush (void ) {write_sysreg (0 , tpidr_el0); +if (system_supports_tpidr2 ()) +write_sysreg_s (0 ,SYS_TPIDR2_EL0 );if (is_compat_task ()) { current->thread.uw.tp_value =0 ;
@@ -342,6 +344,8 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,* out-of-sync with the saved value. */ *task_user_tls (p) =read_sysreg (tpidr_el0); +if (system_supports_tpidr2 ()) + p->thread.tpidr2_el0 =read_sysreg_s (SYS_TPIDR2_EL0 );if (stack_start) {if (is_compat_thread (task_thread_info (p)))
@@ -352,10 +356,12 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,/* * If a TLS pointer was passed to clone, use it for the new -* thread. +* thread. We also reset TPIDR2 if it's in use. */ -if (clone_flags &CLONE_SETTLS ) +if (clone_flags &CLONE_SETTLS ) { p->thread.uw.tp_value = tls; + p->thread.tpidr2_el0 =0 ; + } }else {/* * A kthread has no context to ERET to, so ensure any buggy
@@ -386,6 +392,8 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,void tls_preserve_current_state (void ) { *task_user_tls (current) =read_sysreg (tpidr_el0); +if (system_supports_tpidr2 () && !is_compat_task ()) + current->thread.tpidr2_el0 =read_sysreg_s (SYS_TPIDR2_EL0 ); }static void tls_thread_switch (struct task_struct *next)
@@ -398,6 +406,8 @@ static void tls_thread_switch(struct task_struct *next)write_sysreg (0 , tpidrro_el0);write_sysreg (*task_user_tls (next), tpidr_el0); +if (system_supports_tpidr2 ()) +write_sysreg_s (next->thread.tpidr2_el0,SYS_TPIDR2_EL0 ); }/*
Signature · 1 line
2.30.2
PATCH v5 19/38 arm64/sme: Implement SVCR context switching
In reply to Mark BrownIn SME the use of both streaming SVE mode and ZA are tracked through PSTATE.SM and PSTATE.ZA, visible through the system register SVCR. In order to context switch the floating point state for SME we need to context switch the contents of this register as part of context switching the floating point state.
Since changing the vector length exits streaming SVE mode and disables ZA we also make sure we update SVCR appropriately when setting vector length, and similarly ensure that new threads have streaming SVE mode and ZA disabled.
--- arch/arm64/include/asm/processor.h | 1 + arch/arm64/include/asm/thread_info.h | 1 + arch/arm64/kernel/fpsimd.c | 11 +++++++++++ arch/arm64/kernel/process.c | 2 ++ 4 files changed, 15 insertions(+)
arch/arm64/include/asm/processor.h +1 -0
@@ -168,6 +168,7 @@ struct thread_struct {u64 mte_ctrl;#endif u64 sctlr_user; +u64 svcr;u64 tpidr2_el0; };
arch/arm64/include/asm/thread_info.h +1 -0
@@ -81,6 +81,7 @@ int arch_dup_task_struct(struct task_struct *dst,#define TIF_SVE_VL_INHERIT 24/* Inherit SVE vl_onexec across exec */ #define TIF_SSBD 25/* Wants SSB mitigation */ #define TIF_TAGGED_ADDR 26/* Allow tagged user addresses */ +#define TIF_SME 27/* SME in use */ #define TIF_SME_VL_INHERIT 28/* Inherit SME vl_onexec across exec */ #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
arch/arm64/kernel/fpsimd.c +11 -0
@@ -355,6 +355,9 @@ static void task_fpsimd_load(void)WARN_ON (!system_supports_fpsimd ());WARN_ON (!have_cpu_fpsimd_context ()); +if (IS_ENABLED (CONFIG_ARM64_SME ) &&test_thread_flag (TIF_SME )) +write_sysreg_s (current->thread.svcr,SYS_SVCR_EL0 ); +if (IS_ENABLED (CONFIG_ARM64_SVE ) &&test_thread_flag (TIF_SVE )) {sve_set_vq (sve_vq_from_vl (task_get_sve_vl (current)) -1 ); sve_load_state(sve_pffr(¤t->thread),
@@ -380,6 +383,10 @@ static void fpsimd_save(void)if (test_thread_flag (TIF_FOREIGN_FPSTATE ))return ; +if (IS_ENABLED (CONFIG_ARM64_SME ) && +test_thread_flag (TIF_SME )) + current->thread.svcr =read_sysreg_s (SYS_SVCR_EL0 ); +if (IS_ENABLED (CONFIG_ARM64_SVE ) &&test_thread_flag (TIF_SVE )) {if (WARN_ON (sve_get_vl () != last->sve_vl)) {
@@ -731,6 +738,10 @@ int vec_set_vector_length(struct task_struct *task, enum vec_type type,if (test_and_clear_tsk_thread_flag (task,TIF_SVE ))sve_to_fpsimd (task); +if (system_supports_sme () && type ==ARM64_VEC_SME ) + task->thread.svcr &= ~(SYS_SVCR_EL0_SM_MASK | +SYS_SVCR_EL0_ZA_MASK ); +if (task == current)put_cpu_fpsimd_context ();
arch/arm64/kernel/process.c +2 -0
@@ -309,6 +309,8 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) dst->thread.sve_state =NULL ;clear_tsk_thread_flag (dst,TIF_SVE ); + dst->thread.svcr =0 ; +/* clear any pending asynchronous tag fault raised by the parent */ clear_tsk_thread_flag (dst,TIF_MTE_ASYNC_FAULT );
Signature · 1 line
2.30.2
PATCH v5 20/38 arm64/sme: Implement streaming SVE context switching
In reply to Mark BrownWhen in streaming mode we need to save and restore the streaming mode SVE register state rather than the regular SVE register state. This uses the streaming mode vector length and omits FFR but is otherwise identical, if TIF_SVE is enabled when we are in streaming mode then streaming mode takes precedence.
This does not handle use of streaming SVE state with KVM, ptrace or signals. This will be updated in further patches.
--- arch/arm64/include/asm/fpsimd.h | 23 +++++- arch/arm64/include/asm/fpsimdmacros.h | 11 +++ arch/arm64/include/asm/processor.h | 10 +++ arch/arm64/kernel/entry-fpsimd.S | 9 +++ arch/arm64/kernel/fpsimd.c | 109 +++++++++++++++++++++----- arch/arm64/kvm/fpsimd.c | 3 +- 6 files changed, 142 insertions(+), 23 deletions(-)
arch/arm64/include/asm/fpsimd.h +21 -2
@@ -46,11 +46,22 @@ extern void fpsimd_restore_current_state(void);extern void fpsimd_update_current_state (struct user_fpsimd_state const *state);extern void fpsimd_bind_state_to_cpu (struct user_fpsimd_state *state, -void *sve_state,unsigned int sve_vl); +void *sve_state,unsigned int sve_vl, +unsigned int sme_vl);extern void fpsimd_flush_task_state (struct task_struct *target);extern void fpsimd_save_and_flush_cpu_state (void ); +static inline bool thread_sm_enabled (struct thread_struct *thread) +{ +return system_supports_sme () && (thread->svcr &SYS_SVCR_EL0_SM_MASK ); +} + +static inline bool thread_za_enabled (struct thread_struct *thread) +{ +return system_supports_sme () && (thread->svcr &SYS_SVCR_EL0_ZA_MASK ); +} +/* Maximum VL that SVE/SME VL-agnostic software can transparently support */ #define VL_ARCH_MAX 0x100
@@ -62,7 +73,14 @@ static inline size_t sve_ffr_offset(int vl)static inline void *sve_pffr (struct thread_struct *thread) { -return (char *)thread->sve_state +sve_ffr_offset (thread_get_sve_vl (thread)); +unsigned int vl; + +if (system_supports_sme () &&thread_sm_enabled (thread)) + vl =thread_get_sme_vl (thread); +else + vl =thread_get_sve_vl (thread); + +return (char *)thread->sve_state +sve_ffr_offset (vl); }extern void sve_save_state (void *state,u32 *pfpsr,int save_ffr);
@@ -71,6 +89,7 @@ extern void sve_load_state(void const *state, u32 const *pfpsr,extern void sve_flush_live (bool flush_ffr,unsigned long vq_minus_1);extern unsigned int sve_get_vl (void );extern void sve_set_vq (unsigned long vq_minus_1); +extern void sme_set_vq (unsigned long vq_minus_1);struct arm64_cpu_capabilities ;extern void sve_kernel_enable (const struct arm64_cpu_capabilities *__unused);
arch/arm64/include/asm/fpsimdmacros.h +11 -0
@@ -252,6 +252,17 @@ 921: .endm +/* Update SMCR_EL1.LEN with the new VQ */ +.macro sme_load_vq xvqminus1, xtmp, xtmp2 + mrs_s \xtmp, SYS_SMCR_EL1 + bic \xtmp2, \xtmp, SMCR_ELx_LEN_MASK + orr \xtmp2, \xtmp2, \xvqminus1 + cmp \xtmp2, \xtmp + b.eq 921f + msr_s SYS_SMCR_EL1, \xtmp2 //self-synchronising +921: +.endm + /* Preserve the first 128-bits of Znz and zero the rest. */ .macro _sve_flush_z nz _sve_check_zreg \nz
arch/arm64/include/asm/processor.h +10 -0
@@ -183,6 +183,11 @@ static inline unsigned int thread_get_sve_vl(struct thread_struct *thread)return thread_get_vl (thread,ARM64_VEC_SVE ); } +static inline unsigned int thread_get_sme_vl (struct thread_struct *thread) +{ +return thread_get_vl (thread,ARM64_VEC_SME ); +} +unsigned int task_get_vl (const struct task_struct *task,enum vec_type type);void task_set_vl (struct task_struct *task,enum vec_type type,unsigned long vl);
@@ -196,6 +201,11 @@ static inline unsigned int task_get_sve_vl(const struct task_struct *task)return task_get_vl (task,ARM64_VEC_SVE ); } +static inline unsigned int task_get_sme_vl (const struct task_struct *task) +{ +return task_get_vl (task,ARM64_VEC_SME ); +} +static inline void task_set_sve_vl (struct task_struct *task,unsigned long vl) {task_set_vl (task,ARM64_VEC_SVE , vl);
arch/arm64/kernel/entry-fpsimd.S +9 -0
@@ -86,3 +86,12 @@ SYM_FUNC_START(sve_flush_live) SYM_FUNC_END(sve_flush_live) #endif /* CONFIG_ARM64_SVE */ + +#ifdef CONFIG_ARM64_SME + +SYM_FUNC_START(sme_set_vq) + sme_load_vq x0, x1, x2 + ret +SYM_FUNC_END(sme_set_vq) + +#endif /* CONFIG_ARM64_SME */
arch/arm64/kernel/fpsimd.c +89 -20
204 lines not on this page · raw message
arch/arm64/kvm/fpsimd.c +2 -1
@@ -99,7 +99,8 @@ void kvm_arch_vcpu_ctxsync_fp(struct kvm_vcpu *vcpu)if (vcpu->arch.flags &KVM_ARM64_FP_ENABLED ) {fpsimd_bind_state_to_cpu (&vcpu->arch.ctxt.fp_regs, vcpu->arch.sve_state, - vcpu->arch.sve_max_vl); + vcpu->arch.sve_max_vl, +0 );clear_thread_flag (TIF_FOREIGN_FPSTATE );update_thread_flag (TIF_SVE ,vcpu_has_sve (vcpu));
Signature · 1 line
2.30.2
PATCH v5 21/38 arm64/sme: Implement ZA context switching
In reply to Mark BrownAllocate space for storing ZA on first access to SME and use that to save and restore ZA state when context switching. We do this by using the vector form of the LDR and STR ZA instructions, these do not require streaming mode and have implementation recommendations that they avoid contention issues in shared SMCU implementations.
Since ZA is architecturally guaranteed to be zeroed when enabled we do not need to explicitly zero ZA, either we will be restoring from a saved copy or trapping on first use of SME so we know that ZA must be disabled.
--- arch/arm64/include/asm/fpsimd.h | 4 +++- arch/arm64/include/asm/fpsimdmacros.h | 22 ++++++++++++++++++++++ arch/arm64/include/asm/processor.h | 1 + arch/arm64/kernel/entry-fpsimd.S | 22 ++++++++++++++++++++++ arch/arm64/kernel/fpsimd.c | 17 +++++++++++------ arch/arm64/kvm/fpsimd.c | 2 +- 6 files changed, 60 insertions(+), 8 deletions(-)
arch/arm64/include/asm/fpsimd.h +3 -1
@@ -47,7 +47,7 @@ extern void fpsimd_update_current_state(struct user_fpsimd_state const *state);extern void fpsimd_bind_state_to_cpu (struct user_fpsimd_state *state,void *sve_state,unsigned int sve_vl, -unsigned int sme_vl); +void *za_state,unsigned int sme_vl);extern void fpsimd_flush_task_state (struct task_struct *target);extern void fpsimd_save_and_flush_cpu_state (void );
@@ -90,6 +90,8 @@ extern void sve_flush_live(bool flush_ffr, unsigned long vq_minus_1);extern unsigned int sve_get_vl (void );extern void sve_set_vq (unsigned long vq_minus_1);extern void sme_set_vq (unsigned long vq_minus_1); +extern void sme_save_state (void *state,unsigned int vq_minus_1); +extern void sme_load_state (void const *state,unsigned int vq_minus_1);struct arm64_cpu_capabilities ;extern void sve_kernel_enable (const struct arm64_cpu_capabilities *__unused);
arch/arm64/include/asm/fpsimdmacros.h +22 -0
@@ -309,3 +309,25 @@ ldr w\nxtmp, [\xpfpsr, #4] msr fpcr, x\nxtmp .endm + +.macro sme_save_za nxbase, xvl, nw + mov w\nw, #0 + +423: + _sme_str_zav \nw, \nxbase + add x\nxbase, x\nxbase, \xvl + add x\nw, x\nw, #1 + cmp \xvl, x\nw + bne 423b +.endm + +.macro sme_load_za nxbase, xvl, nw + mov w\nw, #0 + +423: + _sme_ldr_zav \nw, \nxbase + add x\nxbase, x\nxbase, \xvl + add x\nw, x\nw, #1 + cmp \xvl, x\nw + bne 423b +.endm
arch/arm64/include/asm/processor.h +1 -0
@@ -153,6 +153,7 @@ struct thread_struct {unsigned int fpsimd_cpu;void *sve_state;/* SVE registers, if any */ +void *za_state;/* ZA register, if any */ unsigned int vl[ARM64_VEC_MAX ];/* vector length */ unsigned int vl_onexec[ARM64_VEC_MAX ];/* vl after next exec */ unsigned long fault_address;/* fault info */
arch/arm64/kernel/entry-fpsimd.S +22 -0
@@ -94,4 +94,26 @@ SYM_FUNC_START(sme_set_vq) ret SYM_FUNC_END(sme_set_vq) +/* + * Save the SME state + * + * x0 - pointer to buffer for state + * x1 - Bytes per vector + */ +SYM_FUNC_START(sme_save_state) + sme_save_za 0, x1, 12 + ret +SYM_FUNC_END(sme_save_state) + +/* + * Load the SME state + * + * x0 - pointer to buffer for state + * x1 - bytes per vector + */ +SYM_FUNC_START(sme_load_state) + sme_load_za 0, x1, 12 + ret +SYM_FUNC_END(sme_load_state) + #endif /* CONFIG_ARM64_SME */
arch/arm64/kernel/fpsimd.c +11 -6
@@ -117,6 +117,7 @@struct fpsimd_last_state_struct {struct user_fpsimd_state *st;void *sve_state; +void *za_state;unsigned int sve_vl;unsigned int sme_vl; };
@@ -382,11 +383,15 @@ static void task_fpsimd_load(void)if (system_supports_sme ()) {unsigned long sme_vl =task_get_sme_vl (current); +/* Ensure VL is set up for restoring data */ if (test_thread_flag (TIF_SME ))sme_set_vq (sve_vq_from_vl (sme_vl) -1 );write_sysreg_s (current->thread.svcr,SYS_SVCR_EL0 ); +if (thread_za_enabled (¤t->thread)) +sme_load_state (current->thread.za_state, sme_vl); +if (thread_sm_enabled (¤t->thread)) { restore_sve_regs = true; restore_ffr =system_supports_fa64 ();
@@ -429,11 +434,8 @@ static void fpsimd_save(void)if (system_supports_sme ()) { current->thread.svcr =read_sysreg_s (SYS_SVCR_EL0 ); -if (thread_za_enabled (¤t->thread)) { -/* ZA state managment is not implemented yet */ -force_signal_inject (SIGKILL ,SI_KERNEL ,0 ,0 ); -return ; - } +if (thread_za_enabled (¤t->thread)) +sme_save_state (last->za_state, last->sme_vl);/* If we are in streaming mode override regular SVE. */ if (thread_sm_enabled (¤t->thread)) {
@@ -1481,6 +1483,7 @@ static void fpsimd_bind_task_to_cpu(void)WARN_ON (!system_supports_fpsimd ()); last->st = ¤t->thread.uw.fpsimd_state; last->sve_state = current->thread.sve_state; + last->za_state = current->thread.za_state; last->sve_vl =task_get_sve_vl (current); last->sme_vl =task_get_sme_vl (current); current->thread.fpsimd_cpu =smp_processor_id ();
@@ -1497,7 +1500,8 @@ static void fpsimd_bind_task_to_cpu(void) }void fpsimd_bind_state_to_cpu (struct user_fpsimd_state *st,void *sve_state, -unsigned int sve_vl,unsigned int sme_vl) +unsigned int sve_vl,void *za_state, +unsigned int sme_vl) {struct fpsimd_last_state_struct *last =this_cpu_ptr (&fpsimd_last_state);
@@ -1507,6 +1511,7 @@ void fpsimd_bind_state_to_cpu(struct user_fpsimd_state *st, void *sve_state, last->st = st; last->sve_state = sve_state; + last->za_state = za_state; last->sve_vl = sve_vl; last->sme_vl = sme_vl; }
arch/arm64/kvm/fpsimd.c +1 -1
@@ -100,7 +100,7 @@ void kvm_arch_vcpu_ctxsync_fp(struct kvm_vcpu *vcpu)fpsimd_bind_state_to_cpu (&vcpu->arch.ctxt.fp_regs, vcpu->arch.sve_state, vcpu->arch.sve_max_vl, -0 ); +NULL ,0 );clear_thread_flag (TIF_FOREIGN_FPSTATE );update_thread_flag (TIF_SVE ,vcpu_has_sve (vcpu));
Signature · 1 line
2.30.2
PATCH v5 22/38 arm64/sme: Implement traps and syscall handling for SME
In reply to Mark BrownBy default all SME operations in userspace will trap. When this happens we allocate storage space for the SME register state, set up the SVE registers and disable traps. We do not need to initialize ZA since the architecture guarantees that it will be zeroed when enabled and when we trap ZA is disabled.
On syscall we exit streaming mode if we were previously in it and ensure that all but the lower 128 bits of the registers are zeroed while preserving the state of ZA. This follows the aarch64 PCS for SME, ZA state is preserved over a function call and streaming mode is exited. Since the traps for SME do not distinguish between streaming mode SVE and ZA usage if ZA is in use rather than reenabling traps we instead zero the parts of the SVE registers not shared with FPSIMD and leave SME enabled, this simplifies handling SME traps. If ZA is not in use then we reenable SME traps and fall through to normal handling of SVE.
--- arch/arm64/include/asm/esr.h | 1 + arch/arm64/include/asm/exception.h | 1 + arch/arm64/include/asm/fpsimd.h | 15 +++ arch/arm64/kernel/entry-common.c | 10 ++ arch/arm64/kernel/fpsimd.c | 174 ++++++++++++++++++++++++++--- arch/arm64/kernel/process.c | 12 +- arch/arm64/kernel/syscall.c | 43 ++++++- 7 files changed, 233 insertions(+), 23 deletions(-)
arch/arm64/include/asm/esr.h +1 -0
@@ -75,6 +75,7 @@#define ESR_ELx_IL_SHIFT (25)#define ESR_ELx_IL (UL(1) << ESR_ELx_IL_SHIFT)#define ESR_ELx_ISS_MASK (ESR_ELx_IL - 1) +#define ESR_ELx_ISS (esr) ((esr) & ESR_ELx_ISS_MASK)/* ISS field definitions shared by different classes */ #define ESR_ELx_WNR_SHIFT (6)
arch/arm64/include/asm/exception.h +1 -0
@@ -64,6 +64,7 @@ void do_debug_exception(unsigned long addr_if_watchpoint, unsigned int esr, struct pt_regs *regs);void do_fpsimd_acc (unsigned int esr,struct pt_regs *regs);void do_sve_acc (unsigned int esr,struct pt_regs *regs); +void do_sme_acc (unsigned int esr,struct pt_regs *regs);void do_fpsimd_exc (unsigned int esr,struct pt_regs *regs);void do_sysinstr (unsigned int esr,struct pt_regs *regs);void do_sp_pc_abort (unsigned long addr,unsigned int esr,struct pt_regs *regs);
arch/arm64/include/asm/fpsimd.h +15 -0
@@ -282,6 +282,17 @@ static inline void sve_setup(void) { }#ifdef CONFIG_ARM64_SME extern void __init sme_setup (void ); +extern void sme_alloc (struct task_struct *task); + +static inline void sme_user_disable (void ) +{ +sysreg_clear_set (cpacr_el1,CPACR_EL1_SMEN_EL0EN ,0 ); +} + +static inline void sme_user_enable (void ) +{ +sysreg_clear_set (cpacr_el1,0 ,CPACR_EL1_SMEN_EL0EN ); +}static inline void sme_smstart_sm (void ) {
@@ -313,6 +324,7 @@ extern int sme_get_current_vl(void);static inline void sme_setup (void ) { }static inline int sme_max_vl (void ) {return 0 ; }static inline int sme_max_virtualisable_vl (void ) {return 0 ; } +static inline void sme_alloc (struct task_struct *task) { }static inline void sme_smstart_sm (void ) { }static inline void sme_smstop_sm (void ) { }
@@ -327,6 +339,9 @@ static inline int sme_get_current_vl(void) return -EINVAL; } +static inline void sme_user_disable (void ) {BUILD_BUG (); } +static inline void sme_user_enable (void ) {BUILD_BUG (); } +#endif /* ! CONFIG_ARM64_SME */ /* For use by EFI runtime services calls only */
arch/arm64/kernel/entry-common.c +10 -0
@@ -516,6 +516,13 @@ static void noinstr el0_sve_acc(struct pt_regs *regs, unsigned long esr)exit_to_user_mode (regs); } +static void noinstr el0_sme_acc(struct pt_regs *regs, unsigned long esr) +{ +enter_from_user_mode (regs); +local_daif_restore (DAIF_PROCCTX ); +do_sme_acc (esr, regs); +} + static void noinstr el0_fpsimd_exc(struct pt_regs *regs, unsigned long esr) {enter_from_user_mode (regs);
@@ -624,6 +631,9 @@ asmlinkage void noinstr el0t_64_sync_handler(struct pt_regs *regs)case ESR_ELx_EC_SVE:el0_sve_acc (regs, esr);break ; +case ESR_ELx_EC_SME: +el0_sme_acc (regs, esr); +break ;case ESR_ELx_EC_FP_EXC64:el0_fpsimd_exc (regs, esr);break ;
arch/arm64/kernel/fpsimd.c +158 -16
244 lines not on this page · raw message
arch/arm64/kernel/process.c +7 -5
@@ -298,17 +298,19 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)BUILD_BUG_ON (!IS_ENABLED (CONFIG_THREAD_INFO_IN_TASK ));/* -* Detach src's sve_state (if any) from dst so that it does not -* get erroneously used or freed prematurely. dst's sve_state -* will be allocated on demand later on if dst uses SVE. -* For consistency, also clear TIF_SVE here: this could be done +* Detach src's sve/za_state (if any) from dst so that it does not +* get erroneously used or freed prematurely. dst's copies +* will be allocated on demand later on if dst uses SVE/SME. +* For consistency, also clear TIF_SVE/SME here: this could be done * later in copy_process(), but to avoid tripping up future -* maintainers it is best not to leave TIF_SVE and sve_state in +* maintainers it is best not to leave TIF flags and buffers in * an inconsistent state, even temporarily. */ dst->thread.sve_state =NULL ;clear_tsk_thread_flag (dst,TIF_SVE ); + dst->thread.za_state =NULL ; +clear_tsk_thread_flag (dst,TIF_SME ); dst->thread.svcr =0 ;/* clear any pending asynchronous tag fault raised by the parent */
arch/arm64/kernel/syscall.c +41 -2
59 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 23/38 arm64/sme: Implement streaming SVE signal handling
In reply to Mark BrownWhen in streaming mode we have the same set of SVE registers as we do in regular SVE mode with the exception of FFR and the use of the SME vector length. Provide signal handling for these registers by taking one of the reserved words in the SVE signal context as a flags field and defining a flag with a flag which is set for streaming mode. When the flag is set the vector length is set to the streaming mode vector length and we save and restore streaming mode data. We support entering or leaving streaming mode based on the value of the flag but do not support changing the vector length, this is not currently supported SVE signal handling.
We could instead allocate a separate record in the signal frame for the streaming mode SVE context but this inflates the size of the maximal signal frame required and adds complication when validating signal frames from userspace, especially given the current structure of the code.
Any implementation of support for streaming mode vectors in signals will have some potential for causing issues for applications that attempt to handle SVE vectors in signals, use streaming mode but do not understand streaming mode in their signal handling code, it is hard to identify a case that is clearly better than any other - they all have cases where they could cause unexpected register corruption or faults.
--- arch/arm64/include/uapi/asm/sigcontext.h | 16 ++++++-- arch/arm64/kernel/signal.c | 48 ++++++++++++++++++------ 2 files changed, 50 insertions(+), 14 deletions(-)
arch/arm64/include/uapi/asm/sigcontext.h +13 -3
@@ -134,9 +134,12 @@ struct extra_context {struct sve_context {struct _aarch64_ctx head;__u16 vl; -__u16 __reserved[3 ]; +__u16 flags; +__u16 __reserved[2 ]; }; +#define SVE_SIG_FLAG_SM 0x1/* Context describes streaming mode */ +#endif /* !__ASSEMBLY__ */ #include <asm/sve_context.h>
@@ -186,9 +189,16 @@ struct sve_context {* sve_context.vl must equal the thread's current vector length when * doing a sigreturn. * +* On systems with support for SME the SVE register state may reflect either +* streaming or non-streaming mode. In streaming mode the streaming mode +* vector length will be used and the flag SVE_SIG_FLAG_SM will be set in +* the flags field. It is permitted to enter or leave streaming mode in +* a signal return, applications should take care to ensure that any difference +* in vector length between the two modes is handled, including any resixing +* and movement of context blocks. * -* Note: for all these macros, the "vq" argument denotes the SVE -* vector length in quadwords (i.e., units of 128 bits). +* Note: for all these macros, the "vq" argument denotes the vector length +* in quadwords (i.e., units of 128 bits). * * The correct way to obtain vq is to use sve_vq_from_vl(vl). The * result is valid if and only if sve_vl_valid(vl) is true. This is
arch/arm64/kernel/signal.c +37 -11
105 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 24/38 arm64/sme: Implement ZA signal handling
In reply to Mark BrownImplement support for ZA in signal handling in a very similar way to how we implement support for SVE registers, using a signal context structure with optional register state after it. Where present this register state stores the ZA matrix as a series of horizontal vectors numbered from 0 to VL/8 in the endinanness independent format used for vectors.
As with SVE we do not allow changes in the vector length during signal return but we do allow ZA to be enabled or disabled.
--- arch/arm64/include/uapi/asm/sigcontext.h | 41 +++++++ arch/arm64/kernel/fpsimd.c | 3 - arch/arm64/kernel/signal.c | 139 +++++++++++++++++++++++ 3 files changed, 180 insertions(+), 3 deletions(-)
arch/arm64/include/uapi/asm/sigcontext.h +41 -0
@@ -140,6 +140,14 @@ struct sve_context {#define SVE_SIG_FLAG_SM 0x1/* Context describes streaming mode */ +#define ZA_MAGIC 0x54366345 + +struct za_context { +struct _aarch64_ctx head; +__u16 vl; +__u16 __reserved[3 ]; +}; +#endif /* !__ASSEMBLY__ */ #include <asm/sve_context.h>
@@ -259,4 +267,37 @@ struct sve_context {#define SVE_SIG_CONTEXT_SIZE (vq) \ (SVE_SIG_REGS_OFFSET + SVE_SIG_REGS_SIZE(vq)) +/* +* If the ZA register is enabled for the thread at signal delivery then, +* za_context.head.size >= ZA_SIG_CONTEXT_SIZE(sve_vq_from_vl(za_context.vl)) +* and the register data may be accessed using the ZA_SIG_*() macros. +* +* If za_context.head.size < ZA_SIG_CONTEXT_SIZE(sve_vq_from_vl(za_context.vl)) +* then ZA was not enabled and no register data was included in which case +* ZA register was not enabled for the thread and no register data +* the ZA_SIG_*() macros should not be used except for this check. +* +* The same convention applies when returning from a signal: a caller +* will need to remove or resize the za_context block if it wants to +* enable the ZA register when it was previously non-live or vice-versa. +* This may require the caller to allocate fresh memory and/or move other +* context blocks in the signal frame. +* +* Changing the vector length during signal return is not permitted: +* za_context.vl must equal the thread's current SME vector length when +* doing a sigreturn. +*/ + +#define ZA_SIG_REGS_OFFSET \ + ((sizeof(struct za_context) + (__SVE_VQ_BYTES - 1)) \ + / __SVE_VQ_BYTES * __SVE_VQ_BYTES) + +#define ZA_SIG_REGS_SIZE (vq) ((vq * __SVE_VQ_BYTES) * (vq * __SVE_VQ_BYTES)) + +#define ZA_SIG_ZAV_OFFSET (vq, n) (ZA_SIG_REGS_OFFSET + \ + (SVE_SIG_ZREG_SIZE(vq) * n)) + +#define ZA_SIG_CONTEXT_SIZE (vq) \ + (ZA_SIG_REGS_OFFSET + ZA_SIG_REGS_SIZE(vq)) +#endif /* _UAPI__ASM_SIGCONTEXT_H */
arch/arm64/kernel/fpsimd.c +0 -3
@@ -1177,9 +1177,6 @@ void fpsimd_release_task(struct task_struct *dead_task)#ifdef CONFIG_ARM64_SME -/* This will move to uapi/asm/sigcontext.h when signals are implemented */ -#define ZA_SIG_REGS_SIZE (vq) ((vq * __SVE_VQ_BYTES) * (vq * __SVE_VQ_BYTES)) -/* * Return how many bytes of memory are required to store the full SME * specific state (currently just ZA) for task, given task's currently
arch/arm64/kernel/signal.c +139 -0
187 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 25/38 arm64/sme: Implement ptrace support for streaming mode SVE registers
In reply to Mark BrownThe streaming mode SVE registers are represented using the same data structures as for SVE but since the vector lengths supported and in use may not be the same as SVE we represent them with a new type NT_ARM_SSVE. Unfortunately we only have a single 16 bit reserved field available in the header so there is no space to fit the current and maximum vector length for both standard and streaming SVE mode without redefining the structure in a way the creates a complicatd and fragile ABI. Since FFR is not present in streaming mode it is read and written as zero.
Setting NT_ARM_SSVE registers will put the task into streaming mode, similarly setting NT_ARM_SVE registers will exit it. Reads that do not correspond to the current mode of the task will return the header with no register data. For compatibility reasons on write setting no flag for the register type will be interpreted as setting SVE registers, though users can provide no register data as an alternative mechanism for doing so.
--- arch/arm64/include/uapi/asm/ptrace.h | 13 +- arch/arm64/kernel/fpsimd.c | 21 ++- arch/arm64/kernel/ptrace.c | 212 +++++++++++++++++++++------ include/uapi/linux/elf.h | 1 + 4 files changed, 190 insertions(+), 57 deletions(-)
arch/arm64/include/uapi/asm/ptrace.h +8 -5
@@ -109,7 +109,7 @@ struct user_hwdebug_state { } dbg_regs[16 ]; }; -/* SVE/FP/SIMD state (NT_ARM_SVE) */ +/* SVE/FP/SIMD state (NT_ARM_SVE & NT_ARM_SSVE) */ struct user_sve_header {__u32 size;/* total meaningful regset content in bytes */
@@ -220,6 +220,7 @@ struct user_sve_header { (SVE_PT_SVE_PREG_OFFSET (vq, __SVE_NUM_PREGS) - \SVE_PT_SVE_PREGS_OFFSET (vq)) +/* For streaming mode SVE (SSVE) FFR must be read and written as zero */#define SVE_PT_SVE_FFR_OFFSET (vq) \ (SVE_PT_REGS_OFFSET + __SVE_FFR_OFFSET(vq))
@@ -240,10 +241,12 @@ struct user_sve_header { - SVE_PT_SVE_OFFSET + (__SVE_VQ_BYTES - 1)) \ / __SVE_VQ_BYTES * __SVE_VQ_BYTES) -#define SVE_PT_SIZE (vq, flags) \ - (((flags) & SVE_PT_REGS_MASK) == SVE_PT_REGS_SVE ? \ - SVE_PT_SVE_OFFSET + SVE_PT_SVE_SIZE(vq, flags) \ - : SVE_PT_FPSIMD_OFFSET + SVE_PT_FPSIMD_SIZE(vq, flags)) +#define SVE_PT_SIZE (vq, flags) \ + (((flags) & SVE_PT_REGS_MASK) == SVE_PT_REGS_SVE ? \ + SVE_PT_SVE_OFFSET + SVE_PT_SVE_SIZE(vq, flags) \ + : ((((flags) & SVE_PT_REGS_MASK) == SVE_PT_REGS_FPSIMD ? \ + SVE_PT_FPSIMD_OFFSET + SVE_PT_FPSIMD_SIZE(vq, flags) \ + : SVE_PT_REGS_OFFSET)))/* pointer authentication masks (NT_ARM_PAC_MASK) */
arch/arm64/kernel/fpsimd.c +15 -6
@@ -622,14 +622,19 @@ static void __fpsimd_to_sve(void *sst, struct user_fpsimd_state const *fst,*/ static void fpsimd_to_sve (struct task_struct *task) { -unsigned int vq; +unsigned int vq, vl;void *sst = task->thread.sve_state;struct user_fpsimd_state const *fst = &task->thread.uw.fpsimd_state;if (!system_supports_sve ())return ; - vq =sve_vq_from_vl (task_get_sve_vl (task)); +if (thread_sm_enabled (&task->thread)) + vl =task_get_sme_vl (task); +else + vl =task_get_sve_vl (task); + + vq =sve_vq_from_vl (vl);__fpsimd_to_sve (sst, fst, vq); }
@@ -646,7 +651,7 @@ static void fpsimd_to_sve(struct task_struct *task)*/ static void sve_to_fpsimd (struct task_struct *task) { -unsigned int vq; +unsigned int vq, vl;void const *sst = task->thread.sve_state;struct user_fpsimd_state *fst = &task->thread.uw.fpsimd_state;unsigned int i;
@@ -655,7 +660,12 @@ static void sve_to_fpsimd(struct task_struct *task)if (!system_supports_sve ())return ; - vq =sve_vq_from_vl (task_get_sve_vl (task)); +if (thread_sm_enabled (&task->thread)) + vl =task_get_sme_vl (task); +else + vl =task_get_sve_vl (task); + + vq =sve_vq_from_vl (vl);for (i =0 ; i <SVE_NUM_ZREGS ; ++i) { p = (__uint128_t const *)ZREG (sst, vq, i); fst->vregs[i] =arm64_le128_to_cpu (*p);
@@ -796,8 +806,7 @@ int vec_set_vector_length(struct task_struct *task, enum vec_type type,/* * To ensure the FPSIMD bits of the SVE vector registers are preserved, * write any live register state back to task_struct, and convert to a -* regular FPSIMD thread. Since the vector length can only be changed -* with a syscall we can't be in streaming mode while reconfiguring. +* regular FPSIMD thread. */ if (task == current) {get_cpu_fpsimd_context ();
arch/arm64/kernel/ptrace.c +166 -46
303 lines not on this page · raw message
include/uapi/linux/elf.h +1 -0
@@ -427,6 +427,7 @@ typedef struct elf64_shdr {#define NT_ARM_PACG_KEYS 0x408/* ARM pointer authentication generic key */ #define NT_ARM_TAGGED_ADDR_CTRL 0x409/* arm64 tagged address control (prctl()) */ #define NT_ARM_PAC_ENABLED_KEYS 0x40a/* arm64 ptr auth enabled keys (prctl()) */ +#define NT_ARM_SSVE 0x40b/* ARM Streaming SVE registers */ #define NT_ARC_V2 0x600/* ARCv2 accumulator/extra registers */ #define NT_VMCOREDD 0x700/* Vmcore Device Dump Note */ #define NT_MIPS_DSP 0x800/* MIPS DSP ASE registers */
Signature · 1 line
2.30.2
PATCH v5 26/38 arm64/sme: Add ptrace support for ZA
In reply to Mark BrownThe ZA array can be read and written with the NT_ARM_ZA. Similarly to our interface for the SVE vector registers the regset consists of a header with information on the current vector length followed by an optional register data payload, represented as for signals as a series of horizontal vectors from 0 to VL/8 in the endianness independent format used for vectors.
On get if ZA is enabled then register data will be provided, otherwise it will be omitted. On set if register data is provided then ZA is enabled and initialized using the provided data, otherwise it is disabled.
--- arch/arm64/include/uapi/asm/ptrace.h | 56 +++++++++++ arch/arm64/kernel/ptrace.c | 144 +++++++++++++++++++++++++++ include/uapi/linux/elf.h | 1 + 3 files changed, 201 insertions(+)
arch/arm64/include/uapi/asm/ptrace.h +56 -0
@@ -268,6 +268,62 @@ struct user_pac_generic_keys {__uint128_t apgakey; }; +/* ZA state (NT_ARM_ZA) */ + +struct user_za_header { +__u32 size;/* total meaningful regset content in bytes */ +__u32 max_size;/* maxmium possible size for this thread */ +__u16 vl;/* current vector length */ +__u16 max_vl;/* maximum possible vector length */ +__u16 flags; +__u16 __reserved; +}; + +/* +* Common ZA_PT_* flags: +* These must be kept in sync with prctl interface in <linux/prctl.h> +*/ +#define ZA_PT_VL_INHERIT ((1 << 17) /* PR_SME_VL_INHERIT */ >> 16) +#define ZA_PT_VL_ONEXEC ((1 << 18) /* PR_SME_SET_VL_ONEXEC */ >> 16) + + +/* +* The remainder of the ZA state follows struct user_za_header. The +* total size of the ZA state (including header) depends on the +* metadata in the header: ZA_PT_SIZE(vq, flags) gives the total size +* of the state in bytes, including the header. +* +* Refer to <asm/sigcontext.h> for details of how to pass the correct +* "vq" argument to these macros. +*/ + +/* Offset from the start of struct user_za_header to the register data */ +#define ZA_PT_ZA_OFFSET \ + ((sizeof(struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ + / __SVE_VQ_BYTES * __SVE_VQ_BYTES) + +/* +* The payload starts at offset ZA_PT_ZA_OFFSET, and is of size +* ZA_PT_ZA_SIZE(vq, flags). +* +* The ZA array is stored as a sequence of horizontal vectors ZAV of SVL/8 +* bytes each, starting from vector 0. +* +* Additional data might be appended in the future. +* +* The ZA matrix is represented in memory in an endianness-invariant layout +* which differs from the layout used for the FPSIMD V-registers on big-endian +* systems: see sigcontext.h for more explanation. +*/ + +#define ZA_PT_ZAV_OFFSET (vq, n) \ + (ZA_PT_ZA_OFFSET + ((vq * __SVE_VQ_BYTES) * n)) + +#define ZA_PT_ZA_SIZE (vq) ((vq * __SVE_VQ_BYTES) * (vq * __SVE_VQ_BYTES)) + +#define ZA_PT_SIZE (vq) \ + (ZA_PT_ZA_OFFSET + ZA_PT_ZA_SIZE(vq)) +#endif /* __ASSEMBLY__ */ #endif /* _UAPI__ASM_PTRACE_H */
arch/arm64/kernel/ptrace.c +144 -0
162 lines not on this page · raw message
include/uapi/linux/elf.h +1 -0
@@ -428,6 +428,7 @@ typedef struct elf64_shdr {#define NT_ARM_TAGGED_ADDR_CTRL 0x409/* arm64 tagged address control (prctl()) */ #define NT_ARM_PAC_ENABLED_KEYS 0x40a/* arm64 ptr auth enabled keys (prctl()) */ #define NT_ARM_SSVE 0x40b/* ARM Streaming SVE registers */ +#define NT_ARM_ZA 0x40c/* ARM SME ZA registers */ #define NT_ARC_V2 0x600/* ARCv2 accumulator/extra registers */ #define NT_VMCOREDD 0x700/* Vmcore Device Dump Note */ #define NT_MIPS_DSP 0x800/* MIPS DSP ASE registers */
Signature · 1 line
2.30.2
PATCH v5 27/38 arm64/sme: Disable streaming mode and ZA when flushing CPU state
In reply to Mark BrownBoth streaming mode and ZA may increase power consumption when they are enabled and streaming mode makes many FPSIMD and SVE instructions undefined which will cause problems for any kernel mode floating point so disable both when we flush the CPU state. This covers both kernel_neon_begin() and idle and after flushing the state a reload is always required anyway.
--- arch/arm64/include/asm/fpsimd.h | 7 +++++++ arch/arm64/kernel/fpsimd.c | 9 +++++++++ 2 files changed, 16 insertions(+)
arch/arm64/include/asm/fpsimd.h +7 -0
@@ -306,6 +306,12 @@ static inline void sme_smstop_sm(void) asmvolatile (".inst 0xd503427f" ); } +static inline void sme_smstop (void ) +{ +/* SMSTOP SM is an alias for MSR SVCRSMZA, #0 */ + asmvolatile (".inst 0x7f4603d5" ); +} +static inline int sme_max_vl (void ) {return vec_max_vl (ARM64_VEC_SME );
@@ -328,6 +334,7 @@ static inline void sme_alloc(struct task_struct *task) { }static inline void sme_smstart_sm (void ) { }static inline void sme_smstop_sm (void ) { } +static inline void sme_smstop (void ) { }static inline int sme_set_current_vl (unsigned long arg) {
arch/arm64/kernel/fpsimd.c +9 -0
@@ -1755,6 +1755,15 @@ static void fpsimd_flush_cpu_state(void) {WARN_ON (!system_supports_fpsimd ());__this_cpu_write (fpsimd_last_state.st,NULL ); + +/* +* Leaving streaming mode enabled will cause issues for any kernel +* NEON and leaving streaming mode or ZA enabled may increase power +* consumption. +*/ +if (system_supports_sme ()) +sme_smstop (); +set_thread_flag (TIF_FOREIGN_FPSTATE ); }
Signature · 1 line
2.30.2
PATCH v5 28/38 arm64/sme: Save and restore streaming mode over EFI runtime calls
In reply to Mark BrownWhen saving and restoring the floating point state over an EFI runtime call ensure that we handle streaming mode, only handling FFR if we are not in streaming mode and ensuring that we are in normal mode over the call into runtime services.
We currently assume that ZA will not be modified by runtime services, the specification is not yet finalised so this may need updating if that changes.
--- arch/arm64/kernel/fpsimd.c | 47 +++++++++++++++++++++++++++++++++----- 1 file changed, 41 insertions(+), 6 deletions(-)
arch/arm64/kernel/fpsimd.c +41 -6
@@ -1046,21 +1046,25 @@ int vec_verify_vq_map(enum vec_type type)static void __init sve_efi_setup (void ) { -struct vl_info *info = &vl_info[ARM64_VEC_SVE ]; +int max_vl =0 ; +int i;if (!IS_ENABLED (CONFIG_EFI ))return ; +for (i =0 ; i <ARRAY_SIZE (vl_info); i++) + max_vl =max (vl_info[i].max_vl, max_vl); +/* * alloc_percpu() warns and prints a backtrace if this goes wrong. * This is evidence of a crippled system and we are returning void, * so no attempt is made to handle this situation here. */ -if (!sve_vl_valid (info->max_vl)) +if (!sve_vl_valid (max_vl)) goto fail; efi_sve_state =__alloc_percpu ( -SVE_SIG_REGS_SIZE (sve_vq_from_vl (info->max_vl)),SVE_VQ_BYTES ); +SVE_SIG_REGS_SIZE (sve_vq_from_vl (max_vl)),SVE_VQ_BYTES );if (!efi_sve_state) goto fail;
@@ -1841,6 +1845,7 @@ EXPORT_SYMBOL(kernel_neon_end); static DEFINE_PER_CPU(struct user_fpsimd_state, efi_fpsimd_state); static DEFINE_PER_CPU(bool, efi_fpsimd_state_used); static DEFINE_PER_CPU(bool, efi_sve_state_used); +static DEFINE_PER_CPU(bool, efi_sm_state);/* * EFI runtime services support functions
@@ -1875,12 +1880,28 @@ void __efi_fpsimd_begin(void)*/ if (system_supports_sve () &&likely (efi_sve_state)) {char *sve_state =this_cpu_ptr (efi_sve_state); +bool ffr = true; +u64 svcr;__this_cpu_write (efi_sve_state_used, true); +/* If we are in streaming mode don't touch FFR */ +if (system_supports_sme ()) { + svcr =read_sysreg_s (SYS_SVCR_EL0 ); + + ffr = svcr &SYS_SVCR_EL0_SM_MASK ; + +__this_cpu_write (efi_sm_state, ffr); + } +sve_save_state (sve_state +sve_ffr_offset (sve_max_vl ()), &this_cpu_ptr (&efi_fpsimd_state)->fpsr, - true); + ffr); + +if (system_supports_sme ()) +sysreg_clear_set_s (SYS_SVCR_EL0 , +SYS_SVCR_EL0_SM_MASK ,0 ); + }else {fpsimd_save_state (this_cpu_ptr (&efi_fpsimd_state)); }
@@ -1903,11 +1924,25 @@ void __efi_fpsimd_end(void)if (system_supports_sve () &&likely (__this_cpu_read (efi_sve_state_used))) {char const *sve_state =this_cpu_ptr (efi_sve_state); +bool ffr = true; + +/* +* Restore streaming mode; EFI calls are +* normal function calls so should not return in +* streaming mode. +*/ +if (system_supports_sme ()) { +if (__this_cpu_read (efi_sm_state)) { +sysreg_clear_set_s (SYS_SVCR_EL0 , +0 , +SYS_SVCR_EL0_SM_MASK ); + ffr = false; + } + } -sve_set_vq (sve_vq_from_vl (sve_get_vl ()) -1 );sve_load_state (sve_state +sve_ffr_offset (sve_max_vl ()), &this_cpu_ptr (&efi_fpsimd_state)->fpsr, - true); + ffr);__this_cpu_write (efi_sve_state_used, false); }else {
Signature · 1 line
2.30.2
PATCH v5 29/38 arm64/sme: Provide Kconfig for SME
In reply to Mark BrownNow that basline support for the Scalable Matrix Extension (SME) is present introduce the Kconfig option allowing it to be built. While there is no requirement for a system with SME to support SVE at runtime the support for streaming mode SVE is mostly shared with normal SVE so depend on SVE.
Since there is currently no support for KVM and no handling of either streaming mode or ZA with KVM the option the feature is marked as being incompatible with KVM and not enabled by default.
--- arch/arm64/Kconfig | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm64/Kconfig +11 -0
@@ -1719,6 +1719,17 @@ config ARM64_SVE booting the kernel. If unsure and you are not observing these symptoms, you should assume that it is safe to say Y. +config ARM64_SME + bool "ARM Scalable Matrix Extension support" + depends on ARM64_SVE + depends on !KVM + help + The Scalable Matrix Extension (SME) is an extension to the AArch64 + execution state which utilises a substantial subset of the SVE + instruction set, together with the addition of new architectural + register state capable of holding two dimensional matrix tiles to + enable various matrix operations. + config ARM64_MODULE_PLTS bool "Use PLTs to allow module memory to spill over into vmalloc area" depends on MODULES
Signature · 1 line
2.30.2
PATCH v5 30/38 kselftest/arm64: sme: Add streaming SME support to vlset
In reply to Mark BrownThe Scalable Matrix Extenions (SME) introduces additional register state with configurable vector lengths, similar to SVE but configured separately. Extend vlset to support configuring this state with a --sme or -s command line option.
--- tools/testing/selftests/arm64/fp/vlset.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
tools/testing/selftests/arm64/fp/vlset.c +8 -2
@@ -22,12 +22,15 @@ static int inherit = 0;static int no_inherit =0 ;static int force =0 ;static unsigned long vl; +static int set_ctl =PR_SVE_SET_VL ; +static int get_ctl =PR_SVE_GET_VL ;static const struct option options[] = { {"force" , no_argument,NULL ,'f' }, {"inherit" , no_argument,NULL ,'i' }, {"max" , no_argument,NULL ,'M' }, {"no-inherit" , no_argument, &no_inherit,1 }, + {"sme" , no_argument,NULL ,'s' }, {"help" , no_argument,NULL ,'?' }, {} };
@@ -50,6 +53,9 @@ static int parse_options(int argc, char **argv)case 'M' : vl =SVE_VL_MAX ;break ;case 'f' : force =1 ;break ;case 'i' : inherit =1 ;break ; +case 's' : set_ctl =PR_SME_SET_VL ; + get_ctl =PR_SME_GET_VL ; +break ;case 0 :break ;default : goto error; }
@@ -125,14 +131,14 @@ int main(int argc, char **argv)if (inherit) flags |=PR_SVE_VL_INHERIT ; - t =prctl (PR_SVE_SET_VL , vl | flags); + t =prctl (set_ctl, vl | flags);if (t <0 ) {fprintf (stderr,"%s: PR_SVE_SET_VL: %s\n" , program_name,strerror (errno)); goto error; } - t =prctl (PR_SVE_GET_VL ); + t =prctl (get_ctl);if (t ==-1 ) {fprintf (stderr,"%s: PR_SVE_GET_VL: %s\n" , program_name,strerror (errno));
Signature · 1 line
2.30.2
PATCH v5 31/38 kselftest/arm64: Add tests for TPIDR2
In reply to Mark BrownThe Scalable Matrix Extension adds a new system register TPIDR2 intended to be used by libc for its own thread specific use, add some kselftests which exercise the ABI for it.
Since this test should with some adjustment work for TPIDR and any other similar registers added in future add tests for it in a separate directory rather than placing it with the other floating point tests, nothing existing looked suitable so I created a new test directory called "abi".
Since this feature is intended to be used by libc the test is built as freestanding code using nolibc so we don't end up with the test program and libc both trying to manage the register simultaneously and distrupting each other. As a result of being written using nolibc rather than using hwcaps to identify if SME is available in the system we check for the default SME vector length configuration in proc, adding hwcap support to nolibc seems like disproportionate effort and didn't feel entirely idiomatic for what nolibc is trying to do.
--- tools/testing/selftests/arm64/abi/.gitignore | 1 + tools/testing/selftests/arm64/abi/Makefile | 9 +- tools/testing/selftests/arm64/abi/tpidr2.c | 298 +++++++++++++++++++ 3 files changed, 307 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/arm64/abi/tpidr2.c
tools/testing/selftests/arm64/abi/.gitignore +1 -0
@@ -1 +1,2 @@ syscall-abi +tpidr2
tools/testing/selftests/arm64/abi/Makefile +8 -1
@@ -1,8 +1,15 @@ # SPDX-License-Identifier: GPL-2.0 # Copyright (C) 2021 ARM Limited -TEST_GEN_PROGS := syscall-abi +TEST_GEN_PROGS := syscall-abi tpidr2 include ../../lib.mk $(OUTPUT)/syscall-abi: syscall-abi.c syscall-abi-asm.S + +# Build with nolibc since TPIDR2 is intended to be actively managed by +# libc and we're trying to test the functionality that it depends on here. +$(OUTPUT)/tpidr2: tpidr2.c + $(CC) -fno-asynchronous-unwind-tables -fno-ident -s -Os -nostdlib \ + -static -include ../../../../include/nolibc/nolibc.h \ + -ffreestanding -Wall $^ -o $@ -lgcc
tools/testing/selftests/arm64/abi/tpidr2.c new file +298 -0
298 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 32/38 kselftest/arm64: Extend vector configuration API tests to cover SME
In reply to Mark BrownProvide RDVL helpers for SME and extend the main vector configuration tests to cover SME.
--- tools/testing/selftests/arm64/fp/.gitignore | 1 + tools/testing/selftests/arm64/fp/Makefile | 3 ++- tools/testing/selftests/arm64/fp/rdvl-sme.c | 14 ++++++++++++++ tools/testing/selftests/arm64/fp/rdvl.S | 16 ++++++++++++++++ tools/testing/selftests/arm64/fp/rdvl.h | 1 + tools/testing/selftests/arm64/fp/vec-syscfg.c | 10 ++++++++++ 6 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/arm64/fp/rdvl-sme.c
tools/testing/selftests/arm64/fp/.gitignore +1 -0
@@ -1,4 +1,5 @@ fpsimd-test +rdvl-sme rdvl-sve sve-probe-vls sve-ptrace
tools/testing/selftests/arm64/fp/Makefile +2 -1
@@ -3,7 +3,7 @@ CFLAGS += -I../../../../../usr/include/ TEST_GEN_PROGS := sve-ptrace sve-probe-vls vec-syscfg TEST_PROGS_EXTENDED := fpsimd-test fpsimd-stress \ - rdvl-sve \ + rdvl-sme rdvl-sve \ sve-test sve-stress \ vlset
@@ -11,6 +11,7 @@ all: $(TEST_GEN_PROGS) $(TEST_PROGS_EXTENDED) fpsimd-test: fpsimd-test.o asm-utils.o $(CC) -nostdlib $^ -o $@ +rdvl-sme: rdvl-sme.o rdvl.o rdvl-sve: rdvl-sve.o rdvl.o sve-ptrace: sve-ptrace.o sve-probe-vls: sve-probe-vls.o rdvl.o
tools/testing/selftests/arm64/fp/rdvl-sme.c new file +14 -0
@@ -0,0 +1,14 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include <stdio.h> + +#include "rdvl.h" + +int main (void ) +{ +int vl =rdvl_sme (); + +printf ("%d\n" , vl); + +return 0 ; +}
tools/testing/selftests/arm64/fp/rdvl.S +16 -0
@@ -8,3 +8,19 @@ rdvl_sve: hint 34 // BTI C rdvl x0, #1 ret + +.globl rdvl_sme +rdvl_sme: + hint 34 // BTI C + + // Enter streaming mode + mov x16, #1 + msr S3_3_C4_C2_2, x16 + + rdvl x0, #1 + + // Leave streaming mode + mov x16, #0 + msr S3_3_C4_C2_2, x16 + + ret
tools/testing/selftests/arm64/fp/rdvl.h +1 -0
@@ -3,6 +3,7 @@#ifndef RDVL_H #define RDVL_H +int rdvl_sme (void );int rdvl_sve (void );#endif
tools/testing/selftests/arm64/fp/vec-syscfg.c +10 -0
@@ -53,6 +53,16 @@ static struct vec_data vec_data[] = { .prctl_set = PR_SVE_SET_VL, .default_vl_file = "/proc/sys/abi/sve_default_vector_length", }, + { + .name = "SME", + .hwcap_type = AT_HWCAP2, + .hwcap = HWCAP2_SME, + .rdvl = rdvl_sme, + .rdvl_binary = "./rdvl-sme", + .prctl_get = PR_SME_GET_VL, + .prctl_set = PR_SME_SET_VL, + .default_vl_file = "/proc/sys/abi/sme_default_vector_length", + }, };static int stdio_read_integer (FILE *f,const char *what,int *val)
Signature · 1 line
2.30.2
PATCH v5 33/38 kselftest/arm64: sme: Provide streaming mode SVE stress test
In reply to Mark BrownOne of the features of SME is the addition of streaming mode, in which we have access to a set of streaming mode SVE registers at the SME vector length. Since these are accessed using the SVE instructions let's reuse the existing SVE stress test for testing with a compile time option for controlling the few small differences needed:
- Enter streaming mode immediately on starting the program.
- In streaming mode FFR is removed so skip reading and writing FFR.
In order to avoid requiring a cutting edge toolchain with SME support use the op/CR form for specifying SVCR.
--- tools/testing/selftests/arm64/fp/.gitignore | 1 + tools/testing/selftests/arm64/fp/Makefile | 3 + tools/testing/selftests/arm64/fp/ssve-stress | 59 ++++++++++++++++++++ tools/testing/selftests/arm64/fp/sve-test.S | 30 ++++++++++ 4 files changed, 93 insertions(+) create mode 100644 tools/testing/selftests/arm64/fp/ssve-stress
tools/testing/selftests/arm64/fp/.gitignore +1 -0
@@ -4,5 +4,6 @@ rdvl-sve sve-probe-vls sve-ptrace sve-test +ssve-test vec-syscfg vlset
tools/testing/selftests/arm64/fp/Makefile +3 -0
@@ -5,6 +5,7 @@ TEST_GEN_PROGS := sve-ptrace sve-probe-vls vec-syscfg TEST_PROGS_EXTENDED := fpsimd-test fpsimd-stress \ rdvl-sme rdvl-sve \ sve-test sve-stress \ + ssve-test ssve-stress \ vlset all: $(TEST_GEN_PROGS) $(TEST_PROGS_EXTENDED)
@@ -17,6 +18,8 @@ sve-ptrace: sve-ptrace.o sve-probe-vls: sve-probe-vls.o rdvl.o sve-test: sve-test.o asm-utils.o $(CC) -nostdlib $^ -o $@ +ssve-test: sve-test.S asm-utils.o + $(CC) -DSSVE -nostdlib $^ -o $@ vec-syscfg: vec-syscfg.o rdvl.o vlset: vlset.o
tools/testing/selftests/arm64/fp/ssve-stress new file +59 -0
59 lines not on this page · raw message
tools/testing/selftests/arm64/fp/sve-test.S +30 -0
@@ -156,6 +156,7 @@ endfunction // We fill the upper lanes of FFR with zeros. // Beware: corrupts P0. function setup_ffr +#ifndef SSVE mov x4, x30 and w0, w0, #0x3
@@ -178,6 +179,9 @@ function setup_ffr wrffr p0.b ret x4 +#else + ret +#endif endfunction // Trivial memory compare: compare x2 bytes starting at address x0 with
@@ -260,6 +264,7 @@ endfunction // Beware -- corrupts P0. // Clobbers x0-x5. function check_ffr +#ifndef SSVE mov x3, x30 ldr x4, =scratch
@@ -280,6 +285,9 @@ function check_ffr mov x2, x5 mov x30, x3 b memcmp +#else + ret +#endif endfunction // Any SVE register modified here can cause corruption in the main
@@ -295,13 +303,26 @@ function irritator_handler movi v0.8b, #1 movi v9.16b, #2 movi v31.8b, #3 +#ifndef SSVE // And P0 rdffr p0.b // And FFR wrffr p15.b +#endif + + ret +endfunction + +#ifdef SSVE +function enable_sm + // Set SVCR.SM to 1, equivalent to SMSTART SM but doesn't need a + // SME capable toolchain. + mov x0, #1 + msr S3_3_C4_C2_2, x0 ret endfunction +#endif function terminate_handler mov w21, w0
@@ -359,6 +380,11 @@ endfunction .globl _start function _start _start: +#ifdef SSVE + puts "Streaming mode " + bl enable_sm +#endif + // Sanity-check and report the vector length rdvl x19, #8
@@ -407,6 +433,10 @@ _start: orr w2, w2, #SA_NODEFER bl setsignal +#ifdef SSVE + bl enable_sm // syscalls will have exited streaming mode +#endif + mov x22, #0 // generation number, increments per iteration .Ltest_loop: rdvl x0, #8
Signature · 1 line
2.30.2
PATCH v5 34/38 kselftest/arm64: Add stress test for SME ZA context switching
In reply to Mark BrownAdd a stress test for context switching of the ZA register state based on the similar tests Dave Martin wrote for FPSIMD and SVE registers. The test loops indefinitely writing a data pattern to ZA then reading it back and verifying that it's what was expected.
Unlike the other tests we manually assemble the SME instructions since at present no released toolchain has SME support integrated.
--- tools/testing/selftests/arm64/fp/.gitignore | 1 + tools/testing/selftests/arm64/fp/Makefile | 3 + tools/testing/selftests/arm64/fp/za-stress | 59 +++ tools/testing/selftests/arm64/fp/za-test.S | 431 ++++++++++++++++++++ 4 files changed, 494 insertions(+) create mode 100644 tools/testing/selftests/arm64/fp/za-stress create mode 100644 tools/testing/selftests/arm64/fp/za-test.S
tools/testing/selftests/arm64/fp/.gitignore +1 -0
@@ -7,3 +7,4 @@ sve-test ssve-test vec-syscfg vlset +za-test
tools/testing/selftests/arm64/fp/Makefile +3 -0
@@ -6,6 +6,7 @@ TEST_PROGS_EXTENDED := fpsimd-test fpsimd-stress \ rdvl-sme rdvl-sve \ sve-test sve-stress \ ssve-test ssve-stress \ + za-test za-stress \ vlset all: $(TEST_GEN_PROGS) $(TEST_PROGS_EXTENDED)
@@ -22,5 +23,7 @@ ssve-test: sve-test.S asm-utils.o $(CC) -DSSVE -nostdlib $^ -o $@ vec-syscfg: vec-syscfg.o rdvl.o vlset: vlset.o +za-test: za-test.o asm-utils.o + $(CC) -nostdlib $^ -o $@ include ../../lib.mk
tools/testing/selftests/arm64/fp/za-stress new file +59 -0
59 lines not on this page · raw message
tools/testing/selftests/arm64/fp/za-test.S new file +431 -0
431 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 35/38 kselftest/arm64: signal: Add SME signal handling tests
In reply to Mark BrownAdd test cases for the SME signal handing ABI patterned off the SVE tests. Due to the small size of the tests and the differences in ABI (especially around needing to account for both streaming SVE and ZA) there is some code duplication here.
We currently cover:
- Reporting of the vector length.
- Lack of support for changing vector length.
- Presence and size of register state for streaming SVE and ZA.
As with the SVE tests we do not yet have any validation of register contents.
--- .../testing/selftests/arm64/signal/.gitignore | 2 + .../selftests/arm64/signal/test_signals.h | 2 + .../arm64/signal/test_signals_utils.c | 3 + .../testcases/fake_sigreturn_sme_change_vl.c | 92 +++++++++++++ .../arm64/signal/testcases/sme_trap_za.c | 36 +++++ .../selftests/arm64/signal/testcases/sme_vl.c | 70 ++++++++++ .../arm64/signal/testcases/ssve_regs.c | 129 ++++++++++++++++++ 7 files changed, 334 insertions(+) create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sme_change_vl.c create mode 100644 tools/testing/selftests/arm64/signal/testcases/sme_trap_za.c create mode 100644 tools/testing/selftests/arm64/signal/testcases/sme_vl.c create mode 100644 tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
tools/testing/selftests/arm64/signal/.gitignore +2 -0
@@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only mangle_* fake_sigreturn_* +sme_* +ssve_* sve_* !*.[ch]
tools/testing/selftests/arm64/signal/test_signals.h +2 -0
@@ -34,11 +34,13 @@enum {FSSBS_BIT ,FSVE_BIT , +FSME_BIT ,FMAX_END };#define FEAT_SSBS (1UL << FSSBS_BIT)#define FEAT_SVE (1UL << FSVE_BIT) +#define FEAT_SME (1UL << FSME_BIT)/* * A descriptor used to describe and configure a test case.
tools/testing/selftests/arm64/signal/test_signals_utils.c +3 -0
@@ -27,6 +27,7 @@ static int sig_copyctx = SIGTRAP;static char const *const feats_names[FMAX_END ] = {" SSBS " ," SVE " , +" SME " , };#define MAX_FEATS_SZ 128
@@ -266,6 +267,8 @@ int test_init(struct tdescr *td) td->feats_supported |=FEAT_SSBS ;if (getauxval (AT_HWCAP ) &HWCAP_SVE ) td->feats_supported |=FEAT_SVE ; +if (getauxval (AT_HWCAP2 ) &HWCAP2_SME ) + td->feats_supported |=FEAT_SME ;if (feats_ok (td)) { fprintf(stderr, "Required Features: [%s] supported\n",
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sme_change_vl.c new file +92 -0
92 lines not on this page · raw message
tools/testing/selftests/arm64/signal/testcases/sme_trap_za.c new file +36 -0
@@ -0,0 +1,36 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2021 ARM Limited +* +* Verify that accessing ZA without enabling it generates a SIGILL. +*/ + +#include <signal.h> +#include <ucontext.h> +#include <sys/prctl.h> + +#include "test_signals_utils.h" +#include "testcases.h" + +int sme_trap_za_trigger (struct tdescr *td) +{ +/* ZERO ZA */ + asmvolatile (".inst 0xc00800ff" ); + +return 0 ; +} + +int sme_trap_za_run (struct tdescr *td,siginfo_t *si,ucontext_t *uc) +{ +return 1 ; +} + +struct tdescr tde = { + .name ="SME ZA trap" , + .descr ="Check that we get a SIGILL if we access ZA without enabling" , + .timeout =3 , + .sanity_disabled = true, + .trigger = sme_trap_za_trigger, + .run = sme_trap_za_run, + .sig_ok =SIGILL , +};
tools/testing/selftests/arm64/signal/testcases/sme_vl.c new file +70 -0
70 lines not on this page · raw message
tools/testing/selftests/arm64/signal/testcases/ssve_regs.c new file +129 -0
129 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 36/38 kselftest/arm64: Add streaming SVE to SVE ptrace tests
In reply to Mark BrownIn order to allow ptrace of streaming mode SVE registers we have added a new regset for streaming mode which in isolation offers the same ABI as regular SVE with a different vector type. Add this to the array of regsets we handle, together with additional tests for the interoperation of the two regsets.
--- tools/testing/selftests/arm64/fp/sve-ptrace.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
tools/testing/selftests/arm64/fp/sve-ptrace.c +11 -0
@@ -28,6 +28,10 @@#define NT_ARM_SVE 0x405#endif +#ifndef NT_ARM_SSVE +#define NT_ARM_SSVE 0x40b +#endif +struct vec_type {const char *name;unsigned long hwcap_type;
@@ -44,6 +48,13 @@ static const struct vec_type vec_types[] = { .regset = NT_ARM_SVE, .prctl_set = PR_SVE_SET_VL, }, + { + .name = "Streaming SVE", + .hwcap_type = AT_HWCAP2, + .hwcap = HWCAP2_SME, + .regset = NT_ARM_SSVE, + .prctl_set = PR_SME_SET_VL, + }, };#define VL_TESTS (((SVE_VQ_MAX - SVE_VQ_MIN) + 1) * 3)
Signature · 1 line
2.30.2
PATCH v5 37/38 kselftest/arm64: Add coverage for the ZA ptrace interface
In reply to Mark BrownAdd some basic coverage for the ZA ptrace interface, including walking through all the vector lengths supported in the system. As with SVE we do not currently validate the data all the way through to the running process.
--- tools/testing/selftests/arm64/fp/.gitignore | 1 + tools/testing/selftests/arm64/fp/Makefile | 3 +- tools/testing/selftests/arm64/fp/za-ptrace.c | 353 +++++++++++++++++++ 3 files changed, 356 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/arm64/fp/za-ptrace.c
tools/testing/selftests/arm64/fp/.gitignore +1 -0
@@ -7,4 +7,5 @@ sve-test ssve-test vec-syscfg vlset +za-ptrace za-test
tools/testing/selftests/arm64/fp/Makefile +2 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS += -I../../../../../usr/include/ -TEST_GEN_PROGS := sve-ptrace sve-probe-vls vec-syscfg +TEST_GEN_PROGS := sve-ptrace sve-probe-vls vec-syscfg za-ptrace TEST_PROGS_EXTENDED := fpsimd-test fpsimd-stress \ rdvl-sme rdvl-sve \ sve-test sve-stress \
@@ -25,5 +25,6 @@ vec-syscfg: vec-syscfg.o rdvl.o vlset: vlset.o za-test: za-test.o asm-utils.o $(CC) -nostdlib $^ -o $@ +za-ptrace: za-ptrace.o include ../../lib.mk
tools/testing/selftests/arm64/fp/za-ptrace.c new file +353 -0
353 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v5 38/38 kselftest/arm64: Add SME support to syscall ABI test
In reply to Mark BrownFor every possible combination of SVE and SME vector length verify that for each possible value of SVCR after a syscall we leave streaming mode and ZA is preserved. We don't need to take account of any streaming/non streaming SVE vector length changes in the assembler code since the store instructions will handle the vector length for us. We log if the system supports FA64 and only try to set FFR in streaming mode if it does.
--- .../selftests/arm64/abi/syscall-abi-asm.S | 69 +++++- .../testing/selftests/arm64/abi/syscall-abi.c | 204 ++++++++++++++++-- 2 files changed, 250 insertions(+), 23 deletions(-)
tools/testing/selftests/arm64/abi/syscall-abi-asm.S +68 -1
@@ -9,15 +9,42 @@ // invoked is configured in x8 of the input GPR data. // // x0: SVE VL, 0 for FP only +// x1: SME VL // // GPRs: gpr_in, gpr_out // FPRs: fpr_in, fpr_out // Zn: z_in, z_out // Pn: p_in, p_out // FFR: ffr_in, ffr_out +// ZA: za_in, za_out +// SVCR: svcr_in, svcr_out + +#include "syscall-abi.h" .arch_extension sve +/* + * LDR (vector to ZA array): + * LDR ZA[\nw, #\offset], [X\nxbase, #\offset, MUL VL] + */ +.macro _ldr_za nw, nxbase, offset=0 + .inst 0xe1000000 \ + | (((\nw) & 3) << 13) \ + | ((\nxbase) << 5) \ + | ((\offset) & 7) +.endm + +/* + * STR (vector from ZA array): + * STR ZA[\nw, #\offset], [X\nxbase, #\offset, MUL VL] + */ +.macro _str_za nw, nxbase, offset=0 + .inst 0xe1200000 \ + | (((\nw) & 3) << 13) \ + | ((\nxbase) << 5) \ + | ((\offset) & 7) +.endm + .globl do_syscall do_syscall: // Store callee saved registers x19-x29 (80 bytes) plus x0 and x1
@@ -30,6 +57,24 @@ do_syscall: stp x25, x26, [sp, #80] stp x27, x28, [sp, #96] + // Set SVCR if we're doing SME + cbz x1, 1f + adrp x2, svcr_in + ldr x2, [x2, :lo12:svcr_in] + msr S3_3_C4_C2_2, x2 +1: + + // Load ZA if it's enabled - uses x12 as scratch due to SME LDR + tbz x2, #SVCR_ZA_SHIFT, 1f + mov w12, #0 + ldr x2, =za_in +2: _ldr_za 12, 2 + add x2, x2, x1 + add x12, x12, #1 + cmp x1, x12 + bne 2b +1: + // Load GPRs x8-x28, and save our SP/FP for later comparison ldr x2, =gpr_in add x2, x2, #64
@@ -68,7 +113,7 @@ do_syscall: ldp q30, q31, [x2, #16 * 30] 1: - // Load the SVE registers if we're doing SVE + // Load the SVE registers if we're doing SVE/SME cbz x0, 1f ldr x2, =z_in
@@ -105,9 +150,13 @@ do_syscall: ldr z30, [x2, #30, MUL VL] ldr z31, [x2, #31, MUL VL] + // Only set a non-zero FFR, test patterns must be zero since the + // syscall should clear it - this lets us handle FA64. ldr x2, =ffr_in + cbz x2, 2f ldr p0, [x2, #0] wrffr p0.b +2: ldr x2, =p_in ldr p0, [x2, #0, MUL VL]
@@ -169,6 +218,24 @@ do_syscall: stp q28, q29, [x2, #16 * 28] stp q30, q31, [x2, #16 * 30] + // Save SVCR if we're doing SME + cbz x1, 1f + mrs x2, S3_3_C4_C2_2 + adrp x3, svcr_out + str x2, [x3, :lo12:svcr_out] +1: + + // Save ZA if it's enabled - uses x12 as scratch due to SME STR + tbz x2, #SVCR_ZA_SHIFT, 1f + mov w12, #0 + ldr x2, =za_out +2: _str_za 12, 2 + add x2, x2, x1 + add x12, x12, #1 + cmp x1, x12 + bne 2b +1: + // Save the SVE state if we have some cbz x0, 1f
tools/testing/selftests/arm64/abi/syscall-abi.c +182 -22
338 lines not on this page · raw message
Signature · 1 line
2.30.2