Skip to contentSkip to conversation

scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON

PATCH Superseded Julian Braha 2 participants 3 messages Oct 28, 2021 – Oct 29, 2021 SCSI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON

When RESET_TI_SYSCON is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SCSI_UFS_MEDIATEK [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]

This is because RESET_TI_SYSCON is selected by SCSI_UFS_MEDIATEK, but SCSI_UFS_MEDIATEK does not select or depend on RESET_CONTROLLER, despite RESET_TI_SYSCON depending on RESET_CONTROLLER.

These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution.

---
 drivers/scsi/ufs/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/ufs/Kconfig +1 -0
index b2521b830be7..0427f8277a5d 100644
@@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK
 	tristate "Mediatek specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
 	select PHY_MTK_UFS
+  select RESET_CONTROLLER
 	select RESET_TI_SYSCON
 	help
 	  This selects the Mediatek specific additions to UFSHCD platform driver.
Signature · 1 line
2.30.2
#1 lore raw

drivers/scsi/ufs/Kconfig config SCSI_UFS_MEDIATEK · line 121

Quoted 12 lines · Julian Braha
drivers/scsi/ufs/Kconfig +1 -0
index b2521b830be7..0427f8277a5d 100644
@@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK
  	tristate "Mediatek specific hooks to UFS controller platform driver"
  	depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
  	select PHY_MTK_UFS
+  select RESET_CONTROLLER
  	select RESET_TI_SYSCON
  	help
  	  This selects the Mediatek specific additions to UFSHCD platform driver.

Please keep the indentation consistent.

Thanks,

Bart.

#2 lore raw
Quoted 6 lines

Please keep the indentation consistent.

Thanks,

Bart.

Hi Bart,

I have adjusted my text editor, and will resubmit the patch.

- Julian Braha