Skip to contentSkip to conversation

media: stm32-dma2d: fix Kconfig dependencies

PATCH New Arnd Bergmann 1 participant 1 message Oct 29, 2021 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: stm32-dma2d: fix Kconfig dependencies

From: Arnd Bergmann <[email protected]>

The new DMA2D accidentally allowed compile-testing configurations that clearly cannot link:

ld.lld: error: undefined symbol: v4l_vb2q_enable_media_source

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by videobuf2-core.c
media/common/videobuf2/videobuf2-core.o:(vb2_core_streamon) in archive drivers/built-in.a

ld.lld: error: undefined symbol: v4l2_device_register

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by dma2d.c
media/platform/stm32/dma2d/dma2d.o:(dma2d_probe) in archive drivers/built-in.a

ld.lld: error: undefined symbol: video_device_alloc

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by dma2d.c
media/platform/stm32/dma2d/dma2d.o:(dma2d_probe) in archive drivers/built-in.a

ld.lld: error: undefined symbol: v4l2_m2m_init

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by dma2d.c
media/platform/stm32/dma2d/dma2d.o:(dma2d_probe) in archive drivers/built-in.a

Tighten the dependencies to only allow test builds when VIDEO_V4L2 is available, but keep it possible for non-stm32 targets.

Fixes bdbbd511ef0c ("media: stm32-dma2d: STM32 DMA2D driver")
---
 drivers/media/platform/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/Kconfig +2 -1
index 68f16aef8754..9fbdba0fd1e7 100644
@@ -494,7 +494,8 @@ endif # VIDEO_STI_DELTA
 
 config VIDEO_STM32_DMA2D
 	tristate "STM32 Chrom-Art Accelerator (DMA2D)"
-	depends on (VIDEO_DEV && VIDEO_V4L2 && ARCH_STM32) || COMPILE_TEST
+	depends on VIDEO_DEV && VIDEO_V4L2
+	depends on ARCH_STM32 || COMPILE_TEST
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV
 	help
Signature · 1 line
2.29.2