Skip to contentSkip to conversation

wpebackend-fdo: Add -Wno-c++11-narrowing

PATCH In review Khem Raj 2 participants 2 messages Oct 30, 2021

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 wpebackend-fdo: Add -Wno-c++11-narrowing

This commit https://github.com/Igalia/WPEBackend-fdo/commit/e4c578f23359dba4d5abbd14b108f59e1b0701c1
causes this warning due to int to uint conversion without static casts
unless its fixes properly by upstream make behaviour same as g++ where
this is flagged too but only as a warning unlike clang which is pedantic
and enables it as error

Cc lexander Kanavin <[email protected]>
---
 meta/recipes-sato/webkit/wpebackend-fdo_1.12.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-sato/webkit/wpebackend-fdo_1.12.0.bb +4 -0
index ba6c54412a..4a18467ea4 100644
@@ -15,6 +15,10 @@ REQUIRED_DISTRO_FEATURES = "opengl"
 SRC_URI = "https://wpewebkit.org/releases/${BPN}-${PV}.tar.xz"
 SRC_URI[sha256sum] = "6239c9c15523410798d66315de6b491712ab30009ba180f3e0dd076d9b0074ac"
 
+# Especially helps compiling with clang which enable this as error when
+# using c++11
+CXXFLAGS += "-Wno-c++11-narrowing"
+
 # This is a tweak of upstream-version-is-even needed because
 # ipstream directory contains tarballs for other components as well.
 UPSTREAM_CHECK_REGEX = "wpebackend-fdo-(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)\.tar"
Signature · 1 line
2.33.1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Khem Raj
Sent: den 30 oktober 2021 21:45
To: [email protected]
Cc: Khem Raj <[email protected]>; lexander Kanavin <[email protected]>
Subject: [OE-core] [PATCH] wpebackend-fdo: Add -Wno-c++11-narrowing

Quoted 8 lines

This commit https://github.com/Igalia/WPEBackend-fdo/commit/e4c578f23359dba4d5abbd14b108f59e1b0701c1
causes this warning due to int to uint conversion without static casts
unless its fixes properly by upstream make behaviour same as g++ where
this is flagged too but only as a warning unlike clang which is pedantic
and enables it as error

Cc lexander Kanavin <[email protected]>

Typo: lexander -> Alexander

//Peter

Quoted 21 lines
---
 meta/recipes-sato/webkit/wpebackend-fdo_1.12.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-sato/webkit/wpebackend-fdo_1.12.0.bb +4 -1
index ba6c54412a..4a18467ea4 100644
@@ -15,6 +15,10 @@ REQUIRED_DISTRO_FEATURES = "opengl"
 SRC_URI = "https://wpewebkit.org/releases/${BPN}-${PV}.tar.xz"
 SRC_URI[sha256sum] = "6239c9c15523410798d66315de6b491712ab30009ba180f3e0dd076d9b0074ac"
 
+# Especially helps compiling with clang which enable this as error when
+# using c++11
+CXXFLAGS += "-Wno-c++11-narrowing"
+
 # This is a tweak of upstream-version-is-even needed because
 # ipstream directory contains tarballs for other components as well.
 UPSTREAM_CHECK_REGEX = "wpebackend-fdo-(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)\.tar"
--

2.33.1