Skip to contentSkip to conversation

Bluetooth: hci_sync: Fix missing static warnings

PATCH In review Luiz Augusto von Dentz 2 participants 2 messages Nov 1, 2021

Subsystems (2)
lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH v2 1/1 Bluetooth: hci_sync: Fix missing static warnings

From: Luiz Augusto von Dentz <[email protected]>

This fixes the following warnings:

Quoted 1 line
Quoted 1 line

net/bluetooth/hci_sync.c:1333:5: warning: no previous prototype for

'hci_scan_disable_sync' [-Wmissing-prototypes]
1333 | int hci_scan_disable_sync(struct hci_dev *hdev, bool rpa_le_conn)
| ^~~~~~~~~~~~~~~~~~~~~

Quoted 1 line
Quoted 1 line

net/bluetooth/hci_sync.c:1762:5: warning: no previous prototype for

'hci_passive_scan_sync' [-Wmissing-prototypes]
1762 | int hci_passive_scan_sync(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~

Fixes e8907f76544f ("Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 3")
---
 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/bluetooth/hci_sync.c +2 -2
index e3f44e621b7f..fb7ecf24b89a 100644
@@ -1397,7 +1397,7 @@ static int hci_le_set_addr_resolution_enable_sync(struct hci_dev *hdev, u8 val)
 				     sizeof(val), &val, HCI_CMD_TIMEOUT);
 }
 
-int hci_scan_disable_sync(struct hci_dev *hdev)
+static int hci_scan_disable_sync(struct hci_dev *hdev)
 {
 	int err;
 
@@ -1968,7 +1968,7 @@ static int hci_start_scan_sync(struct hci_dev *hdev, u8 type, u16 interval,
 	return hci_le_set_scan_enable_sync(hdev, LE_SCAN_ENABLE, filter_dup);
 }
 
-int hci_passive_scan_sync(struct hci_dev *hdev)
+static int hci_passive_scan_sync(struct hci_dev *hdev)
 {
 	u8 own_addr_type;
 	u8 filter_policy;
Signature · 1 line
2.31.1
maintainer
#1 lore raw

Hi Luiz,

Quoted 9 lines

This fixes the following warnings:

Quoted 1 line
Quoted 1 line

net/bluetooth/hci_sync.c:1333:5: warning: no previous prototype for

'hci_scan_disable_sync' [-Wmissing-prototypes]
1333 | int hci_scan_disable_sync(struct hci_dev *hdev, bool rpa_le_conn)

        |     ^~~~~~~~~~~~~~~~~~~~~
Quoted 1 line
Quoted 1 line

net/bluetooth/hci_sync.c:1762:5: warning: no previous prototype for

'hci_passive_scan_sync' [-Wmissing-prototypes]
1762 | int hci_passive_scan_sync(struct hci_dev *hdev)

Quoted 8 lines
        |     ^~~~~~~~~~~~~~~~~~~~~
Fixes e8907f76544f ("Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 3")

---
net/bluetooth/hci_sync.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel