Skip to contentSkip to conversation

selftests/bpf: make netcnt selftests serial to avoid spurious failures

PATCH Applied Andrii Nakryiko 2 participants 2 messages Nov 3, 2021

Subsystems (3)
lore
Share & tools
lore

Andrii Nakryiko

author maintainer
#0 lore raw

PATCH 1/1 selftests/bpf: make netcnt selftests serial to avoid spurious failures

When running ./test_progs -j test_netcnt fails with a very high probability, undercounting number of packets received (9999 vs expected 10000). It seems to be conflicting with other cgroup/skb selftests. So make it serial for now to make parallel mode more robust.

---
 tools/testing/selftests/bpf/prog_tests/netcnt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/netcnt.c +1 -1
index 6ede48bde91b..954964f0ac3d 100644
@@ -8,7 +8,7 @@
 
 #define CG_NAME "/netcnt"
 
-void test_netcnt(void)
+void serial_test_netcnt(void)
 {
 	union percpu_net_cnt *percpu_netcnt = NULL;
 	struct bpf_cgroup_storage_key key;
Signature · 1 line
2.30.2
#1 lore raw
This patch was applied to bpf/bpf.git (master) by Daniel Borkmann <[email protected]>:

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <[email protected]>:

Quoted 8 lines · On Tue, 2 Nov 2021 22:41:13 -0700 you wrote:

When running ./test_progs -j test_netcnt fails with a very high probability, undercounting number of packets received (9999 vs expected 10000). It seems to be conflicting with other cgroup/skb selftests. So make it serial for now to make parallel mode more robust.

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: make netcnt selftests serial to avoid spurious failures

    https://git.kernel.org/bpf/bpf/c/401a33da3a45

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html