Skip to contentSkip to conversation

MAINTAINERS: rectify entry for INTEL KEEM BAY OCS ECC CRYPTO DRIVER

PATCH In review Lukas Bulwahn 3 participants 3 messages Nov 3, 2021 – Nov 20, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: rectify entry for INTEL KEEM BAY OCS ECC CRYPTO DRIVER

Commit c9f608c38009 ("crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver") only adds drivers/crypto/keembay/keembay-ocs-ecc.c, but adds a file entry drivers/crypto/keembay/ocs-ecc-curve-defs.h in MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns warns:

warning: no file matches F: drivers/crypto/keembay/ocs-ecc-curve-defs.h

Assuming that this header is obsolete and will not be included in the repository, remove the unneeded file entry from MAINTAINERS.

---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
index ba9f6537abc3..1fb254aa12d1 100644
@@ -9671,7 +9671,6 @@ F:	Documentation/devicetree/bindings/crypto/intel,keembay-ocs-ecc.yaml
 F:	drivers/crypto/keembay/Kconfig
 F:	drivers/crypto/keembay/Makefile
 F:	drivers/crypto/keembay/keembay-ocs-ecc.c
-F:	drivers/crypto/keembay/ocs-ecc-curve-defs.h
 
 INTEL KEEM BAY OCS HCU CRYPTO DRIVER
 M:	Daniele Alessandrelli <[email protected]>
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Lukas,

Quoted 10 lines · Lukas Bulwahn

Commit c9f608c38009 ("crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver") only adds drivers/crypto/keembay/keembay-ocs-ecc.c, but adds a file entry drivers/crypto/keembay/ocs-ecc-curve-defs.h in MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns warns:

  warning: no file matches  F:  drivers/crypto/keembay/ocs-ecc-curve-defs.h

Assuming that this header is obsolete and will not be included in the repository, remove the unneeded file entry from MAINTAINERS.

My bad, that header was in a previous version of the patchset but was eventually dropped and I forgot to remove it from the MAINTAINERS file.

Thanks for reporting and fixing this.

Quoted 18 lines

---
 MAINTAINERS | 1 -

 1 file changed, 1 deletion(-)
MAINTAINERS +0 -0
index ba9f6537abc3..1fb254aa12d1 100644
@@ -9671,7 +9671,6 @@ F:        Documentation/devicetree/bindings/crypto/intel,keembay-ocs-ecc.yaml

 F:     drivers/crypto/keembay/Kconfig
 F:     drivers/crypto/keembay/Makefile
 F:     drivers/crypto/keembay/keembay-ocs-ecc.c
-F:     drivers/crypto/keembay/ocs-ecc-curve-defs.h

 INTEL KEEM BAY OCS HCU CRYPTO DRIVER
 M:     Daniele Alessandrelli <[email protected]>

maintainer
#2 lore raw
In reply to Lukas Bulwahn
Quoted 8 lines · Lukas Bulwahn

Commit c9f608c38009 ("crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver") only adds drivers/crypto/keembay/keembay-ocs-ecc.c, but adds a file entry drivers/crypto/keembay/ocs-ecc-curve-defs.h in MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns warns:

warning: no file matches F: drivers/crypto/keembay/ocs-ecc-curve-defs.h

Quoted 7 lines

Assuming that this header is obsolete and will not be included in the repository, remove the unneeded file entry from MAINTAINERS.

---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt