net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10
Subsystems (4)
PATCH 1/1 net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10
Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are only 1G.
--- drivers/net/dsa/mv88e6xxx/chip.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/dsa/mv88e6xxx/chip.c +4 -1
@@ -640,7 +640,10 @@ static void mv88e6393x_phylink_validate(struct mv88e6xxx_chip *chip, int port,unsigned long *mask, struct phylink_link_state *state) { -if (port ==0 || port ==9 || port ==10 ) { + bool is_6191x = + chip->info->prod_num ==MV88E6XXX_PORT_SWITCH_ID_PROD_6191X ; + +if (((port ==0 || port ==9 ) && !is_6191x) || port ==10 ) { phylink_set(mask, 10000baseT_Full); phylink_set(mask, 10000baseKR_Full); phylink_set(mask, 10000baseCR_Full);
Signature · 1 line
2.32.0
Quoted 2 lines · Marek Behún
Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are only 1G.
Interesting. The original commit says:
SERDESes can do USXGMII, 10GBASER and 5GBASER (on 6191X only one SERDES is capable of more than 1g; USXGMII is not yet supported with this change)
which is ambiguously worded - so I guess we now know that it's only port 10 that supports speeds above 1G.
Can ports 0 / 1 / 10 be changed at runtime (iow, is the C_Mode field writable on these ports?)
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Quoted 4 lines · On Thu, 4 Nov 2021 18:15:57 +0000 "Russell King (Oracle)"…
Quoted 2 lines · Marek Behún
Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are only 1G.
Quoted 8 lines
Interesting. The original commit says:
SERDESes can do USXGMII, 10GBASER and 5GBASER (on 6191X only one SERDES is capable of more than 1g; USXGMII is not yet supported with this change)
which is ambiguously worded - so I guess we now know that it's only port 10 that supports speeds above 1G.
Yes, I just found this info in datasheet.
Quoted 2 lines
Can ports 0 / 1 / 10 be changed at runtime (iow, is the
C_Modefield writable on these ports?)
Yes, cmode is writable on these ports. serdes.c also provides some errata fixes when changing cmode.
(BTW Russell I have already updated your patch
net: dsa: mv88e6xxx: populate supported_interfaces
from your net-queue branch.
I am rebasing your work on top of net-next and also adding some other stuff. I will send you the patches later.)
Marek
Quoted 6 lines · Marek Behún
Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are only 1G.
Fixes de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")Signed-off-by Marek Behún <[email protected]>Cc Russell King (Oracle) <[email protected]>
Andrew
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 4 Nov 2021 18:17:47 +0100 you wrote:
Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are only 1G.
Fixes de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")Signed-off-by Marek Behún <[email protected]>Cc Russell King (Oracle) <[email protected]>[...]
Here is the summary with links:
- [net] net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10
https://git.kernel.org/netdev/net/c/dc2fc9f03c5c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html