x86/vdso: remove -nostdlib compiler flag
Subsystems (3)
PATCH 1/2 x86/vdso: remove -nostdlib compiler flag
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
Since
379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")
$(LD) is directly used, hence -nostdlib is unneeded.
---
arch/x86/entry/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/entry/vdso/Makefile +1 -1
@@ -172,7 +172,7 @@ $(obj)/vdso32.so.dbg: $(obj)/vdso32/vdso32.lds $(vobjs32) FORCE # The DSO images are built using a special linker script. # quiet_cmd_vdso = VDSO $@ - cmd_vdso = $(LD) -nostdlib -o $@ \ + cmd_vdso = $(LD) -o $@ \ $(VDSO_LDFLAGS) $(VDSO_LDFLAGS_$(filter %.lds,$(^F))) \ -T $(filter %.lds,$^) $(filter %.o,$^) && \ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@'
Signature · 1 line
2.30.2
PATCH 2/2 x86/purgatory: remove -nostdlib compiler flag
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
$(LD) is directly used for linking purgatory.{ro,chk} here, hence -nostdlib is unneeded.
---
arch/x86/purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/purgatory/Makefile +1 -1
@@ -16,7 +16,7 @@ CFLAGS_sha256.o := -D__DISABLE_EXPORTS # When linking purgatory.ro with -r unresolved symbols are not checked, # also link a purgatory.chk binary without -r to check for unresolved symbols. -PURGATORY_LDFLAGS := -e purgatory_start -nostdlib -z nodefaultlib +PURGATORY_LDFLAGS := -e purgatory_start -z nodefaultlib LDFLAGS_purgatory.ro := -r $(PURGATORY_LDFLAGS) LDFLAGS_purgatory.chk := $(PURGATORY_LDFLAGS) targets += purgatory.ro purgatory.chk
Signature · 1 line
2.30.2
Re: [PATCH 2/2] x86/purgatory: remove -nostdlib compiler flag
Quoted 4 lines · Masahiro Yamada
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
Is that right? ld.lld recognizes --nostdlib and has --help text for it.
Quoted 25 lines
$(LD) is directly used for linking purgatory.{ro,chk} here, hence -nostdlib is unneeded.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/purgatory/Makefile +1
-2@@ -16,7 +16,7 @@ CFLAGS_sha256.o := -D__DISABLE_EXPORTS # When linking purgatory.ro with -r unresolved symbols are not checked, # also link a purgatory.chk binary without -r to check for unresolved symbols. -PURGATORY_LDFLAGS := -e purgatory_start -nostdlib -z nodefaultlib +PURGATORY_LDFLAGS := -e purgatory_start -z nodefaultlib LDFLAGS_purgatory.ro := -r $(PURGATORY_LDFLAGS) LDFLAGS_purgatory.chk := $(PURGATORY_LDFLAGS) targets += purgatory.ro purgatory.chk --2.30.2
Signature · 2 lines
Thanks, ~Nick Desaulniers
Re: [PATCH 2/2] x86/purgatory: remove -nostdlib compiler flag
Quoted 7 lines · Nick Desaulniers
Quoted 4 lines · Masahiro Yamada
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
Is that right? ld.lld recognizes --nostdlib and has --help text for it.
GCC/Clang driver -nostdlib != ld.bfd/ld.lld -nostdlib.
ld.lld -nostdlib just ignores SEARCH_DIR in a linker script. I think ld.bfd's -nostdlib is more complex than that which also has something to do with its internal linker script location. Anyway, getting of the obscure ld -nostdlib is a good idea.
Quoted 29 lines
Quoted 25 lines
$(LD) is directly used for linking purgatory.{ro,chk} here, hence -nostdlib is unneeded.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/purgatory/Makefile +1
-2@@ -16,7 +16,7 @@ CFLAGS_sha256.o := -D__DISABLE_EXPORTS # When linking purgatory.ro with -r unresolved symbols are not checked, # also link a purgatory.chk binary without -r to check for unresolved symbols. -PURGATORY_LDFLAGS := -e purgatory_start -nostdlib -z nodefaultlib +PURGATORY_LDFLAGS := -e purgatory_start -z nodefaultlib LDFLAGS_purgatory.ro := -r $(PURGATORY_LDFLAGS) LDFLAGS_purgatory.chk := $(PURGATORY_LDFLAGS) targets += purgatory.ro purgatory.chk --2.30.2
Signature · 2 lines
Thanks, ~Nick Desaulniers
Nick Desaulniers
Reviewed-byRe: [PATCH 2/2] x86/purgatory: remove -nostdlib compiler flag
Quoted 8 lines · Fangrui Song' via Clang Built Linux
Quoted 6 lines · Nick Desaulniers
Quoted 4 lines · Masahiro Yamada
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
Quoted 8 lines
Quoted 1 line
Is that right? ld.lld recognizes --nostdlib and has --help text for it.
GCC/Clang driver -nostdlib != ld.bfd/ld.lld -nostdlib.
ld.lld -nostdlib just ignores
SEARCH_DIRin a linker script. I think ld.bfd's -nostdlib is more complex than that which also has something to do with its internal linker script location. Anyway, getting of the obscure ld -nostdlib is a good idea.
Ok, I verified that the size of arch/x86/purgatory/purgatory.ro, arch/x86/entry/vdso/vdso64.so, and arch/x86/entry/vdso/vdso32.so don't change with this series. (ldd is not happy with the .so's regardless).
I also suspect that the linker when invoked directly can't assuming it's linking object files created from C sources (ie. could have been assembler sources), so there's no reason to assume that the libc, C runtime, or compiler runtime would need to be linked against.
Quoted 35 lines
Quoted 17 lines
Quoted 17 lines
$(LD) is directly used for linking purgatory.{ro,chk} here, hence -nostdlib is unneeded.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/purgatory/Makefile +0
-0@@ -16,7 +16,7 @@ CFLAGS_sha256.o := -D__DISABLE_EXPORTSQuoted 13 lines
Quoted 9 lines
arch/x86/purgatory/Makefile +1
-2# When linking purgatory.ro with -r unresolved symbols are not checked, # also link a purgatory.chk binary without -r to check for unresolved symbols. -PURGATORY_LDFLAGS := -e purgatory_start -nostdlib -z nodefaultlib +PURGATORY_LDFLAGS := -e purgatory_start -z nodefaultlib LDFLAGS_purgatory.ro := -r $(PURGATORY_LDFLAGS) LDFLAGS_purgatory.chk := $(PURGATORY_LDFLAGS) targets += purgatory.ro purgatory.chk --2.30.2
--
Thanks,
~Nick Desaulniers--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20211109000531.k23mgrfjn5tomevv%40google.com.
Signature · 2 lines
Thanks, ~Nick Desaulniers
[tip: x86/vdso] x86/purgatory: Remove -nostdlib compiler flag
In reply to Masahiro YamadaThe following commit has been merged into the x86/vdso branch of tip:
The following commit has been merged into the x86/vdso branch of tip:
Commit-ID: 9102fa34604159642625f42d7f801f1e04d9ca12 Gitweb: https://git.kernel.org/tip/9102fa34604159642625f42d7f801f1e04d9ca12 Author: Masahiro Yamada <[email protected]> AuthorDate: Mon, 08 Nov 2021 01:26:41 +09:00 Committer: Borislav Petkov <[email protected]> CommitterDate: Thu, 30 Dec 2021 14:13:06 +01:00
x86/purgatory: Remove -nostdlib compiler flag
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
$(LD) is directly used for linking purgatory.{ro,chk} here, hence -nostdlib is unneeded.
--- arch/x86/purgatory/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/purgatory/Makefile +1 -1
@@ -16,7 +16,7 @@ CFLAGS_sha256.o := -D__DISABLE_EXPORTS # When linking purgatory.ro with -r unresolved symbols are not checked, # also link a purgatory.chk binary without -r to check for unresolved symbols. -PURGATORY_LDFLAGS := -e purgatory_start -nostdlib -z nodefaultlib +PURGATORY_LDFLAGS := -e purgatory_start -z nodefaultlib LDFLAGS_purgatory.ro := -r $(PURGATORY_LDFLAGS) LDFLAGS_purgatory.chk := $(PURGATORY_LDFLAGS) targets += purgatory.ro purgatory.chk
Quoted 5 lines · Masahiro Yamada
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
Quoted 7 lines
Since
379d98ddf413("x86: vdso: Use $LD instead of $CC to link")$(LD) is directly used, hence -nostdlib is unneeded.
Signed-off-by Masahiro Yamada <[email protected]>
Thanks for the patch!
Quoted 25 lines
---
arch/x86/entry/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/entry/vdso/Makefile +1
-2@@ -172,7 +172,7 @@ $(obj)/vdso32.so.dbg: $(obj)/vdso32/vdso32.lds $(vobjs32) FORCE # The DSO images are built using a special linker script. # quiet_cmd_vdso = VDSO $@ - cmd_vdso = $(LD) -nostdlib -o $@ \ + cmd_vdso = $(LD) -o $@ \ $(VDSO_LDFLAGS) $(VDSO_LDFLAGS_$(filter %.lds,$(^F))) \ -T $(filter %.lds,$^) $(filter %.o,$^) && \ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@' --2.30.2
--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20211107162641.324688-1-masahiroy%40kernel.org.
Signature · 2 lines
Thanks, ~Nick Desaulniers
[tip: x86/vdso] x86/vdso: Remove -nostdlib compiler flag
In reply to Masahiro YamadaThe following commit has been merged into the x86/vdso branch of tip:
The following commit has been merged into the x86/vdso branch of tip:
Commit-ID: a41f5b78ac5ba65986b31ddc6325a0b8cc8b8864 Gitweb: https://git.kernel.org/tip/a41f5b78ac5ba65986b31ddc6325a0b8cc8b8864 Author: Masahiro Yamada <[email protected]> AuthorDate: Mon, 08 Nov 2021 01:26:40 +09:00 Committer: Borislav Petkov <[email protected]> CommitterDate: Thu, 30 Dec 2021 14:08:20 +01:00
x86/vdso: Remove -nostdlib compiler flag
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver.
Since
379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")
$(LD) is directly used, hence -nostdlib is unneeded.
--- arch/x86/entry/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/entry/vdso/Makefile +1 -1
@@ -172,7 +172,7 @@ $(obj)/vdso32.so.dbg: $(obj)/vdso32/vdso32.lds $(vobjs32) FORCE # The DSO images are built using a special linker script. # quiet_cmd_vdso = VDSO $@ - cmd_vdso = $(LD) -nostdlib -o $@ \ + cmd_vdso = $(LD) -o $@ \ $(VDSO_LDFLAGS) $(VDSO_LDFLAGS_$(filter %.lds,$(^F))) \ -T $(filter %.lds,$^) $(filter %.o,$^) && \ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@'