Skip to contentSkip to conversation

net/ice: fix AdminQ handling on DCF passive reset

PATCH Applied [email protected] 2 participants 2 messages Nov 9, 2021 – Nov 10, 2021 Network drivers

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 net/ice: fix AdminQ handling on DCF passive reset

From: Dapeng Yu <[email protected]>

DCF tries to handle AdminQ when DCF is reset by PF, however the invalid data may be returned, and error log may be output in this situation.

This patch stops handling AdminQ when a passive reset is detected to avoid this situation.

Fixes 7564d5509611 ("net/ice: add DCF hardware initialization")
Cc [email protected]
Signed-off-by Dapeng Yu <[email protected]>
---
 drivers/net/ice/ice_dcf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_dcf.c +1 -1
index 366ff0a907..cca1d7bf46 100644
@@ -166,7 +166,7 @@ ice_dcf_handle_virtchnl_msg(struct ice_dcf_hw *hw)
 	info.buf_len = ICE_DCF_AQ_BUF_SZ;
 	info.msg_buf = hw->arq_buf;
 
-	while (pending) {
+	while (pending && !hw->resetting) {
 		ret = iavf_clean_arq_element(&hw->avf, &info, &pending);
 		if (ret != IAVF_SUCCESS)
 			break;
Signature · 1 line
2.27.0
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 16 lines

-----Original Message-----
From: Yu, DapengX <[email protected]>
Sent: Tuesday, November 9, 2021 3:50 PM
To: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Wang, Haiyue <[email protected]>; Yu, DapengX <[email protected]>; [email protected]
Subject: [PATCH] net/ice: fix AdminQ handling on DCF passive reset

From: Dapeng Yu <[email protected]>

DCF tries to handle AdminQ when DCF is reset by PF, however the invalid data may be returned, and error log may be output in this situation.

Quoted 7 lines

This patch stops handling AdminQ when a passive reset is detected to avoid this situation.

Fixes 7564d5509611 ("net/ice: add DCF hardware initialization")
Cc [email protected]
Signed-off-by Dapeng Yu <[email protected]>
Acked-by Qi Zhang <[email protected]>

Applied to dpdk-next-net-intel.

Thanks
Qi