glibc: ptest: Add running glibc time related test suite (Y2038) with ptest
PATCH v4 1/1 glibc: ptest: Add running glibc time related test suite (Y2038) with ptest
This patch introduces new recipe - namely 'glibc-tests', which builds and installs time related (to check if Y2038 support works) glibc test suite to OE/Yocto built image.
It reuses code from already available 'glibc-testsuite' recipe, which is run with 'bitbake glibc-testsuite -c check' and uses qemu to execute remotely (via SSH) tests on some emulated machine.
This recipe installs time related glibc tests on some rootfs image. Afterwards, those tests can be executed on the real hardware, to facilitate validation of it with Y2038 problem compliance.
To test time related subset - one needs to call:
ptest-runner glibc-tests
then change the date after Y2038 threshold for 32 bit systems:
date -s "20 JAN 2038 18:00:00"
and then run ptest-runner again.
To facilitate debugging, source files are provided by default with the unstripped debugging symbols. Such approach would reduce the already complex recipe (as it inherits base glibc one), so there is no need to also install *-dbg and *-src packages.
---
Changes for v4:
- Add entry for 'glibc-tests' in the maintainers.inc file
- Remove nativesdk from BBCLASSEXTEND as this resipe is not supposed to be the part of SDK
Changes for v3:
- Provide missing ${PN}-ptest for PACKAGES, PROVIDES and RPROVIDES variables
Changes for v2:
- Just focus on time related set of tests as those can be run as standalone
- Reuse of already built tests (from glibc-tests.inc) and depoloy them on the HW target.
- Provide single 'run-ptest' script.
- Update the recipe to run with newest poky's -master
--- meta/conf/distro/include/maintainers.inc | 1 + .../distro/include/ptest-packagelists.inc | 1 + meta/recipes-core/glibc/glibc-tests_2.34.bb | 113 ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest | 37 ++++++ 4 files changed, 152 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb create mode 100755 meta/recipes-core/glibc/glibc/run-ptest
meta/conf/distro/include/maintainers.inc +1 -0
@@ -209,6 +209,7 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-glibc-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glide = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>"
meta/conf/distro/include/ptest-packagelists.inc +1 -0
@@ -61,6 +61,7 @@ PTESTS_FAST = "\ slang-ptest \ wayland-ptest \ zlib-ptest \ + glibc-tests-ptest \ " PTESTS_FAST:remove:mips64 = "qemu-ptest" PTESTS_PROBLEMS:append:mips64 = "qemu-ptest"
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +113 -0
113 lines not on this page · raw message
meta/recipes-core/glibc/glibc/run-ptest new file +37 -0
@@ -0,0 +1,37 @@ +#!/bin/sh +# ptest script for glibc - to run time related tests to +# facilitate Y2038 validation +# Run with 'ptest-runner glibc-tests' + +output() { + retcode=$? + if [ $retcode -eq 0 ] + then echo "PASS: $i" + elif [ $retcode -eq 77 ] + then echo "SKIP: $i" + else echo "FAIL: $i" + fi +} + +# Allow altering time on the target +export GLIBC_TEST_ALLOW_TIME_SETTING="1" + +tst_time64=$(ls -r ${PWD}/tests/glibc-ptest/*-time64) + +# Remove '-time64' suffix - those tests are also time +# related +tst_time_tmp=$(sed -e "s/-time64$//" <<< ${tst_time64}) + +# Run tests supporting only 32 bit time +for i in ${tst_time_tmp} +do + $i >/dev/null 2>&1 + output +done + +# Run tests supporting only 64 bit time +for i in ${tst_time64} +do + $i >/dev/null 2>&1 + output +done
Signature · 1 line
2.20.1
seeing this
https://errors.yoctoproject.org/Errors/Details/616955/
Quoted 241 lines · Lukasz Majewski
This patch introduces new recipe - namely 'glibc-tests', which builds and installs time related (to check if Y2038 support works) glibc test suite to OE/Yocto built image.
It reuses code from already available 'glibc-testsuite' recipe, which is run with 'bitbake glibc-testsuite -c check' and uses qemu to execute remotely (via SSH) tests on some emulated machine.
This recipe installs time related glibc tests on some rootfs image. Afterwards, those tests can be executed on the real hardware, to facilitate validation of it with Y2038 problem compliance.
To test time related subset - one needs to call:
ptest-runner glibc-tests
then change the date after Y2038 threshold for 32 bit systems:
date -s "20 JAN 2038 18:00:00"
and then run ptest-runner again.To facilitate debugging, source files are provided by default with the unstripped debugging symbols. Such approach would reduce the already complex recipe (as it inherits base glibc one), so there is no need to also install *-dbg and *-src packages.
Signed-off-by Lukasz Majewski <[email protected]>---
Changes for v4:
- Add entry for 'glibc-tests' in the maintainers.inc file
- Remove nativesdk from BBCLASSEXTEND as this resipe is not supposed to be the part of SDKChanges for v3:
- Provide missing ${PN}-ptest for PACKAGES, PROVIDES and RPROVIDES variablesChanges for v2:
- Just focus on time related set of tests as those can be run as standalone
- Reuse of already built tests (from glibc-tests.inc) and depoloy them on the HW target.
- Provide single 'run-ptest' script.
- Update the recipe to run with newest poky's -master--- meta/conf/distro/include/maintainers.inc | 1 + .../distro/include/ptest-packagelists.inc | 1 + meta/recipes-core/glibc/glibc-tests_2.34.bb | 113 ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest | 37 ++++++ 4 files changed, 152 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb create mode 100755 meta/recipes-core/glibc/glibc/run-ptestmeta/conf/distro/include/maintainers.inc +1
-0@@ -209,6 +209,7 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-glibc-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glide = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>"meta/conf/distro/include/ptest-packagelists.inc +1
-0@@ -61,6 +61,7 @@ PTESTS_FAST = "\ slang-ptest \ wayland-ptest \ zlib-ptest \ + glibc-tests-ptest \ " PTESTS_FAST:remove:mips64 = "qemu-ptest" PTESTS_PROBLEMS:append:mips64 = "qemu-ptest"meta/recipes-core/glibc/glibc-tests_2.34.bb new file +113
-0@@ -0,0 +1,113 @@ +require glibc_${PV}.bb +require glibc-tests.inc + +inherit ptest + +SRC_URI:append = " \ + file://run-ptest \ +" + +SUMMARY = "glibc tests to be run with ptest" + +# Erase some variables already set by glibc_${PV} +python __anonymous() { + # Remove packages provided by glibc build, we only need a subset of them + d.setVar("PACKAGES", "${PN} ${PN}-ptest") + + d.setVar("PROVIDES", "${PN} ${PN}-ptest") + d.setVar("RPROVIDES", "${PN} ${PN}-ptest") + + d.setVar("BBCLASSEXTEND", "") + d.setVar("RRECOMMENDS", "") +} + +# Remove any lefovers from original glibc recipe +RPROVIDES:${PN} = "${PN}" +RRECOMMENDS:${PN} = "" +RDEPENDS:${PN} = " glibc sed" +DEPENDS:append = " sed" + +# Just build tests for target - do not run them +do_check:append () { + oe_runmake -i check run-built-tests=no +} +addtask do_check after do_compile before do_install_ptest_base + +glibc_strip_build_directory () { + # Delete all non executable files from build directory + find ${B} ! -executable -type f -delete + + # Remove build dynamic libraries and links to them as + # those are already installed in the target device + find ${B} -type f -name "*.so" -delete + find ${B} -type l -name "*.so*" -delete + + # Remove headers (installed with glibc) + find ${B} -type f -name "*.h" -delete + + find ${B} -type f -name "isomac" -delete + find ${B} -type f -name "annexc" -delete +} + +do_install_ptest_base () { + glibc_strip_build_directory + + ls -r ${B}/*/*-time64 > ${B}/tst_time64 + + # Remove '-time64' suffix - those tests are also time related + sed -e "s/-time64$//" ${B}/tst_time64 > ${B}/tst_time_tmp + tst_time=$(cat ${B}/tst_time_tmp ${B}/tst_time64) + + rm ${B}/tst_time_tmp ${B}/tst_time64 + echo "${tst_time}" + + # Install build test programs to the image + install -d ${D}${PTEST_PATH}/tests/glibc-ptest/ + + for f in "${tst_time}" + do + cp -r ${f} ${D}${PTEST_PATH}/tests/glibc-ptest/ + done + + install -d ${D}${PTEST_PATH} + cp ${WORKDIR}/run-ptest ${D}${PTEST_PATH}/ + +} + +# The datadir directory is required to allow core (and reused) +# glibc cleanup function to finish correctly, as this directory +# is not created for ptests +stash_locale_package_cleanup:prepend () { + mkdir -p ${PKGD}${datadir} +} + +stash_locale_sysroot_cleanup:prepend () { + mkdir -p ${SYSROOT_DESTDIR}${datadir} +} + +# Prevent the do_package() task to set 'libc6' prefix +# for glibc tests related packages +python populate_packages:prepend () { + if d.getVar('DEBIAN_NAMES'): + d.setVar('DEBIAN_NAMES', '') +} + +FILES:${PN} = "${PTEST_PATH}/* /usr/src/debug/glibc-tests/*" + +EXCLUDE_FROM_SHLIBS = "1" + +# Install debug data in .debug and sources in /usr/src/debug +# It is more handy to have _all_ the sources and symbols in one +# place (package) as this recipe will be used for validation and +# debugging. +PACKAGE_DEBUG_SPLIT_STYLE = "debug" + +# glibc test cases violate by default some Yocto/OE checks (staticdev, +# textrel) +# 'debug-files' - add everything (including debug) into one package +# (no need to install/build *-src package) +INSANE_SKIP:${PN} += "staticdev textrel debug-files rpaths" + +deltask do_stash_locale +do_install[noexec] = "1" +do_populate_sysroot[noexec] = "1"meta/recipes-core/glibc/glibc/run-ptest new file +37
-1@@ -0,0 +1,37 @@ +#!/bin/sh +# ptest script for glibc - to run time related tests to +# facilitate Y2038 validation +# Run with 'ptest-runner glibc-tests' + +output() { + retcode=$? + if [ $retcode -eq 0 ] + then echo "PASS: $i" + elif [ $retcode -eq 77 ] + then echo "SKIP: $i" + else echo "FAIL: $i" + fi +} + +# Allow altering time on the target +export GLIBC_TEST_ALLOW_TIME_SETTING="1" + +tst_time64=$(ls -r ${PWD}/tests/glibc-ptest/*-time64) + +# Remove '-time64' suffix - those tests are also time +# related +tst_time_tmp=$(sed -e "s/-time64$//" <<< ${tst_time64}) + +# Run tests supporting only 32 bit time +for i in ${tst_time_tmp} +do + $i >/dev/null 2>&1 + output +done + +# Run tests supporting only 64 bit time +for i in ${tst_time64} +do + $i >/dev/null 2>&1 + output +done --2.20.1
Hi Khem,
Quoted 3 lines
seeing this
The error is about autoconf version:
DEBUG: Executing shell function do_configure
aclocal.m4:6: error: Exactly version 2.69 of Autoconf is required but you have 2.71
aclocal.m4:6: the top level
autom4te: error: m4 failed with exit status: 63
This is strange, as on my setup (qemuarm, qemuarm64, qemux86) the glibc and glibc-tests are built without any issues with autoconf version 2.71.
I've built the glibc-tests without issues with:
Build Configuration:
BB_VERSION = "1.52.0" BUILD_SYS = "x86_64-linux" NATIVELSBSTRING = "universal" TARGET_SYS = "riscv64-poky-linux" MACHINE = "qemuriscv64" DISTRO = "poky" DISTRO_VERSION = "3.4" TUNE_FEATURES = "riscv64"
meta
meta-poky
meta-yocto-bsp =
"glibc-ptest_v4:164923f0586ac189f01938a32fa102c2df7cc447"
DISTRO=poky MACHINE=qemuriscv64 bitbake glibc-tests
Khem, could you help me with setting up environment to reproduce this issue?
Quoted 237 lines · Lukasz Majewski
Quoted 235 lines
This patch introduces new recipe - namely 'glibc-tests', which builds and installs time related (to check if Y2038 support works) glibc test suite to OE/Yocto built image.
It reuses code from already available 'glibc-testsuite' recipe, which is run with 'bitbake glibc-testsuite -c check' and uses qemu to execute remotely (via SSH) tests on some emulated machine.
This recipe installs time related glibc tests on some rootfs image. Afterwards, those tests can be executed on the real hardware, to facilitate validation of it with Y2038 problem compliance.
To test time related subset - one needs to call:
ptest-runner glibc-tests
then change the date after Y2038 threshold for 32 bit systems:
date -s "20 JAN 2038 18:00:00"
and then run ptest-runner again.To facilitate debugging, source files are provided by default with the unstripped debugging symbols. Such approach would reduce the already complex recipe (as it inherits base glibc one), so there is no need to also install *-dbg and *-src packages.
Signed-off-by Lukasz Majewski <[email protected]>---
Changes for v4:
- Add entry for 'glibc-tests' in the maintainers.inc file
- Remove nativesdk from BBCLASSEXTEND as this resipe is not supposed to be the part of SDKChanges for v3:
- Provide missing ${PN}-ptest for PACKAGES, PROVIDES and RPROVIDES variablesChanges for v2:
- Just focus on time related set of tests as those can be run as standalone
- Reuse of already built tests (from glibc-tests.inc) and depoloy them on the HW target.
- Provide single 'run-ptest' script.
- Update the recipe to run with newest poky's -master--- meta/conf/distro/include/maintainers.inc | 1 + .../distro/include/ptest-packagelists.inc | 1 + meta/recipes-core/glibc/glibc-tests_2.34.bb | 113 ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest | 37 ++++++ 4 files changed, 152 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb create mode 100755 meta/recipes-core/glibc/glibc/run-ptest(quoted diff) +0
-0b/meta/conf/distro/include/maintainers.inc index
baec2bef4d..7104e091fc100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -209,6 +209,7 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-glibc-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glide = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>" diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc index2e324f8da4..fd52fa72a4100644 --- a/meta/conf/distro/include/ptest-packagelists.inc +++ b/meta/conf/distro/include/ptest-packagelists.inc @@ -61,6 +61,7 @@PTESTS_FAST= "\ slang-ptest \ wayland-ptest \ zlib-ptest \meta/conf/distro/include/ptest-packagelists.inc +1
-0+ glibc-tests-ptest \ " PTESTS_FAST:remove:mips64 = "qemu-ptest" PTESTS_PROBLEMS:append:mips64 = "qemu-ptest"(quoted diff) +0
-0b/meta/recipes-core/glibc/glibc-tests_2.34.bb new file mode 100644 index 0000000000..d2d3cfff91
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +14
-0@@ -0,0 +1,113 @@ +require glibc_${PV}.bb +require glibc-tests.inc + +inherit ptest + +SRC_URI:append = " \ + file://run-ptest \ +" + +SUMMARY = "glibc tests to be run with ptest" + +# Erase some variables already set by glibc_${PV} +python __anonymous() { + # Remove packages provided by glibc build, we only need asubset of them
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +43
-0+ d.setVar("PACKAGES", "${PN} ${PN}-ptest") + + d.setVar("PROVIDES", "${PN} ${PN}-ptest") + d.setVar("RPROVIDES", "${PN} ${PN}-ptest") + + d.setVar("BBCLASSEXTEND", "") + d.setVar("RRECOMMENDS", "") +} + +# Remove any lefovers from original glibc recipe +RPROVIDES:${PN} = "${PN}" +RRECOMMENDS:${PN} = "" +RDEPENDS:${PN} = " glibc sed" +DEPENDS:append = " sed" + +# Just build tests for target - do not run them +do_check:append () { + oe_runmake -i check run-built-tests=no +} +addtask do_check after do_compile before do_install_ptest_base + +glibc_strip_build_directory () { + # Delete all non executable files from build directory + find ${B} ! -executable -type f -delete + + # Remove build dynamic libraries and links to them as + # those are already installed in the target device + find ${B} -type f -name "*.so" -delete + find ${B} -type l -name "*.so*" -delete + + # Remove headers (installed with glibc) + find ${B} -type f -name "*.h" -delete + + find ${B} -type f -name "isomac" -delete + find ${B} -type f -name "annexc" -delete +} + +do_install_ptest_base () { + glibc_strip_build_directory + + ls -r ${B}/*/*-time64 > ${B}/tst_time64 + + # Remove '-time64' suffix - those tests are also timerelated
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +48
-0+ sed -e "s/-time64$//" ${B}/tst_time64 > ${B}/tst_time_tmp + tst_time=$(cat ${B}/tst_time_tmp ${B}/tst_time64) + + rm ${B}/tst_time_tmp ${B}/tst_time64 + echo "${tst_time}" + + # Install build test programs to the image + install -d ${D}${PTEST_PATH}/tests/glibc-ptest/ + + for f in "${tst_time}" + do + cp -r ${f} ${D}${PTEST_PATH}/tests/glibc-ptest/ + done + + install -d ${D}${PTEST_PATH} + cp ${WORKDIR}/run-ptest ${D}${PTEST_PATH}/ + +} + +# The datadir directory is required to allow core (and reused) +# glibc cleanup function to finish correctly, as this directory +# is not created for ptests +stash_locale_package_cleanup:prepend () { + mkdir -p ${PKGD}${datadir} +} + +stash_locale_sysroot_cleanup:prepend () { + mkdir -p ${SYSROOT_DESTDIR}${datadir} +} + +# Prevent the do_package() task to set 'libc6' prefix +# for glibc tests related packages +python populate_packages:prepend () { + if d.getVar('DEBIAN_NAMES'): + d.setVar('DEBIAN_NAMES', '') +} + +FILES:${PN} = "${PTEST_PATH}/* /usr/src/debug/glibc-tests/*" + +EXCLUDE_FROM_SHLIBS = "1" + +# Install debug data in .debug and sources in /usr/src/debug +# It is more handy to have _all_ the sources and symbols in one +# place (package) as this recipe will be used for validation and +# debugging. +PACKAGE_DEBUG_SPLIT_STYLE = "debug" + +# glibc test cases violate by default some Yocto/OE checks(staticdev, +# textrel)
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +7
-0+# 'debug-files' - add everything (including debug) into one package +# (no need to install/build *-src package) +INSANE_SKIP:${PN} += "staticdev textrel debug-files rpaths" + +deltask do_stash_locale +do_install[noexec] = "1" +do_populate_sysroot[noexec] = "1"(quoted diff) +0
-0b/meta/recipes-core/glibc/glibc/run-ptest new file mode 100755 index 0000000000..f637986105
meta/recipes-core/glibc/glibc/run-ptest new file +32
-0@@ -0,0 +1,37 @@ +#!/bin/sh +# ptest script for glibc - to run time related tests to +# facilitate Y2038 validation +# Run with 'ptest-runner glibc-tests' + +output() { + retcode=$? + if [ $retcode -eq 0 ] + then echo "PASS: $i" + elif [ $retcode -eq 77 ] + then echo "SKIP: $i" + else echo "FAIL: $i" + fi +} + +# Allow altering time on the target +export GLIBC_TEST_ALLOW_TIME_SETTING="1" + +tst_time64=$(ls -r ${PWD}/tests/glibc-ptest/*-time64) + +# Remove '-time64' suffix - those tests are also time +# related +tst_time_tmp=$(sed -e "s/-time64$//" <<< ${tst_time64}) + +# Run tests supporting only 32 bit time +for i in ${tst_time_tmp} +do + $i >/dev/null 2>&1 + output +done + +# Run tests supporting only 64 bit time
Quoted 8 lines
Quoted 8 lines
meta/recipes-core/glibc/glibc/run-ptest new file +5
-1+for i in ${tst_time64} +do + $i >/dev/null 2>&1 + output +done --2.20.1
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 35 lines · Lukasz Majewski
Hi Khem,
Quoted 3 lines
seeing this
The error is about autoconf version:
DEBUG: Executing shell function
do_configure
aclocal.m4:6: error: Exactly version 2.69 of Autoconf is required but you have 2.71aclocal.m4:6: the top level
autom4te: error: m4 failed with exit status: 63This is strange, as on my setup (qemuarm, qemuarm64, qemux86) the glibc and glibc-tests are built without any issues with autoconf version 2.71.
I've built the glibc-tests without issues with:
Build Configuration:
BB_VERSION = "1.52.0" BUILD_SYS = "x86_64-linux" NATIVELSBSTRING = "universal" TARGET_SYS = "riscv64-poky-linux" MACHINE = "qemuriscv64" DISTRO = "poky" DISTRO_VERSION = "3.4" TUNE_FEATURES = "riscv64"meta
meta-poky
meta-yocto-bsp =
"glibc-ptest_v4:164923f0586ac189f01938a32fa102c2df7cc447"
Quoted 5 lines
DISTRO=poky MACHINE=qemuriscv64 bitbake glibc-tests
Khem, could you help me with setting up environment to reproduce this issue?
The autoconf version message isn't a fatal error and if you look at your own build logs you probably have that too. What looks like it is the issue is:
checking if riscv64-yoe-linux-clang -target riscv64-yoe-linux -mlittle-endian -mno-relax -Qunused-arguments -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=TOPDIR/build/tmp/work/riscv64-yoe-linux/glibc-tests/2.34-r0/recipe-sysroot is sufficient to build libc... no
which I think leads to:
configure: error:
*** These critical programs are missing or too old: compiler
Khem was implying this was a musl build, I can't see that from the logs but if it is a musl build, it shouldn't be building glibc tests.
For that reason I did add:
to master-next since I believe that was the remaining issue blocking the patch apart from a typo Khem also mentioned which I meant to find and tweak.
I still am concerned about having duplication of tests but I don't see any way around that since you want to get this patch merged and I don't have any solution for that.
Cheers,
Richard
Quoted 50 lines · Richard Purdie
Quoted 35 lines · Lukasz Majewski
Hi Khem,
Quoted 3 lines
seeing this
The error is about autoconf version:
DEBUG: Executing shell function
do_configure
aclocal.m4:6: error: Exactly version 2.69 of Autoconf is required but you have 2.71aclocal.m4:6: the top level
autom4te: error: m4 failed with exit status: 63This is strange, as on my setup (qemuarm, qemuarm64, qemux86) the glibc and glibc-tests are built without any issues with autoconf version 2.71.
I've built the glibc-tests without issues with:
Build Configuration:
BB_VERSION = "1.52.0" BUILD_SYS = "x86_64-linux" NATIVELSBSTRING = "universal" TARGET_SYS = "riscv64-poky-linux" MACHINE = "qemuriscv64" DISTRO = "poky" DISTRO_VERSION = "3.4" TUNE_FEATURES = "riscv64"meta
meta-poky
meta-yocto-bsp =
"glibc-ptest_v4:164923f0586ac189f01938a32fa102c2df7cc447"Quoted 5 lines
DISTRO=poky MACHINE=qemuriscv64 bitbake glibc-tests
Khem, could you help me with setting up environment to reproduce this issue?
The autoconf version message isn't a fatal error and if you look at your own
build logs you probably have that too. What looks like it is the issue is:checking if riscv64-yoe-linux-clang -target riscv64-yoe-linux
(quoted diff) +0
-3-mlittle-endian -mno-relax -Qunused-arguments -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=TOPDIR/build/tmp/work/riscv64-yoe-linux/glibc-tests/2.34-r0/recipe-sysroot
Quoted 2 lines
is sufficient to build libc... no
Right so perhaps we need to set TOOLCHAIN to gcc for this in meta-clang which should fix it
Quoted 29 lines
which I think leads to:
configure: error:
*** These critical programs are missing or too old: compilerKhem was implying this was a musl build, I can't see that from the logs but if
it is a musl build, it shouldn't be building glibc tests.For that reason I did add:
to master-next since I believe that was the remaining issue blocking the patch
apart from a typo Khem also mentioned which I meant to find and tweak.I still am concerned about having duplication of tests but I don't see any way
around that since you want to get this patch merged and I don't have any solution for that.Cheers,
Richard
Quoted 69 lines · Lukasz Majewski
This patch introduces new recipe - namely 'glibc-tests', which builds and installs time related (to check if Y2038 support works) glibc test suite to OE/Yocto built image.
It reuses code from already available 'glibc-testsuite' recipe, which is run with 'bitbake glibc-testsuite -c check' and uses qemu to execute remotely (via SSH) tests on some emulated machine.
This recipe installs time related glibc tests on some rootfs image. Afterwards, those tests can be executed on the real hardware, to facilitate validation of it with Y2038 problem compliance.
To test time related subset - one needs to call:
ptest-runner glibc-tests
then change the date after Y2038 threshold for 32 bit systems:
date -s "20 JAN 2038 18:00:00"
and then run ptest-runner again.To facilitate debugging, source files are provided by default with the unstripped debugging symbols. Such approach would reduce the already complex recipe (as it inherits base glibc one), so there is no need to also install *-dbg and *-src packages.
Signed-off-by Lukasz Majewski <[email protected]>---
Changes for v4:
- Add entry for 'glibc-tests' in the maintainers.inc file
- Remove nativesdk from BBCLASSEXTEND as this resipe is not supposed to be the part of SDKChanges for v3:
- Provide missing ${PN}-ptest for PACKAGES, PROVIDES and RPROVIDES variablesChanges for v2:
- Just focus on time related set of tests as those can be run as standalone
- Reuse of already built tests (from glibc-tests.inc) and depoloy them on the HW target.
- Provide single 'run-ptest' script.
- Update the recipe to run with newest poky's -master--- meta/conf/distro/include/maintainers.inc | 1 + .../distro/include/ptest-packagelists.inc | 1 + meta/recipes-core/glibc/glibc-tests_2.34.bb | 113 ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest | 37 ++++++ 4 files changed, 152 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb create mode 100755 meta/recipes-core/glibc/glibc/run-ptestmeta/conf/distro/include/maintainers.inc +1
-0@@ -209,6 +209,7 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-glibc-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glide = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>"meta/conf/distro/include/ptest-packagelists.inc +0
-0
meta/conf/distro/include/ptest-packagelists.inc PTESTS_FAST = "\ · line 64
Quoted 4 lines
meta/conf/distro/include/ptest-packagelists.inc +1
-0@@ -61,6 +61,7 @@ PTESTS_FAST = "\ slang-ptest \ wayland-ptest \ zlib-ptest \ + glibc-tests-ptest \
this will break musl. So lets change this to
PTESTS_FAST:append:libc-glibc = " glibc-tests-ptest"
Quoted 23 lines
meta/conf/distro/include/ptest-packagelists.inc +0
-0" PTESTS_FAST:remove:mips64 = "qemu-ptest" PTESTS_PROBLEMS:append:mips64 = "qemu-ptest"meta/recipes-core/glibc/glibc-tests_2.34.bb new file +14
-0@@ -0,0 +1,113 @@ +require glibc_${PV}.bb +require glibc-tests.inc + +inherit ptest + +SRC_URI:append = " \ + file://run-ptest \ +" + +SUMMARY = "glibc tests to be run with ptest" + +# Erase some variables already set by glibc_${PV} +python __anonymous() { + # Remove packages provided by glibc build, we only need a subset of them
meta/recipes-core/glibc/glibc-tests_2.34.bb line 24
Quoted 10 lines
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +10
-0+ d.setVar("PACKAGES", "${PN} ${PN}-ptest") + + d.setVar("PROVIDES", "${PN} ${PN}-ptest") + d.setVar("RPROVIDES", "${PN} ${PN}-ptest") + + d.setVar("BBCLASSEXTEND", "") + d.setVar("RRECOMMENDS", "") +} + +# Remove any lefovers from original glibc recipe
^^^^^^
typo
Quoted 135 lines
meta/recipes-core/glibc/glibc-tests_2.34.bb new file +89
-0+RPROVIDES:${PN} = "${PN}" +RRECOMMENDS:${PN} = "" +RDEPENDS:${PN} = " glibc sed" +DEPENDS:append = " sed" + +# Just build tests for target - do not run them +do_check:append () { + oe_runmake -i check run-built-tests=no +} +addtask do_check after do_compile before do_install_ptest_base + +glibc_strip_build_directory () { + # Delete all non executable files from build directory + find ${B} ! -executable -type f -delete + + # Remove build dynamic libraries and links to them as + # those are already installed in the target device + find ${B} -type f -name "*.so" -delete + find ${B} -type l -name "*.so*" -delete + + # Remove headers (installed with glibc) + find ${B} -type f -name "*.h" -delete + + find ${B} -type f -name "isomac" -delete + find ${B} -type f -name "annexc" -delete +} + +do_install_ptest_base () { + glibc_strip_build_directory + + ls -r ${B}/*/*-time64 > ${B}/tst_time64 + + # Remove '-time64' suffix - those tests are also time related + sed -e "s/-time64$//" ${B}/tst_time64 > ${B}/tst_time_tmp + tst_time=$(cat ${B}/tst_time_tmp ${B}/tst_time64) + + rm ${B}/tst_time_tmp ${B}/tst_time64 + echo "${tst_time}" + + # Install build test programs to the image + install -d ${D}${PTEST_PATH}/tests/glibc-ptest/ + + for f in "${tst_time}" + do + cp -r ${f} ${D}${PTEST_PATH}/tests/glibc-ptest/ + done + + install -d ${D}${PTEST_PATH} + cp ${WORKDIR}/run-ptest ${D}${PTEST_PATH}/ + +} + +# The datadir directory is required to allow core (and reused) +# glibc cleanup function to finish correctly, as this directory +# is not created for ptests +stash_locale_package_cleanup:prepend () { + mkdir -p ${PKGD}${datadir} +} + +stash_locale_sysroot_cleanup:prepend () { + mkdir -p ${SYSROOT_DESTDIR}${datadir} +} + +# Prevent the do_package() task to set 'libc6' prefix +# for glibc tests related packages +python populate_packages:prepend () { + if d.getVar('DEBIAN_NAMES'): + d.setVar('DEBIAN_NAMES', '') +} + +FILES:${PN} = "${PTEST_PATH}/* /usr/src/debug/glibc-tests/*" + +EXCLUDE_FROM_SHLIBS = "1" + +# Install debug data in .debug and sources in /usr/src/debug +# It is more handy to have _all_ the sources and symbols in one +# place (package) as this recipe will be used for validation and +# debugging. +PACKAGE_DEBUG_SPLIT_STYLE = "debug" + +# glibc test cases violate by default some Yocto/OE checks (staticdev, +# textrel) +# 'debug-files' - add everything (including debug) into one package +# (no need to install/build *-src package) +INSANE_SKIP:${PN} += "staticdev textrel debug-files rpaths" + +deltask do_stash_locale +do_install[noexec] = "1" +do_populate_sysroot[noexec] = "1"meta/recipes-core/glibc/glibc/run-ptest new file +37
-1@@ -0,0 +1,37 @@ +#!/bin/sh +# ptest script for glibc - to run time related tests to +# facilitate Y2038 validation +# Run with 'ptest-runner glibc-tests' + +output() { + retcode=$? + if [ $retcode -eq 0 ] + then echo "PASS: $i" + elif [ $retcode -eq 77 ] + then echo "SKIP: $i" + else echo "FAIL: $i" + fi +} + +# Allow altering time on the target +export GLIBC_TEST_ALLOW_TIME_SETTING="1" + +tst_time64=$(ls -r ${PWD}/tests/glibc-ptest/*-time64) + +# Remove '-time64' suffix - those tests are also time +# related +tst_time_tmp=$(sed -e "s/-time64$//" <<< ${tst_time64}) + +# Run tests supporting only 32 bit time +for i in ${tst_time_tmp} +do + $i >/dev/null 2>&1 + output +done + +# Run tests supporting only 64 bit time +for i in ${tst_time64} +do + $i >/dev/null 2>&1 + output +done --2.20.1
Quoted 77 lines · Khem Raj
Quoted 69 lines · Lukasz Majewski
This patch introduces new recipe - namely 'glibc-tests', which builds and installs time related (to check if Y2038 support works) glibc test suite to OE/Yocto built image.
It reuses code from already available 'glibc-testsuite' recipe, which is run with 'bitbake glibc-testsuite -c check' and uses qemu to execute remotely (via SSH) tests on some emulated machine.
This recipe installs time related glibc tests on some rootfs image. Afterwards, those tests can be executed on the real hardware, to facilitate validation of it with Y2038 problem compliance.
To test time related subset - one needs to call:
ptest-runner glibc-tests
then change the date after Y2038 threshold for 32 bit systems:
date -s "20 JAN 2038 18:00:00"
and then run ptest-runner again.To facilitate debugging, source files are provided by default with the unstripped debugging symbols. Such approach would reduce the already complex recipe (as it inherits base glibc one), so there is no need to also install *-dbg and *-src packages.
Signed-off-by Lukasz Majewski <[email protected]>---
Changes for v4:
- Add entry for 'glibc-tests' in the maintainers.inc file
- Remove nativesdk from BBCLASSEXTEND as this resipe is not supposed to be the part of SDKChanges for v3:
- Provide missing ${PN}-ptest for PACKAGES, PROVIDES and RPROVIDES variablesChanges for v2:
- Just focus on time related set of tests as those can be run as standalone
- Reuse of already built tests (from glibc-tests.inc) and depoloy them on the HW target.
- Provide single 'run-ptest' script.
- Update the recipe to run with newest poky's -master--- meta/conf/distro/include/maintainers.inc | 1 + .../distro/include/ptest-packagelists.inc | 1 + meta/recipes-core/glibc/glibc-tests_2.34.bb | 113 ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest | 37 ++++++ 4 files changed, 152 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb create mode 100755 meta/recipes-core/glibc/glibc/run-ptestmeta/conf/distro/include/maintainers.inc +1
-0@@ -209,6 +209,7 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-glibc-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glide = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>"meta/conf/distro/include/ptest-packagelists.inc +0
-0meta/conf/distro/include/ptest-packagelists.inc PTESTS_FAST = "\ · line 64
Quoted 4 lines
meta/conf/distro/include/ptest-packagelists.inc +1
-0@@ -61,6 +61,7 @@ PTESTS_FAST = "\ slang-ptest \ wayland-ptest \ zlib-ptest \ + glibc-tests-ptest \this will break musl. So lets change this to
Quoted 1 line
PTESTS_FAST:append:libc-glibc = " glibc-tests-ptest"
FWIW I tested a tweak in master-next for that...
Cheers,
Richard
Hi Richard, Khem
Quoted 81 lines · Khem Raj
Quoted 80 lines
Quoted 67 lines · Lukasz Majewski
This patch introduces new recipe - namely 'glibc-tests', which builds and installs time related (to check if Y2038 support works) glibc test suite to OE/Yocto built image.
It reuses code from already available 'glibc-testsuite' recipe, which is run with 'bitbake glibc-testsuite -c check' and uses qemu to execute remotely (via SSH) tests on some emulated machine.
This recipe installs time related glibc tests on some rootfs image. Afterwards, those tests can be executed on the real hardware, to facilitate validation of it with Y2038 problem compliance.
To test time related subset - one needs to call:
ptest-runner glibc-tests
then change the date after Y2038 threshold for 32 bit systems:
date -s "20 JAN 2038 18:00:00"
and then run ptest-runner again.To facilitate debugging, source files are provided by default with the unstripped debugging symbols. Such approach would reduce the already complex recipe (as it inherits base glibc one), so there is no need to also install *-dbg and *-src packages.
Signed-off-by Lukasz Majewski <[email protected]>---
Changes for v4:
- Add entry for 'glibc-tests' in the maintainers.inc file
- Remove nativesdk from BBCLASSEXTEND as this resipe is not supposed to be the part of SDKChanges for v3:
- Provide missing ${PN}-ptest for PACKAGES, PROVIDES and RPROVIDES variablesChanges for v2:
- Just focus on time related set of tests as those can be run as standalone
- Reuse of already built tests (from glibc-tests.inc) and depoloy them on the HW target.
- Provide single 'run-ptest' script.
- Update the recipe to run with newest poky's -master--- meta/conf/distro/include/maintainers.inc | 1 + .../distro/include/ptest-packagelists.inc | 1 + meta/recipes-core/glibc/glibc-tests_2.34.bb | 113 ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest | 37 ++++++ 4 files changed, 152 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb create mode 100755 meta/recipes-core/glibc/glibc/run-ptest(quoted diff) +0
-0b/meta/conf/distro/include/maintainers.inc index
baec2bef4d..7104e091fc100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -209,6 +209,7 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-glibc-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glide = "Otavio Salvador <[email protected]>"Quoted 8 lines
RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>" diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc index
2e324f8da4..fd52fa72a4100644 --- a/meta/conf/distro/include/ptest-packagelists.inc +++ b/meta/conf/distro/include/ptest-packagelists.inc @@ -61,6 +61,7 @@PTESTS_FAST= "\ slang-ptest \ wayland-ptest \ zlib-ptest \
+ glibc-tests-ptest \this will break musl. So lets change this to
Quoted 4 lines
Quoted 1 line
PTESTS_FAST:append:libc-glibc = " glibc-tests-ptest"
FWIW I tested a tweak in master-next for that...
Shall I prepare v5 with fix for that, or will you keep patches from master-next (with your fix for this) ?
(I would prefer personally the latter option :-) ).
Quoted 4 lines
Cheers,
Richard
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]