gpio: xlp: Remove Netlogic XLP variants
PATCH 1/1 gpio: xlp: Remove Netlogic XLP variants
Netlogic XLP was removed in commit 95b8a5e0111a ("MIPS: Remove NETLOGIC support"). With those gone, the single platform left to support is Cavium ThunderX2. Remove all the Netlogic variants and DT support.
For simplicity, the existing kconfig name is retained.
--- drivers/gpio/Kconfig | 10 ++- drivers/gpio/gpio-xlp.c | 142 +++------------------------------------- 2 files changed, 13 insertions(+), 139 deletions(-)
drivers/gpio/Kconfig +4 -6
@@ -730,14 +730,12 @@ config GPIO_XILINX Say yes here to support the Xilinx FPGA GPIO device. config GPIO_XLP - tristate "Netlogic XLP GPIO support" - depends on OF_GPIO && (CPU_XLP || ARCH_THUNDER2 || COMPILE_TEST) + tristate "Cavium ThunderX2 GPIO support" + depends on ARCH_THUNDER2 || COMPILE_TEST select GPIOLIB_IRQCHIP help - This driver provides support for GPIO interface on Netlogic XLP MIPS64 - SoCs. Currently supported XLP variants are XLP8XX, XLP3XX, XLP2XX, - XLP9XX and XLP5XX. The same GPIO controller block is also present in - Cavium's ThunderX2 CN99XX SoCs. + This driver provides support for GPIO interface on Cavium's ThunderX2 + CN99XX SoCs (Originally from Netlogic XLP). If unsure, say N.
drivers/gpio/gpio-xlp.c +9 -133
208 lines not on this page · raw message
Signature · 1 line
2.32.0
Quoted 10 lines · Rob Herring
Netlogic XLP was removed in commit
95b8a5e0111a("MIPS: Remove NETLOGIC support"). With those gone, the single platform left to support is Cavium ThunderX2. Remove all the Netlogic variants and DT support.For simplicity, the existing kconfig name is retained.
Cc Linus Walleij <[email protected]>Cc Bartosz Golaszewski <[email protected]>Signed-off-by Rob Herring <[email protected]>
A question:
drivers/gpio/gpio-xlp.c static int xlp_gpio_probe(struct platform_device *pdev) · line 264
Quoted 3 lines
drivers/gpio/gpio-xlp.c +0
-0@@ -373,7 +263,7 @@ static int xlp_gpio_probe(struct platform_device *pdev) gc->label =dev_name (&pdev->dev); gc->base =0 ;
Can we also set this to -1 and use dynamic GPIO base allocation? (Can be a separate patch.)
Yours,
Linus Walleij
Quoted 19 lines · Linus Walleij
Quoted 10 lines · Rob Herring
Netlogic XLP was removed in commit
95b8a5e0111a("MIPS: Remove NETLOGIC support"). With those gone, the single platform left to support is Cavium ThunderX2. Remove all the Netlogic variants and DT support.For simplicity, the existing kconfig name is retained.
Cc Linus Walleij <[email protected]>Cc Bartosz Golaszewski <[email protected]>Signed-off-by Rob Herring <[email protected]>Reviewed-by Linus Walleij <[email protected]>A question:
Quoted 6 lines
drivers/gpio/gpio-xlp.c static int xlp_gpio_probe(struct platform_device *pdev) · line 264
Quoted 3 lines
drivers/gpio/gpio-xlp.c +0
-0@@ -373,7 +263,7 @@ static int xlp_gpio_probe(struct platform_device *pdev) gc->label =dev_name (&pdev->dev); gc->base =0 ;Can we also set this to -1 and use dynamic GPIO base allocation? (Can be a separate patch.)
No clue. What's normal for GPIO ACPI systems? Does that mean more than 1 instance is broken currently?
Rob
Quoted 10 lines · Rob Herring
Quoted 6 lines · Linus Walleij
drivers/gpio/gpio-xlp.c static int xlp_gpio_probe(struct platform_device *pdev) · line 264
Quoted 3 lines
drivers/gpio/gpio-xlp.c +0
-0@@ -373,7 +263,7 @@ static int xlp_gpio_probe(struct platform_device *pdev) gc->label =dev_name (&pdev->dev); gc->base =0 ;Can we also set this to -1 and use dynamic GPIO base allocation? (Can be a separate patch.)
No clue. What's normal for GPIO ACPI systems?
Dynamic allocation (-1) c.f.drivers/pinctrl/intel/pinctrl-intel.c
Quoted 2 lines
Does that mean more than
1 instance is broken currently?
Yes.
Yours,
Linus Walleij
Bartosz Golaszewski
AppliedQuoted 7 lines · Rob Herring
Netlogic XLP was removed in commit
95b8a5e0111a("MIPS: Remove NETLOGIC support"). With those gone, the single platform left to support is Cavium ThunderX2. Remove all the Netlogic variants and DT support.For simplicity, the existing kconfig name is retained.
Quoted 9 lines
Cc Linus Walleij <[email protected]>Cc Bartosz Golaszewski <[email protected]>Signed-off-by Rob Herring <[email protected]>--- drivers/gpio/Kconfig | 10 ++- drivers/gpio/gpio-xlp.c | 142 +++------------------------------------- 2 files changed, 13 insertions(+), 139 deletions(-)
Applied, thanks!
Bart