net/mlx5: Lag, fix a potential Oops with mlx5_lag_create_definer()
Subsystems (5)
PATCH 1/1 net/mlx5: Lag, fix a potential Oops with mlx5_lag_create_definer()
There is a minus character missing from ERR_PTR(ENOMEM) so if this allocation fails it will lead to an Oops in the caller.
Fixes dc48516ec7d3 ("net/mlx5: Lag, add support to create definers for LAG")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c +1 -1
@@ -289,7 +289,7 @@ mlx5_lag_create_definer(struct mlx5_lag *ldev, enum netdev_lag_hash hash, lag_definer =kzalloc (sizeof (*lag_definer),GFP_KERNEL );if (!lag_definer) -return ERR_PTR (ENOMEM ); +return ERR_PTR (-ENOMEM ); match_definer_mask = kvzalloc(MLX5_FLD_SZ_BYTES(match_definer, match_mask),
Signature · 1 line
2.20.1
Quoted 9 lines · Dan Carpenter
There is a minus character missing from
ERR_PTR(ENOMEM)so if this allocation fails it will lead to an Oops in the caller.Fixes dc48516ec7d3 ("net/mlx5: Lag, add support to create definers for LAG")Signed-off-by Dan Carpenter <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by Leon Romanovsky <[email protected]>
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Wed, 10 Nov 2021 11:07:06 +0300 you wrote:
There is a minus character missing from
ERR_PTR(ENOMEM)so if this allocation fails it will lead to an Oops in the caller.Fixes dc48516ec7d3 ("net/mlx5: Lag, add support to create definers for LAG")Signed-off-by Dan Carpenter <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net/mlx5: Lag, fix a potential Oops with mlx5_lag_create_definer()
https://git.kernel.org/netdev/net/c/c7ebe23cee35
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html