Skip to contentSkip to conversation

net/mlx5: fix add Tx scheduling check

PATCH In review Viacheslav Ovsiienko 2 participants 2 messages Nov 10, 2021 – Nov 14, 2021 Network drivers

lore
Share & tools
lore

Viacheslav Ovsiienko

author
#0 lore raw

PATCH 1/1 net/mlx5: fix add Tx scheduling check

There was the redundant check for the enabled E-Switch, this resulted in device probing failure if the Tx scheduling was requested and E-Switch was enabled.

Fixes f17e4b4ffef9 ("net/mlx5: add Tx scheduling check on queue creation")
Cc [email protected]
Signed-off-by Viacheslav Ovsiienko <[email protected]>
---
 drivers/net/mlx5/linux/mlx5_os.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/mlx5/linux/mlx5_os.c +1 -2
index de880ee4c9..c29fe3d92b 100644
@@ -1727,8 +1727,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
 		priv->obj_ops = ibv_obj_ops;
 	}
 	if (config->tx_pp &&
-	    (priv->config.dv_esw_en ||
-	     priv->obj_ops.txq_obj_new != mlx5_txq_devx_obj_new)) {
+	    priv->obj_ops.txq_obj_new != mlx5_txq_devx_obj_new) {
 		/*
 		 * HAVE_MLX5DV_DEVX_UAR_OFFSET is required to support
 		 * packet pacing and already checked above.
Signature · 1 line
2.18.1
#1 lore raw

Hi,

Quoted 12 lines

-----Original Message-----
From: Slava Ovsiienko <[email protected]>
Sent: Wednesday, November 10, 2021 3:06 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Matan Azrad <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix add Tx scheduling check

There was the redundant check for the enabled E-Switch, this resulted in device probing failure if the Tx scheduling was requested and E-Switch was enabled.

Quoted 5 lines
Fixes f17e4b4ffef9 ("net/mlx5: add Tx scheduling check on queue creation")
Cc [email protected]
Signed-off-by Viacheslav Ovsiienko <[email protected]>

---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh