drm/bridge/tc358775: Fix for dual-link LVDS
Subsystems (3)
PATCH 1/1 drm/bridge/tc358775: Fix for dual-link LVDS
Fixed wrong register shift for single/dual link LVDS output.
--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/tc358775.c +1 -1
@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
Signature · 1 line
2.30.2
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Quoted 24 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +1
-2@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
Robert,
I do not have the hardware to test this feature. Sorry for the late response.
Quoted 34 lines · Robert Foss
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Review
Quoted 9 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/bridge/tc358775.cdrivers/gpu/drm/bridge/tc358775.c static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t
Quoted 4 lines
index
2272adcc5b4a..1d6ec1baeff2100644drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_tval)
Quoted 11 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2}#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
Signature · 2 lines
regards, vinaysimha
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
Quoted 43 lines · Vinay Simha B N
Robert,
I do not have the hardware to test this feature. Sorry for the late response.Quoted 23 lines · Robert Foss
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Quoted 15 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
--
regards,
vinaysimha
Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss <[email protected]> napsal:
Quoted 54 lines
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
Quoted 3 lines · Vinay Simha B N
Robert,
I do not have the hardware to test this feature. Sorry for the lateresponse.
Quoted 2 lines
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <[email protected]>
Quoted 9 lines · wrote:
Quoted 9 lines
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Quoted 1 line · Jiri Vanek
Quoted 8 lines
Quoted 8 lines
Review
Quoted 8 lines
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/bridge/tc358775.cQuoted 4 lines
Quoted 4 lines
drivers/gpu/drm/bridge/tc358775.c static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t
Quoted 4 lines
index
2272adcc5b4a..1d6ec1baeff2100644drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_tval)
Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/bridge/tc358775.c static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t · line 243
Quoted 3 lines
drivers/gpu/drm/bridge/tc358775.c +0
-0}#define TC358775_LVCFG_LVDLINK__MASK
0x00000002Quoted 14 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2-#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
--
regards,
vinaysimha
Excellent.
Jiri, can you add your Tested-by tag to this patch?
Quoted 53 lines · Jiří Vaněk
Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss <[email protected]> napsal:
Quoted 49 lines
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
Quoted 43 lines · Vinay Simha B N
Robert,
I do not have the hardware to test this feature. Sorry for the late response.Quoted 23 lines · Robert Foss
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Quoted 15 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
--
regards,
vinaysimha
Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS display used.
Quoted 53 lines · Jiří Vaněk
Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss <[email protected]> napsal:
Quoted 49 lines
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
Quoted 43 lines · Vinay Simha B N
Robert,
I do not have the hardware to test this feature. Sorry for the late response.Quoted 23 lines · Robert Foss
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Quoted 15 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
--
regards,
vinaysimha
Signature · 2 lines
regards, vinaysimha
Robert,
What is R-b tag?
Quoted 49 lines · Robert Foss
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
Quoted 43 lines · Vinay Simha B N
Robert,
I do not have the hardware to test this feature. Sorry for the late response.Quoted 23 lines · Robert Foss
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
Quoted 15 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
--
regards,
vinaysimha
Signature · 2 lines
regards, vinaysimha
Quoted 3 lines · On Tue, Jan 4, 2022, 17:56 Vinay Simha B N <[email protected]> wrote:
Robert,
What is R-b tag?
It looks like this Reviewed-by: Name Lastname <email address>
Maybe have a quick look at this document.
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
Quoted 65 lines · Robert Foss
Quoted 6 lines
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <[email protected]>
Quoted 3 lines · wrote:
Quoted 3 lines
Robert,
I do not have the hardware to test this feature. Sorry for the lateresponse.
Quoted 2 lines
Quoted 2 lines
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <[email protected]>
Quoted 8 lines · wrote:
Quoted 8 lines
Quoted 8 lines
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <[email protected]>
Quoted 9 lines · wrote:
Quoted 9 lines
Quoted 9 lines
Review
Quoted 9 lines
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by Jiri Vanek <[email protected]>--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/bridge/tc358775.cQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/bridge/tc358775.c static inline u32
Quoted 4 lines
index
2272adcc5b4a..1d6ec1baeff2100644drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32
TC358775_LVCFG_PCLKDIV(uint32_t val)Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/bridge/tc358775.c static inline u32 · line 243
Quoted 3 lines
drivers/gpu/drm/bridge/tc358775.c +0
-0}#define TC358775_LVCFG_LVDLINK__MASK
0x00000002Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2-#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
2.30.2
--
regards,
vinaysimha--
regards,
vinaysimha
PATCH v2 1/1 drm/bridge/tc358775: Fix for dual-link LVDS
In reply to Jiri VanekFixed wrong register shift for single/dual link LVDS output.
---
v1:
* Initial version
v2:
* Tested-by tag added
--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/tc358775.c +1 -1
@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
Signature · 1 line
2.30.2
Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS display/panel used.
Quoted 34 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Tested-by Jiri Vanek <[email protected]>Signed-off-by Jiri Vanek <[email protected]>---
v1:
* Initial versionv2:
* Tested-by tag added--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +1
-2@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --2.30.2
Signature · 2 lines
regards, vinaysimha
Robert Foss
AppliedQuoted 32 lines · Vinay Simha B N
Reviewed-by Vinay Simha BN <[email protected]>Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS display/panel used.Quoted 24 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Tested-by Jiri Vanek <[email protected]>Signed-off-by Jiri Vanek <[email protected]>---
v1:
* Initial versionv2:
* Tested-by tag added--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +0
-0@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
Quoted 7 lines
drivers/gpu/drm/bridge/tc358775.c static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
Quoted 7 lines
drivers/gpu/drm/bridge/tc358775.c +1
-2#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --
Applied to drm-misc-next
AUO P215HVN01.0 / AUO G215HVN01.0
čt 6. 1. 2022 v 20:22 odesílatel Vinay Simha B N <[email protected]> napsal:
Quoted 48 lines
Reviewed-by Vinay Simha BN <[email protected]>Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS display/panel used.Quoted 31 lines · Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output.
Tested-by Jiri Vanek <[email protected]>Signed-off-by Jiri Vanek <[email protected]>---
v1:
* Initial versionv2:
* Tested-by tag added--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358775.c +1
-2@@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1static inline u32 TC358775_LVCFG_LVDLINK (uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --Quoted 3 lines
2.30.2
--
regards,
vinaysimha