speakup: remove redundant assignment of variable i
Subsystems (2)
PATCH 1/1 speakup: remove redundant assignment of variable i
From: Colin Ian King <[email protected]>
The variable i is being initialized a value that is never read, it is re-assigned later on in a for-loop. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/accessibility/speakup/speakup_acntpc.c | 2 +- drivers/accessibility/speakup/speakup_dtlk.c | 2 +- drivers/accessibility/speakup/speakup_keypc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/accessibility/speakup/speakup_acntpc.c +1 -1
@@ -247,7 +247,7 @@ static void synth_flush(struct spk_synth *synth)static int synth_probe (struct spk_synth *synth) {unsigned int port_val =0 ; -int i =0 ; +int i;pr_info ("Probing for %s.\n" , synth->long_name);if (port_forced) {
drivers/accessibility/speakup/speakup_dtlk.c +1 -1
@@ -316,7 +316,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)static int synth_probe (struct spk_synth *synth) {unsigned int port_val =0 ; -int i =0 ; +int i;struct synth_settings *sp;pr_info ("Probing for DoubleTalk.\n" );
drivers/accessibility/speakup/speakup_keypc.c +1 -1
@@ -254,7 +254,7 @@ static void synth_flush(struct spk_synth *synth)static int synth_probe (struct spk_synth *synth) {unsigned int port_val =0 ; -int i =0 ; +int i;pr_info ("Probing for %s.\n" , synth->long_name);if (port_forced) {
Signature · 1 line
2.32.0
Colin Ian King, le mer. 10 nov. 2021 22:53:01 +0000, a ecrit:
Quoted 7 lines
From: Colin Ian King <[email protected]>
The variable i is being initialized a value that is never read, it is re-assigned later on in a for-loop. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>
Reviewed-by Samuel Thibault <[email protected]>
Quoted 48 lines
--- drivers/accessibility/speakup/speakup_acntpc.c | 2 +- drivers/accessibility/speakup/speakup_dtlk.c | 2 +- drivers/accessibility/speakup/speakup_keypc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)drivers/accessibility/speakup/speakup_acntpc.c +1
-1@@ -247,7 +247,7 @@ static void synth_flush(struct spk_synth *synth)static int synth_probe (struct spk_synth *synth) {unsigned int port_val =0 ; -int i =0 ; +int i;pr_info ("Probing for %s.\n" , synth->long_name);if (port_forced) {drivers/accessibility/speakup/speakup_dtlk.c +1
-1@@ -316,7 +316,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)static int synth_probe (struct spk_synth *synth) {unsigned int port_val =0 ; -int i =0 ; +int i;struct synth_settings *sp;pr_info ("Probing for DoubleTalk.\n" );drivers/accessibility/speakup/speakup_keypc.c +1
-1@@ -254,7 +254,7 @@ static void synth_flush(struct spk_synth *synth)static int synth_probe (struct spk_synth *synth) {unsigned int port_val =0 ; -int i =0 ; +int i;pr_info ("Probing for %s.\n" , synth->long_name);if (port_forced) {Signature · 1 line
2.32.0