mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation.patch removed from -mm tree
The patch titled
Subject: mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation
has been removed from the -mm tree. Its filename was
mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Chen Wandun <[email protected]>
Subject: mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation
"mm/vmalloc: fix numa spreading for large hash tables" will cause significant performance regressions in some situations as Andrew mentioned in [1]. The main situation is vmalloc, vmalloc will allocate pages with NUMA_NO_NODE by default, that will result in alloc page one by one;
In order to solve this, __alloc_pages_bulk and mempolicy should be considered at the same time.
1) If node is specified in memory allocation request, it will alloc all pages by __alloc_pages_bulk.
2) If interleaving allocate memory, it will cauculate how many pages should be allocated in each node, and use __alloc_pages_bulk to alloc pages in each node.
---
include/linux/gfp.h | 4 ++ mm/mempolicy.c | 82 ++++++++++++++++++++++++++++++++++++++++++ mm/vmalloc.c | 20 ++++++++-- 3 files changed, 102 insertions(+), 4 deletions(-)
include/linux/gfp.h renamed from include/linux/gfp.h~mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation +4 -0
@@ -535,6 +535,10 @@ unsigned long __alloc_pages_bulk(gfp_t gstruct list_head *page_list, struct page **page_array); +unsigned long alloc_pages_bulk_array_mempolicy (gfp_t gfp, +unsigned long nr_pages, +struct page **page_array); +/* Bulk allocate order-0 pages */ static inline unsigned long alloc_pages_bulk_list (gfp_t gfp,unsigned long nr_pages,struct list_head *list)
mm/mempolicy.c renamed from mm/mempolicy.c~mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation +82 -0
88 lines not on this page · raw message
mm/vmalloc.c renamed from mm/vmalloc.c~mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation +16 -4
@@ -2843,7 +2843,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,* to fails, fallback to a single page allocator that is * more permissive. */ -if (!order && nid !=NUMA_NO_NODE ) { +if (!order) {while (nr_allocated < nr_pages) {unsigned int nr, nr_pages_request;
@@ -2855,8 +2855,20 @@ vm_area_alloc_pages(gfp_t gfp, int nid,*/ nr_pages_request =min (100U , nr_pages - nr_allocated); - nr =alloc_pages_bulk_array_node (gfp, nid, - nr_pages_request, pages + nr_allocated); +/* memory allocation should consider mempolicy, we can't +* wrongly use nearest node when nid == NUMA_NO_NODE, +* otherwise memory may be allocated in only one node, +* but mempolcy want to alloc memory by interleaving. +*/ +if (IS_ENABLED (CONFIG_NUMA ) && nid ==NUMA_NO_NODE ) + nr =alloc_pages_bulk_array_mempolicy (gfp, + nr_pages_request, + pages + nr_allocated); + +else + nr =alloc_pages_bulk_array_node (gfp, nid, + nr_pages_request, + pages + nr_allocated); nr_allocated += nr;cond_resched ();
@@ -2868,7 +2880,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,if (nr != nr_pages_request)break ; } - }else if (order) + }else /* * Compound pages required for remap_vmalloc_page if * high-order pages.
_
Patches currently in -mm which might be from [email protected] are