Skip to contentSkip to conversation

init-make-unknown-command-line-param-message-clearer.patch removed from -mm tree

merged [email protected] 1 participant 1 message Nov 11, 2021

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: init: make unknown command line param message clearer
has been removed from the -mm tree. Its filename was
init-make-unknown-command-line-param-message-clearer.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Andrew Halaney <[email protected]>
Subject: init: make unknown command line param message clearer

The prior message is confusing users, which is the exact opposite of the goal. If the message is being seen, one of the following situations is happening:

1. the param is misspelled
2. the param is not valid due to the kernel configuration
3. the param is intended for init but isn't after the '--' delineator on the command line

To make that more clear to the user, explicitly mention "kernel command line" and also note that the params are still passed to user space to avoid causing any alarm over params intended for init.

---

 init/main.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
init/main.c renamed from init/main.c~init-make-unknown-command-line-param-message-clearer +3 -1
@@ -924,7 +924,9 @@ static void __init print_unknown_bootopt
 	for (p = &envp_init[2]; *p; p++)
 		end += sprintf(end, " %s", *p);
 
-	pr_notice("Unknown command line parameters:%s\n", unknown_options);
+	/* Start at unknown_options[1] to skip the initial space */
+	pr_notice("Unknown kernel command line parameters \"%s\", will be passed to user space.\n",
+		&unknown_options[1]);
 	memblock_free(unknown_options, len);
 }
 

_

Patches currently in -mm which might be from [email protected] are

init-mainc-silence-some-wunused-parameter-warnings.patch