Skip to contentSkip to conversation

arm64: export this_cpu_has_cap

PATCH In review Jackie Liu 3 participants 3 messages Nov 11, 2021 arm64

lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH 1/1 arm64: export this_cpu_has_cap

From: Jackie Liu <[email protected]>

After commit 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling"), driver coresight use this_cpu_has_cap for check feature, but if we compile it as a module, it will cause a compilation error.

[...]
ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1765: modules] Error 2
make: *** Waiting for unfinished jobs....
[...]

Fixes 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
Reported-by kernelbot <[email protected]>
Signed-off-by Jackie Liu <[email protected]>
---
 arch/arm64/kernel/cpufeature.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/kernel/cpufeature.c +1 -0
index ecbdff795f5e..646662407a07 100644
@@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
 
 	return false;
 }
+EXPORT_SYMBOL_GPL(this_cpu_has_cap);
 
 /*
  * This helper function is used in a narrow window when,
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw
Quoted 14 lines · Jackie Liu

From: Jackie Liu <[email protected]>

After commit 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling"), driver coresight use this_cpu_has_cap for check feature, but if we compile it as a module, it will cause a compilation error.

[...]
ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1765: modules] Error 2
make: *** Waiting for unfinished jobs....
[...]

Quoted 3 lines
Fixes 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
Reported-by kernelbot <[email protected]>
Signed-off-by Jackie Liu <[email protected]>

There is a patch already, not sure whether it has made it into mainline:

https://lore.kernel.org/r/[email protected]

Signature · 6 lines
Catalin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw
Quoted 15 lines · Catalin Marinas
Quoted 14 lines · Jackie Liu

From: Jackie Liu <[email protected]>

After commit 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling"), driver coresight use this_cpu_has_cap for check feature, but if we compile it as a module, it will cause a compilation error.

[...]
ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1765: modules] Error 2
make: *** Waiting for unfinished jobs....
[...]

Quoted 7 lines
Quoted 3 lines
Fixes 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
Reported-by kernelbot <[email protected]>
Signed-off-by Jackie Liu <[email protected]>

There is a patch already, not sure whether it has made it into mainline:

https://lore.kernel.org/r/[email protected]

This is queued in Greg's char-misc tree (char-misc-linus branch) and should be sent out at rc1.

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/log/?h=char-misc-linus

Suzuki

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel