Skip to contentSkip to conversation

failsafe: Bug fix for the secondary process RX-TX support

PATCH Applied Kumara Parameshwaran 2 participants 2 messages Nov 11, 2021 – Nov 17, 2021 Network drivers

lore
Share & tools
lore

Kumara Parameshwaran

author
#0 lore raw

PATCH 1/1 failsafe: Bug fix for the secondary process RX-TX support

Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe.

Fixes 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process")
Cc [email protected]
Signed-off-by Kumara Parameshwaran <[email protected]>
---
 drivers/net/failsafe/failsafe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/failsafe/failsafe.c +1 -2
index ad6b43538e..3c754a5f66 100644
@@ -340,8 +340,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
 	INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s",
 			name);
 
-	if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
-	    strlen(rte_vdev_device_args(vdev)) == 0) {
+	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (!eth_dev) {
 			ERROR("Failed to probe %s", name);
Signature · 1 line
2.30.1 (Apple Git-130)
Reviewed-by on v1 1/1 Applied
#1 lore raw
Quoted 9 lines · Kumara Parameshwaran

Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe.

Fixes 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process")
Cc [email protected]
Signed-off-by Kumara Parameshwaran <[email protected]>

Renamed patch title as:
net/failsafe: fix secondary process probe

Reviewed-by Ferruh Yigit <[email protected]>

Applied to dpdk-next-net/main, thanks.