Skip to contentSkip to conversation

cpufreq: intel_pstate: Add Ice Lake server to out-of-band IDs

PATCH Applied Adamos Ttofari 2 participants 2 messages Nov 12, 2021 – Nov 17, 2021

Subsystems (2)
CPU frequency scaling framework Intel pstate driver
lore
Share & tools
lore

Adamos Ttofari

author
#0 lore raw

PATCH 1/1 cpufreq: intel_pstate: Add Ice Lake server to out-of-band IDs

Commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode") enabled the use of Intel P-State driver for Ice Lake servers. But it doesn't cover the case when OS can't control P-States.

Therefore, for Ice Lake server, if MSR_MISC_PWR_MGMT bits 8 or 18 are enabled, then the Intel P-State driver should exit as OS can't control P-States.

Fixes fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode")
Signed-off-by Adamos Ttofari <[email protected]>
Cc Hendrik Borghorst <[email protected]>
Cc David Woodhouse <[email protected]>
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +1 -0
index 815df3daae9d..1088ff350159 100644
@@ -2353,6 +2353,7 @@ static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst = {
 	X86_MATCH(BROADWELL_D,		core_funcs),
 	X86_MATCH(BROADWELL_X,		core_funcs),
 	X86_MATCH(SKYLAKE_X,		core_funcs),
+	X86_MATCH(ICELAKE_X,		core_funcs),
 	{}
 };
Signature · 12 lines
2.32.0




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
maintainer Applied
#1 lore raw
Quoted 23 lines · Adamos Ttofari

Commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode") enabled the use of Intel P-State driver for Ice Lake servers. But it doesn't cover the case when OS can't control P-States.

Therefore, for Ice Lake server, if MSR_MISC_PWR_MGMT bits 8 or 18 are enabled, then the Intel P-State driver should exit as OS can't control P-States.

Fixes fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode")
Signed-off-by Adamos Ttofari <[email protected]>
Cc Hendrik Borghorst <[email protected]>
Cc David Woodhouse <[email protected]>
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +0 -0
index 815df3daae9d..1088ff350159 100644

drivers/cpufreq/intel_pstate.c static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst = {

Quoted 8 lines
drivers/cpufreq/intel_pstate.c +1 -1
@@ -2353,6 +2353,7 @@ static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst = {
        X86_MATCH(BROADWELL_D,          core_funcs),
        X86_MATCH(BROADWELL_X,          core_funcs),
        X86_MATCH(SKYLAKE_X,            core_funcs),
+       X86_MATCH(ICELAKE_X,            core_funcs),
        {}
 };
 
--

Applied as 5.16-rc material, thanks!