blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
Subsystems (2)
PATCH 1/1 blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
Commit cd006509b0a9 ("blk-iocost: account for IO size when testing latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in config BLK_CGROUP_IOCOST.
Hence, ./scripts/checkkconfigsymbols.py warns:
BLK_RQ_IO_DATA_LEN
Referencing files: block/Kconfig
Probably, this select is just some unintended left-over from an earlier draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the repository. So, drop this dead select to an undefined config.
--- block/Kconfig | 1 - 1 file changed, 1 deletion(-)
block/Kconfig +0 -1
@@ -133,7 +133,6 @@ config BLK_CGROUP_FC_APPID config BLK_CGROUP_IOCOST bool "Enable support for cost model based cgroup IO controller" depends on BLK_CGROUP - select BLK_RQ_IO_DATA_LEN select BLK_RQ_ALLOC_TIME help Enabling this option enables the .weight interface for cost
Signature · 1 line
2.26.2
Quoted 9 lines · Lukas Bulwahn
Commit
cd006509b0a9("blk-iocost: account for IO size when testing latencies") selects the non-existing configBLK_RQ_IO_DATA_LENin configBLK_CGROUP_IOCOST.Hence,
./scripts/checkkconfigsymbols.pywarns:
BLK_RQ_IO_DATA_LEN
Referencing files: block/Kconfig
Quoted 6 lines
Probably, this select is just some unintended left-over from an earlier draft version;
BLK_RQ_IO_DATA_LENwas never defined in any commit in the repository. So, drop this dead select to an undefined config.Fixes cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")Signed-off-by Lukas Bulwahn <[email protected]>
Thanks.
Signature · 1 line
tejun