Skip to contentSkip to conversation

Support Sharp LQ101R1SX03 display panel

PATCH Superseded Dmitry Osipenko 2 participants 6 messages Nov 14, 2021 – Nov 30, 2021

Subsystems (5)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover Support Sharp LQ101R1SX03 display panel

Add support for Sharp LQ101R1SX03 display panel used by ASUS Transformer TF701T tablet device.

Anton Bambura (2):
dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03 drm/panel: sharp: lq101r1sx01: Support LQ101R1SX03

 .../devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml  | 4 +++-
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c               | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.33.1
#1 lore raw

PATCH 1/2 dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

From: Anton Bambura <[email protected]>

LQ101R1SX03 is compatible with LQ101R1SX01, document it.

---
 .../devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml +3 -1
index a679d3647dbd..f7514eb9ebda 100644
@@ -30,7 +30,9 @@ allOf:
 
 properties:
   compatible:
-    const: sharp,lq101r1sx01
+    enum:
+      - sharp,lq101r1sx01
+      - sharp,lq101r1sx03
 
   reg: true
   power-supply: true
Signature · 1 line
2.33.1
maintainer
#2 lore raw

Re: [PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

Quoted 3 lines · Dmitry Osipenko

From: Anton Bambura <[email protected]>

LQ101R1SX03 is compatible with LQ101R1SX01, document it.

Then sounds like '"sharp,lq101r1sx03", "sharp,lq101r1sx01"' would be the appropriate compatible value. Do that, and you don't need a driver change.

Quoted 25 lines
---
 .../devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml +3 -1
index a679d3647dbd..f7514eb9ebda 100644
@@ -30,7 +30,9 @@ allOf:
 
 properties:
   compatible:
-    const: sharp,lq101r1sx01
+    enum:
+      - sharp,lq101r1sx01
+      - sharp,lq101r1sx03
 
   reg: true
   power-supply: true
Signature · 1 line
2.33.1
#3 lore raw

Re: [PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

30.11.2021 00:32, Rob Herring пишет:

Quoted 8 lines · Dmitry Osipenko
Quoted 3 lines

From: Anton Bambura <[email protected]>

LQ101R1SX03 is compatible with LQ101R1SX01, document it.

Then sounds like '"sharp,lq101r1sx03", "sharp,lq101r1sx01"' would be the appropriate compatible value. Do that, and you don't need a driver change.

Apparently you're right. The "sharp,lq101r1sx03" should be a slightly improved revision of "sharp,lq101r1sx01". I see now that LQ101R1SX03 is sold as a spare part panel for ASUS TF701T, hence these panels should be entirely compatible with each other.

#4 lore raw

Re: [PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

30.11.2021 18:54, Dmitry Osipenko пишет:

Quoted 6 lines

30.11.2021 00:32, Rob Herring пишет:

Quoted 5 lines · Dmitry Osipenko
Quoted 3 lines

From: Anton Bambura <[email protected]>

LQ101R1SX03 is compatible with LQ101R1SX01, document it.

Quoted 9 lines
Quoted 3 lines

Then sounds like '"sharp,lq101r1sx03", "sharp,lq101r1sx01"' would be the appropriate compatible value. Do that, and you don't need a driver change.

Apparently you're right. The "sharp,lq101r1sx03" should be a slightly improved revision of "sharp,lq101r1sx01". I see now that LQ101R1SX03 is sold as a spare part panel for ASUS TF701T, hence these panels should be entirely compatible with each other.

I mixed up the panel model which TF701T uses.

I compared datasheets of both panel variants. These panel have differences in the pins configuration. Hence panels seems aren't compatible in terms of hardware integration, although the difference is small. They should be compatible from software perspective.

#5 lore raw

PATCH 2/2 drm/panel: sharp: lq101r1sx01: Support LQ101R1SX03

In reply to Dmitry Osipenko

From: Anton Bambura <[email protected]>

LQ101R1SX03 is compatible with LQ101R1SX01, add compatible to the driver.

---
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c +1 -0
index f8cd2a42ed13..bbd1d889e069 100644
@@ -304,6 +304,7 @@ static const struct drm_panel_funcs sharp_panel_funcs = {
 
 static const struct of_device_id sharp_of_match[] = {
 	{ .compatible = "sharp,lq101r1sx01", },
+	{ .compatible = "sharp,lq101r1sx03", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sharp_of_match);
Signature · 1 line
2.33.1