Skip to contentSkip to conversation

iio: adxrs290: fix data signedness

PATCH Applied Nuno Sá 3 participants 3 messages Nov 15, 2021 – Nov 20, 2021

Subsystems (3)
IIO Analog Devices IIO drivers Analog devices inc ADXRS290 driver
lore
Share & tools
lore

Nuno Sá

author maintainer
#0 lore raw

PATCH v3 1/1 iio: adxrs290: fix data signedness

From: Kister Genesis Jimenez <[email protected]>

Properly sign-extend the rate and temperature data.

Fixes 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")
Signed-off-by Kister Genesis Jimenez <[email protected]>
Signed-off-by Nuno Sá <[email protected]>

---
changes in v2:
* removed redundant temp & 0xFFF.

changes in v3:
* full name in Signed-off-by tag.

 drivers/iio/gyro/adxrs290.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/gyro/adxrs290.c +3 -2
index 3e0734ddafe3..600e9725da78 100644
@@ -7,6 +7,7 @@
  */
 
 #include <linux/bitfield.h>
+#include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/kernel.h>

@@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct iio_dev *indio_dev, const u8 cmd, int *
 		goto err_unlock;
 	}
 
-	*val = temp;
+	*val = sign_extend32(temp, 15);
 
 err_unlock:
 	mutex_unlock(&st->lock);

@@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct iio_dev *indio_dev, int *val)
 	}
 
 	/* extract lower 12 bits temperature reading */
-	*val = temp & 0x0FFF;
+	*val = sign_extend32(temp, 11);
 
 err_unlock:
 	mutex_unlock(&st->lock);
Signature · 1 line
2.33.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 4 lines · Nuno Sá

From: Kister Genesis Jimenez <[email protected]>

Properly sign-extend the rate and temperature data.

Reviewed-by Andy Shevchenko <[email protected]>
Quoted 46 lines
Fixes 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")
Signed-off-by Kister Genesis Jimenez <[email protected]>
Signed-off-by Nuno Sá <[email protected]>

---
changes in v2:
* removed redundant temp & 0xFFF.

changes in v3:
* full name in Signed-off-by tag.

 drivers/iio/gyro/adxrs290.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/gyro/adxrs290.c +3 -3
index 3e0734ddafe3..600e9725da78 100644
@@ -7,6 +7,7 @@
  */
 
 #include <linux/bitfield.h>
+#include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/kernel.h>

@@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct iio_dev *indio_dev, const u8 cmd, int *
                goto err_unlock;
        }
 
-       *val = temp;
+       *val = sign_extend32(temp, 15);
 
 err_unlock:
        mutex_unlock(&st->lock);

@@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct iio_dev *indio_dev, int *val)
        }
 
        /* extract lower 12 bits temperature reading */
-       *val = temp & 0x0FFF;
+       *val = sign_extend32(temp, 11);
 
 err_unlock:
        mutex_unlock(&st->lock);
--

2.33.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
Quoted 7 lines · On Mon, 15 Nov 2021 12:57:46 +0200 Andy Shevchenko <[email protected]>…
Quoted 4 lines · Nuno Sá

From: Kister Genesis Jimenez <[email protected]>

Properly sign-extend the rate and temperature data.

Reviewed-by Andy Shevchenko <[email protected]>

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

Quoted 49 lines
Quoted 47 lines
Fixes 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")
Signed-off-by Kister Genesis Jimenez <[email protected]>
Signed-off-by Nuno Sá <[email protected]>

---
changes in v2:
* removed redundant temp & 0xFFF.

changes in v3:
* full name in Signed-off-by tag.

 drivers/iio/gyro/adxrs290.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/gyro/adxrs290.c +3 -3
index 3e0734ddafe3..600e9725da78 100644
@@ -7,6 +7,7 @@
  */
 
 #include <linux/bitfield.h>
+#include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/kernel.h>

@@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct iio_dev *indio_dev, const u8 cmd, int *
                goto err_unlock;
        }
 
-       *val = temp;
+       *val = sign_extend32(temp, 15);
 
 err_unlock:
        mutex_unlock(&st->lock);

@@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct iio_dev *indio_dev, int *val)
        }
 
        /* extract lower 12 bits temperature reading */
-       *val = temp & 0x0FFF;
+       *val = sign_extend32(temp, 11);
 
 err_unlock:
        mutex_unlock(&st->lock);
--

2.33.1