Skip to contentSkip to conversation

gdb-common: Add --with-liblzma-prefix in xz PACKAGECONFIG.

PATCH In review Jim Wilson 2 participants 5 messages Nov 16, 2021 – Nov 23, 2021

lore
Share & tools
lore

Jim Wilson

author
#0 lore raw

PATCH 1/1 gdb-common: Add --with-liblzma-prefix in xz PACKAGECONFIG.

This fixes an arch linux gdb configure error with liblzma installed.

Without the --with-liblzma-prefix option, when configuring the target gdb, gdb configure may find the native liblzma (on a non-multiarch system) and try to use it, which gives a configure error. We already use --with-libexpat-prefix for expat, we just need to do the same for liblzma.

This was reported here:
https://github.com/sifive/meta-sifive/issues/34
https://github.com/sifive/freedom-u-sdk/issues/148

---
 meta/recipes-devtools/gdb/gdb-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-common.inc +1 -1
index f3ab3544da..925b0c2f80 100644
@@ -37,7 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
 PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
 # ncurses is already a hard DEPENDS, but would be added here if it weren't
 PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
-PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
+PACKAGECONFIG[xz] = "--with-lzma --with-liblzma-prefix=${STAGING_DIR_HOST},--without-lzma,xz"
 PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils"
 
 GDBPROPREFIX = "--program-prefix=''"
Signature · 1 line
2.25.1
#1 lore raw
Quoted 22 lines · Jim Wilson

This fixes an arch linux gdb configure error with liblzma installed.

Without the --with-liblzma-prefix option, when configuring the target gdb, gdb configure may find the native liblzma (on a non-multiarch system) and try to use it, which gives a configure error. We already use --with-libexpat-prefix for expat, we just need to do the same for liblzma.

This was reported here:
https://github.com/sifive/meta-sifive/issues/34
https://github.com/sifive/freedom-u-sdk/issues/148

---
  meta/recipes-devtools/gdb/gdb-common.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-common.inc +0 -0
index f3ab3544da..925b0c2f80 100644

meta/recipes-devtools/gdb/gdb-common.inc PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python · line 40

Quoted 5 lines
meta/recipes-devtools/gdb/gdb-common.inc +1 -1
@@ -37,7 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
  PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
  # ncurses is already a hard DEPENDS, but would be added here if it weren't
  PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
-PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
+PACKAGECONFIG[xz] = "--with-lzma --with-liblzma-prefix=${STAGING_DIR_HOST},--without-lzma,xz"

this looks ok to me. Although I wonder why gdb's configure is not able to find it in staging sysroot automatically, I have seen similar behavior in gmp and mpfr in past as well.

Quoted 14 lines
meta/recipes-devtools/gdb/gdb-common.inc +0 -1
  PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils"
 
  GDBPROPREFIX = "--program-prefix=''"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#158320): https://lists.openembedded.org/g/openembedded-core/message/158320
Mute This Topic: https://lists.openembedded.org/mt/87085648/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 7 lines · Khem Raj
Quoted 1 line · Jim Wilson

This fixes an arch linux gdb configure error with liblzma installed.

this looks ok to me. Although I wonder why gdb's configure is not able to find it in staging sysroot automatically, I have seen similar behavior in gmp and mpfr in past as well.

I have no familiarity with the OE cross native build system. I didn't spend much time looking at that. There might be something wrong with gdb configure, or there might be something wrong with options or environment variables passed to gdb configure. But since we already passed the --with-expat-prefix option to configure, doing the same for liblzma was the easiest way to get this working.

Jim

#3 lore raw
Quoted 4 lines · Jim Wilson
Quoted 2 lines · Khem Raj

On 11/15/21 17:44, Jim Wilson wrote:

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

This fixes an arch linux gdb configure error with liblzma installed.

this looks ok to me. Although I wonder why gdb's configure is not able to find it in staging sysroot automatically, I have seen similar behavior in gmp and mpfr in past as well.

I have no familiarity with the OE cross native build system. I didn't spend much time looking at that. There might be something wrong with gdb configure, or there might be something wrong with options or environment variables passed to gdb configure. But since we already passed the --with-expat-prefix option to configure, doing the same for liblzma was the easiest way to get this working.

yes, this patch is fine in itself.

Quoted 2 lines

Jim

author
#4 lore raw
Quoted 2 lines · Khem Raj

yes, this patch is fine in itself.

Thanks. I see that the patch got applied last week.

Jim