Skip to contentSkip to conversation

parisc: Include stringify.h to avoid build error in crypto/api.c

PATCH New Helge Deller 1 participant 4 messages Nov 16, 2021

Subsystems (3)
lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH 1/4 parisc: Include stringify.h to avoid build error in crypto/api.c

Include <linux/stringify.h> to avoid this build error:
arch/parisc/include/asm/jump_label.h: error: expected ':' before '__stringify' arch/parisc/include/asm/jump_label.h: error: label 'l_yes' defined but not used [-Werror=unused-label]

---
 arch/parisc/include/asm/jump_label.h | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/include/asm/jump_label.h +1 -0
index 7efb1aa2f7f8..af2a598bc0f8 100644
@@ -5,6 +5,7 @@
 #ifndef __ASSEMBLY__
 
 #include <linux/types.h>
+#include <linux/stringify.h>
 #include <asm/assembly.h>
 
 #define JUMP_LABEL_NOP_SIZE 4

--
2.31.1

author maintainer
#1 lore raw

PATCH 2/4 parisc: Increase FRAME_WARN to 4096 on parisc

PA-RISC uses a much bigger frame size for functions than other architectures. So increase it to 4096 to silence lots of warnings.

---
 lib/Kconfig.debug | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
lib/Kconfig.debug +3 -2
index 9ef7ce18b4f5..4fd34095c369 100644
@@ -346,8 +346,9 @@ config FRAME_WARN
 	int "Warn for stack frames larger than"
 	range 0 8192
 	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
-	default 1536 if (!64BIT && (PARISC || XTENSA))
-	default 1024 if (!64BIT && !PARISC)
+	default 4096 if PARISC
+	default 1536 if (!64BIT && XTENSA)
+	default 1024 if !64BIT
 	default 2048 if 64BIT
 	help
 	  Tell gcc to warn at build time for stack frames larger than this.

--
2.31.1

author maintainer
#2 lore raw

PATCH 3/4 parisc: Wire up futex_waitv

In reply to Helge Deller
---
 arch/parisc/kernel/syscalls/syscall.tbl | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/kernel/syscalls/syscall.tbl +1 -0
index bf751e0732b7..358c00000755 100644
@@ -446,3 +446,4 @@
 446	common	landlock_restrict_self		sys_landlock_restrict_self
 # 447 reserved for memfd_secret
 448	common	process_mrelease		sys_process_mrelease
+449	common	futex_waitv			sys_futex_waitv

--
2.31.1

author maintainer
#3 lore raw

PATCH 4/4 parisc: Move assembler related defines below the __ASSEMBLY__ umbrella

In reply to Helge Deller

Building allmodconfig generates some errors in the gpu/drm/msm (MSM/snapdragon) drivers, because there a conflicting COND() define is used as well. Although those drivers aren't relevant for parisc, they are nevertheless compiled when CONFIG_COMPILE_TEST is defined.

The parisc COND() define is only used for assembly statements. So we can simply move it including the other mnemonics inside the #ifdef __ASSEMBLY__ part to avoid this conflict.

---
 arch/parisc/include/asm/assembly.h | 44 ++++++++++++++++--------------
 1 file changed, 24 insertions(+), 20 deletions(-)
arch/parisc/include/asm/assembly.h +24 -20
index 7085df079702..39e7985086f9 100644
@@ -3,38 +3,19 @@
  * Copyright (C) 1999 Hewlett-Packard (Frank Rowand)
  * Copyright (C) 1999 Philipp Rumpf <[email protected]>
  * Copyright (C) 1999 SuSE GmbH
+ * Copyright (C) 2021 Helge Deller <[email protected]>
  */
 
 #ifndef _PARISC_ASSEMBLY_H
 #define _PARISC_ASSEMBLY_H
 
-#define CALLEE_FLOAT_FRAME_SIZE	80
-
 #ifdef CONFIG_64BIT
-#define LDREG	ldd
-#define STREG	std
-#define LDREGX  ldd,s
-#define LDREGM	ldd,mb
-#define STREGM	std,ma
-#define SHRREG	shrd
-#define SHLREG	shld
-#define ANDCM   andcm,*
-#define	COND(x)	* ## x
 #define RP_OFFSET	16
 #define FRAME_SIZE	128
 #define CALLEE_REG_FRAME_SIZE	144
 #define REG_SZ		8
 #define ASM_ULONG_INSN	.dword
 #else	/* CONFIG_64BIT */
-#define LDREG	ldw
-#define STREG	stw
-#define LDREGX  ldwx,s
-#define LDREGM	ldwm
-#define STREGM	stwm
-#define SHRREG	shr
-#define SHLREG	shlw
-#define ANDCM   andcm
-#define COND(x)	x
 #define RP_OFFSET	20
 #define FRAME_SIZE	64
 #define CALLEE_REG_FRAME_SIZE	128
@@ -45,6 +26,7 @@
 /* Frame alignment for 32- and 64-bit */
 #define FRAME_ALIGN     64
 
+#define CALLEE_FLOAT_FRAME_SIZE	80
 #define CALLEE_SAVE_FRAME_SIZE (CALLEE_REG_FRAME_SIZE + CALLEE_FLOAT_FRAME_SIZE)
 
 #ifdef CONFIG_PA20
@@ -67,6 +49,28 @@
 
 #ifdef __ASSEMBLY__
 
+#ifdef CONFIG_64BIT
+#define LDREG	ldd
+#define STREG	std
+#define LDREGX  ldd,s
+#define LDREGM	ldd,mb
+#define STREGM	std,ma
+#define SHRREG	shrd
+#define SHLREG	shld
+#define ANDCM   andcm,*
+#define	COND(x)	* ## x
+#else	/* CONFIG_64BIT */
+#define LDREG	ldw
+#define STREG	stw
+#define LDREGX  ldwx,s
+#define LDREGM	ldwm
+#define STREGM	stwm
+#define SHRREG	shr
+#define SHLREG	shlw
+#define ANDCM   andcm
+#define COND(x)	x
+#endif
+
 #ifdef CONFIG_64BIT
 /* the 64-bit pa gnu assembler unfortunately defaults to .level 1.1 or 2.0 so
  * work around that for now... */

--
2.31.1