Skip to contentSkip to conversation

target/i386/kvm: Replace use of __u32 type

PATCH-for-7.0 Applied Philippe Mathieu-Daudé 3 participants 4 messages Nov 16, 2021 – Dec 17, 2021 KVM

lore
Share & tools
lore
#0 lore raw

QEMU coding style mandates to not use Linux kernel internal types for scalars types. Replace __u32 by uint32_t.

---
 target/i386/kvm/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/i386/kvm/kvm.c +1 -1
index 5a698bde19a..13f8e30c2a5 100644
@@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
     c->edx = cpu->hyperv_limits[2];
 
     if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
-        __u32 function;
+        uint32_t function;
 
         /* Create zeroed 0x40000006..0x40000009 leaves */
         for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;
Signature · 1 line
2.31.1
#2 lore raw
In reply to Philippe Mathieu-Daudé

Hi Laurent,

This patch is reviewed, can it go via your trivial tree?

Quoted 22 lines · Philippe Mathieu-Daudé

QEMU coding style mandates to not use Linux kernel internal types for scalars types. Replace __u32 by uint32_t.

---
 target/i386/kvm/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/i386/kvm/kvm.c +1 -1
index 5a698bde19a..13f8e30c2a5 100644
@@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
     c->edx = cpu->hyperv_limits[2];
 
     if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
-        __u32 function;
+        uint32_t function;
 
         /* Create zeroed 0x40000006..0x40000009 leaves */
         for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;
#3 lore raw
In reply to Philippe Mathieu-Daudé

Le 16/11/2021 à 20:39, Philippe Mathieu-Daudé a écrit :

Quoted 14 lines

QEMU coding style mandates to not use Linux kernel internal types for scalars types. Replace __u32 by uint32_t.

---
  target/i386/kvm/kvm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
target/i386/kvm/kvm.c +0 -0
index 5a698bde19a..13f8e30c2a5 100644

target/i386/kvm/kvm.c static int hyperv_fill_cpuids(CPUState *cs, · line 1412

Quoted 8 lines
target/i386/kvm/kvm.c +1 -1
@@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
      c->edx = cpu->hyperv_limits[2];
 
      if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
-        __u32 function;
+        uint32_t function;
 
          /* Create zeroed 0x40000006..0x40000009 leaves */
          for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;

Applied to my trivial-patches branch.

Thanks,
Laurent