Skip to contentSkip to conversation

x86/kvm: remove unused ack_notifier callbacks

PATCH In review Juergen Gross 2 participants 2 messages Nov 17, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/kvm: remove unused ack_notifier callbacks

Commit f52447261bc8c2 ("KVM: irq ack notification") introduced an ack_notifier() callback in struct kvm_pic and in struct kvm_ioapic without using them anywhere. Remove those callbacks again.

---
 arch/x86/kvm/ioapic.h | 1 -
 arch/x86/kvm/irq.h    | 1 -
 2 files changed, 2 deletions(-)
arch/x86/kvm/ioapic.h +0 -1
index 623a3c5afad7..5666c39d8df1 100644
@@ -81,7 +81,6 @@ struct kvm_ioapic {
 	unsigned long irq_states[IOAPIC_NUM_PINS];
 	struct kvm_io_device dev;
 	struct kvm *kvm;
-	void (*ack_notifier)(void *opaque, int irq);
 	spinlock_t lock;
 	struct rtc_status rtc_status;
 	struct delayed_work eoi_inject;
arch/x86/kvm/irq.h +0 -1
index 650642b18d15..c2d7cfe82d00 100644
@@ -56,7 +56,6 @@ struct kvm_pic {
 	struct kvm_io_device dev_master;
 	struct kvm_io_device dev_slave;
 	struct kvm_io_device dev_elcr;
-	void (*ack_notifier)(void *opaque, int irq);
 	unsigned long irq_states[PIC_NUM_PINS];
 };
 
Signature · 1 line
2.26.2
maintainer
#1 lore raw
Quoted 28 lines · Juergen Gross

Commit f52447261bc8c2 ("KVM: irq ack notification") introduced an ack_notifier() callback in struct kvm_pic and in struct kvm_ioapic without using them anywhere. Remove those callbacks again.

---
  arch/x86/kvm/ioapic.h | 1 -
  arch/x86/kvm/irq.h    | 1 -
  2 files changed, 2 deletions(-)
arch/x86/kvm/ioapic.h +0 -1
index 623a3c5afad7..5666c39d8df1 100644
@@ -81,7 +81,6 @@ struct kvm_ioapic {
  	unsigned long irq_states[IOAPIC_NUM_PINS];
  	struct kvm_io_device dev;
  	struct kvm *kvm;
-	void (*ack_notifier)(void *opaque, int irq);
  	spinlock_t lock;
  	struct rtc_status rtc_status;
  	struct delayed_work eoi_inject;
arch/x86/kvm/irq.h +0 -0
index 650642b18d15..c2d7cfe82d00 100644

arch/x86/kvm/irq.h struct kvm_pic { · line 61

Quoted 7 lines
arch/x86/kvm/irq.h +0 -1
@@ -56,7 +56,6 @@ struct kvm_pic {
  	struct kvm_io_device dev_master;
  	struct kvm_io_device dev_slave;
  	struct kvm_io_device dev_elcr;
-	void (*ack_notifier)(void *opaque, int irq);
  	unsigned long irq_states[PIC_NUM_PINS];
  };
 

Nice. Queued, thanks.

Paolo