Skip to contentSkip to conversation

common/mlx5: fix user mode register access attribute

PATCH In review [email protected] 2 participants 2 messages Nov 17, 2021

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 common/mlx5: fix user mode register access attribute

From: Michael Baum <[email protected]>

To detect the timestamp mode configured on the NIC the mlx5 PMD uses the firmware command ACCESS_REGISTER_USER.
The HCA capability command has an attribute flag checking whether firmware supports the command.

However, the HCA capability query command read the flag from wrong place in PRM structure.

This patch move the plag to correct place.

Fixes 972a1bf8120d ("common/mlx5: fix user mode register access command")
Cc [email protected]
Signed-off-by Michael Baum <[email protected]>
Acked-by Viacheslav Ovsiienko <[email protected]>
---
 drivers/common/mlx5/mlx5_prm.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/common/mlx5/mlx5_prm.h +4 -3
index 13959575e3..2ded67e85e 100644
@@ -1370,13 +1370,14 @@ struct mlx5_ifc_cmd_hca_cap_bits {
 	u8 reserved_at_bc[0x4];
 	u8 reserved_at_c0[0x8];
 	u8 log_max_cq_sz[0x8];
-	u8 reserved_at_d0[0xb];
+	u8 reserved_at_d0[0x2];
+	u8 access_register_user[0x1];
+	u8 reserved_at_d3[0x8];
 	u8 log_max_cq[0x5];
 	u8 log_max_eq_sz[0x8];
 	u8 relaxed_ordering_write[0x1];
 	u8 relaxed_ordering_read[0x1];
-	u8 access_register_user[0x1];
-	u8 log_max_mkey[0x5];
+	u8 log_max_mkey[0x6];
 	u8 reserved_at_f0[0x8];
 	u8 dump_fill_mkey[0x1];
 	u8 reserved_at_f9[0x3];
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 20 lines

-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Wednesday, November 17, 2021 12:57 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Michael Baum <[email protected]>; [email protected]
Subject: [PATCH] common/mlx5: fix user mode register access attribute

From: Michael Baum <[email protected]>

To detect the timestamp mode configured on the NIC the mlx5 PMD uses the
firmware command ACCESS_REGISTER_USER.
The HCA capability command has an attribute flag checking whether firmware supports the command.

However, the HCA capability query command read the flag from wrong place in PRM structure.

Quoted 8 lines

This patch move the plag to correct place.

Fixes 972a1bf8120d ("common/mlx5: fix user mode register access

command")
Cc: [email protected]

Signed-off-by Michael Baum <[email protected]>
Acked-by Viacheslav Ovsiienko <[email protected]>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh