Skip to contentSkip to conversation

fs/ioctl: Remove unnecessary __user annotation

PATCH Applied Amit Daniel Kachhap 1 participant 1 message Nov 22, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fs/ioctl: Remove unnecessary __user annotation

__user annotations are used by the checker (e.g sparse) to mark user pointers. However here __user is applied to a struct directly, without a pointer being directly involved.

Although the presence of __user does not cause sparse to emit a warning, __user should be removed for consistency with other uses of offsetof().

Note: No functional changes intended.

---
Re-posting v2 with minor commit log changes for v5.16-rc1.

 fs/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ioctl.c +1 -1
index 504e69578112..1ed097e94af2 100644
@@ -430,7 +430,7 @@ static int ioctl_file_dedupe_range(struct file *file,
 		goto out;
 	}
 
-	size = offsetof(struct file_dedupe_range __user, info[count]);
+	size = offsetof(struct file_dedupe_range, info[count]);
 	if (size > PAGE_SIZE) {
 		ret = -ENOMEM;
 		goto out;
Signature · 1 line
2.17.1