perf dlfilter: Drop unused variable
PATCH 1/1 perf dlfilter: Drop unused variable
Compiling tools/perf/dlfilters/dlfilter-test-api-v0.c result in:
checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |
So remove the variable now.
--- tools/perf/dlfilters/dlfilter-test-api-v0.c | 2 -- 1 file changed, 2 deletions(-)
tools/perf/dlfilters/dlfilter-test-api-v0.c +0 -2
@@ -308,8 +308,6 @@ int filter_event_early(void *data, const struct perf_dlfilter_sample *sample, voint filter_event (void *data,const struct perf_dlfilter_sample *sample,void *ctx) { -struct filter_data *d = data; -pr_debug ("%s API\n" , __func__);return do_checks (data, sample, ctx, false);
Signature · 1 line
2.34.0
Quoted 6 lines · Salvatore Bonaccorso
Compiling
tools/perf/dlfilters/dlfilter-test-api-v0.cresult in:checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |
Did you get this warning when issuing "make"? From my side, it generated this gcc command so I didn't get it (make DEBUG=1):
gcc -c -Iinclude -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
Thanks,
German
Quoted 21 lines
So remove the variable now.
Signed-off-by Salvatore Bonaccorso <[email protected]>--- tools/perf/dlfilters/dlfilter-test-api-v0.c | 2 -- 1 file changed, 2 deletions(-)tools/perf/dlfilters/dlfilter-test-api-v0.c +0
-2@@ -308,8 +308,6 @@ int filter_event_early(void *data, const struct perf_dlfilter_sample *sample, voint filter_event (void *data,const struct perf_dlfilter_sample *sample,void *ctx) { -struct filter_data *d = data; -pr_debug ("%s API\n" , __func__);return do_checks (data, sample, ctx, false);
Hi German,
Quoted 9 lines · German Gomez
Quoted 6 lines · Salvatore Bonaccorso
Compiling
tools/perf/dlfilters/dlfilter-test-api-v0.cresult in:checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |
Quoted 6 lines
Did you get this warning when issuing "make"? From my side, it generated this gcc command so I didn't get it (make DEBUG=1):
gcc -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cReviewed-by German Gomez <[email protected]>
Only when passing -Wall (this is the case when building the kernel packages in Debian with additional flags, so this is why this was spotted):
gcc -Wall -c -Iinclude -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
311 | struct filter_data *d = data;
|Regards,
Salvatore
Arnaldo Carvalho de Melo
maintainerEm Wed, Dec 08, 2021 at 12:11:59PM +0100, Salvatore Bonaccorso escreveu:
Quoted 19 lines
Hi German,
Quoted 9 lines · German Gomez
Quoted 6 lines · Salvatore Bonaccorso
Compiling
tools/perf/dlfilters/dlfilter-test-api-v0.cresult in:checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |Quoted 6 lines
Did you get this warning when issuing "make"? From my side, it generated this gcc command so I didn't get it (make DEBUG=1):
gcc -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cReviewed-by German Gomez <[email protected]>
Quoted 9 lines
Only when passing -Wall (this is the case when building the kernel packages in Debian with additional flags, so this is why this was spotted):
gcc -Wall -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cdlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]311 | struct filter_data *d = data; |
So I'm applying this, its an obvious cleanup, but please CC the author next time, I'm doing it in this reply, Adrian, ok?
- Arnaldo
Adrian Hunter
reviewerQuoted 30 lines · Arnaldo Carvalho de Melo
Em Wed, Dec 08, 2021 at 12:11:59PM +0100, Salvatore Bonaccorso escreveu:
Quoted 19 lines
Hi German,
Quoted 9 lines · German Gomez
Quoted 6 lines · Salvatore Bonaccorso
Compiling
tools/perf/dlfilters/dlfilter-test-api-v0.cresult in:checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |Quoted 6 lines
Did you get this warning when issuing "make"? From my side, it generated this gcc command so I didn't get it (make DEBUG=1):
gcc -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cReviewed-by German Gomez <[email protected]>Quoted 9 lines
Only when passing -Wall (this is the case when building the kernel packages in Debian with additional flags, so this is why this was spotted):
gcc -Wall -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cdlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]311 | struct filter_data *d = data; |
Quoted 2 lines
So I'm applying this, its an obvious cleanup, but please CC the author next time, I'm doing it in this reply, Adrian, ok?
Yes, thank you!
Hi,
Quoted 30 lines · Arnaldo Carvalho de Melo
Em Wed, Dec 08, 2021 at 12:11:59PM +0100, Salvatore Bonaccorso escreveu:
Quoted 19 lines
Hi German,
Quoted 9 lines · German Gomez
Quoted 6 lines · Salvatore Bonaccorso
Compiling
tools/perf/dlfilters/dlfilter-test-api-v0.cresult in:checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |Quoted 6 lines
Did you get this warning when issuing "make"? From my side, it generated this gcc command so I didn't get it (make DEBUG=1):
gcc -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cReviewed-by German Gomez <[email protected]>Quoted 9 lines
Only when passing -Wall (this is the case when building the kernel packages in Debian with additional flags, so this is why this was spotted):
gcc -Wall -c -Iinclude -o
dlfilters/dlfilter-test-api-v0.o-fpicdlfilters/dlfilter-test-api-v0.cdlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]311 | struct filter_data *d = data; |
Quoted 2 lines
So I'm applying this, its an obvious cleanup, but please CC the author next time, I'm doing it in this reply, Adrian, ok?
Yes right, I apologies for that, something went wrong when I generated the list of people to contact using
./scripts/get_maintainer.pl ./tools/perf/dlfilters/dlfilter-test-api-v0.c
and write up the persons to contact.
Thank you!
Regards,
Salvatore