mailbox: imx: Fix an IS_ERR() vs NULL bug
Subsystems (3)
PATCH 1/1 mailbox: imx: Fix an IS_ERR() vs NULL bug
The devm_kzalloc() function does not return error pointers, it returns NULL on failure.
Fixes 97961f78e8bc ("mailbox: imx: support i.MX8ULP S4 MU")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/mailbox/imx-mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mailbox/imx-mailbox.c +2 -2
@@ -563,8 +563,8 @@ static int imx_mu_probe(struct platform_device *pdev) size =sizeof (struct imx_sc_rpc_msg_max ); priv->msg =devm_kzalloc (dev, size,GFP_KERNEL ); -if (IS_ERR (priv->msg)) -return PTR_ERR (priv->msg); +if (!priv->msg) +return -ENOMEM ; priv->clk =devm_clk_get (dev,NULL );if (IS_ERR (priv->clk)) {
Signature · 1 line
2.20.1
Quoted 7 lines
Subject: [PATCH] mailbox: imx: Fix an
IS_ERR()vs NULL bugThe
devm_kzalloc()function does not return error pointers, it returns NULL on failure.Fixes 97961f78e8bc ("mailbox: imx: support i.MX8ULP S4 MU")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Peng Fan <[email protected]>
Quoted 19 lines
--- drivers/mailbox/imx-mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mailbox/imx-mailbox.c +2
-2@@ -563,8 +563,8 @@ static int imx_mu_probe(struct platform_device *pdev) size =sizeof (struct imx_sc_rpc_msg_max ); priv->msg =devm_kzalloc (dev, size,GFP_KERNEL ); -if (IS_ERR (priv->msg)) -return PTR_ERR (priv->msg); +if (!priv->msg) +return -ENOMEM ; priv->clk =devm_clk_get (dev,NULL );
Quoted 3 lines
if (
IS_ERR(priv->clk)) {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel