hw/nvme: zoned random write area
cover hw/nvme: zoned random write area
From: Klaus Jensen <[email protected]>
This series adds support for a zoned random write area as standardized in TP 4076 ("Zoned Random Write Area").
Klaus Jensen (4):
hw/nvme: add struct for zone management send hw/nvme: add zone attribute get/set helpers hw/nvme: add ozcs enum
hw/nvme: add support for zoned random write area
hw/nvme/ctrl.c | 185 ++++++++++++++++++++++++++++++++++++------- hw/nvme/ns.c | 61 +++++++++++++- hw/nvme/nvme.h | 10 +++ hw/nvme/trace-events | 1 + include/block/nvme.h | 43 +++++++++- 5 files changed, 271 insertions(+), 29 deletions(-)
Signature · 1 line
2.34.0
PATCH 1/4 hw/nvme: add struct for zone management send
From: Klaus Jensen <[email protected]>
Add struct for Zone Management Send in preparation for more zone send flags.
--- hw/nvme/ctrl.c | 10 ++++------ include/block/nvme.h | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 6 deletions(-)
hw/nvme/ctrl.c +4 -6
@@ -3593,26 +3593,24 @@ done:static uint16_t nvme_zone_mgmt_send (NvmeCtrl *n,NvmeRequest *req) { -NvmeCmd *cmd = (NvmeCmd *)&req->cmd; +NvmeZoneSendCmd *cmd = (NvmeZoneSendCmd *)&req->cmd;NvmeNamespace *ns = req->ns;NvmeZone *zone;NvmeZoneResetAIOCB *iocb;uint8_t *zd_ext; -uint32_t dw13 =le32_to_cpu (cmd->cdw13);uint64_t slba =0 ;uint32_t zone_idx =0 ;uint16_t status; -uint8_t action; +uint8_t action = cmd->zsa;bool all;enum NvmeZoneProcessingMask proc_mask =NVME_PROC_CURRENT_ZONE ; - action = dw13 &0xff ; - all = !!(dw13 &0x100 ); + all = cmd->zsflags[0 ] &NVME_ZSFLAG_SELECT_ALL ; req->status =NVME_SUCCESS ;if (!all) { - status =nvme_get_mgmt_zone_slba_idx (ns, cmd, &slba, &zone_idx); + status =nvme_get_mgmt_zone_slba_idx (ns, &req->cmd, &slba, &zone_idx);if (status) {return status; }
include/block/nvme.h +18 -0
@@ -1433,6 +1433,20 @@ enum NvmeZoneType { NVME_ZONE_TYPE_SEQ_WRITE = 0x02, }; +typedef struct QEMU_PACKED NvmeZoneSendCmd { +uint8_t opcode; +uint8_t flags; +uint16_t cid; +uint32_t nsid; +uint32_t rsvd2[4 ]; +NvmeCmdDptr dptr; +uint64_t slba; +uint32_t rsvd12; +uint8_t zsa; +uint8_t zsflags[3 ]; +uint32_t rsvd14[2 ]; +} NvmeZoneSendCmd; +enum NvmeZoneSendAction {NVME_ZONE_ACTION_RSD =0x00 ,NVME_ZONE_ACTION_CLOSE =0x01 ,
@@ -1443,6 +1457,10 @@ enum NvmeZoneSendAction { NVME_ZONE_ACTION_SET_ZD_EXT = 0x10, }; +enum { +NVME_ZSFLAG_SELECT_ALL =1 <<0 , +}; + typedef struct QEMU_PACKED NvmeZoneDescr {uint8_t zt;uint8_t zs;
Signature · 1 line
2.34.0
PATCH 4/4 hw/nvme: add support for zoned random write area
In reply to Klaus JensenFrom: Klaus Jensen <[email protected]>
Add support for TP 4076 ("Zoned Random Write Area"), v2021.08.23 ("Ratified").
This adds three new namespace parameters: "zoned.numzrwa" (number of zrwa resources, i.e. number of zones that can have a zrwa), "zoned.zrwas" (zrwa size in LBAs), "zoned.zrwafg" (granularity in LBAs for flushes).
--- hw/nvme/ctrl.c | 171 ++++++++++++++++++++++++++++++++++++++----- hw/nvme/ns.c | 58 +++++++++++++++ hw/nvme/nvme.h | 10 +++ hw/nvme/trace-events | 1 + include/block/nvme.h | 17 ++++- 5 files changed, 237 insertions(+), 20 deletions(-)
hw/nvme/ctrl.c +152 -19
@@ -299,26 +299,37 @@ static void nvme_assign_zone_state(NvmeNamespace *ns, NvmeZone *zone, } } -/* -* Check if we can open a zone without exceeding open/active limits. -* AOR stands for "Active and Open Resources" (see TP 4053 section 2.5). -*/ -static int nvme_aor_check (NvmeNamespace *ns,uint32_t act,uint32_t opn) +static uint16_t nvme_zns_check_resources (NvmeNamespace *ns,uint32_t act, +uint32_t opn,uint32_t zrwa) {if (ns->params.max_active_zones !=0 && ns->nr_active_zones + act > ns->params.max_active_zones) {trace_pci_nvme_err_insuff_active_res (ns->params.max_active_zones);return NVME_ZONE_TOO_MANY_ACTIVE |NVME_DNR ; } +if (ns->params.max_open_zones !=0 && ns->nr_open_zones + opn > ns->params.max_open_zones) {trace_pci_nvme_err_insuff_open_res (ns->params.max_open_zones);return NVME_ZONE_TOO_MANY_OPEN |NVME_DNR ; } +if (zrwa > ns->zns.numzrwa) { +return NVME_NOZRWA |NVME_DNR ; + } +return NVME_SUCCESS ; } +/* +* Check if we can open a zone without exceeding open/active limits. +* AOR stands for "Active and Open Resources" (see TP 4053 section 2.5). +*/ +static uint16_t nvme_aor_check (NvmeNamespace *ns,uint32_t act,uint32_t opn) +{ +return nvme_zns_check_resources (ns, act, opn,0 ); +} +static bool nvme_addr_is_cmb (NvmeCtrl *n,hwaddr addr) {hwaddr hi, lo;
@@ -1605,9 +1616,19 @@ static uint16_t nvme_check_zone_write(NvmeNamespace *ns, NvmeZone *zone,return status; } -if (unlikely (slba != zone->w_ptr)) { -trace_pci_nvme_err_write_not_at_wp (slba, zone->d.zslba, zone->w_ptr); -return NVME_ZONE_INVALID_WRITE ; +if (zone->d.za &NVME_ZA_ZRWA_VALID ) { +uint64_t ezrwa = zone->w_ptr +2 * ns->zns.zrwas; + +if (slba < zone->w_ptr || slba + nlb > ezrwa) { +trace_pci_nvme_err_zone_invalid_write (slba, zone->w_ptr); +return NVME_ZONE_INVALID_WRITE ; + } + }else { +if (unlikely (slba != zone->w_ptr)) { +trace_pci_nvme_err_write_not_at_wp (slba, zone->d.zslba, + zone->w_ptr); +return NVME_ZONE_INVALID_WRITE ; + } }if (unlikely ((slba + nlb) > zcap)) {
@@ -1687,6 +1708,14 @@ static uint16_t nvme_zrm_finish(NvmeNamespace *ns, NvmeZone *zone)/* fallthrough */ case NVME_ZONE_STATE_CLOSED :nvme_aor_dec_active (ns); + +if (zone->d.za &NVME_ZA_ZRWA_VALID ) { +NVME_ZA_CLEAR (zone->d.za,NVME_ZA_ZRWA_VALID ); +if (ns->params.numzrwa) { + ns->zns.numzrwa++; + } + } +/* fallthrough */ case NVME_ZONE_STATE_EMPTY :nvme_assign_zone_state (ns, zone,NVME_ZONE_STATE_FULL );
@@ -1722,6 +1751,13 @@ static uint16_t nvme_zrm_reset(NvmeNamespace *ns, NvmeZone *zone)/* fallthrough */ case NVME_ZONE_STATE_CLOSED :nvme_aor_dec_active (ns); + +if (zone->d.za &NVME_ZA_ZRWA_VALID ) { +if (ns->params.numzrwa) { + ns->zns.numzrwa++; + } + } +/* fallthrough */ case NVME_ZONE_STATE_FULL : zone->w_ptr = zone->d.zslba;
@@ -1755,6 +1791,7 @@ static void nvme_zrm_auto_transition_zone(NvmeNamespace *ns)enum {NVME_ZRM_AUTO =1 <<0 , +NVME_ZRM_ZRWA =1 <<1 , }; static uint16_t nvme_zrm_open_flags(NvmeCtrl *n, NvmeNamespace *ns,
@@ -1773,7 +1810,8 @@ static uint16_t nvme_zrm_open_flags(NvmeCtrl *n, NvmeNamespace *ns,if (n->params.auto_transition_zones) {nvme_zrm_auto_transition_zone (ns); } - status =nvme_aor_check (ns, act,1 ); + status =nvme_zns_check_resources (ns, act,1 , + (flags &NVME_ZRM_ZRWA ) ?1 :0 );if (status) {return status; }
@@ -1801,6 +1839,12 @@ static uint16_t nvme_zrm_open_flags(NvmeCtrl *n, NvmeNamespace *ns,/* fallthrough */ case NVME_ZONE_STATE_EXPLICITLY_OPEN : +if (flags &NVME_ZRM_ZRWA ) { + ns->zns.numzrwa--; + +NVME_ZA_SET (zone->d.za,NVME_ZA_ZRWA_VALID ); + } +return NVME_SUCCESS ;default :
@@ -1814,12 +1858,6 @@ static inline uint16_t nvme_zrm_auto(NvmeCtrl *n, NvmeNamespace *ns,return nvme_zrm_open_flags (n, ns, zone,NVME_ZRM_AUTO ); } -static inline uint16_t nvme_zrm_open (NvmeCtrl *n,NvmeNamespace *ns, -NvmeZone *zone) -{ -return nvme_zrm_open_flags (n, ns, zone,0 ); -} -static void nvme_advance_zone_wp (NvmeNamespace *ns,NvmeZone *zone,uint32_t nlb) {
@@ -1830,6 +1868,20 @@ static void nvme_advance_zone_wp(NvmeNamespace *ns, NvmeZone *zone, } } +static void nvme_zoned_zrwa_implicit_flush (NvmeNamespace *ns,NvmeZone *zone, +uint32_t nlbc) +{ +uint16_t nzrwafgs =DIV_ROUND_UP (nlbc, ns->zns.zrwafg); + + nlbc = nzrwafgs * ns->zns.zrwafg; + +trace_pci_nvme_zoned_zrwa_implicit_flush (zone->d.zslba, nlbc); + + zone->w_ptr += nlbc; + +nvme_advance_zone_wp (ns, zone, nlbc); +} +static void nvme_finalize_zoned_write (NvmeNamespace *ns,NvmeRequest *req) {NvmeRwCmd *rw = (NvmeRwCmd *)&req->cmd;
@@ -1842,6 +1894,17 @@ static void nvme_finalize_zoned_write(NvmeNamespace *ns, NvmeRequest *req) zone =nvme_get_zone_by_slba (ns, slba);assert (zone); +if (zone->d.za &NVME_ZA_ZRWA_VALID ) { +uint64_t ezrwa = zone->w_ptr + ns->zns.zrwas -1 ; +uint64_t elba = slba + nlb -1 ; + +if (elba > ezrwa) { +nvme_zoned_zrwa_implicit_flush (ns, zone, elba - ezrwa); + } + +return ; + } +nvme_advance_zone_wp (ns, zone, nlb); }
@@ -2642,7 +2705,9 @@ static void nvme_copy_in_completed_cb(void *opaque, int ret) goto invalid; } - iocb->zone->w_ptr += nlb; +if (!(iocb->zone->d.za &NVME_ZA_ZRWA_VALID )) { + iocb->zone->w_ptr += nlb; + } }qemu_iovec_reset (&iocb->iov);
@@ -3181,6 +3246,10 @@ static uint16_t nvme_do_write(NvmeCtrl *n, NvmeRequest *req, bool append,if (append) {bool piremap = !!(ctrl &NVME_RW_PIREMAP ); +if (unlikely (zone->d.za &NVME_ZA_ZRWA_VALID )) { +return NVME_INVALID_ZONE_OP |NVME_DNR ; + } +if (unlikely (slba != zone->d.zslba)) {trace_pci_nvme_err_append_not_at_start (slba, zone->d.zslba); status =NVME_INVALID_FIELD ;
@@ -3232,7 +3301,9 @@ static uint16_t nvme_do_write(NvmeCtrl *n, NvmeRequest *req, bool append, goto invalid; } - zone->w_ptr += nlb; +if (!(zone->d.za &NVME_ZA_ZRWA_VALID )) { + zone->w_ptr += nlb; + } } data_offset =nvme_l2b (ns, slba);
@@ -3316,7 +3387,24 @@ enum NvmeZoneProcessingMask {static uint16_t nvme_open_zone (NvmeNamespace *ns,NvmeZone *zone,NvmeZoneState state,NvmeRequest *req) { -return nvme_zrm_open (nvme_ctrl (req), ns, zone); +NvmeZoneSendCmd *cmd = (NvmeZoneSendCmd *)&req->cmd; +int flags =0 ; + +if (cmd->zsflags[0 ] &NVME_ZSFLAG_ZRWA_ALLOC ) { +uint16_t ozcs =le16_to_cpu (ns->id_ns_zoned->ozcs); + +if (!(ozcs &NVME_ID_NS_ZONED_OZCS_ZRWASUP )) { +return NVME_INVALID_ZONE_OP |NVME_DNR ; + } + +if (zone->w_ptr % ns->zns.zrwafg) { +return NVME_NOZRWA |NVME_DNR ; + } + + flags =NVME_ZRM_ZRWA ; + } + +return nvme_zrm_open_flags (nvme_ctrl (req), ns, zone, flags); } static uint16_t nvme_close_zone(NvmeNamespace *ns, NvmeZone *zone,
@@ -3591,6 +3679,44 @@ done: } } +static uint16_t nvme_zone_mgmt_send_zrwa_flush (NvmeCtrl *n,NvmeZone *zone, +uint64_t elba,NvmeRequest *req) +{ +NvmeNamespace *ns = req->ns; +uint16_t ozcs =le16_to_cpu (ns->id_ns_zoned->ozcs); +uint64_t wp = zone->d.wp; +uint32_t nlb = elba - wp +1 ; +uint16_t status; + + +if (!(ozcs &NVME_ID_NS_ZONED_OZCS_ZRWASUP )) { +return NVME_INVALID_ZONE_OP |NVME_DNR ; + } + +if (!(zone->d.za &NVME_ZA_ZRWA_VALID )) { +return NVME_INVALID_FIELD |NVME_DNR ; + } + +if (elba < wp || elba > wp + ns->zns.zrwas) { +return NVME_ZONE_BOUNDARY_ERROR |NVME_DNR ; + } + +if (nlb % ns->zns.zrwafg) { +return NVME_INVALID_FIELD |NVME_DNR ; + } + + status =nvme_zrm_auto (n, ns, zone); +if (status) { +return status; + } + + zone->w_ptr += nlb; + +nvme_advance_zone_wp (ns, zone, nlb); + +return NVME_SUCCESS ; +} +static uint16_t nvme_zone_mgmt_send (NvmeCtrl *n,NvmeRequest *req) {NvmeZoneSendCmd *cmd = (NvmeZoneSendCmd *)&req->cmd;
@@ -3617,7 +3743,7 @@ static uint16_t nvme_zone_mgmt_send(NvmeCtrl *n, NvmeRequest *req) } zone = &ns->zone_array[zone_idx]; -if (slba != zone->d.zslba) { +if (slba != zone->d.zslba && action !=NVME_ZONE_ACTION_ZRWA_FLUSH ) {trace_pci_nvme_err_unaligned_zone_cmd (action, slba, zone->d.zslba);return NVME_INVALID_FIELD |NVME_DNR ; }
@@ -3693,6 +3819,13 @@ static uint16_t nvme_zone_mgmt_send(NvmeCtrl *n, NvmeRequest *req) }break ; +case NVME_ZONE_ACTION_ZRWA_FLUSH : +if (all) { +return NVME_INVALID_FIELD |NVME_DNR ; + } + +return nvme_zone_mgmt_send_zrwa_flush (n, zone, slba, req); +default :trace_pci_nvme_err_invalid_mgmt_action (action); status =NVME_INVALID_FIELD ;
hw/nvme/ns.c +58 -0
82 lines not on this page · raw message
hw/nvme/nvme.h +10 -0
@@ -114,6 +114,10 @@ typedef struct NvmeNamespaceParams {uint32_t max_active_zones;uint32_t max_open_zones;uint32_t zd_extension_size; + +uint32_t numzrwa; +uint64_t zrwas; +uint64_t zrwafg; } NvmeNamespaceParams; typedef struct NvmeNamespace {
@@ -130,6 +134,12 @@ typedef struct NvmeNamespace {uint16_t status;int attached; +struct { +uint16_t zrwas; +uint16_t zrwafg; +uint32_t numzrwa; + } zns; +QTAILQ_ENTRY (NvmeNamespace) entry;NvmeIdNsZoned *id_ns_zoned;
hw/nvme/trace-events +1 -0
@@ -103,6 +103,7 @@ pci_nvme_set_descriptor_extension(uint64_t slba, uint32_t zone_idx) "set zone de pci_nvme_zd_extension_set(uint32_t zone_idx) "set descriptor extension for zone_idx=%"PRIu32"" pci_nvme_clear_ns_close(uint32_t state, uint64_t slba) "zone state=%"PRIu32", slba=%"PRIu64" transitioned to Closed state" pci_nvme_clear_ns_reset(uint32_t state, uint64_t slba) "zone state=%"PRIu32", slba=%"PRIu64" transitioned to Empty state" +pci_nvme_zoned_zrwa_implicit_flush(uint64_t zslba, uint32_t nlb) "zslba 0x%"PRIx64" nlb %"PRIu32"" # error conditions pci_nvme_err_mdts(size_t len) "len %zu"
include/block/nvme.h +16 -1
@@ -890,6 +890,8 @@ enum NvmeStatusCodes {NVME_INVALID_PROT_INFO =0x0181 ,NVME_WRITE_TO_RO =0x0182 ,NVME_CMD_SIZE_LIMIT =0x0183 , +NVME_INVALID_ZONE_OP =0x01b6 , +NVME_NOZRWA =0x01b7 ,NVME_ZONE_BOUNDARY_ERROR =0x01b8 ,NVME_ZONE_FULL =0x01b9 , NVME_ZONE_READ_ONLY = 0x01ba,
@@ -1345,7 +1347,12 @@ typedef struct QEMU_PACKED NvmeIdNsZoned {uint32_t mor;uint32_t rrl;uint32_t frl; -uint8_t rsvd20[2796 ]; +uint8_t rsvd12[24 ]; +uint32_t numzrwa; +uint16_t zrwafg; +uint16_t zrwas; +uint8_t zrwacap; +uint8_t rsvd53[2763 ];NvmeLBAFE lbafe[16 ];uint8_t rsvd3072[768 ];uint8_t vs[256 ];
@@ -1353,6 +1360,11 @@ typedef struct QEMU_PACKED NvmeIdNsZoned {enum NvmeIdNsZonedOzcs {NVME_ID_NS_ZONED_OZCS_RAZB =1 <<0 , +NVME_ID_NS_ZONED_OZCS_ZRWASUP =1 <<1 , +}; + +enum NvmeIdNsZonedZrwacap { +NVME_ID_NS_ZONED_ZRWACAP_EXPFLUSHSUP =1 <<0 , };/*Deallocate Logical Block Features*/
@@ -1408,6 +1420,7 @@ enum NvmeZoneAttr {NVME_ZA_FINISHED_BY_CTLR =1 <<0 ,NVME_ZA_FINISH_RECOMMENDED =1 <<1 ,NVME_ZA_RESET_RECOMMENDED =1 <<2 , +NVME_ZA_ZRWA_VALID =1 <<3 , NVME_ZA_ZD_EXT_VALID = 1 << 7, };
@@ -1463,10 +1476,12 @@ enum NvmeZoneSendAction {NVME_ZONE_ACTION_RESET =0x04 ,NVME_ZONE_ACTION_OFFLINE =0x05 ,NVME_ZONE_ACTION_SET_ZD_EXT =0x10 , + NVME_ZONE_ACTION_ZRWA_FLUSH = 0x11, };enum {NVME_ZSFLAG_SELECT_ALL =1 <<0 , +NVME_ZSFLAG_ZRWA_ALLOC =1 <<1 , }; typedef struct QEMU_PACKED NvmeZoneDescr {
Signature · 1 line
2.34.0
PATCH 3/4 hw/nvme: add ozcs enum
In reply to Klaus JensenFrom: Klaus Jensen <[email protected]>
Add enumeration for OZCS values.
--- hw/nvme/ns.c | 3 ++- include/block/nvme.h | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-)
hw/nvme/ns.c +2 -1
@@ -266,7 +266,8 @@ static void nvme_ns_init_zoned(NvmeNamespace *ns) id_ns_z->mar =cpu_to_le32 (ns->params.max_active_zones -1 ); id_ns_z->mor =cpu_to_le32 (ns->params.max_open_zones -1 ); id_ns_z->zoc =0 ; - id_ns_z->ozcs = ns->params.cross_zone_read ?0x01 :0x00 ; + id_ns_z->ozcs = ns->params.cross_zone_read ? +NVME_ID_NS_ZONED_OZCS_RAZB :0x00 ;for (i =0 ; i <= ns->id_ns.nlbaf; i++) { id_ns_z->lbafe[i].zsze =cpu_to_le64 (ns->zone_size);
include/block/nvme.h +4 -0
@@ -1351,6 +1351,10 @@ typedef struct QEMU_PACKED NvmeIdNsZoned {uint8_t vs[256 ]; } NvmeIdNsZoned; +enum NvmeIdNsZonedOzcs { +NVME_ID_NS_ZONED_OZCS_RAZB =1 <<0 , +}; +/*Deallocate Logical Block Features*/ #define NVME_ID_NS_DLFEAT_GUARD_CRC (dlfeat) ((dlfeat) & 0x10)#define NVME_ID_NS_DLFEAT_WRITE_ZEROES (dlfeat) ((dlfeat) & 0x08)
Signature · 1 line
2.34.0
PATCH 2/4 hw/nvme: add zone attribute get/set helpers
In reply to Klaus JensenFrom: Klaus Jensen <[email protected]>
Add some get/set helpers for zone attributes.
--- hw/nvme/ctrl.c | 4 ++-- include/block/nvme.h | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-)
hw/nvme/ctrl.c +2 -2
@@ -295,7 +295,7 @@ static void nvme_assign_zone_state(NvmeNamespace *ns, NvmeZone *zone,case NVME_ZONE_STATE_READ_ONLY :break ;default : - zone->d.za =0 ; +NVME_ZA_CLEAR_ALL (zone->d.za); } }
@@ -3356,7 +3356,7 @@ static uint16_t nvme_set_zd_ext(NvmeNamespace *ns, NvmeZone *zone)return status; }nvme_aor_inc_active (ns); - zone->d.za |=NVME_ZA_ZD_EXT_VALID ; +NVME_ZA_SET (zone->d.za,NVME_ZA_ZD_EXT_VALID );nvme_assign_zone_state (ns, zone,NVME_ZONE_STATE_CLOSED );return NVME_SUCCESS ; }
include/block/nvme.h +4 -0
@@ -1407,6 +1407,10 @@ enum NvmeZoneAttr { NVME_ZA_ZD_EXT_VALID = 1 << 7, }; +#define NVME_ZA_SET (za, attrs) ((za) |= (attrs)) +#define NVME_ZA_CLEAR (za, attrs) ((za) &= ~(attrs)) +#define NVME_ZA_CLEAR_ALL (za) ((za) = 0x0) + typedef struct QEMU_PACKED NvmeZoneReportHeader {uint64_t nr_zones;uint8_t rsvd[56 ];
Signature · 1 line
2.34.0
Quoted 11 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
This series adds support for a zoned random write area as standardized in TP 4076 ("Zoned Random Write Area").
Klaus Jensen (4):
hw/nvme: add struct for zone management send hw/nvme: add zone attribute get/set helpers hw/nvme: add ozcs enum
hw/nvme: add support for zoned random write area
Quoted 10 lines
hw/nvme/ctrl.c | 185 ++++++++++++++++++++++++++++++++++++------- hw/nvme/ns.c | 61 +++++++++++++- hw/nvme/nvme.h | 10 +++ hw/nvme/trace-events | 1 + include/block/nvme.h | 43 +++++++++- 5 files changed, 271 insertions(+), 29 deletions(-)Signature · 1 line
2.34.0
Bzzzzz ping :)
Quoted 19 lines · Klaus Jensen
Quoted 18 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
This series adds support for a zoned random write area as standardized in TP 4076 ("Zoned Random Write Area").
Klaus Jensen (4):
hw/nvme: add struct for zone management send hw/nvme: add zone attribute get/set helpers hw/nvme: add ozcs enum
hw/nvme: add support for zoned random write areahw/nvme/ctrl.c | 185 ++++++++++++++++++++++++++++++++++++------- hw/nvme/ns.c | 61 +++++++++++++- hw/nvme/nvme.h | 10 +++ hw/nvme/trace-events | 1 + include/block/nvme.h | 43 +++++++++- 5 files changed, 271 insertions(+), 29 deletions(-)
Quoted 5 lines
Quoted 3 lines
Signature · 1 line
2.34.0Bzzzzz ping :)
Hi Klaus,
Are you pinging Keith? It's not clear from the "To:" header and I want to check that I'm not holding up your patches.
Thanks,
Stefan
+CC Dmitry
Quoted 24 lines · Stefan Hajnoczi
Quoted 23 lines · Klaus Jensen
Quoted 21 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
This series adds support for a zoned random write area as standardized in TP 4076 ("Zoned Random Write Area").
Klaus Jensen (4):
hw/nvme: add struct for zone management send hw/nvme: add zone attribute get/set helpers hw/nvme: add ozcs enum
hw/nvme: add support for zoned random write areahw/nvme/ctrl.c | 185 ++++++++++++++++++++++++++++++++++++------- hw/nvme/ns.c | 61 +++++++++++++- hw/nvme/nvme.h | 10 +++ hw/nvme/trace-events | 1 + include/block/nvme.h | 43 +++++++++- 5 files changed, 271 insertions(+), 29 deletions(-)Signature · 1 line
2.34.0
Quoted 6 lines
Quoted 1 line
Bzzzzz ping :)
Hi Klaus,
Are you pinging Keith? It's not clear from the "To:" header and I want to check that I'm not holding up your patches.
Oh, I've never actually considered moving those that I ping to "To:", makes sense!
And no - you are not holding up anything. I'm just pinging anyone interested in hw/nvme (and zns).
Re: [PATCH for-7.0 1/4] hw/nvme: add struct for zone management send
In reply to Klaus Jenseninclude/block/nvme.h enum NvmeZoneType { · line 1446
Quoted 11 lines · Klaus Jensen
include/block/nvme.h +11
-0+typedef struct QEMU_PACKED NvmeZoneSendCmd { +uint8_t opcode; +uint8_t flags; +uint16_t cid; +uint32_t nsid; +uint32_t rsvd2[4 ]; +NvmeCmdDptr dptr; +uint64_t slba; +uint32_t rsvd12; +uint8_t zsa; +uint8_t zsflags[3 ];
This should be just a single uint8_t for zsflags, followed by 'uint8_t rsvd[2]'.
Otherwise, looks good.
Re: [PATCH for-7.0 3/4] hw/nvme: add ozcs enum
In reply to Klaus JensenQuoted 3 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
Add enumeration for OZCS values.
Looks good.
Re: [PATCH for-7.0 2/4] hw/nvme: add zone attribute get/set helpers
In reply to Klaus JensenQuoted 23 lines · Klaus Jensen
hw/nvme/ctrl.c +2
-2@@ -295,7 +295,7 @@ static void nvme_assign_zone_state(NvmeNamespace *ns, NvmeZone *zone,case NVME_ZONE_STATE_READ_ONLY :break ;default : - zone->d.za =0 ; +NVME_ZA_CLEAR_ALL (zone->d.za); } }@@ -3356,7 +3356,7 @@ static uint16_t nvme_set_zd_ext(NvmeNamespace *ns, NvmeZone *zone)return status; }nvme_aor_inc_active (ns); - zone->d.za |=NVME_ZA_ZD_EXT_VALID ; +NVME_ZA_SET (zone->d.za,NVME_ZA_ZD_EXT_VALID );nvme_assign_zone_state (ns, zone,NVME_ZONE_STATE_CLOSED );return NVME_SUCCESS ; }include/block/nvme.h +0
-0
include/block/nvme.h enum NvmeZoneAttr { · line 1412
Quoted 6 lines
include/block/nvme.h +3
-0@@ -1407,6 +1407,10 @@ enum NvmeZoneAttr { NVME_ZA_ZD_EXT_VALID = 1 << 7, }; +#define NVME_ZA_SET (za, attrs) ((za) |= (attrs)) +#define NVME_ZA_CLEAR (za, attrs) ((za) &= ~(attrs)) +#define NVME_ZA_CLEAR_ALL (za) ((za) = 0x0)
This doesn't really look any more helpful than open coding it. I think it would appear better to take a "struct NvmeZone" type parameter instead, and use inline functions instead of macro.
Re: [PATCH for-7.0 4/4] hw/nvme: add support for zoned random write area
In reply to Klaus JensenQuoted 11 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
Add support for TP 4076 ("Zoned Random Write Area"), v2021.08.23 ("Ratified").
This adds three new namespace parameters: "zoned.numzrwa" (number of zrwa resources, i.e. number of zones that can have a zrwa), "zoned.zrwas" (zrwa size in LBAs), "zoned.zrwafg" (granularity in LBAs for flushes).
Signed-off-by Klaus Jensen <[email protected]>
Looks good, and will just need a minor update if you choose to take the feedback from patch 2 onboard.