Skip to contentSkip to conversation

Allow rfddump and rfdformat to work on a test mtdram

PATCH In review Sean Young 2 participants 3 messages Nov 27, 2021 – Mar 16, 2022 Memory technology devices (MTD)

lore
Share & tools
lore

Sean Young

author
#0 lore raw

PATCH 1/1 Allow rfddump and rfdformat to work on a test mtdram

rfd can be used with mtdram since commit e03a81213a9c ("mtd: rfd_ftl: allow use of MTD_RAM for testing purposes"), which is in kernel v5.15.

---
 nor-utils/rfddump.c   | 2 +-
 nor-utils/rfdformat.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
nor-utils/rfddump.c +1 -1
index 01ab4c2..c85c067 100644
@@ -200,7 +200,7 @@ int main(int argc, char *argv[])
 			return 1;
 		}
 
-		if (mtd_info.type != MTD_NORFLASH) {
+		if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
 			fprintf(stderr, "%s: wrong type\n", rfd.mtd_filename);
 			close(fd);
 			return 2;
nor-utils/rfdformat.c +1 -1
index 0a3d9fb..160c081 100644
@@ -108,7 +108,7 @@ int main(int argc, char *argv[])
 		return 1;
 	}
 
-	if (mtd_info.type != MTD_NORFLASH) {
+	if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
 		fprintf(stderr, "%s: not NOR flash\n", mtd_filename);
 		close(fd);
 		return 2;
Signature · 6 lines
2.33.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
author
#1 lore raw
Quoted 2 lines · Sean Young

rfd can be used with mtdram since commit e03a81213a9c ("mtd: rfd_ftl: allow use of MTD_RAM for testing purposes"), which is in kernel v5.15.

Why has this patch been marked "not applicable", also without any discussion?

https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

So the kernel side changes are accepted and merged upstream, but the necessary user space changes are "not applicable". Is there a plan to revert the kernel side commits?

Sean

Quoted 40 lines
---
 nor-utils/rfddump.c   | 2 +-
 nor-utils/rfdformat.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
nor-utils/rfddump.c +1 -1
index 01ab4c2..c85c067 100644
@@ -200,7 +200,7 @@ int main(int argc, char *argv[])
 			return 1;
 		}
 
-		if (mtd_info.type != MTD_NORFLASH) {
+		if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
 			fprintf(stderr, "%s: wrong type\n", rfd.mtd_filename);
 			close(fd);
 			return 2;
nor-utils/rfdformat.c +1 -1
index 0a3d9fb..160c081 100644
@@ -108,7 +108,7 @@ int main(int argc, char *argv[])
 		return 1;
 	}
 
-	if (mtd_info.type != MTD_NORFLASH) {
+	if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
 		fprintf(stderr, "%s: not NOR flash\n", mtd_filename);
 		close(fd);
 		return 2;
Signature · 6 lines
2.33.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#2 lore raw

----- Ursprüngliche Mail -----

Quoted 10 lines

Von: "Sean Young" <[email protected]>
An: "linux-mtd" <[email protected]>
CC: "david oberhollenzer" <[email protected]>, "richard" <[email protected]>
Gesendet: Mittwoch, 16. März 2022 10:40:20
Betreff: Re: [PATCH] Allow rfddump and rfdformat to work on a test mtdram

Quoted 2 lines · Sean Young

rfd can be used with mtdram since commit e03a81213a9c ("mtd: rfd_ftl: allow use of MTD_RAM for testing purposes"), which is in kernel v5.15.

Quoted 7 lines

Why has this patch been marked "not applicable", also without any discussion?

https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

So the kernel side changes are accepted and merged upstream, but the necessary user space changes are "not applicable". Is there a plan to revert the kernel side commits?

I don't think "not applicable" was set on purpose. David?

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/