firmware_loader: export sysctl registration
Subsystems (4)
Luis Chamberlain
maintainerPATCH 1/1 firmware_loader: export sysctl registration
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls.
--- drivers/base/firmware_loader/fallback_table.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/base/firmware_loader/fallback_table.c +2 -0
@@ -56,10 +56,12 @@ int register_firmware_config_sysctl(void)return -ENOMEM ; return 0; } +EXPORT_SYMBOL_NS_GPL (register_firmware_config_sysctl,FIRMWARE_LOADER_PRIVATE );void unregister_firmware_config_sysctl (void ) {unregister_sysctl_table (firmware_config_sysct_table_header); firmware_config_sysct_table_header =NULL ; } +EXPORT_SYMBOL_NS_GPL (unregister_firmware_config_sysctl,FIRMWARE_LOADER_PRIVATE );#endif /* CONFIG_SYSCTL */
Signature · 1 line
2.33.0
Quoted 9 lines · Luis Chamberlain
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls.
Reported-by Randy Dunlap <[email protected]>Fixes firmware_loader: move firmware sysctl to its own filesSigned-off-by Luis Chamberlain <[email protected]>
Thanks.
Quoted 22 lines
--- drivers/base/firmware_loader/fallback_table.c | 2 ++ 1 file changed, 2 insertions(+)drivers/base/firmware_loader/fallback_table.c +2
-0@@ -56,10 +56,12 @@ int register_firmware_config_sysctl(void)return -ENOMEM ; return 0; } +EXPORT_SYMBOL_NS_GPL (register_firmware_config_sysctl,FIRMWARE_LOADER_PRIVATE );void unregister_firmware_config_sysctl (void ) {unregister_sysctl_table (firmware_config_sysct_table_header); firmware_config_sysct_table_header =NULL ; } +EXPORT_SYMBOL_NS_GPL (unregister_firmware_config_sysctl,FIRMWARE_LOADER_PRIVATE );#endif /* CONFIG_SYSCTL */
Signature · 1 line
~Randy
Greg KH
maintainerQuoted 8 lines · Luis Chamberlain
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls.
Reported-by Randy Dunlap <[email protected]>Fixes firmware_loader: move firmware sysctl to its own files
Have a git id for this?
thanks,
greg k-h
Luis Chamberlain
maintainerQuoted 11 lines · Greg KH
Quoted 8 lines · Luis Chamberlain
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls.
Reported-by Randy Dunlap <[email protected]>Fixes firmware_loader: move firmware sysctl to its own filesHave a git id for this?
I thought it would be ephemeral at this point since it was on linux-next, so had not provided one. If it is a static commit then I suppose this is 5cc0fea09ee52c9bcb6c41456bea03ca1b49602d
Luis
Greg KH
maintainerQuoted 8 lines · Luis Chamberlain
Quoted 7 lines · Greg KH
Quoted 6 lines · Luis Chamberlain
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Reported-by Randy Dunlap <[email protected]>Fixes firmware_loader: move firmware sysctl to its own filesHave a git id for this?
I thought it would be ephemeral at this point since it was on linux-next, so had not provided one. If it is a static commit then I suppose this is
5cc0fea09ee52c9bcb6c41456bea03ca1b49602d
Depends on where it came from. If -mm then yes, it's not a valid id. If someone else, it might be a real id.
thanks,
greg k-h
Luis Chamberlain
maintainerQuoted 12 lines · Greg KH
Quoted 11 lines · Luis Chamberlain
Quoted 10 lines · Greg KH
Quoted 8 lines · Luis Chamberlain
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls.
Reported-by Randy Dunlap <[email protected]>Fixes firmware_loader: move firmware sysctl to its own files
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Have a git id for this?
I thought it would be ephemeral at this point since it was on linux-next, so had not provided one. If it is a static commit then I suppose this is
5cc0fea09ee52c9bcb6c41456bea03ca1b49602dDepends on where it came from. If -mm then yes, it's not a valid id. If someone else, it might be a real id.
It came in through -mm.
Luis