ksmbd: fix uninitialized symbol 'pntsd_size'

PATCH New Namjae Jeon 1 participant 1 message Dec 1, 2021

Subsystems (3)

Stable branch SMB client (CIFS) Kernel SMB3 server (ksmbd)

lore

Share & tools

lore

Namjae Jeon

author maintainer

2021-12-01 01:55 UTC #0 lore raw

PATCH 1/1 ksmbd: fix uninitialized symbol 'pntsd_size'

No check for if "rc" is an error code for build_sec_desc(). This can cause problems with using uninitialized pntsd_size.

Fixes e2f34481b24d ("cifsd: add server-side procedures for SMB3")

Cc [email protected] # v5.15

Reported-by Dan Carpenter <[email protected]>

Signed-off-by Namjae Jeon <[email protected]>

---
 fs/ksmbd/smb2pdu.c | 4 ++++
 1 file changed, 4 insertions(+)

fs/ksmbd/smb2pdu.c +4 -0

index c70972b49da8..615f977b9d15 100644
@@ -2960,6 +2960,10 @@ int smb2_open(struct ksmbd_work *work)
 							    &pntsd_size, &fattr);
 					posix_acl_release(fattr.cf_acls);
 					posix_acl_release(fattr.cf_dacls);
+					if (rc) {
+						kfree(pntsd);
+						goto err_out;
+					}
 
 					rc = ksmbd_vfs_set_sd_xattr(conn,
 								    user_ns,

Signature · 1 line

2.25.1