Skip to contentSkip to conversation

clk: Remove no-op request and rfree callbacks

PATCH Applied Sean Anderson 2 participants 3 messages Dec 1, 2021 – Jan 15, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: Remove no-op request and rfree callbacks

These callbacks are optional. Remove ones which do nothing.

---

 drivers/clk/ics8n3qv01.c          |  6 ------
 drivers/clk/tegra/tegra-car-clk.c |  9 ---------
 drivers/clk/ti/clk-sci.c          | 14 --------------
 3 files changed, 29 deletions(-)
drivers/clk/ics8n3qv01.c +0 -6
index 6bc1b8ba9d..33fb6ed0c7 100644
@@ -180,11 +180,6 @@ static ulong ics8n3qv01_set_rate(struct clk *clk, ulong fout)
 	return 0;
 }
 
-static int ics8n3qv01_request(struct clk *clock)
-{
-	return 0;
-}
-
 static ulong ics8n3qv01_get_rate(struct clk *clk)
 {
 	struct ics8n3qv01_priv *priv = dev_get_priv(clk->dev);
@@ -203,7 +198,6 @@ static int ics8n3qv01_disable(struct clk *clk)
 }
 
 static const struct clk_ops ics8n3qv01_ops = {
-	.request = ics8n3qv01_request,
 	.get_rate = ics8n3qv01_get_rate,
 	.set_rate = ics8n3qv01_set_rate,
 	.enable = ics8n3qv01_enable,
drivers/clk/tegra/tegra-car-clk.c +0 -9
index 09a7cf470c..c5214b9b3e 100644
@@ -30,14 +30,6 @@ static int tegra_car_clk_request(struct clk *clk)
 	return 0;
 }
 
-static int tegra_car_clk_free(struct clk *clk)
-{
-	debug("%s(clk=%p) (dev=%p, id=%lu)\n", __func__, clk, clk->dev,
-	      clk->id);
-
-	return 0;
-}
-
 static ulong tegra_car_clk_get_rate(struct clk *clk)
 {
 	enum clock_id parent;
@@ -82,7 +74,6 @@ static int tegra_car_clk_disable(struct clk *clk)
 
 static struct clk_ops tegra_car_clk_ops = {
 	.request = tegra_car_clk_request,
-	.rfree = tegra_car_clk_free,
 	.get_rate = tegra_car_clk_get_rate,
 	.set_rate = tegra_car_clk_set_rate,
 	.enable = tegra_car_clk_enable,
drivers/clk/ti/clk-sci.c +0 -14
index acb9eadf03..74df5a397b 100644
@@ -64,18 +64,6 @@ static int ti_sci_clk_of_xlate(struct clk *clk,
 	return 0;
 }
 
-static int ti_sci_clk_request(struct clk *clk)
-{
-	debug("%s(clk=%p)\n", __func__, clk);
-	return 0;
-}
-
-static int ti_sci_clk_free(struct clk *clk)
-{
-	debug("%s(clk=%p)\n", __func__, clk);
-	return 0;
-}
-
 static ulong ti_sci_clk_get_rate(struct clk *clk)
 {
 	struct ti_sci_clk_data *data = dev_get_priv(clk->dev);
@@ -208,8 +196,6 @@ static const struct udevice_id ti_sci_clk_of_match[] = {
 
 static struct clk_ops ti_sci_clk_ops = {
 	.of_xlate = ti_sci_clk_of_xlate,
-	.request = ti_sci_clk_request,
-	.rfree = ti_sci_clk_free,
 	.get_rate = ti_sci_clk_get_rate,
 	.set_rate = ti_sci_clk_set_rate,
 	.set_parent = ti_sci_clk_set_parent,
Signature · 1 line
2.33.0
author Applied
#2 lore raw
In reply to Sean Anderson
Quoted 3 lines · Sean Anderson

These callbacks are optional. Remove ones which do nothing.

Applied, thanks!

[1/1] clk: Remove no-op request and rfree callbacks

      commit: 460970faec567f9285199140c6e5dbe2112bb843

Best regards,

Signature · 1 line
Sean Anderson <[email protected]>