s390x: uv: Fix UVC cmd prepare reset name
PATCH 1/1 s390x: uv: Fix UVC cmd prepare reset name
The specification and the kernel use UVC_CMD_PREPARE_RESET so let's fix our naming up.
The call bit is named correctly but is not the same as the name we use on KVM. So let's clear that up too.
Signed-off-by Janosch Frank <[email protected]>
--- lib/s390x/asm/uv.h | 4 ++-- s390x/uv-guest.c | 2 +- s390x/uv-host.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/s390x/asm/uv.h +2 -2
@@ -39,7 +39,7 @@#define UVC_CMD_VERIFY_IMG 0x0302#define UVC_CMD_CPU_RESET 0x0310#define UVC_CMD_CPU_RESET_INITIAL 0x0311 -#define UVC_CMD_PERF_CONF_CLEAR_RESET 0x0320 +#define UVC_CMD_PREPARE_RESET 0x0320#define UVC_CMD_CPU_RESET_CLEAR 0x0321#define UVC_CMD_CPU_SET_STATE 0x0330#define UVC_CMD_SET_UNSHARED_ALL 0x0340
@@ -66,7 +66,7 @@ enum uv_cmds_inst {BIT_UVC_CMD_CPU_RESET =15 ,BIT_UVC_CMD_CPU_RESET_INITIAL =16 ,BIT_UVC_CMD_CPU_SET_STATE =17 , -BIT_UVC_CMD_PREPARE_CLEAR_RESET =18 , +BIT_UVC_CMD_PREPARE_RESET =18 ,BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET =19 ,BIT_UVC_CMD_UNSHARE_ALL =20 , BIT_UVC_CMD_PIN_PAGE_SHARED = 21,
s390x/uv-guest.c +1 -1
@@ -142,7 +142,7 @@ static struct { { "verify", UVC_CMD_VERIFY_IMG, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_VERIFY_IMG }, { "cpu reset", UVC_CMD_CPU_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET }, { "cpu initial reset", UVC_CMD_CPU_RESET_INITIAL, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET_INITIAL }, - { "conf clear reset", UVC_CMD_PERF_CONF_CLEAR_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_CLEAR_RESET }, + { "prepare clear reset", UVC_CMD_PREPARE_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_RESET }, { "cpu clear reset", UVC_CMD_CPU_RESET_CLEAR, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET }, { "cpu set state", UVC_CMD_CPU_SET_STATE, sizeof(struct uv_cb_cpu_set_state), BIT_UVC_CMD_CPU_SET_STATE }, { "pin shared", UVC_CMD_PIN_PAGE_SHARED, sizeof(struct uv_cb_cfs), BIT_UVC_CMD_PIN_PAGE_SHARED },
s390x/uv-host.c +1 -1
@@ -55,7 +55,7 @@ static struct cmd_list cmds[] = { { "verify", UVC_CMD_VERIFY_IMG, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_VERIFY_IMG }, { "cpu reset", UVC_CMD_CPU_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET }, { "cpu initial reset", UVC_CMD_CPU_RESET_INITIAL, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET_INITIAL }, - { "conf clear reset", UVC_CMD_PERF_CONF_CLEAR_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_CLEAR_RESET }, + { "conf clear reset", UVC_CMD_PREPARE_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_RESET }, { "cpu clear reset", UVC_CMD_CPU_RESET_CLEAR, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET }, { "cpu set state", UVC_CMD_CPU_SET_STATE, sizeof(struct uv_cb_cpu_set_state), BIT_UVC_CMD_CPU_SET_STATE }, { "pin shared", UVC_CMD_PIN_PAGE_SHARED, sizeof(struct uv_cb_cfs), BIT_UVC_CMD_PIN_PAGE_SHARED },
Signature · 1 line
2.32.0
Quoted 7 lines · On Thu, 2 Dec 2021 13:11:22 +0000 Janosch Frank <[email protected]> wrote:
The specification and the kernel use
UVC_CMD_PREPARE_RESETso let's fix our naming up.The call bit is named correctly but is not the same as the name we use on KVM. So let's clear that up too.
Signed-off-by Janosch Frank <[email protected]>
Reviewed-by Claudio Imbrenda <[email protected]>
Quoted 54 lines
--- lib/s390x/asm/uv.h | 4 ++-- s390x/uv-guest.c | 2 +- s390x/uv-host.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)lib/s390x/asm/uv.h +2
-2@@ -39,7 +39,7 @@#define UVC_CMD_VERIFY_IMG 0x0302#define UVC_CMD_CPU_RESET 0x0310#define UVC_CMD_CPU_RESET_INITIAL 0x0311 -#define UVC_CMD_PERF_CONF_CLEAR_RESET 0x0320 +#define UVC_CMD_PREPARE_RESET 0x0320#define UVC_CMD_CPU_RESET_CLEAR 0x0321#define UVC_CMD_CPU_SET_STATE 0x0330#define UVC_CMD_SET_UNSHARED_ALL 0x0340@@ -66,7 +66,7 @@ enum uv_cmds_inst {BIT_UVC_CMD_CPU_RESET =15 ,BIT_UVC_CMD_CPU_RESET_INITIAL =16 ,BIT_UVC_CMD_CPU_SET_STATE =17 , -BIT_UVC_CMD_PREPARE_CLEAR_RESET =18 , +BIT_UVC_CMD_PREPARE_RESET =18 ,BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET =19 ,BIT_UVC_CMD_UNSHARE_ALL =20 , BIT_UVC_CMD_PIN_PAGE_SHARED = 21,s390x/uv-guest.c +1
-1@@ -142,7 +142,7 @@ static struct { { "verify", UVC_CMD_VERIFY_IMG, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_VERIFY_IMG }, { "cpu reset", UVC_CMD_CPU_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET }, { "cpu initial reset", UVC_CMD_CPU_RESET_INITIAL, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET_INITIAL }, - { "conf clear reset", UVC_CMD_PERF_CONF_CLEAR_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_CLEAR_RESET }, + { "prepare clear reset", UVC_CMD_PREPARE_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_RESET }, { "cpu clear reset", UVC_CMD_CPU_RESET_CLEAR, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET }, { "cpu set state", UVC_CMD_CPU_SET_STATE, sizeof(struct uv_cb_cpu_set_state), BIT_UVC_CMD_CPU_SET_STATE }, { "pin shared", UVC_CMD_PIN_PAGE_SHARED, sizeof(struct uv_cb_cfs), BIT_UVC_CMD_PIN_PAGE_SHARED },s390x/uv-host.c +1
-1@@ -55,7 +55,7 @@ static struct cmd_list cmds[] = { { "verify", UVC_CMD_VERIFY_IMG, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_VERIFY_IMG }, { "cpu reset", UVC_CMD_CPU_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET }, { "cpu initial reset", UVC_CMD_CPU_RESET_INITIAL, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET_INITIAL }, - { "conf clear reset", UVC_CMD_PERF_CONF_CLEAR_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_CLEAR_RESET }, + { "conf clear reset", UVC_CMD_PREPARE_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_RESET }, { "cpu clear reset", UVC_CMD_CPU_RESET_CLEAR, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET }, { "cpu set state", UVC_CMD_CPU_SET_STATE, sizeof(struct uv_cb_cpu_set_state), BIT_UVC_CMD_CPU_SET_STATE }, { "pin shared", UVC_CMD_PIN_PAGE_SHARED, sizeof(struct uv_cb_cfs), BIT_UVC_CMD_PIN_PAGE_SHARED },