Skip to contentSkip to conversation

tune-cortexa72: Add new tune for crc and crypto

PATCH Superseded Jagadeesh Krishnanjanappa 2 participants 3 messages Dec 5, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tune-cortexa72: Add new tune for crc and crypto

The newly added cortexa72-crypto tune builds programs for armv8a with crc+crypto. Whereas default tune cortexa72 builds programs with armv8a only.

[YOCTO #14641]

---
 .../conf/machine/include/arm/armv8a/tune-cortexa72.inc | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +7 -3
index 2a510bd45b..8c32286c84 100644
@@ -6,8 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa72', ' -mcpu=corte
 require conf/machine/include/arm/arch-armv8a.inc
 
 # Little Endian base configs
-AVAILTUNES += "cortexa72"
+AVAILTUNES += "cortexa72 cortexa72-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc-crypto} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72"
+ARMPKGARCH:tune-cortexa72-crypto      = "cortexa72"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72    = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto"
 BASE_LIB:tune-cortexa72               = "lib64"
+BASE_LIB:tune-cortexa72-crypto        = "lib64"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Jagadeesh Krishnanjanappa

The newly added cortexa72-crypto tune builds programs for armv8a with crc+crypto. Whereas default tune cortexa72 builds programs with armv8a only.

There is another patch I sent to add converse infact to support nocrypto instead because this change you propose will regress existing cortexa72 tunes for machines which have crypto aes implemented in hardware and it will be not backward compatible since many bsps try to support multiple releases
So far only rpi4 cortexa72 SOCs are one which don’t have crypto are you aware of some others ?

Quoted 52 lines

[YOCTO #14641]

---
 .../conf/machine/include/arm/armv8a/tune-cortexa72.inc | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +0 -0
index 2a510bd45b..8c32286c84 100644
@@ -6,8 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES',

'cortexa72', ' -mcpu=corte
require conf/machine/include/arm/arch-armv8a.inc

# Little Endian base configs

meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +1 -2
-AVAILTUNES += "cortexa72"
+AVAILTUNES += "cortexa72 cortexa72-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          =

"${TUNE_FEATURES:tune-armv8a-crc-crypto} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72 =
"${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72"

meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +2 -0
+ARMPKGARCH:tune-cortexa72-crypto      = "cortexa72"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a}

cortexa72"
+TUNE_FEATURES:tune-cortexa72-crypto = "${TUNE_FEATURES:tune-cortexa72}
crc crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72 =
"${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crypto =
"${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto"
BASE_LIB:tune-cortexa72 = "lib64"
+BASE_LIB:tune-cortexa72-crypto = "lib64"
--
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#159190):
https://lists.openembedded.org/g/openembedded-core/message/159190
Mute This Topic: https://lists.openembedded.org/mt/87515896/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

So far only rpi4 cortexa72 SOCs are one which don’t have crypto are you aware of some others ?
JK: I do not know other SoCs which do not have crypto. The change is similar to other meta/conf/machine/include/arm/armv8a/tune-cortexa*.inc files where crypto has been added as
separate DEFAULTTUNE.

Regards,
Jagadeesh

Quoted 70 lines · Khem Raj
Quoted 3 lines · Jagadeesh Krishnanjanappa

The newly added cortexa72-crypto tune builds programs for armv8a with crc+crypto. Whereas default tune cortexa72 builds programs with armv8a only.

There is another patch I sent to add converse infact to support nocrypto instead because this change you propose will regress existing cortexa72 tunes for machines which have crypto aes implemented in hardware and it will be not backward compatible since many bsps try to support multiple releases
So far only rpi4 cortexa72 SOCs are one which don’t have crypto are you aware of some others ?

Quoted 52 lines

[YOCTO #14641]

---
 .../conf/machine/include/arm/armv8a/tune-cortexa72.inc | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +0 -0
index 2a510bd45b..8c32286c84 100644
@@ -6,8 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES',

'cortexa72', ' -mcpu=corte
require conf/machine/include/arm/arch-armv8a.inc

# Little Endian base configs

meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +1 -2
-AVAILTUNES += "cortexa72"
+AVAILTUNES += "cortexa72 cortexa72-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          =

"${TUNE_FEATURES:tune-armv8a-crc-crypto} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72 =
"${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72"

meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +2 -0
+ARMPKGARCH:tune-cortexa72-crypto      = "cortexa72"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a}

cortexa72"
+TUNE_FEATURES:tune-cortexa72-crypto = "${TUNE_FEATURES:tune-cortexa72}
crc crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72 =
"${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crypto =
"${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto"
BASE_LIB:tune-cortexa72 = "lib64"
+BASE_LIB:tune-cortexa72-crypto = "lib64"
--
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#159190):
https://lists.openembedded.org/g/openembedded-core/message/159190
Mute This Topic: https://lists.openembedded.org/mt/87515896/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-